From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB39C001DF for ; Fri, 20 Oct 2023 03:37:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B224800C6; Thu, 19 Oct 2023 23:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 062738D0003; Thu, 19 Oct 2023 23:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4544800C6; Thu, 19 Oct 2023 23:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4AB48D0003 for ; Thu, 19 Oct 2023 23:37:57 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A74EBA101B for ; Fri, 20 Oct 2023 03:37:57 +0000 (UTC) X-FDA: 81364430994.26.C1B3BE1 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2120.outbound.protection.outlook.com [40.107.215.120]) by imf29.hostedemail.com (Postfix) with ESMTP id C151312000D for ; Fri, 20 Oct 2023 03:37:52 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=WMoek5Pa; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf29.hostedemail.com: domain of justinjiang@vivo.com designates 40.107.215.120 as permitted sender) smtp.mailfrom=justinjiang@vivo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697773075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IuPsCV+wDdaN5JJKDxKbeTyfukDgPzJqqblflDbN5ng=; b=Kw53LhyxopaF0FBIbe5aAR1fXtWTNALE8wc/eHwVKtuggntb4MBhGJfEMaQyqT4l5d0mdk /ydq3hELUq1v9TgN0Oj6LIDEx2BbTW/R67OK1I1JYTUmm2louvpqWHJONFzy/SmiRsyZU6 UC56GqwtOdZoXpJkKAGcq+f6wOWqVfA= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=WMoek5Pa; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf29.hostedemail.com: domain of justinjiang@vivo.com designates 40.107.215.120 as permitted sender) smtp.mailfrom=justinjiang@vivo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1697773075; a=rsa-sha256; cv=pass; b=5O3LGSVtHJ8SzDBZN5/b+H6O/65PO7tV7tWx+B3pA0JhnXY3I5icYpXC4P2xBhx17rJ/+q rJ9otb4bkytGQhhHoMzbl7nPb72cqpNPPYJeID135HBsHbI8pApznV/hPYcFvFoBU9NyfH AwXZafkQGiiTsdQ3kzm56GJRKIEG3Kc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWFx3CREPk7LTrKppvREe8InSaac9V4xUfChXWnU34LsXtHWBJPV65qYfRWjUliwGBQxGWQ6FFjcAq1Z27pgza/JJszteILWqor0gWVIhz6be+T2aM+XQfm7b2PwuFTL885MQodp9CwruDHzQ6OTfX0JaUKTMBijpLY/sGAt2rSsfL1tz+WK+Cyk6ME2GlVE5kG+0s7OOekkt63IjL1mtE0MjupL8mktI/q6UOwKZ4UkVNVc/8/nML656+2nCd6UgPvC4+bZ07TYYr8cgu7T18C6emG6mRczcorFdEK60rSLYnLp9UqTRA7X8kRk8s2j9Cd3Lkd1oq6zOjYrSK3fFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IuPsCV+wDdaN5JJKDxKbeTyfukDgPzJqqblflDbN5ng=; b=iNZs0HY9esXi4w3i5n2sJ95+chrnhy3ZiKw/7v03YE5yCpfcWvywrrlT4S4X7mB4zqqUfB4Fcb71J0cXqgaejxF+nn72HIaiSl3M0XdZW7vbeqNvTIsaLBnYyAzKubH7FmCF7Wl/a/83wP2cZZE5MGDkIcJo31VDfc00es1XNK2yL5NnFoz8ocu9kQwQHzv4rbc8hMJE2HehQnL52iBychqEKGGeVbm4FUsSkR5pAZ/MxyCbCIK91TD7ZJC1lC4TkmrERteVq0/QWj7LOgThYWNXDeiz30BiXXDMogoC/bsuaWV1wm75oojHuYoJBu4AKlK8JSMrhaWyIv3FVE8opg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IuPsCV+wDdaN5JJKDxKbeTyfukDgPzJqqblflDbN5ng=; b=WMoek5PasEy/6gW697KN9lTyf8rY+7fk3qd2SEhMglWkRPRhvf8idaP9zWvzQrvFaF4e3vxWP1KgWtetosTxysNq8p98Bu4AT8C4NvugpVd2Hzw1XqO/ytFoJKlrj2/TcOeZrE0pjADMoKmSZNvgGIcVZtzuNRgbPAjp6iQoucGXl1KgzUiTZ27NjsX6rEhVKgUmlkx5NCBEKK/E8G83VesDOBoPLz3LNzBplirBbBvJYnU2iPjKzj+LVwkuRmJed2lM6U2BpPwVIMu9i2OAvfSF0PWUZRqNs+vEKQgtxRpO82bGGRe88THdskW3QcZy+tZ62ARvL3pqIRAhzV52kA== Received: from JH0PR06MB6849.apcprd06.prod.outlook.com (2603:1096:990:47::12) by TY0PR06MB5496.apcprd06.prod.outlook.com (2603:1096:400:267::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Fri, 20 Oct 2023 03:37:45 +0000 Received: from JH0PR06MB6849.apcprd06.prod.outlook.com ([fe80::32d4:1209:6b36:86e5]) by JH0PR06MB6849.apcprd06.prod.outlook.com ([fe80::32d4:1209:6b36:86e5%7]) with mapi id 15.20.6907.025; Fri, 20 Oct 2023 03:37:45 +0000 Message-ID: Date: Fri, 20 Oct 2023 11:37:41 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio skip unmap To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com References: <20231019134211.329-1-justinjiang@vivo.com> <20231019134211.329-3-justinjiang@vivo.com> From: zhiguojiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0181.apcprd01.prod.exchangelabs.com (2603:1096:4:189::13) To JH0PR06MB6849.apcprd06.prod.outlook.com (2603:1096:990:47::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: JH0PR06MB6849:EE_|TY0PR06MB5496:EE_ X-MS-Office365-Filtering-Correlation-Id: 0270a854-7002-4d9d-191d-08dbd11dec6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: usFI9oVPB8jUFIJYoIJ5ofV8jW1c3pnTgp+jTFtJQEQcx6PqFT5aIdWbWwPq4nJ1jE/uo+5uG8HKlhlDKJRpZ9xgmkxL/cNG1uL751VFpO3u7nQn4Yf+jQ1s8gsxP6zXCdl1+ExE9w94MRCN5qMmcengtq5f0g2OKyXiFQ9MYTv2mN2LsX83mVjlCQohOL6/jHoq+7ucXb20psqo01prBzL7HzRsL9mX05MjLysiIRJ/AF4V4akUb5hc9ifNEimnQFhH7lkQ9sIJ7i33NDjTJApNi1sXgFV6Xk6mMKFBVzVAFFOOVYAA4L42cdFIoNuZEcOO22gGG3QFRF+CW0psL2oppu1g3sS8qI6VOdVKkei7DuCmFU/AFnS+L1fhdcsTJRaj5BvA0pxQG8xqCVEETao5aGCPq+OcgXCfmZbhHYjtkY1APgGFN8HLrGbURap9bq7sbnb725WVDe3mZtoPHeHrArTFsTtdXyeP5jgn8UqeKLPd6hMKT/yCRIPcNC5DMZD7vPd7vUbF5f6L10ZRh22WNUhLfcbDPrnnGBQaVlIMF5Owgi9Os9oxuXJ0aDPqyuWLNKDr7DSUGoGkVsJsaPXxiMkw5Ma/90nErH9C9/8N6BzW+dvpSZ2Qhs5RpkYypxWRkqLFCLgGxDVodqE6RT25v0F0L/zN7P0yWUleZcmHa8cL+BFp+COL23EB9dRu7EeXxSRRTKdBALcZ67s+vQndYWf7cNfIGgQc5dpY7iY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:JH0PR06MB6849.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(346002)(396003)(39860400002)(136003)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(5660300002)(31686004)(6916009)(66476007)(66556008)(66946007)(316002)(478600001)(8676002)(8936002)(6486002)(83380400001)(4326008)(38100700002)(2616005)(86362001)(31696002)(107886003)(52116002)(6512007)(26005)(2906002)(6506007)(6666004)(36756003)(41300700001)(4744005)(38350700005)(43062005)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFlOUXVQdFdKV2lnVVB2QzIrMmI4WDc2VXpyZkdOVmpzeUQwMDZLMk02MFNx?= =?utf-8?B?dW9HOHIyRHFqblBybE5xRkx2TnNRYmFBalpxa3NxbDZMakZJSnpkck1pUTZB?= =?utf-8?B?YllRUlF5V1hWQ0tHSnNaUXF6d1V4WDF6blZKRTQwMFpSL0xMSjI0V1JPR2p2?= =?utf-8?B?MVBYMlhFdUNEWER4OHJ5R1FVQzlIcXpMTzRHNHhVY2VEUGF6Nzl4d2NiUlU4?= =?utf-8?B?OVRFSWNUcmFic055NmFQVW5rU2pIM0NRR1ZzQlgybEFQMTV4YWVNelJaRUwx?= =?utf-8?B?dkloQjhZWXFEVmxlWGs5ckcyVURRbUR3NWd2N2Zic0EvdnNwTmtvUFFOMVRI?= =?utf-8?B?MVpGTlNORHE5WHBjVWtDNjM2L2tSUFBGb2NCQ1N4MjJHK1Q1NExkMjNRdHJZ?= =?utf-8?B?Rjdrd3FRUlcvcHIyd3hqRUZtbHRMT0F0bTFFVm5aa0VKTXVvN2xWR05GSXBK?= =?utf-8?B?QlljZktOMlBSTTAwckQ2OURySUxVU1dONUgya0FKYjhucjF5NnNwZVJoVHJE?= =?utf-8?B?c1BtUm55UlhyejJmSXg2WUU2Rm1SclBENms1MXFaR09jVUlzNjVJMFNGRkR4?= =?utf-8?B?dTJDNXVXTVIwMGN0ajFPLzRaNENoeDdXSGRRVWxBMHVuRGU3bllxS0lIWkd5?= =?utf-8?B?ZDFQMVBoak9Gb1lScmJ1aFdJM1p5RmZ2Qm5pcWVZaXRGNU12d2hiOGI2OS91?= =?utf-8?B?YzluYk9XQ082V1FhSHFFNndrVjdUT0tCZUdhQTJzam51SkUxcVAzN2I0TDdv?= =?utf-8?B?VHZ2S2QzdE1CaEtPeGVuMXc4UnRodVJZR2FoaU5DQXdhQzk0MzdJUHZCeWVp?= =?utf-8?B?dlNxNHFyY2F0QnkvZ21FK1hPTjZiaTM1MFNGWmt2RHZNeFNxUUNXVFlkOXRj?= =?utf-8?B?Nk1OWEU5WkE5OFVTeU5ubkNhcVczMTlKcWFiQ2hxSnZzUUZPbFBib3dGRGlR?= =?utf-8?B?ekN6UmZaeGg0cWJSWkhnbm5qUHNSL2RVQ3JyU2FzUU83KzNuQmc5Ti83UXNI?= =?utf-8?B?aTdEVkpLaEQySy80c0hVT2RtbnFSOVpFTXc4NTZKV2NneW1WQmxjdy9leURH?= =?utf-8?B?bnNDb1MxdDErRkFGNU1BZXh4bEFWNHY3am9JeXVweDgrYW9Ld2E0TDdXK0lq?= =?utf-8?B?TUY2U2RFcjhRNlpKTUtLVVBXSGgvblJ6UHpnU1BiUURneDRPVUxtM1dXYXpW?= =?utf-8?B?NDdXNWU3TDdINld1L1JwQ2J0Mll5OHFNZmtVdWxBUmg0aGJBUTljTTZUaElT?= =?utf-8?B?UUVUWWQrQWtNZy9LNVM4d1ZkR0pTbUhpRHpnU2ZHeFZ0T3pycGJTWmRqTTdW?= =?utf-8?B?amZUaW9pQVBVa1ZjTDdlWkxxVURnN3FkbWl0bFBkTFdrVE5JUGNhbnRzYktL?= =?utf-8?B?Umt4akNiNCtKSFgzRzFoNGd5TkN4NTdzSTU2T0tuR0Vaczg4OUlKRGUvd2hK?= =?utf-8?B?RC82eC9ycXdJRlNibXBiQVF4T3FqMlJheFpRcG02cWJxcWRXWk1iTjlHZFdv?= =?utf-8?B?SVlMbzhUNno0QVUwb0JHdEkrZk5EUHdBRWxKNWg0UmtXcEZNTUtmR0JnVFR2?= =?utf-8?B?RWxRR3ZqSDNoQWxEVGl3U0RibmFJSkpOL3dDRlRsaHdQZnRiWmhuR0hNa0g1?= =?utf-8?B?d1NwbW5QeEI2Zk9BMlV2akJHeUhKSC8xOExFcTdUczJyU3lmRTQ3MjlObGxX?= =?utf-8?B?eWhrSlAvcy8vYzdwUGd5cDFzbzNyLzNEMHpNUE9sV1V1RTR1NHlHa2NBekd4?= =?utf-8?B?d1JtS1pZQmhXZktFd0xhdlBIQlZnM3BxdUdkQ3dZem5iLzh5ZWE0dTFPam4z?= =?utf-8?B?akZpcXAvWkJTWnJ6bENzUWJUeVBkU2ZjYkJWSGlIcjhMRTVZMmkyZVdFSGR1?= =?utf-8?B?cFFUSi83bmV6bHdWMlczVlJFbE9xdFBrcTJHNEdnbXJ2eUNnTFIway9SSUhv?= =?utf-8?B?d2ordHM5L0Q3b3h0eHNCaThIZXQ0cDZKV2hYL1lJY3Yva3hUS2ZaaHlUTHBq?= =?utf-8?B?aGxJWkpWV2RiUk1GRHo0dnBrUmxDcGliVHo1SERWdFhRM21JWXVYbEthd0ZM?= =?utf-8?B?c2VZSmc3cWJjcGpRZmxjQ0RSOE9neUpQdmxCc2s1dzA3eXZtTzRubkxURlpz?= =?utf-8?Q?Ci0R6kzXcgT1jsHISrMBfKJDW?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0270a854-7002-4d9d-191d-08dbd11dec6f X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 03:37:45.5411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aP0x2MrGZ0OiWqUsDdoxDnWjQfw7LU5PhwvpLdG+AIclY2OMirwVrmSvqf2MjayyFleFexK5oXi5QZTIBW4X8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5496 X-Rspamd-Queue-Id: C151312000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dsi3ahmguwadujxkuqt4foh8z589ka8f X-HE-Tag: 1697773072-374670 X-HE-Meta: U2FsdGVkX1+DjlN0u0kPWZKne8UlR/sQm67tjG82+a/Qh/B9+O8eM+FGox1VTbdd7dtdg2Iol+pauzT+7x3jELcpECHanJYkzvedeglbswHUZv4x1qJ8LLt4nhoJAXqxlteoxFK1Svde7m6fqGqXMj68aSJTfaD+BFSpkYztC23s/qwKji3mSzT30juk2z1E11iPBAH8nyKc68K9Sg4Ym8SF1ObtWSHlPO5KwYZZbgwxZYdVnezyQssmEqaRcBfx7bSHyKfQgz9YAbX+hI4xyTz9fIaCSoYXDs/4OaBMFrbmC+fQzsYei8JaZmc02Bgm87BYryDOdo8avqNJI8owltja0StOt7RpgJJGnCgldMA6pUcuQewpVmQEcta9Vd+A+EfjAU71YmHwbmznAPKyccsaHFxqJviPJlmjNhrlCU+I2F03CTT/JgAD7eGz6LbMSgPlRcoSL6rQCBDig9pKGqpLdwPs525aFEV3oa8qxyP/3mB8+ATdFepTaSbFkfuUcwmK5DaSBKRHt1IFeD/wEdRGNb+wG6UlPUA5c2NX5Cco3HMtEHBCGPlkP5TZYsc2cqUkeNscqq65+XsoWdcqpnpv9+IFl52cec4E9tB3u24et51bygXu13CpLxr/psm2t3hLw+grwz4f7tccHbPpP5aMfuiJ8q0GYJaGStLWGKChqGabzybn1fQoh/EVaT3vC9nRx7vBhI2GcdYHxs+WRdWvrGduvRoE9TI+0iMYma5dgyWhyRglE2dUTJQDyGD5zwkLOzMyuMILk9tQbqlZZNzoXQGEEJY25KoET2fhQLtc3iEVucgS5gsET0xicSGnh0qVgsUwqnILWt1QkS2NiDJZE8dmLY5YTkVeKjjmL/L4P4EhHnzNEgJixlRdMOv8sE1GF45ZlnL9/4L1YLrwZhbG3lSkqEWBkzdqtQlAO80Cs5mIIHw2StBz1XQZzBht+z4+7QYZZMeTBKn9spm /89m0CL1 SCbYJnWPze7I1BDVxt2r8SxyJ6sY7wcY/279+EveJIuB8oQBvPzi4e8JLvQ4Vf2oo9LIMNQ2jKeVFe6sNRvFP8pAGDGechI33Qpnim4eKvjd3w/88NwhskTXrsvJ78bhXtiHYggbKlYdiNPDf2w00gpOLvipuWSlWZ4Efa/bCzmLd/RbOJ0gLd3Ogxhztpa1sRUKjBirh8YUr7UucaeBkMpoZI1phZ+iln53471ZPxRDeG6ovW+NkPz3+Jiqh5CawT/wEb9R2V9US9REPMt4iwTAM+o5iMEXPNOlFHgw3lMJyGX8echsJs7MuKVM8715nomnYF8PDh+Vbon4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.151767, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/10/20 11:29, Matthew Wilcox 写道: > On Thu, Oct 19, 2023 at 09:42:11PM +0800, Zhiguo Jiang wrote: >> +++ b/mm/vmscan.c >> @@ -1225,7 +1225,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, >> stat->nr_ref_keep += nr_pages; >> goto keep_locked; >> case FOLIOREF_RECLAIM: >> + break; >> case FOLIOREF_RECLAIM_CLEAN: >> + if (dirty) >> + goto activate_locked; > Why activate_locked and not keep_locked? Hi, This is  a mistake, should be keep_locked.