From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE196C0218D for ; Wed, 29 Jan 2025 15:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AC9F28006E; Wed, 29 Jan 2025 10:19:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 135F7280067; Wed, 29 Jan 2025 10:19:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF17128006E; Wed, 29 Jan 2025 10:19:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D0E9D280067 for ; Wed, 29 Jan 2025 10:19:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7CDCFA0DF8 for ; Wed, 29 Jan 2025 15:19:55 +0000 (UTC) X-FDA: 83060849550.19.57FD70D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id DC326A0007 for ; Wed, 29 Jan 2025 15:19:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fCMQVsxk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sAVdirgs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fCMQVsxk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sAVdirgs; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738163993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YHRX5uKm3iDMqyqGabNmEcorE438syzAi8YDpRBTwGY=; b=X4zYyC7AfpWrVAZASwovEetsca/ofDlEVJ8efjrd3sc3FHdBXCVVEDdiSjcOCAti96HQZH J8G0LUWFyG7wBUmw/rcdiQU7obl5R29m91CtkbMpkOe+syBclv75U0N4Moyr6191n21gOt MJFYupiLbx0OyG7/97cjyIyyYDHNIZU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fCMQVsxk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sAVdirgs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fCMQVsxk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sAVdirgs; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738163993; a=rsa-sha256; cv=none; b=ZLGXSNE14Z2LtYnJenm43P/Dmevrk5aLTUhYDzOTopLegngIvpRkEeOkqB7HHI5v/+jVwz MwJaC5SPzYoAbEhKzeUwCA6wv581ncqYKcCp82SNVZKpJMKA9VOWhyGOQb4sdb/e8dBQHB 12XefaiP+s/ZCjR4Fw1MBXR/0ciurx0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 06151210ED; Wed, 29 Jan 2025 15:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738163991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YHRX5uKm3iDMqyqGabNmEcorE438syzAi8YDpRBTwGY=; b=fCMQVsxk3ST9mpa5usHO/w1XTDWxuFvQlfeeMViCGESvfMtS6FVzi+n8OyQfdMi/b8m1gR 0pnXldLf5uvpeRXRcPfI8W+vXY0UjjQivjzrhyc+cu7poOF6gOLV0I5PVADKtzLfysIhOt CPfye9c1kfL+xvwSoQ7plu7Mbl0zBSk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738163991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YHRX5uKm3iDMqyqGabNmEcorE438syzAi8YDpRBTwGY=; b=sAVdirgsxX1fbX1gzmKXgg1oIh0OlmI3sXwhsruTmLH3dEl8ymodxPedSrJ99bysOOAAQP s4x1ay2o7XjXazAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738163991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YHRX5uKm3iDMqyqGabNmEcorE438syzAi8YDpRBTwGY=; b=fCMQVsxk3ST9mpa5usHO/w1XTDWxuFvQlfeeMViCGESvfMtS6FVzi+n8OyQfdMi/b8m1gR 0pnXldLf5uvpeRXRcPfI8W+vXY0UjjQivjzrhyc+cu7poOF6gOLV0I5PVADKtzLfysIhOt CPfye9c1kfL+xvwSoQ7plu7Mbl0zBSk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738163991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YHRX5uKm3iDMqyqGabNmEcorE438syzAi8YDpRBTwGY=; b=sAVdirgsxX1fbX1gzmKXgg1oIh0OlmI3sXwhsruTmLH3dEl8ymodxPedSrJ99bysOOAAQP s4x1ay2o7XjXazAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA02F137D2; Wed, 29 Jan 2025 15:19:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zV3HOBZHmmdSMQAAD6G6ig (envelope-from ); Wed, 29 Jan 2025 15:19:50 +0000 Message-ID: Date: Wed, 29 Jan 2025 16:19:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm: make vmg->target consistent and further simplify commit_merge() Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <829048d075d18dd34572f330d17af66b8cff8441.1737929364.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <829048d075d18dd34572f330d17af66b8cff8441.1737929364.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DC326A0007 X-Stat-Signature: ohnnwf6ziym9ttbwigrcb94rbfbimedb X-Rspam-User: X-HE-Tag: 1738163992-408873 X-HE-Meta: U2FsdGVkX1+w65JOpHFM6lgeTz1mju5H9725UqNu7MvOa+rCl6fPCKCbXXV+MqdWBdxV6R/Bdnr26luVPIDI9wtk41BtGbGteUZr3cfUxysBjRlBy1830AaBAZXyFXPUq+5d4HVK+z9KJixkydCi8G55o+2n6Dsbiw6hBwUtcLhNknSh/HXP1Kx5zhm6SfUxoMnbvhiM8qJPPWRDH2ws3csm+80nTZM9k2OUfawgcs2jC6QyvBRrodLv2/BdxGDYYt5ViJ1BC7eoA7a6ugYsOefbyba2RdkLk44lc35eH6lRDoQse0pMfsW9xaOeTcEI1GGhA2T6f7c7d/ef4B54mPIRNRFdVRZV1OZL9kk2ucvnVQQL26SRNHnQy4tCDPEzre3MwMdOO4xBsZ+i0qHA4GCEHtBevrqzxQPD7sh3uay2dc6fbntseOt+4qergl8EA0pOeo389gqtpBihsGso0qAW+XfrpIrnb3G8YB7ZPb0c2kcatL9N0a6vAJq6Yk9HNUSnz6qbes5l8DpxlauzO1IIgWh6JLNluw1s8bADa/y/LnNWvPvK6y9aaSqx27M6HSZhMvhybuAdnPYlrFEKg4dUD8qUDsBZyg3ElaZNLYdfJbC1oXXaKLbxBQ4f2rvPD+bBCKEiLkteFJ70nluObkHVU5VK8qrOv6O2aB14cemqBItdV0URUp7rGzDKaGfcdOMcM7GV0DgZVZZ8cN6riSX/8BjK2XgKgBYONCIhpqLWArX7HNkDZolRurT725sQZcBePPAFjmNsjrTkllPdy6EnuYsYKi/ck3qcxftwaL99jXz4U8ruFHSKnqlOEBDgyKIDPykp7uVV5mnl0UdG8gVtOvOUdjLijAzPdRKfvuqBE7mAMhCJTN7jIhWBtWJzYixYs95JwD4eQo7rzMZI1WilwzwUQqn7LkCTVGYW1PCiZnrQYJwW9Yy2DBkpDX2vpnCzQGHexVOJm6JV7Cu ZSqewbTl 0wGbfYuscTJICxOPexe9UwdHLJnw3SDLHSFrAUA7dqjDZN75DhGzQZxV2mdp4JVAhMiHuihdpiWqXOBd6dQf6gsKpyQSOycSCDQitmlbzHSNc22aR+rAssTMxZCQqDlt6s6xEBXhTQvuJYJBKu5Q0lrbvtnesmtHzRLuJp4deVYBCQnFpGmuAW72qXPw3cEkk0Bw+VbXjgvx7ptta+xvOs0WL1MclvX55qN+cCVfXVQ68iMOtyh6MUt0rP4zxBGM9k+9btTUoosW/U3QCP/i7we2OkTy+R6i1Loje X-Bogosity: Ham, tests=bogofilter, spamicity=0.257794, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/27/25 16:50, Lorenzo Stoakes wrote: > + if (flags & __VMG_FLAG_REMOVE_MIDDLE) { > + *remove = vmg->middle; > + remove = &vp->remove2; > + } > + if (flags & __VMG_FLAG_REMOVE_NEXT) > + *remove = vmg->next; > + > + if (flags & __VMG_FLAG_ADJUST_MIDDLE_START) > + adjust = vmg->middle; > + else if (flags & __VMG_FLAG_ADJUST_NEXT_START) > + adjust = vmg->next; > + else > + adjust = NULL; > + > + vp->adj_next = adjust; Realized this has kinda made it more obvious that vp->adj_next is a misnomer?