From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5344CD3420 for ; Sun, 1 Sep 2024 19:24:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD50F8D0022; Sun, 1 Sep 2024 15:24:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C85D86B025F; Sun, 1 Sep 2024 15:24:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE2A8D0022; Sun, 1 Sep 2024 15:24:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 90C3D6B025C for ; Sun, 1 Sep 2024 15:24:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7DDBC1630 for ; Sun, 1 Sep 2024 19:24:38 +0000 (UTC) X-FDA: 82517146236.22.6C9FEAF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 8AEE240011 for ; Sun, 1 Sep 2024 19:24:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YyI5ClPQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WdoCDFAP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ebSqpJ0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=I6xxAivP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725218582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMXloFOsskVFWKhKs56ZfZ1pyeKtrYkUHP+PazICv1M=; b=A3az/L59e75fskAvfPjPqpwWySQLjxCu7/MHQaPGOJxwGokB8V9asgFbT8bqDBCyIAiaZQ +sRj/x0iZVqIgbmGV74fu+IFwSyLiaB7B9iOB5Ejf1pm06jBkN0S4EO73GM5cEdIlMF5mj W7EDIg8nrFwPeWYEmVEnCl+77am3oOE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725218582; a=rsa-sha256; cv=none; b=qe1YNBwgox2UVL4giE6tnLgiaYiQr7SkkYWgF3KouAra/P2vKWgHtyZHSanN4hHiJF5k7q Oo0z5+CS1g8FSU8bi5MMDUHtyFU4uharB3XgLqSM6ras+hNSwCmovzSI0z9NGo1+i/iflU r60Qmcd7wTKOgbbr43JQ6e9E6L1omHo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YyI5ClPQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WdoCDFAP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ebSqpJ0V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=I6xxAivP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9988121B11; Sun, 1 Sep 2024 19:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725218673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMXloFOsskVFWKhKs56ZfZ1pyeKtrYkUHP+PazICv1M=; b=YyI5ClPQkzMpsBlIwKauFBMTYqN3gqy1xoYnaMArTFXaiwYOR/7kt/sSk91x6EEiR0oACt EMVNia1sWFgep1kVZYrXcdYfqO9cOdh0QwrRwdTFBYHJU6WaQsfRU2iw3/f24QjntLUsMe pZC7VZSTq6rN7dAUw/D2iWiPi7yDzFE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725218673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMXloFOsskVFWKhKs56ZfZ1pyeKtrYkUHP+PazICv1M=; b=WdoCDFAPHrkoBMjsl88zkwgni5kOqMGwQwLD1c0OoBjAfdSXZMo5lut8VukN/ylMI52H3f 9jXOZkyUjpar7mDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725218672; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMXloFOsskVFWKhKs56ZfZ1pyeKtrYkUHP+PazICv1M=; b=ebSqpJ0V+jLo33OoDv5f+Kju76utNx+aeK8oUjEbfZYZyZrYt8DT0lQYTiTDp9VUD+QBW4 mxikjSqYrwWpoTZb+qViQLwW1qHRxFQNS3UUUbygv/Kph0U4EgG4Zpphe9gPymMmgnpAmr jADxE4C5XvgQwmyl9gREh02P8+0bIHo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725218672; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMXloFOsskVFWKhKs56ZfZ1pyeKtrYkUHP+PazICv1M=; b=I6xxAivPXAA162w3GWink8OR1q/bQC+aywWnFTAbtl6uv353G5mQwHYa6odq3ca+O6jeSo zjvvwdGuoVxVfZBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7FC041373A; Sun, 1 Sep 2024 19:24:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ji41HnC/1GYvcgAAD6G6ig (envelope-from ); Sun, 01 Sep 2024 19:24:32 +0000 Message-ID: Date: Sun, 1 Sep 2024 21:24:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: order-0 page alloc failures during interrupt context on v6.6.43 To: Matt Fleming Cc: linux-mm@kvack.org, "Christoph Lameter (Ampere)" , willy@infradead.org, kernel-team , Mel Gorman , Johannes Weiner , Charan Teja Kalla References: <148e864e-c344-40df-92e9-f919314f6e7b@suse.cz> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 9ebu5e8jch9jpecgk1b68gb3scrc8r4h X-Rspamd-Queue-Id: 8AEE240011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725218675-565383 X-HE-Meta: U2FsdGVkX18nvymr69FpRG/B1PuJG1Q/wzZCIb1AZgwbTksd5bJCH1ddiCXrUoT8ZVX1llLyfgJz3cnafujxjZjk6hBiPUjPGBSvTWyoW5OMw+WqbKoi3DJRKV94ziyB8LOV58S53pqebONTfKL5Z3hYG0USCjIUZIMscP0+WqGcW9PqYpqFj9yT1IHTmDXwPUvkBmrYgX2FViGNsZsh0V34uzhzEGFnJRUJPj1mivzvnNYEqhZt4GTFfnS828spCqq2cgAhSaF9EF/HZdRJsXDTEcJF9/k7REnGYwjIQ0TSnBr2Jhsv89SZoE2Hr0q//UAtjNWSys5dMvmgJvrq0IJSxvnMIFx6WE6/ZNwJCWitJ/M4IH59P05SmABjxxrDjXZsUgd1Eywt7zjIQDMG1ay104xIgpwe7ndE5f4dG8fKx3jkdEXP42LhzXWFS4+Dj1SCZJEndkBe3YJcQpho2xvoWy61vu/tQsmwF9c7/ojYzmFf762HY8Su7SfGksXebbVoAmHiZiUeKOc/Qv74guLRzVptXWX8feerESn9q7zhAaEMFaic+2/soinh3WHBEEOtGAZLXzKza29FNEtJiNidQ2Ed0j9oMY1Ah3OvWvwNmj6HnyXgwCRC0vxaiTCe8Pedu4awALrsm91baITs45QzRMRa8+XxO2mznAeE2bDQak+UGnusdaVNZ7uWXk7jVSYpFpJGCsBEIS0QqiqziXfDjK6bcKZIsXVdwhYogfolklhs6mDRFT55EOgQWsyydWRlpNXIiDQrQN57X6/XkVDR/a2V3l8ETICvo+/vNI9jnMsM3g3l519YLSnh1Pvs5I9tzMm7DqQHm/BXY5G1lw8IrcZmySOZNRi240BP85zLVsR9FuZMv0s/VLzFTJ/30kFKen57q1nCTKSmq2ylDxTp+O4qe3pF2zf8pWn6ebPlf+ytxw2V7/2D4IGKmK/PCtduIhAF9sF5kt199KQ GLXRv5uT IB+381ZzX+efjfWGXhH/meSoKPopgwNXzCJugewttjcWafsZhv3+DXesGHtRDbEpPip7G1XBLxBOLUT78MJjmELSAi423WLLi1eNgvkYwn6a4sedT7U0P0SEYzDydNR3AeySyuoNQjpDJi6bgTmXZye5X14cf0Fq6ndThQreGaEwJkMGxgOn9rwBAz4/l4wwPz9XU8Oy1YN+zi4M2foGbOmEF8rHFFiNZYskgRb3Ea1w6LBs1g+htGoPV5d6JRQ+K4gpv93LabYBfwroz1cCFtdyXIDTa03bzKeRsvkfRIyxigUmD1N5aI+R9ag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000330, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/30/24 17:43, Matt Fleming wrote: > On Thu, Aug 29, 2024 at 4:48 PM Vlastimil Babka wrote: >> AFAICS: >> >> - __zone_watermark_unusable_free() for ALLOC_RESERVES (which includes >> ALLOC_NON_BLOCK which GFP_ATOMIC allocations have) does not subtract the >> reserve_highatomic, so the allocations pass the watermarks >> - but in rmqueue_buddy() only ALLOC_OOM is able to fallback into highatomic >> - unreserve_highatomic_pageblock() is only called from reclaim and there's >> no reclaim for GFP_ATOMIC >> >> (also worth checking if kswapd even does anything if free > high, but it's >> all highatomic, maybe not? so it can't help us here) > > As far as I can tell we'll wake kswapd but like you said because free >> high it thinks the pgdat is balanced. Hm wonder if we should change that and kswapd should count free without highatomic reserve. > How is the system supposed to recover in this situation? Wait for a > non-atomic alloc to fail and enter direct reclaim? That's probably how it recovers but it's not how it's supposed to recover :) Aside from changing the kswapd behavior, GFP_ATOMIC should likely be allowed to fallback into highatomic reserve in rmqueue_buddy() same as ALLOC_OOM can?