From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58AAEC5320E for ; Tue, 20 Aug 2024 07:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB10E6B007B; Tue, 20 Aug 2024 03:53:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A60656B0082; Tue, 20 Aug 2024 03:53:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D94A6B0083; Tue, 20 Aug 2024 03:53:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F9D96B007B for ; Tue, 20 Aug 2024 03:53:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11D8AA173A for ; Tue, 20 Aug 2024 07:53:25 +0000 (UTC) X-FDA: 82471858770.22.0B6D03E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id C853B140006 for ; Tue, 20 Aug 2024 07:53:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nzh0uQdR; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724140363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tJ/f2InT+rIdlvMsba4cZ0b6wvEJfFILppiqtiUQSE8=; b=neridfmlAa3gAUBSm7qKY2U+t6WqHYpbHWsYxffm51N7zuhNOZiZFbbHSXWEaSZvSE+8JQ 6UBV8WvkuoVaEBtKJANkHy5/jabdBOZ3VQTqCdLiU4KbO6pwNfMV/yYfOBk0QOQqvZUiCr QEfzn4shTttMQCmRKu2+mwamxu1nWNM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nzh0uQdR; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724140363; a=rsa-sha256; cv=none; b=ZK9WuDeTD+pgsHZ014yuCRcDoPgtq5vLxiOLHTHyofYoyZgRoMe5EKZLbe8G1Dvw3QSbJS lXlzmDzzwqFJrk0qmM6LbHcBUSlo4Qcoj1T5eZvSdviwukE7Me4rygPpZ7Da9SwrH7ZcSK hL1zwAnmYsi2M1/VNJg3EEnaEoDmNqg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724140401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tJ/f2InT+rIdlvMsba4cZ0b6wvEJfFILppiqtiUQSE8=; b=Nzh0uQdRgW0pOkz1FvHLslqwB712v5AkaCzv7Tahic15v0in6oNr7rQGPXOpj47HRywG+D uuTKUt1U2mLR2iMkqxT+VabdREwQHo6Vt9wKSufCT0kozNk2NqkxqnMkqJ//ygSJZs5lgR eYMGs79I2tZhQ9WYiBoNo9evXnMxw/g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-AttVi2yNPQyccr1X18F9pg-1; Tue, 20 Aug 2024 03:53:17 -0400 X-MC-Unique: AttVi2yNPQyccr1X18F9pg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-429097df54bso41501725e9.1 for ; Tue, 20 Aug 2024 00:53:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724140396; x=1724745196; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tJ/f2InT+rIdlvMsba4cZ0b6wvEJfFILppiqtiUQSE8=; b=vvsgcUxhibM089JyppmJ8uF0HIwm5qf8sKfOLbIgwYdSS4XQnz2moYihaDZzAoY9OG rvZfqeUh6NZ/oVSa7K23sIGZq7fyK86qYC9H3gY58pe3b2gID1slk+lOl31qSdhIEeHI fzZ03pszBDlwZYzwOvG4N9wUPZDhu8oUK0WxWSNXLqLG9JaHabEaX97fCPviYNRkLne2 eqUp13UI1DL30BBM4BzXKbUbeioCavzsboe/1oygoPxXnyX475+ullvqyiml74FdLNGc XTucyttL7tyNQuAvVHlKvPARkdXuJgHYKwMJBVyRLhVD/PXVWlK8MxndZGddFWpjMJYI 0g2g== X-Forwarded-Encrypted: i=1; AJvYcCVsQzjlszAQ3bZ3roEns1wyHSfp3+iPNDdSe9ICIdJFE7SxBv4WD74+X9idzWcs506B3PLQLmZl5g==@kvack.org X-Gm-Message-State: AOJu0YwPg1LaOfnfKKjrdSKnYmidMDffGmQ3rHLRJ5mBSWQnZy4gDRJp BdwOzqBTAX2gbB+a+krjI+fZp9tg0u1eEBYuT+1gxJYOedA03dvMEwmh5pDDE8mjROsF5kmFD23 4wByoY2RlRxnWmmIF24Zl42qpL5Ns4F0RPXKIr+E+dOCmufx/ X-Received: by 2002:a05:600c:310f:b0:426:5b21:97fa with SMTP id 5b1f17b1804b1-429ed7e432cmr110396255e9.29.1724140396463; Tue, 20 Aug 2024 00:53:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKF9tbs3TxyVLawmP6xbfPrLvS5chViXYaWgcFNPtLJq/kkxt8HYBLAltrhLoOL7Ja2XgKTA== X-Received: by 2002:a05:600c:310f:b0:426:5b21:97fa with SMTP id 5b1f17b1804b1-429ed7e432cmr110395855e9.29.1724140395510; Tue, 20 Aug 2024 00:53:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed? (p200300cbc74b0e009c12cdf2bf1cb8ed.dip0.t-ipconnect.de. [2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded36051sm186115095e9.24.2024.08.20.00.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 00:53:14 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 09:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm: override mTHP "enabled" defaults at kernel cmdline To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baohua@kernel.org, baolin.wang@linux.alibaba.com, corbet@lwn.net, ioworker0@gmail.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com References: <20240817045516.58037-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817045516.58037-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C853B140006 X-Stat-Signature: azdiodcc34zamb6wi1yeixizbieeetcp X-HE-Tag: 1724140401-271377 X-HE-Meta: U2FsdGVkX1+V+pcE1t26G/49hW9to3+E2v9biwcK9cBaXZuyzOSX64sPZ+V1BnA9a0BCAIc7+lOwqESO2jbcP0gZvezb/vpGU8ArYEtFVHiW3U0wH9+pM6lQq67cKVesq6Z7R8clIntg3s1o2s/39h7vnvuW5YGWeHB0ly4VJUtmu4vkZv0w9NTTkFeIXjGCCAhimBsmYOJwBw+AamGCIIxOzHpZUa8TILJiS/lgktSnMSFTL9awoEIex8aCclZS2iuagHijNDToQcwjhiVR9VcRCti72+g4apOq77UtmgpBLsUse/mVnrcnX5rRBrvo7mmcW6jw6Bt/4GTiGskBavPrME6jE3JBBKMRPUC8em3OhAS+jkoydnn5OJGkUi1VJD8ekdFFxz1fIZ8toVOk/ASsHstM1DcfNIubg7XlrDo0mWwBng3v9m6+/e3/h370dWqvO7b6P06dAp2iAzPznJBJOfXzOPN/H2SBlnSVXYkvrHpnA3PGd11azUjC30gX7MhUCRmZVm/wXotHEaaf34+A2AyBJnh+z84ZPkWDBDc7Io0xck2Um/k7+nZ5Ene/BmU7oq4WH3NXtaTZa3Kzf/wxkMNFmMzwjzq01c/ecCSrWAWMj56yVdrDySjc6hYACM810W9azJhNaliz0jY/Cwt7gQ/O70IZPuQ4jDRDGAXuVEVq5ZPNh5FFzg+GhRUftM6JuoJ56yNEb9KAoNKKHcmSvQMs7FQkV/29dG74/0DMx4mWMVI16Qt+IwGGTn4Bgf9FWhPjdfsfL64mEXoMSD63vFDvbvGcVkUG3SnDzUq6PRzUZoxsbnh5UCsdIvlDfoIHgV2CNpDiC0LYLckqemF9AXiOadeix0J1mJduhIlXNTZQZ9cj9vvvDTo8YwQDZaKswJKfcC5JG0skHFmg7bcYgYMcIidb3ZWWzASsiGW72GQupAxT1mlhpARbdwh5HjroHWFgMsrB23JqZcS gllEWqYh UZ2mDKNE24ikfXB0AK7cN+gYmWZcnWukHCfa00InP8PO1j52qs57KRIDMs6/d8PCWdsfXI+Q7JAVM6dUt1nKSSBVnwlWmeRQntbr762IEtGxzMnO2vDNTSCukmdn6g5s4FlJy8juG3+oB1TJOymWpNW7vC6KTYj2iC9VvUY/FqvSUQz1s5GDPBf3R5LD2612xfmMS5ehkeM+ocvQvTYs9y7VrMDgIZijlvFxUFQXv5zcqcUXyEGiO9L4obmHCajfniDJY/R0KV8k2s2Al+VVi730oJ+6H3nbvh7DIQKM7d913ZYu+d7G2Qdcu4Rx2LAXRozskjr+wlrbTNquVw9AwUNk9Hj69am0QH6uNWKwFu1cHClsmQ5R1EV00urngByfdvHr90QCYsHDDPwu5Y4cMPtUIyyPhQTuk0l9FsbTUpYJSwi7sa+Qb7AOf1ySNVrzmyTtEo/y9RPpgeXJBdLv6njmsCitGRB4obt1o7rUti8Rv5mtZyIHCkY/+1eSCjo9W7Zd3ZRlmXEQb8ma4gWMNpurwuKPpulVcSMJk0mapSAr1x4K01cvEkJduTUSo2shzuMUBlCBwIvI81/IOu+a78JZXwxLBuZwNllGrWsZDKMjVCFI+MEB0JH3L8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 06:55, Barry Song wrote: > From: Ryan Roberts > > Add thp_anon= cmdline parameter to allow specifying the default enablement > of each supported anon THP size. The parameter accepts the following > format and can be provided multiple times to configure each size: > > thp_anon=,[KMG]:;-[KMG]: > > An example: > > thp_anon=16K-64K:always;128K,512K:inherit;256K:madvise;1M-2M:never > > See Documentation/admin-guide/mm/transhuge.rst for more details. > > Configuring the defaults at boot time is useful to allow early user > space to take advantage of mTHP before its been configured through > sysfs. > > Signed-off-by: Ryan Roberts > Co-developed-by: Barry Song > Signed-off-by: Barry Song > Reviewed-by: Baolin Wang > Tested-by: Baolin Wang > Cc: David Hildenbrand > Cc: Jonathan Corbet > Cc: Lance Yang Acked-by: David Hildenbrand Some nits: > --- > -v5: > * collect Baolin's reviewed-by and tested-by tags, thanks! > * use get_order and check size is power 2, David, Baolin; > * use proper __initdata > > .../admin-guide/kernel-parameters.txt | 9 ++ > Documentation/admin-guide/mm/transhuge.rst | 38 +++++-- > mm/huge_memory.c | 100 +++++++++++++++++- > 3 files changed, 139 insertions(+), 8 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index f0057bac20fb..d0d141d50638 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -6629,6 +6629,15 @@ > : poll all this frequency > 0: no polling (default) > > + thp_anon= [KNL] > + Format: ,[KMG]:;-[KMG]: > + state is one of "always", "madvise", "never" or "inherit". > + Can be used to control the default behavior of the s/Can be used to control/Control/ > + system with respect to anonymous transparent hugepages. > + Can be used multiple times for multiple anon THP sizes. > + See Documentation/admin-guide/mm/transhuge.rst for more > + details. > + > threadirqs [KNL,EARLY] > Force threading of all interrupt handlers except those > marked explicitly IRQF_NO_THREAD. > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 60522f49178b..4468851b6ecb 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -284,13 +284,37 @@ that THP is shared. Exceeding the number would block the collapse:: > > A higher value may increase memory footprint for some workloads. [...] > unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > unsigned long vm_flags, > @@ -756,7 +757,10 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj) > * disable all other sizes. powerpc's PMD_ORDER isn't a compile-time > * constant so we have to do this here. > */ > - huge_anon_orders_inherit = BIT(PMD_ORDER); > + if (!anon_orders_configured) { > + huge_anon_orders_inherit = BIT(PMD_ORDER); > + anon_orders_configured = true; > + } > > *hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj); > if (unlikely(!*hugepage_kobj)) { > @@ -941,6 +945,100 @@ static int __init setup_transparent_hugepage(char *str) > } > __setup("transparent_hugepage=", setup_transparent_hugepage); > > +static inline int get_order_from_str(const char *size_str) > +{ > + unsigned long size; > + char *endptr; > + int order; > + > + size = memparse(size_str, &endptr); > + > + if (!is_power_of_2(size)) > + goto err; > + order = get_order(size); > + if ((1 << order) & ~THP_ORDERS_ALL_ANON) Could do "if (BIT(order) & ~THP_ORDERS_ALL_ANON)" > + goto err; > + > + return order; > +err: > + pr_err("invalid size %s in thp_anon boot parameter\n", size_str); > + return -EINVAL; > +} > + > +static char str_dup[PAGE_SIZE] __initdata; > +static int __init setup_thp_anon(char *str) > +{ > + char *token, *range, *policy, *subtoken; > + unsigned long always, inherit, madvise; > + char *start_size, *end_size; > + int start, end, nr; > + char *p; > + > + if (!str || strlen(str) + 1 > PAGE_SIZE) > + goto err; > + strcpy(str_dup, str); > + > + always = huge_anon_orders_always; > + madvise = huge_anon_orders_madvise; > + inherit = huge_anon_orders_inherit; Should we only pickup these values if "anon_orders_configured", otherwise start with 0? Likely that's implicit right now. > + p = str_dup; > + while ((token = strsep(&p, ";")) != NULL) { > + range = strsep(&token, ":"); > + policy = token; > + > + if (!policy) > + goto err; > + > + while ((subtoken = strsep(&range, ",")) != NULL) { > + if (strchr(subtoken, '-')) { > + start_size = strsep(&subtoken, "-"); > + end_size = subtoken; > + > + start = get_order_from_str(start_size); > + end = get_order_from_str(end_size); > + } else { > + start = end = get_order_from_str(subtoken); > + } > + > + if (start < 0 || end < 0 || start > end) > + goto err; > + > + nr = end - start + 1; This only works as long as we don't have any "Holes", which is the case right now. > + if (!strcmp(policy, "always")) { > + bitmap_set(&always, start, nr); > + bitmap_clear(&inherit, start, nr); > + bitmap_clear(&madvise, start, nr); > + } else if (!strcmp(policy, "madvise")) { > + bitmap_set(&madvise, start, nr); > + bitmap_clear(&inherit, start, nr); > + bitmap_clear(&always, start, nr); > + } else if (!strcmp(policy, "inherit")) { > + bitmap_set(&inherit, start, nr); > + bitmap_clear(&madvise, start, nr); > + bitmap_clear(&always, start, nr); > + } else if (!strcmp(policy, "never")) { > + bitmap_clear(&inherit, start, nr); > + bitmap_clear(&madvise, start, nr); > + bitmap_clear(&always, start, nr); > + } else { > + pr_err("invalid policy %s in thp_anon boot parameter\n", policy); > + goto err; > + } > + } > + } > + > + huge_anon_orders_always = always; > + huge_anon_orders_madvise = madvise; > + huge_anon_orders_inherit = inherit; > + anon_orders_configured = true; > + return 1; > + > +err: > + pr_warn("thp_anon=%s: cannot parse, ignored\n", str); "cannot parse, ignored" -> "error parsing string, ignoring setting" ? > + return 0; > +} > +__setup("thp_anon=", setup_thp_anon); > + > pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) > { > if (likely(vma->vm_flags & VM_WRITE)) -- Cheers, David / dhildenb