From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC14C4345F for ; Mon, 15 Apr 2024 15:06:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4733C6B0092; Mon, 15 Apr 2024 11:06:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4240F6B0093; Mon, 15 Apr 2024 11:06:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E046B0095; Mon, 15 Apr 2024 11:06:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B4FA6B0092 for ; Mon, 15 Apr 2024 11:06:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C06041A06A2 for ; Mon, 15 Apr 2024 15:06:27 +0000 (UTC) X-FDA: 82012092414.22.517595E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 756CF40019 for ; Mon, 15 Apr 2024 15:06:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AVjO6klC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713193585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SWMgTI6choihLIiQqxi4W/di2i0okUpqfQyANhD1YlM=; b=WtfxrBSXZ4nZEAaV/uiZOVTG1dylo1ESO88lsNLrseXWsvAPJN4sZUUeTSA8WiP9zL0a9S LSyLux4UJ6dWL90kSG0QEgltdd4DFNQX5BZFSxt1uusCkdXCkhBjmLqP2Pm+An1M2gGTNn 6RMyTxRBj7NJUUoYwNn3DNdvRUt12HY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AVjO6klC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713193585; a=rsa-sha256; cv=none; b=S6Sv06TTBm0RB+Yx/r6FVNKULBpzSdVuan4MLrfHCbegq2XOXOP76PtlP0jk4FHx5qfsv2 Uj6vEUiMx2pINnxMtGknBExjTDQOQAB8EndM0T6VQXFPtyIoACqFy5waBDwZtev06mNKiu HTQJNPnNAW77nTGwYsai5qUKakgRw4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713193584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SWMgTI6choihLIiQqxi4W/di2i0okUpqfQyANhD1YlM=; b=AVjO6klC2zjo7eCSDfqEes513NydNr8qrYjT/SBggElkFefYWLRLNCfprWfKU9P47Xwnwl 5RQJkCqH8wHrNm7M4hrR5ipEGBuvenhA4Yy/5xyL4rFjOd+l8v/+lK11jI3IwZq8HRuc1j /FlcFL45P4K26FpLGsm/lGx1ayNydzc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-kLaxBSBfMXqRqecKZ0s2Sg-1; Mon, 15 Apr 2024 11:06:23 -0400 X-MC-Unique: kLaxBSBfMXqRqecKZ0s2Sg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343ee356227so2108685f8f.2 for ; Mon, 15 Apr 2024 08:06:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713193582; x=1713798382; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SWMgTI6choihLIiQqxi4W/di2i0okUpqfQyANhD1YlM=; b=JMZFZN9YexLCv7inR5VW/L69nG3iMIlDkoynl6mJT4O5Wl2YpyVuqGMH59FaMmldT9 nmpyOnAStN2U7M5D/gc7vzFKqoGLYGKjbQQYaWAaPUuQBN7w7zXOehDbNxzJB9XbSpz4 RGDj4n2WtpTRw0NPzn54NfF8h7/y0HE2fz7MeJBaOjSmE8/9Nlsl3GThvCWT0zX1OQE7 UBpC1vffruW3LihEkidSJZdio4zSHDmmEyc/YFftDQox35UksPwggElu0iHLCN8wAQ3f F3Q8KqRetqTipNYk6Ceav8iWmiCXlNgcmLi2w8nG1qAowK/6FQlicW05EnMnKdEfCpEL GPEg== X-Forwarded-Encrypted: i=1; AJvYcCWShS2TAPwb8rlS50UMvDVSqFY7WbVevPiRKM8ptx0swK54OWz8FCL8KoelP969nxYc6la7PvjawEOB9z/0WqquABU= X-Gm-Message-State: AOJu0YyGtmIW4wPOmBXrBYqkOzjVdDZJX99ADbRLQ9LA46Zesr8AIqgG mRZnDzIKDb6aQSXtf2ud51Bv18yZWR/HX0RXFGIrrAKO2XdBfC8YaWBcrj6mtHtXZDZOhdB/g8w m6Fqpu/N6umVspnUz5zKC4tVj3VD/WMfLnnR13VhssEWJUf2o X-Received: by 2002:adf:c086:0:b0:346:b79c:b1ee with SMTP id d6-20020adfc086000000b00346b79cb1eemr7359572wrf.44.1713193581819; Mon, 15 Apr 2024 08:06:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3IpHGX4eBvaap7cR+1gBUBPyeuaceWkZ5RyrQBFH8pySWHVwiaycuCHDvCmsZ1kwulqhBhA== X-Received: by 2002:adf:c086:0:b0:346:b79c:b1ee with SMTP id d6-20020adfc086000000b00346b79cb1eemr7359553wrf.44.1713193581396; Mon, 15 Apr 2024 08:06:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:d800:568a:6ea7:5272:797c? (p200300cbc706d800568a6ea75272797c.dip0.t-ipconnect.de. [2003:cb:c706:d800:568a:6ea7:5272:797c]) by smtp.gmail.com with ESMTPSA id q3-20020adfb183000000b00343cad2a4d3sm12481436wra.18.2024.04.15.08.06.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 08:06:21 -0700 (PDT) Message-ID: Date: Mon, 15 Apr 2024 17:06:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 3/3] virtio_balloon: introduce memory scan/reclaim info To: zhenwei pi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240415084113.1203428-1-pizhenwei@bytedance.com> <20240415084113.1203428-4-pizhenwei@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240415084113.1203428-4-pizhenwei@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ksgew4ox6x4c41nukk86m9wmoo7d4jph X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 756CF40019 X-HE-Tag: 1713193585-961750 X-HE-Meta: U2FsdGVkX19Byae7Can+1AvLRLBg6YkOEGJlgvWSuK5ZZ4c8X+O7NqjXISj6GZFwh2J269AZ3ntuY4wU6ojslauCDgLf8Vb0bVdYMjXsYRmI9YZc4pwinuHez9xQ0ODhtDKv4I57wwvT7wYwljut98SQ1fOLRIcj+6SbwVX7rs31dtQYZaBNldOPFm5QlhUVqHluP2RrAh0tD7JzPnOjuLt23NZZGmwyUKxYbC0uDuTO7f2ryvmNaCbD1qp4mMnumwgb3aVQplx/pnr1hcnxbxzJ53o7ELhiFr4IV2dFqatfoOt/IeHgawMTN45O2d6nzd0tOx5XkKXbb1iiuZTtN6ea8KgcCUpcgaSsfniOxhPhWrasEq4zcVtddepif29YtcyZ1b5JYFfAn26bESWoA2vOH23jpnbs4gGyLHvMTCY+N36wRfqxhzXbWVFMIDjrJT7N6rL8cpNUgsPx0qKJqY5MFM3IsvAhgmhfGmPh3St2+meGPYL6VuDwVeCA2vIYGPTkDZSjrYVmpcbOQPQRLZeCoSnshClvwUiZdqU6QretTjMUjs7sY/p6Gw/jRfXc0R96EMwouyNFFW3ZzSToK7WZvX5VwZHXykPz4Hlh1pFiZ4mrV6u3zyUDBJwW/teI9v46cAbIqqELG5YlmqYMrbtMceZb2eRinTnJe+Rburaml+VS385kCh8cJdhO2cO8LrBq2Tg3HJANIokbz5Wux+iitHkaxEE4lN3uPuubehEorGXdSpOwZnIBnIUxW+AEd4UHqO21BYurL0UHj3+gtPxbJHS4O07XW5T53/eYGiOJIbOOW1MaOM4SWCGdkgFYEFtxs4Aa28n1NWcnEsMv0vSRk2Mb8YkVm5jhzfIIlt9C4wKQotw/eZeo++UK29Yc/tzAvkcMSlKFgFYH4nXvroynpd5vZyklGu6OaCVZuHEOarUEeD60zGnHbFnb5gm2XwVH2wlin4wucOIlny1 QIc2oGLf ZUulWRBe2D6ryhJJ5F6xpRrb8ZdR63DyHr+efoF5ZZqKgYziYO0OyVM9JyQiddbDcdebPEnrrQvonrWapMPWipSKZ6Kt8idbBKLEgM8uWeLOwg6vvajdG4HoxTlfmzBHNp1B01Ge9bjuRCRAYOXtjKxKtZeOPBfJr4HuKw/uuFdiFuzLnqvd/z2/ArufbZ8qFeT+4OviUDmZs5Bm7wzzRDehwZXOos1crIPiil7SGO4koeeSS0GEf8E7qs2CX64JUwbbepaFDGFGSpiqGKAwJQJqbqFPq0MFWWTNUf6SL+7HhRjLHhMfPqFT1N0SLfBCq/NhFNeXQPPLOU1JTLU/BxbT2s/MyaYoaNm8wehUw8XhSZNYX7HQWrPx+3Zg76lT84YLil3q82vXtDAx3Tywpzo+/KfC/+HtKWZYRBcaSnVIPgI3IRn0NWXAVQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.04.24 10:41, zhenwei pi wrote: > Expose memory scan/reclaim information to the host side via virtio > balloon device. > > Now we have a metric to analyze the memory performance: > > y: counter increases > n: counter does not changes > h: the rate of counter change is high > l: the rate of counter change is low > > OOM: VIRTIO_BALLOON_S_OOM_KILL > STALL: VIRTIO_BALLOON_S_ALLOC_STALL > ASCAN: VIRTIO_BALLOON_S_SCAN_ASYNC > DSCAN: VIRTIO_BALLOON_S_SCAN_DIRECT > ARCLM: VIRTIO_BALLOON_S_RECLAIM_ASYNC > DRCLM: VIRTIO_BALLOON_S_RECLAIM_DIRECT > > - OOM[y], STALL[*], ASCAN[*], DSCAN[*], ARCLM[*], DRCLM[*]: > the guest runs under really critial memory pressure > > - OOM[n], STALL[h], ASCAN[*], DSCAN[l], ARCLM[*], DRCLM[l]: > the memory allocation stalls due to cgroup, not the global memory > pressure. > > - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[h]: > the memory allocation stalls due to global memory pressure. The > performance gets hurt a lot. A high ratio between DRCLM/DSCAN shows > quite effective memory reclaiming. > > - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[l]: > the memory allocation stalls due to global memory pressure. > the ratio between DRCLM/DSCAN gets low, the guest OS is thrashing > heavily, the serious case leads poor performance and difficult > trouble shooting. Ex, sshd may block on memory allocation when > accepting new connections, a user can't login a VM by ssh command. > > - OOM[n], STALL[n], ASCAN[h], DSCAN[n], ARCLM[l], DRCLM[n]: > the low ratio between ARCLM/ASCAN shows that the guest tries to > reclaim more memory, but it can't. Once more memory is required in > future, it will struggle to reclaim memory. > > Signed-off-by: zhenwei pi > --- > drivers/virtio/virtio_balloon.c | 9 +++++++++ > include/uapi/linux/virtio_balloon.h | 12 ++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 4b9c9569f6e5..7b86514e99d4 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -372,6 +372,15 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > stall += events[ALLOCSTALL_MOVABLE]; > update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); > > + update_stat(vb, idx++, VIRTIO_BALLOON_S_SCAN_ASYNC, > + pages_to_bytes(events[PGSCAN_KSWAPD])); > + update_stat(vb, idx++, VIRTIO_BALLOON_S_SCAN_DIRECT, > + pages_to_bytes(events[PGSCAN_DIRECT])); > + update_stat(vb, idx++, VIRTIO_BALLOON_S_RECLAIM_ASYNC, > + pages_to_bytes(events[PGSTEAL_KSWAPD])); > + update_stat(vb, idx++, VIRTIO_BALLOON_S_RECLAIM_DIRECT, > + pages_to_bytes(events[PGSTEAL_DIRECT])); > + > return idx; > } > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index 13d0c32ba27c..0875a9cccb01 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -73,7 +73,11 @@ struct virtio_balloon_config { > #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ > #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ > #define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ > -#define VIRTIO_BALLOON_S_NR 12 > +#define VIRTIO_BALLOON_S_SCAN_ASYNC 12 /* Amount of memory scanned asynchronously */ > +#define VIRTIO_BALLOON_S_SCAN_DIRECT 13 /* Amount of memory scanned directly */ > +#define VIRTIO_BALLOON_S_RECLAIM_ASYNC 14 /* Amount of memory reclaimed asynchronously */ > +#define VIRTIO_BALLOON_S_RECLAIM_DIRECT 15 /* Amount of memory reclaimed directly */ Should these be the other way around: ASYN_SCAN ... ASYNC_RECLAIM so we can get ... > +#define VIRTIO_BALLOON_S_NR 16 > > #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ > VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ > @@ -87,7 +91,11 @@ struct virtio_balloon_config { > VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ > VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ > VIRTIO_BALLOON_S_NAMES_prefix "oom-kill", \ > - VIRTIO_BALLOON_S_NAMES_prefix "alloc-stall" \ > + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stall", \ > + VIRTIO_BALLOON_S_NAMES_prefix "scan-async", \ > + VIRTIO_BALLOON_S_NAMES_prefix "scan-direct", \ > + VIRTIO_BALLOON_S_NAMES_prefix "reclaim-async", \ > + VIRTIO_BALLOON_S_NAMES_prefix "reclaim-direct" \ ... "async-scans", "async-reclaims" ... -- Cheers, David / dhildenb