From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C2DE7718B for ; Mon, 30 Dec 2024 02:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EDBF6B007B; Sun, 29 Dec 2024 21:58:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D7F6B0083; Sun, 29 Dec 2024 21:58:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 665516B0085; Sun, 29 Dec 2024 21:58:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4990E6B007B for ; Sun, 29 Dec 2024 21:58:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E679D120364 for ; Mon, 30 Dec 2024 02:58:43 +0000 (UTC) X-FDA: 82950116298.10.0D035FA Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf25.hostedemail.com (Postfix) with ESMTP id B3FACA0005 for ; Mon, 30 Dec 2024 02:58:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735527491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIld135pCFzLfvQjgHv5nAOdTC+ZJkjR7mxrX3V72Jk=; b=u4rTkfOVAV0V6u4MNdBTuPFDGm0z00+ZTRdKEEUmUR6f4K90+J21kQOFNvW+BtIEpEQvWK CKuct+hxiW41zcmy8xiBk6ebRevvQR3e29rblfdAWw4OFcmILc3+v4pwCNuUrLM3hSpJIC fWgitMvJy5tM+fRbkoaew+lASqOQ5lU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735527491; a=rsa-sha256; cv=none; b=ljzeScCF2lhODiSvrNxOOYrf/u3Ml/JskJDO7Re24VwAygpVn5LRKmvBb7vPl+/hES9qJC Bf31WwsvD2XFL1rn6XfcHeze43cEWqx1+moblzgqF29Km0c9Pgaf5+nXoFherqEwi3xnCu 4DhWGJE9xj0Nh6naRgldGm42L0jL2Dc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4YM12k43FDzRkY9; Mon, 30 Dec 2024 10:56:30 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id BCED3180A9E; Mon, 30 Dec 2024 10:58:35 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Dec 2024 10:58:32 +0800 Subject: Re: [PATCH v4 -next 00/15] sysctl: move sysctls from vm_table into its own files To: Jeff Layton , , References: <20241228145746.2783627-1-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: Date: Mon, 30 Dec 2024 10:58:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml100007.china.huawei.com (7.185.36.28) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B3FACA0005 X-Stat-Signature: socsehxmc457cxcrdbcawhy1pog97mz4 X-Rspam-User: X-HE-Tag: 1735527487-461822 X-HE-Meta: U2FsdGVkX187KHHnpkQlW9RzK2ii+Nunb3j4yms6zRtQTE8virqLQzZSjIhARefit/AUetquhZRFz5B0jE3QhJ7i1rTqm0HNQpycE/4rElUvdSm0f97BCAr5jdcUZXxJON3yYekjn/gSb2n4T3ykTh9rx0+tzxM04MY0ORjP1sweDY02yjhLXPQjWYByDWqG2fga9IBk2V83xadNK0mUo6qU1UCPYmwO42eUbiwDgFctm8P3KwqoOynA5AQ2muQXxp8KnYOXRZpq3Hyk62KpZSN9g35UqLbz7oKGGfvIlMHvQ/sgC+r3acO819Ian7oeE1+GmUT6Dn6Wo8+x0o2wFC9cZmKaCkpmJ+FQGhZP/rfzjiYZsHzA0IMAmh59IOWiRuun4vGqyLfTn13QSf+9Arw+Bvq3YpiSLlgExvj5GPpHVvp1cE3cM08T9su3g397hnJFY1bMosqDQsptrfrME70GH8F1AuVzFLyWzBnMhv0oZlPv9NAh2eznrr6L/FSN3XneAKQk5YF45XBnnep8E0noRJ+2AW+pGJnPy2PHv47mGqGDjAwHIf1nmcLFRRq/6rXlY9ntT8poLg0hJ857LOPYVAku5sDVAhMRh3Sh2L7IqfCa+zYNsgxKcpFTrQ18EGhaiKeuFij+xU3pbu3jHwwnQXHV6KcRflvofS1Y4+p+FedI4Ae/PrinMDnhO2mNDJpWQM52f0KiQlpjUh0shfruN0XmOBgmvkR/IgGN3IZb+Qqa6o2t7uYZq2CeM7ECMI4k9xKymHpRgXMOgx77SVEdp0BRTAH35nBLOyxmvxeO1y1HGEeKKibwICff1GXQMF2aZ+JtfnROorhjAFwH77rgEdrmbwJKnIbvWhSiZ4sfLxteHRFZPVfOJOeNJWJdBfiELKRtsovgYf2h4S6rUqNkzxMtKaVRMd/ngfuUD27lk5S1u/HS9rv9ruKCTSSbHc4sxilfdMQwR6yQkTm H0QhrEBV LqhXq4G2KP4uD2mRyoQyb9ELFhagHmIYXybDCmX1ZCqc5va4kiJ3izMqVd0m5FyIJPQzHl+rbboexW/0DfIFRl6wozytBFFoQ8VNlZ3jQ1t/3ejqJwk52nKthc9C0LiY3Sib46PAXg5lTJbIPhm94f2iRcJt/45Cv6ILrOaPTE0Eq6d7bKExkYumXrJ2pQEFygfaB/pDJMKbCku0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/28 23:11, Jeff Layton wrote: > On Sat, 2024-12-28 at 22:57 +0800, Kaixiong Yu wrote: >> This patch series moves sysctls of vm_table in kernel/sysctl.c to >> places where they actually belong, and do some related code clean-ups. >> After this patch series, all sysctls in vm_table have been moved into its >> own files, meanwhile, delete vm_table. >> >> All the modifications of this patch series base on >> linux-next(tags/next-20241219). To test this patch series, the code was >> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and >> x86_64 architectures. After this patch series is applied, all files >> under /proc/sys/vm can be read or written normally. >> >> Changes in v4: >> - due to my mistake, the previous version sent 15 patches twice. >> Please ignore that, as this version is the correct one. >> - change all "static struct ctl_table" type into >> "static const struct ctl_table" type in patch1~10,12,13,14 >> - simplify result of rpcauth_cache_shrink_count() in patch11 >> >> Changes in v3: >> - change patch1~10, patch14 title suggested by Joel Granados >> - change sysctl_stat_interval to static type in patch1 >> - add acked-by from Paul Moore in patch7 >> - change dirtytime_expire_interval to static type in patch9 >> - add acked-by from Anna Schumaker in patch11 >> >> Changes in v2: >> - fix sysctl_max_map_count undeclared issue in mm/nommu.c for patch6 >> - update changelog for patch7/12, suggested by Kees/Paul >> - fix patch8, sorry for wrong changes and forget to built with NOMMU >> - add reviewed-by from Kees except patch8 since patch8 is wrong in v1 >> - add reviewed-by from Jan Kara, Christian Brauner in patch12 >> >> Kaixiong Yu (15): >> mm: vmstat: move sysctls to mm/vmstat.c >> mm: filemap: move sysctl to mm/filemap.c >> mm: swap: move sysctl to mm/swap.c >> mm: vmscan: move vmscan sysctls to mm/vmscan.c >> mm: util: move sysctls to mm/util.c >> mm: mmap: move sysctl to mm/mmap.c >> security: min_addr: move sysctl to security/min_addr.c >> mm: nommu: move sysctl to mm/nommu.c >> fs: fs-writeback: move sysctl to fs/fs-writeback.c >> fs: drop_caches: move sysctl to fs/drop_caches.c >> sunrpc: simplify rpcauth_cache_shrink_count() >> fs: dcache: move the sysctl to fs/dcache.c >> x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c >> sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c >> sysctl: remove unneeded include >> >> arch/sh/kernel/vsyscall/vsyscall.c | 14 ++ >> arch/x86/entry/vdso/vdso32-setup.c | 16 ++- >> fs/dcache.c | 21 ++- >> fs/drop_caches.c | 23 ++- >> fs/fs-writeback.c | 30 ++-- >> include/linux/dcache.h | 7 +- >> include/linux/mm.h | 23 --- >> include/linux/mman.h | 2 - >> include/linux/swap.h | 9 -- >> include/linux/vmstat.h | 11 -- >> include/linux/writeback.h | 4 - >> kernel/sysctl.c | 221 ----------------------------- >> mm/filemap.c | 18 ++- >> mm/internal.h | 10 ++ >> mm/mmap.c | 54 +++++++ >> mm/nommu.c | 15 +- >> mm/swap.c | 16 ++- >> mm/swap.h | 1 + >> mm/util.c | 67 +++++++-- >> mm/vmscan.c | 23 +++ >> mm/vmstat.c | 44 +++++- >> net/sunrpc/auth.c | 2 +- >> security/min_addr.c | 11 ++ >> 23 files changed, 330 insertions(+), 312 deletions(-) >> > Nice cleanup. > > Reviewed-by: Jeff Layton > . Thanks for your review. Best.