From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DD1D13588 for ; Mon, 28 Oct 2024 10:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC0F16B0083; Mon, 28 Oct 2024 06:00:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D70206B0085; Mon, 28 Oct 2024 06:00:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE9706B0088; Mon, 28 Oct 2024 06:00:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A05416B0083 for ; Mon, 28 Oct 2024 06:00:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6EA94141E03 for ; Mon, 28 Oct 2024 10:00:35 +0000 (UTC) X-FDA: 82722566724.30.56D356E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 5A53D2000C for ; Mon, 28 Oct 2024 10:00:45 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KP+bAas1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730109540; a=rsa-sha256; cv=none; b=T8iu5tkJaf5D/YpIKxHKKyx0gaaxdLn/TFXIqHgDr+R3EFvj2fUS6NX+eyLghnO6WP/U3d 83L4u5OM5VBpS1C06pYuFfutAAleSLqjmyStIi6FSDTG+6mYKSvfDzWsyqVcem4FLWO2hj rTIYWSaYVoa3YCqEelrU/UTpXLGKmVk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KP+bAas1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730109540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GqzL2w6B1jVMB1dcRlFeFxzQyUCGW+BbycS3D25S+NQ=; b=sm8G+W8b0dCin/lAc8Q1cwIVBNNSLkPBDDtxVadLllqYpJLbBurs1s+ckl39PzhPKr9syh aAoRfcQwmJFk11XfFavcWzDRKeNOZDBxIuqFXIeZH/PNypT4LeVWWuDHt/IAzIgF70b7zT lHQxdMCtR9kOlej6IjY/4A/fIzoRmHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730109655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GqzL2w6B1jVMB1dcRlFeFxzQyUCGW+BbycS3D25S+NQ=; b=KP+bAas1+2p5hNfLg/SPkU1dwNP2IubvObrVAQJpe39W7hafmoVuNSWZrS97lZKZMP/eGW OcVxEFqd9AgS7v+JCuXFoCU19ogsz1x55xH6yA8k1UVFrf0O0DgdjA91Mgn58ydT2vq8Jt yDtbUeLiBsnKLahH6PVGt6z+3YVAKfo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-upVfEMHmNMWnmafFR70Klw-1; Mon, 28 Oct 2024 06:00:54 -0400 X-MC-Unique: upVfEMHmNMWnmafFR70Klw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4316138aff6so31848975e9.1 for ; Mon, 28 Oct 2024 03:00:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730109653; x=1730714453; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GqzL2w6B1jVMB1dcRlFeFxzQyUCGW+BbycS3D25S+NQ=; b=I0mfXmdgYY5tDxiVyOylbadXx84qduM56xeJFOsjz/vHuQz+3AdxViiS1oR+LwXQZZ D1dDm//75TJ8sh8TSmV4+eETq2DovkQRjwUYhcgx4dor0Yrqzis9Z6/GufHESkJMVYkh bBa5VN8Azsyfe0OlDvBUEDDMY4n92LGbrCFNcbHfbsk9CAq0nCPR3jPcxaTz05KLIBxQ DF3Cf3NzZSGbfo9lXmOaciX3fRCDNx49FX+JCVEVTIvWiOQ/Mt1euWf70Tu7ZP2rBGM1 cQU7sl5WVB5HOo6Ssnf9iXph3mkU/AGnY6QEnnnpSeD3bKBF9nVY3YR/iPw47RMFgWFZ s3fA== X-Forwarded-Encrypted: i=1; AJvYcCWa4hWOD+8YJJj1MlkRcUar0HDPkHAwn7Oxsb0VJOplw9QE8fJclWE+ibUkuGrDRmcZjUj8txMrNA==@kvack.org X-Gm-Message-State: AOJu0Yx5SDkrJjOuNMeph8lHJ9l4dFTHmxl/6JvbB7IDQSnVE8CPLhkU sK8ybufChkCIz8F3a5nEWUO12xMh9jzM1118jr6aqtCJh6zHrgLIIhDxLjP0XqrABERo05hULSK Q7LqVpXTFHoqzi5+Z6ezOc56pNjODg6JMU+tGCfD9bGWj3wuE X-Received: by 2002:a05:600c:3583:b0:42c:baf9:bee7 with SMTP id 5b1f17b1804b1-4319ac9ca86mr59630025e9.12.1730109653028; Mon, 28 Oct 2024 03:00:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdVM3p+7Xo6zsUU5thc1zg8YzT8OI4Yx0qmxg04HXjQJemWHUuIZgWmBA8dHalvp+7tmTqKQ== X-Received: by 2002:a05:600c:3583:b0:42c:baf9:bee7 with SMTP id 5b1f17b1804b1-4319ac9ca86mr59629715e9.12.1730109652604; Mon, 28 Oct 2024 03:00:52 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43193573cedsm108023625e9.4.2024.10.28.03.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 03:00:52 -0700 (PDT) Message-ID: Date: Mon, 28 Oct 2024 11:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5A53D2000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 59cjxhcetccdsxqq7fouwc3t9u5j7ms1 X-HE-Tag: 1730109645-180772 X-HE-Meta: U2FsdGVkX1969E7Qi7Ol03SKPEbouw6iIGn+5BKKcRq5R0+uGaDVCKtUt3H1ZDaHO/BR1pf8hYGbSveCN+UWnWXisf32RReQQQNoNGSydCmFkqPwWU2RB/ol0d6pR1emncH0R0tCQ+kGzgXF+3R8p1hGOD3C6eUtzlNC9fqjsi7mQDUUCRHNoZyHrA6yZLPiTClJv38DjhT23iAx9VXcfft17/15VjN8KHVH/gliJhTiv/DYqYAyA/X3TDmN9PKWYTL00KZaf1jEYwR8wG7OyRdCUztO/jfvP1PdMChcaFbvg4u9zHfjpQLwLOos93V3I22kPZ9mlHuFvWvHFyBDbRRs34XDoPH4B1U3vXNP5WoddUyr1J/f/gUD7VocETLX6upmwdNKU16TSrVY0a6crK4fsudMVUT4NkDCDVFbEZRESv1P8kuj5QepQE3XHmR0ARmsIwLGzwicgQeTYnanXXw4ILHq0+8agQDH+dtKDqPO/w6aN9zHOmqWeFiuU71BuxPaDqAcat7yyt5fG8GWWRszNgZ7Ys4bkCzb/hjdIcR93yZFBJS5aEkKXCVI17l9beqzxXyLuFIsTVjNs4VFa5RFptJfV65FA1x/4BZqgbKHwm/BFNUa5WCT7bQwhoX4dPKhjdGhcRyVfJxeTMuFc1sjp8+fZ1wJYKtw/ST+tX3OaywOSEBL+qnwC8XxQH1wmDUsEh5karnpn+M7+iGYoy2WnN2Un2grhbofF/zTlrUCuX+XEuAlmJldStwuBhzHCWp875JismkPS4c10Wawb1nEQYj3J++pRbk9zqiPInhOhkjcaRZVLQ2wGdw5ht7KGIRvRG4iymngUEE+N7BNy/GYpyOLxluGknr6cYyEfQeMdHodC2boB2cvPtvcpmWg/W9pKsTWQqPSGOT98yDTSj2cZxJk11vSbdsqbIlHORb0y4NGqyFiqBws71ebLiLMGuW4NwLlq1WY/jSFDcw ur5nyQJq iQA3tFsw3w7s/4+90BR/axwrpCUblgD9sXt1TpOMmYPtWfTWasASlsd2UwKHQojX6NtwOlhCiDQ7cPKPZI+LuvtUVw/0IsV+Winp0YPGEBUr4rY29SEoqoa699a7aOOaxqK4Ndtk5r70atGME9jQgFQjPP8u1to/UagCn5Y6xuRYUgOD7lVkhYEQUavTe5qnGlj8KtCMPvDuU8vCJR4zdn+Txae1OtL0adHls58SqB0HK0CENTHIOvVfK9DiI8SCe4IRYnQZY1So833cIGoT1a3FnZqbSLxCm4OOI/Jd3FJvXZyzDAUCGI9VIy6YVF6dJqfZQq7Rfq7hopyWOjR9EYijsU7e5J4cofznZ5BbaO8WnkHbTm99Cr6T7U8Am6VMZDeTkyux5UrDmUVN+HZOegyuBiWJaYkOufN2lLkTPUTlcBFDzem1LDQZ7Wnev8vJ9DvCJEJIce9MHfv4zCA5Zo3CtlG0U/ZvG3N4JIAUdJxRZ2+krY2HDgEl+mMVhuYViaxWLe2owIepX8b3pdJloAHGHog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.10.24 07:43, Kefeng Wang wrote: > When clearing gigantic page, it zeros page from the first page to the > last page, if directly passing addr_hint which maybe not the address > of the first page of folio, then some archs could flush the wrong cache > if it does use the addr_hint as a hint. For non-gigantic page, it > calculates the base address inside, even passed the wrong addr_hint, it > only has performance impact as the process_huge_page() wants to process > target page last to keep its cache lines hot), no functional impact. > > Let's pass the real accessed address to folio_zero_user() and use the > aligned address in clear_gigantic_page() to fix it. > > Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to folio_zero_user()") > Signed-off-by: Kefeng Wang > --- > v2: > - update changelog to clarify the impact, per Andrew > > fs/hugetlbfs/inode.c | 2 +- > mm/memory.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index a4441fb77f7c..a5ea006f403e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > error = PTR_ERR(folio); > goto out; > } > - folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); > + folio_zero_user(folio, addr); > __folio_mark_uptodate(folio); > error = hugetlb_add_to_page_cache(folio, mapping, index); > if (unlikely(error)) { > diff --git a/mm/memory.c b/mm/memory.c > index 75c2dfd04f72..ef47b7ea5ddd 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6821,6 +6821,7 @@ static void clear_gigantic_page(struct folio *folio, unsigned long addr, > int i; > > might_sleep(); > + addr = ALIGN_DOWN(addr, folio_size(folio)); Right, that's what's effectively done in a very bad way in process_huge_page() unsigned long addr = addr_hint & ~(((unsigned long)nr_pages << PAGE_SHIFT) - 1); That should all be cleaned up ... process_huge_page() likely shouldn't be even consuming "nr_pages". In clear_gigantic_page(), can you please rename the "unsigned long addr" parameter to unsigned long "addr_hint" and use an additional "unsigned long addr" ? -- Cheers, David / dhildenb