From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E142C28B2E for ; Tue, 11 Mar 2025 11:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1265F280003; Tue, 11 Mar 2025 07:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FE6D280001; Tue, 11 Mar 2025 07:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9485280003; Tue, 11 Mar 2025 07:29:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFCB5280001 for ; Tue, 11 Mar 2025 07:29:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 404391A1D51 for ; Tue, 11 Mar 2025 11:29:40 +0000 (UTC) X-FDA: 83209050120.02.13C0E25 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 17CEA40012 for ; Tue, 11 Mar 2025 11:29:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Izhc1lc5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=FmbLC9Vx; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741692577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vkY2e2tICmhBu70Pd5loGVqWwzXdYNSZXvQVCdfBawc=; b=H6X3DfxOjPQszvV/3OahY/UC4EusxHA4hwwq1EwG8TYfE7UUpqsrpRDUDxiAn+SEhOL5PK EbUQyj0lAdDU+cY9QpyRuNjYZjb0Q6n9bl481aeHlkcnCuQxiBII1eICQDDhmM9oD6fBmC ckrqPAREsUsaHmv4M7elTOrXxlEjfQc= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Izhc1lc5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=FmbLC9Vx; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741692577; a=rsa-sha256; cv=pass; b=pvtCzDD/vHwW3BdnK6bUn9em4Prcz/be5wB6T1ojrz0KgcppFawGKbmb+HGoLRYgzK+9LT R1pmag7ta48jt6+VkxpennjpnaIVutdOdEwh8D4viHIJ3C7RLx6ciw3eKts+MZAl+JlrRe JRtX9zvyPiQuKdnpQHPq0nGGReh2x1M= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52B1fqlc013378; Tue, 11 Mar 2025 11:29:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=vkY2e2tICmhBu70Pd5 loGVqWwzXdYNSZXvQVCdfBawc=; b=Izhc1lc5puriLO5/OcZhtlRvcEpYUiGNmI VQ/ya5r8v6I7a9tVoqbZeh7auOWdFUJGoFNCS2LbQhcFR2w8zz0/e4FRa1qW+FGR 97ntzkCOPYgzGnP7OcEWXaL5uMzqnmcYTHD24h7yunxaXf9BTZSXnVqgdcAW/ZCU PIqnvT/rYy8HtCVr5HiWKYYNqJLHpn1SoPPOeu5ywpjuG2T5IEi4OSA2tl6d3/hf Dnt5vZObZPwnl3p+SCY4Jw5z52FoqeZ4EyRGxc6srBVxfKwmn8BII9gbD5FRwcWs QvTeBamWkqF2OTYZyDgCal+MgqxbcqgzvQO8emDtanKH/vYJ2YxQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 458dgt4j2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 11:29:26 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 52B9FJNM030561; Tue, 11 Mar 2025 11:29:25 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 458gcn89a8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 11:29:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QPNn4Dglu9oZ0K7HjN1REy471SNwqx8ubqT5/BcQQxPPDrTRZtDmXy8w3a1DShYTzRXuFpm+FDLXifk6zi83nt/8Z79Rp+beBDlsvkmYLm2Y0318LmQFEH1SgdrJXvwevVHZk4YSrMLcECkv8I7DdTaVFaVzQuyVYKGH5W5XM4P/O3Yk6vBaIHbjQC/YnTVxQUszHNntYeIgUMfmP1VyjrajO5u3pyr3kurHTA6+ooSAdakqjG7VC83cTU9OCBzDdRcfNaYm64ObQwbjmAwgEcsQ8hbUPUxu8K8JD7ItzAHAS+DaDxUGQ19N64c/2GSc11WJodTjrIy2m/sskHqxLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vkY2e2tICmhBu70Pd5loGVqWwzXdYNSZXvQVCdfBawc=; b=LPQcbso3StLMwIM+dagXtXuUm16oYtbnUKZAo5Rw2605Db/NLrMHdAEZ2PE6Fha8EWheFIVSbQNk9+DA0B4BwEXoF/bttselKqxq+aXqtGuxc0MHALuaJKzeUnaEc1Yr7N2BKOfZKJHofoB+acYWi+C1+FLwXTpi1bvVBq2pQW1QwqYGIbm5g/7lMUZDlsj8d037SzrzNT882hMOTE2wDMNpmy8TzA19pYj0km/lNhm3PDkNRjWc0LAyL9970Io2I1d7S/5sWeAGIkCELq5LAaO5jmamn7/HWwD9h41ogboKK3JYCUsWRxkxBsUNuOZzK1tLq89PH5vq4MWWVSAvUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkY2e2tICmhBu70Pd5loGVqWwzXdYNSZXvQVCdfBawc=; b=FmbLC9VxNKR8AbvYyc6Yd9mIfUg2THGcFZ6o9jMMveGFF0Xvgbv72jGbeWJVU6KOsqxubN6u8sHTVAQPqcdLeMCtWTHi46aM4xV8b6VipgezD9OmeiMgnLP1ly+0qSQ2aftga8H9sDPlGU098BxVVn1r7/2uGH2pWvTF9UkzrDc= Received: from MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) by IA1PR10MB6097.namprd10.prod.outlook.com (2603:10b6:208:3ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.22; Tue, 11 Mar 2025 11:29:21 +0000 Received: from MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c]) by MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c%7]) with mapi id 15.20.8489.025; Tue, 11 Mar 2025 11:29:21 +0000 Date: Tue, 11 Mar 2025 11:29:19 +0000 From: Lorenzo Stoakes To: SeongJae Park Cc: Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/9] mm/madvise: split out populate behavior check logic Message-ID: References: <20250310172318.653630-1-sj@kernel.org> <20250310172318.653630-3-sj@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310172318.653630-3-sj@kernel.org> X-ClientProxiedBy: LO4P123CA0264.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::17) To MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4112:EE_|IA1PR10MB6097:EE_ X-MS-Office365-Filtering-Correlation-Id: 38d70256-0dc7-4268-039c-08dd608ff82a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tQkkRX96E9MD0eSPg3wmXLSZ88zNCDYx5emBSKtvlRjy8vK3qmZxSzKRWo0C?= =?us-ascii?Q?d6iOmGvn7/EGFh7FUQ0qdjBrOwBcNnQMZuURWSu0xSwzzL/8wmPKqAjWOb0w?= =?us-ascii?Q?xSd1RXLtoKPravXm8qYU8V6UMj8IWH66z0DQ6fH9PmO69nS5m/9a/3tFK+Ox?= =?us-ascii?Q?tsuxc14PzbJIPdPaOY+IMl3F0qe2kqrGl0//DiIdpNkqcXia6q5GVP3H2Hyg?= =?us-ascii?Q?3jsToN6gCmg0A00tAiyDStXYRZhnZiRO77a2/V6HhEnciugQKW5HQjGa0XYr?= =?us-ascii?Q?9q5Kcs5hUBjmvh2rx4gE1l8oXlVEhKp9FxCzz/w4FPW7VOKcJFPN+v/yV7HJ?= =?us-ascii?Q?gm9yzVPd/73kPj3sw97ihZH7CaekkQ7d4pcfxXML+jIVwkYrdPHpurvSR9Vj?= =?us-ascii?Q?JwGEnAsccbpI81ybKA5WGYp2cNOYwOtxG1m1SnKTzAaOWbG8A3oZZovJB6El?= =?us-ascii?Q?k2XuJyS5Dvb/pudWlA3dHrIw3rJwPMYgO2MzeLueJfjB2nQRhTrW3/i/a2GI?= =?us-ascii?Q?M1MfGaMwqV4sFjgejdKluBZ2KKLQsnG8EwFb8jlhrCjXc8tbTYy3U8P8oBaM?= =?us-ascii?Q?QVOk0trEiEyZgYOMMoyRiXZaEj3nTzJqEPidUtaDD9dQENqmPtqbWxECnqGd?= =?us-ascii?Q?r1Sy4T1hn4XBdEZ9lJ2yose06/QTIGcj+IBQYIBp0s3mDtloYDHYy/lmRKeN?= =?us-ascii?Q?n6YQYCB7X+5jwePwxSo/OUdbQB398N5PXwpWNjgRCV5g6nkKD8MMgYndDU9c?= =?us-ascii?Q?bhdQM9B8I6ru4sg9vTE4pK79vEOc+a9Lr7zsUf6cCQaxNo7wYKrbAwek/Wjr?= =?us-ascii?Q?IiNnyhjiQlH3xs+7shECiTFf2qaLsUYUsycuX1k6dqlG3q6YbVrebcZXgz6V?= =?us-ascii?Q?dZBRltaD13kGsj2VmUOfvTjf3PvlTk6Zu/Bg6jeWmn6ZSd94jM2FlU6VRCYi?= =?us-ascii?Q?KN6bAqVNrGCJC3IZ8DoXVSOmukgw+mdMAlYbZHDcanrTHgUlzjhWEAXFxtMc?= =?us-ascii?Q?ycWF4Uo0BP3gJNm1+pjRAnfFHUdkW+KM9TF3TMwiNKRHEO7OCuB9RlnCF79P?= =?us-ascii?Q?gyfkZHokNhIvAhpzvq2eAONVq6VlCAl7FYAf2/rnkjD836ZDJV4uVKJLCPKl?= =?us-ascii?Q?2doFAbGczvqggmKZ5ZJU6dF62neiqA6o5KVwroXf4OqOTicKNYgq9txdi+cg?= =?us-ascii?Q?7eDMOrgRMfSilRw4RXU/tUwh2+kPFp54w+mRzOWa2//HIXGxrgF1tWCNUO/Y?= =?us-ascii?Q?wfyivlyK9wQqDlodk8AZ9Ipkx0svZsnTnS8DOC2bt/a4OTU9GkCOKooDPV45?= =?us-ascii?Q?6k1LDN9Fs+qrC1wGvDt4KfrT0u1W8RHgsKiiJyZvFsIinMIKAFULLbd3YCkZ?= =?us-ascii?Q?OLuMrwa4U5f9eYi5WICiSVltGo3u?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4112.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hIkwO3IMIdvAov51/4IHXnf9oF7oFiTicYS/ajeWy1CLrapHHA54Gv86Biak?= =?us-ascii?Q?40UkNplbk25aL82O66h57ZZxfWrWQhmXR0k6nDZnjCMUfhoLcAYroyraC63o?= =?us-ascii?Q?sAecBSxXDd2cS2T3t95CyNd0od4yNb2orjLh4qeprT3qVSyMm4+Dm7Rm6tuZ?= =?us-ascii?Q?iNnTufbvbfMT3PNUgoPzxRx93zHNPZgQ6zchmIVELCMdIJH4SPX2M4w8sTHr?= =?us-ascii?Q?wyAxp0q0u8dFi3mT2a6+qPseRYddngySCANcPMCu0m3YQj96YmGbTnIszftY?= =?us-ascii?Q?brg+sAZiL2NOkCgphon3iyQSP+6vNKlIY2k8TE0fvXnaAFjLzrMW1vebamg/?= =?us-ascii?Q?p3tj578cEzFjzfZglLXZP27ts+FGkf3vtMN6z/SR6qPgDJVcj8nUQd4yPfAZ?= =?us-ascii?Q?FWRjTOkPmDCRasPtuTcbI2yZ0vqXw35vxseSAjyOwn8+JjrobdnviDIaTWsv?= =?us-ascii?Q?tkBf8p7HYFTxPTX+lTHJoDNRPFvoGNcnduL7Um0vAdvvTH+Q6BYFryimYNre?= =?us-ascii?Q?6CydDSEH77CU3jpCi/zxF9UzSNuaJgp8Oj5XWlEpFs+CWJSJARBq9MOHFerC?= =?us-ascii?Q?Pk0/TvTLhcVU2ttYrGrw3smJimU64YRV/hTzxfctejFU1+//etjmp1m4yNXt?= =?us-ascii?Q?EMUeeiOiNcxAKFJt4AbSwLC4Cvjxf1hTl1N2kccwoyC782AznFW+N0hKzReM?= =?us-ascii?Q?9T5RYu+KPFGH5FnP/IX6T9Ig5za9rNtag9ZAJvGSR2ezuI7vbrv2+07Hdzn7?= =?us-ascii?Q?C3cEPYUElSBgoT/uuyC1uE+Kj04UpXxtgMy7h9rMLqWtc7oqQzkP8dqME28F?= =?us-ascii?Q?XvEYSFKKi2S0YICjUA+Q46NpWtS9RFrGhD9Jms4EzkNDhbglJlJ9ppVKQblo?= =?us-ascii?Q?a4uNmjGdbuZktM6CjSYmzgm26CtRWrqgtH4KUMCRkuv+t5yslOjT3mZzmqpY?= =?us-ascii?Q?Y+8x8oR3Hyx/JZyRNDQcwk4Kcq/0Anzs02ft52CXUjWZ15Djcts4MCN17lxa?= =?us-ascii?Q?OG9AXWy4rV2KupNj3FvRE6UNFwHAhqOlhlbLOvg2BAxG43AkAcVK27rzCQDr?= =?us-ascii?Q?1nTC4PN5U50EjsJr1jLCb6wy3PL/eYym9Tv3ZYMmJbFQ8isllETKLQ7RCLko?= =?us-ascii?Q?dh3vwzY0jU6WbW23ODPm+4BY3QH72wehykumF4lUcIQ0H+w6uXLhuPLFxk6k?= =?us-ascii?Q?LGimwEJxzEpMpixkrX4h+zwqjrymQAyxT54hIvgFxsd6VcjoGgwWsgfURAy8?= =?us-ascii?Q?e2FxY2np1C3chsQwl81mBbWll+beXa9eTeXGUrrxc/3eptmMi/8ZsrtiSps5?= =?us-ascii?Q?GgmWALfICbNLpm+CIlc/YiEBPDRsscTXnOIOS1L/OIMAjzU5775IALlvZ5Qf?= =?us-ascii?Q?q0MceHKWjswEMAL8/WmGS4PuP+5DUdCBbFtUQfebs3rAVn/JupVT9FVegTeJ?= =?us-ascii?Q?5oRT4VRAyCMa7gR9TCCLsUFq4b9An26hFwqi8q/5Eg6fRU/e2YDvxpZiPM0P?= =?us-ascii?Q?yWZtWXYVhH1lwJKeQfQxn9GzJH0tuTH4MP4wnEVEMZl51LtCbEsMuCG6DuDm?= =?us-ascii?Q?rV60+nofWGXlOwgj/cEf9aDw0VRJdJSNlMSGObdSXZI7ukacwvFTsBBBLOID?= =?us-ascii?Q?Og=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +sWij1XLP1Gb9egNx7bMkNctNjFYuv/oPtHyUwm6S8gVJeIAxHQ345bdbx4j2sNoyU9LmvdYsLmpt6aJlra01my0QmdSuxFAOahJ6bXcFee+8b0UvK5LwOJXtrTfcip9EP6Aw/qeMMmhRsyFb2ogqXOnpenNdcC8EVoiLC0M1UB9TTEtyBBWP4HLodS9Yl3pPuXcOOsRZubJv7xzNzfD4B+D5CosetBjsZpY9aKi47SQzOHuQKBl5oj3Bk5bXvXG3oxunOviWaagUlKWjVkcgeaTyYw57MN4yKml1AELGcnuWuMkCV1D3eF8XZkvFVuyV7+a1XOF8UzsXOmOw6rl1Vo1IXb/aLnBQDkHkzwDdAaO8xqAxU7GItx07NDS+aCSFVUa0lKy9y0CI2YyftW81sC1LjC0ZonP//DchhgqSrKrXSG0M1s+VG2kjUqLaZOpv23G01jiNiKdvLGvWZPAIybowenkLki6gNqDHx30ctyCscRamM9jpr61wfOM79Dx4QhX9bnrznMceAc5qZGHSy8aaKyjlK4IvX5QzpkgeJVhlwJJv9xc1Ptam3Zo12T+qVxY07sSGzfhbtryTl52Ehn0jberZIVO+FfOFJZ9NHU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38d70256-0dc7-4268-039c-08dd608ff82a X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4112.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2025 11:29:21.7957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HsXyVz9rY+jtPNskiPDKX4651Gm965jr6Wq25Vx2DPne4DiVlASC0piJbbCz7xiHBLZVS5DtOXuO5oJv44GjRAPsojZ9uxc1rdjxGEFVMZU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6097 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-11_01,2025-03-11_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2503110075 X-Proofpoint-GUID: cqXesEU3ASptGmnZFKi-BCHJmULHYeLS X-Proofpoint-ORIG-GUID: cqXesEU3ASptGmnZFKi-BCHJmULHYeLS X-Rspam-User: X-Rspamd-Queue-Id: 17CEA40012 X-Rspamd-Server: rspam03 X-Stat-Signature: 6ugzmkn7s15hsd7touyaag9dm9dmu7ra X-HE-Tag: 1741692576-326159 X-HE-Meta: U2FsdGVkX19Kzu3g65M8sG59KBkoF+aNJW8RMXlSSX9vz/3kPABbA7cOWqk5rUh3dm9P8yM38oD5PJ2hyIOvB9cW0uQaHapLlQDw0MizVPgEFgLkXOuQkgHbjCI7yeG1Xswg3jcAhth8d+mfdBZz5IcWm45D8TYQ4zJ2/VsiH+q7pYcvBzT02NHlSR3fYhEgeTFu4mNI4lZvKWdfq111L4caf3hJ6beAk+Y8XUYfFwmm4i54eJ2IB4dy6ngex1xQE1fj4BtxEIo2v4SezoJtvANp2/wYBJdsAd/iUu/qxK4uYtPlL2+QSXgfN5ccvJQJIFDb43Fic+KiQWIPgLSRSCI7ikZvscby/bDSd8D+HxqjnXcTQd+2KOoCWV2ntD+yJjhoAm+EZiJknDoLoPBHm/lPeB0N1tRIkz5C/ilzPe4OrmxEcD5fK2PTyDkP23VbhOmoWvzdYqQMjUujL6CudRv7kXE/YvRlAGDseZZhFRxKtQBZdvYIrVWmkvTIQWC15j0OUOaCK/Ig83yxozMhIIVAJl8mGDHDCeixZ5zLYs4vi9YryvMbWs+i3j9a6fIYuA1XH6r8Jkd7dl12XXYAa7WW1/teDRhBzgOs7/06MdlWSuYKsILa/FbYLqWQseBKq4VVQ4PHVDre3wWYW42hj76zCC5nUqqRchiohzrSvhSN8uUfmo8fuVh/7t+E38f2emL+j8TCcHJt5oGHPi1gQooMPTMFVWxottDXbB/pvSdzrDiyz2jK/9dVtBwtak8c3FnskK4X2+xV2QEcxcK+mi+ZIg8QXGs7jeT35GerKP71uQjmtdXirSQXE0iVuDK9M5JsNGg7Zf6pGVg8/Kcw1UNm008qA0qB8eF4/ovcKZvqgWExx0wV9Qbl+Acdna19KaHfGeDOYQ/xv4UkcvZR4VRJqoVD+CoxA8qBFY6l2Mg8dUo4kpIjxRFRqUjnmul0NOdPYmhUwxEAjdlTUL9 VIsyy4eb +XXCBUMOOyO9CpPXvQe3OKNYftiX8dynlm7tXKxnLqyRLQrBeoGV0/j4hNNxfDDUtUvXsutMYSRdCXhL6WsJ2bkmWHrD6n8Gd2C2/mY9Hca97+4Pu8EvE7Nr4LRtxOKYPHLc0shNfnYB3CehQDgPrqef+qW1RTFe8vkxLBxUtACfDB2IRMutxHZSFFi7qvkan4D8BRqKQvxRn6SlXrK9Rrag+BQKU4qOJus8EiztM711zguuz9ff1gjn8/nT33X5LxPKighHbNdWMX923GCDTNZFrA6VXytph9N2EoT0Mv/tOM66HHyQkSlPoZHDSu7QGIGeX2pWSDWDMxXmSDZqHU5+xqmHA/HS+u5lKdvEE4PX7k92LD8UKYXLlbi3x/9chAyqWbT4QRl+miqtCRliO7Q6zJ8haL+MhCOttiorWoDmqNZzC2I0CFqU8Bu1/5SG2XkrLEQlbWo+J8gHM08vgxG/k+RfTPbHlQpHExOuWwN51034FPy8KYPGH0bdUv5NdepaB/stRxOGn3++P1LCN4ZDEZ5sC5NXMoppJmcfxNwxMlXIw8802NTCjdiiPAPVRvI+IiDFUqDnkuEx1n1K18XTXAJJYce9HkHN2HfSavAFqTIIibqrdMC6IPYx6lbsYW96+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 10:23:11AM -0700, SeongJae Park wrote: > madvise_do_behavior() has a long open-coded 'behavior' check for > MADV_POPULATE_{READ,WRITE}. It adds multiple layers[1] and make the > code arguably take longer time to read. Like is_memory_failure(), split > out the check to a separate function. This is not technically removing > the additional layer but discourage further extending the switch-case. > Also it makes madvise_do_behavior() code shorter and therefore easier to > read. > > [1] https://lore.kernel.org/bd6d0bf1-c79e-46bd-a810-9791efb9ad73@lucifer.local > > Signed-off-by: SeongJae Park LGTM, so: Reviewed-by: Lorenzo Stoakes > --- > mm/madvise.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index c3ab1f283b18..611db868ae38 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1640,6 +1640,17 @@ static bool is_valid_madvise(unsigned long start, size_t len_in, int behavior) > return true; > } > > +static bool is_madvise_populate(int behavior) > +{ > + switch (behavior) { > + case MADV_POPULATE_READ: > + case MADV_POPULATE_WRITE: > + return true; > + default: > + return false; > + } > +} > + > static int madvise_do_behavior(struct mm_struct *mm, > unsigned long start, size_t len_in, size_t len, int behavior) > { > @@ -1653,16 +1664,11 @@ static int madvise_do_behavior(struct mm_struct *mm, > end = start + len; > > blk_start_plug(&plug); > - switch (behavior) { > - case MADV_POPULATE_READ: > - case MADV_POPULATE_WRITE: > + if (is_madvise_populate(behavior)) > error = madvise_populate(mm, start, end, behavior); > - break; > - default: > + else > error = madvise_walk_vmas(mm, start, end, behavior, > madvise_vma_behavior); > - break; > - } > blk_finish_plug(&plug); > return error; > } > -- > 2.39.5