From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D509C2D0BF for ; Thu, 5 Dec 2019 08:23:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AF6C24648 for ; Thu, 5 Dec 2019 08:23:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AF6C24648 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9031B6B0F32; Thu, 5 Dec 2019 03:23:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DA336B0F33; Thu, 5 Dec 2019 03:23:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8172A6B0F34; Thu, 5 Dec 2019 03:23:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 6C2126B0F32 for ; Thu, 5 Dec 2019 03:23:56 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 1FBD53CF8 for ; Thu, 5 Dec 2019 08:23:56 +0000 (UTC) X-FDA: 76230399672.21.drink68_223fde190d319 X-HE-Tag: drink68_223fde190d319 X-Filterd-Recvd-Size: 2650 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 08:23:55 +0000 (UTC) Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1icmQ5-00057R-Aj; Thu, 05 Dec 2019 11:23:29 +0300 Subject: Re: [PATCH] mm: vmscan: protect shrinker idr replace with CONFIG_MEMCG To: Yang Shi , hannes@cmpxchg.org, mhocko@suse.com, shakeelb@google.com, guro@fb.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1575486978-45249-1-git-send-email-yang.shi@linux.alibaba.com> From: Kirill Tkhai Message-ID: Date: Thu, 5 Dec 2019 11:23:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1575486978-45249-1-git-send-email-yang.shi@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.12.2019 22:16, Yang Shi wrote: > Since commit 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: > make shrinker not depend on memcg kmem"), shrinkers' idr is protected by > CONFIG_MEMCG instead of CONFIG_MEMCG_KMEM, so it makes no sense to > protect shrinker idr replace with CONFIG_MEMCG_KMEM. > > Cc: Kirill Tkhai > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Shakeel Butt > Cc: Roman Gushchin > Signed-off-by: Yang Shi It looks like that in CONFIG_SLOB case we do not even call some shrinkers for subordinate mem cgroups (i.e., we don't call deferred_split_shrinker), since they never become completely registered. Fixes: 0a432dcbeb32edcd211a5d8f7847d0da7642a8b4 ("mm: shrinker: make shrinker not depend on memcg kmem") Reviewed-by: Kirill Tkhai > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index ee4eecc..e7f10c4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -422,7 +422,7 @@ void register_shrinker_prepared(struct shrinker *shrinker) > { > down_write(&shrinker_rwsem); > list_add_tail(&shrinker->list, &shrinker_list); > -#ifdef CONFIG_MEMCG_KMEM > +#ifdef CONFIG_MEMCG > if (shrinker->flags & SHRINKER_MEMCG_AWARE) > idr_replace(&shrinker_idr, shrinker, shrinker->id); > #endif >