From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: catalin.marinas@arm.com, will@kernel.org,
lorenzo.stoakes@oracle.com, ryan.roberts@arm.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, riel@surriel.com,
harry.yoo@oracle.com, jannh@google.com, willy@infradead.org,
baohua@kernel.org, dev.jain@arm.com, axelrasmussen@google.com,
yuanchu@google.com, weixugc@google.com, hannes@cmpxchg.org,
zhengqi.arch@bytedance.com, shakeel.butt@linux.dev,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] mm: support batched checking of the young flag for MGLRU
Date: Tue, 3 Mar 2026 09:57:23 +0100 [thread overview]
Message-ID: <e2f163d0-db70-4484-b8a3-48e1a347288f@kernel.org> (raw)
In-Reply-To: <3701c315-b19c-4c87-aff3-cc76e1009a43@linux.alibaba.com>
>> unsigned long pfn;
>> struct folio *folio;
>> - pte_t ptent = ptep_get(pte + i);
>> + pte_t ptent = ptep_get(pte);
>> + nr = 1;
>> total++;
>> walk->mm_stats[MM_LEAF_TOTAL]++;
>> @@ -3533,7 +3534,16 @@ static bool walk_pte_range(pmd_t *pmd,
>> unsigned long start, unsigned long end,
>> if (!folio)
>> continue;
>
> Thanks for the code. I considered simplifying the logic this way, but
> this logic would be incorrect. Because the 'start' can be updated by the
> get_next_vma() below, when we goto restart, we will get a new 'i' value
> by 'pte_index(start)', so I kept the 'i' variable.
You're right, that's some horrible, horrible code.
--
Cheers,
David
next prev parent reply other threads:[~2026-03-03 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 9:44 [PATCH v2 0/6] " Baolin Wang
2026-02-27 9:44 ` [PATCH v2 1/6] mm: use inline helper functions instead of ugly macros Baolin Wang
2026-02-27 9:44 ` [PATCH v2 2/6] mm: rename ptep/pmdp_clear_young_notify() to ptep/pmdp_test_and_clear_young_notify() Baolin Wang
2026-03-02 9:06 ` David Hildenbrand (Arm)
2026-02-27 9:44 ` [PATCH v2 3/6] mm: rmap: add a ZONE_DEVICE folio warning in folio_referenced() Baolin Wang
2026-02-27 9:44 ` [PATCH v2 4/6] mm: add a batched helper to clear the young flag for large folios Baolin Wang
2026-03-02 9:07 ` David Hildenbrand (Arm)
2026-03-03 2:36 ` Baolin Wang
2026-03-03 8:51 ` David Hildenbrand (Arm)
2026-02-27 9:44 ` [PATCH v2 5/6] mm: support batched checking of the young flag for MGLRU Baolin Wang
2026-03-02 9:57 ` David Hildenbrand (Arm)
2026-03-03 6:03 ` Baolin Wang
2026-03-03 8:57 ` David Hildenbrand (Arm) [this message]
2026-02-27 9:44 ` [PATCH v2 6/6] arm64: mm: implement the architecture-specific test_and_clear_young_ptes() Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f163d0-db70-4484-b8a3-48e1a347288f@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=catalin.marinas@arm.com \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=jannh@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox