From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBC3C4332F for ; Mon, 21 Nov 2022 08:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 718CD6B0072; Mon, 21 Nov 2022 03:05:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C8E46B0073; Mon, 21 Nov 2022 03:05:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 569FF6B0074; Mon, 21 Nov 2022 03:05:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 453F66B0072 for ; Mon, 21 Nov 2022 03:05:52 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1E40D1A0ED3 for ; Mon, 21 Nov 2022 08:05:52 +0000 (UTC) X-FDA: 80156715744.23.43BC99E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A733E40014 for ; Mon, 21 Nov 2022 08:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669017948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4fkuVnnKfnYdazWQA0wQdSIDRDvDUTp9+DxYQu2B22U=; b=U9zqECG1xbkZUhVQdXzBTvjNOoe1NKcRFALjzwEREbQcHL6SwG0mlynNdPKmr2osLtfpKJ C/IjGjEQIvqY9Yfxn165IbI0lQ6VjWatUsUq6TttUKUekjKKyeAxQQ3EecHT34fJMCdI5d bSqPjpXfJM0aX/Hrlil94QDQ8HfeMZQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-260-TpCKs8A0M8md5omNtTSVTA-1; Mon, 21 Nov 2022 03:05:46 -0500 X-MC-Unique: TpCKs8A0M8md5omNtTSVTA-1 Received: by mail-wm1-f72.google.com with SMTP id f1-20020a1cc901000000b003cf703a4f08so2769936wmb.2 for ; Mon, 21 Nov 2022 00:05:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4fkuVnnKfnYdazWQA0wQdSIDRDvDUTp9+DxYQu2B22U=; b=bg3tha4WdZF/TtB+bo7bjDe2B2/tzQFB+jnjuxqSXw0FA0YEvWSc8gDZrRBTUyG6m8 CPOOUHyPd2YAvu0tXqmU0oy6Po6JuIwnafHHmUTxUreQwmOO6LfHYPug0m54Yd4hLE1A jNGeL/fj+NHY+6mvNIb4hv+p88b5Gfyw745jVfz2m1q4lReQhpJ4yj1mneojaRUv4pR7 83J7hp794DQozFjS8F9qH+ZRz3hfKBCiOyQ+f07DE/P0K4rufS3UbVq6XJyi9IRcu4n3 GeFBhv6+XwTZkNdZ1c+waDn/azx99Z0keLii8CfZcd7w1RXNvnVMMd6vo2I8D1rtUmDq HlNQ== X-Gm-Message-State: ANoB5pm3FwyHjQokLBtNjp15Ys0UlFdpGZCuDdeBm6S6xTDDwDY1WOlv 0xQb0lKkhfDriq0yCec3jj3w6WJKqgb1MtJjXOJJoU3aAQhnsdK27xSieRG1WAETSeJu/yDa7eW e2vxGz+0KEWU= X-Received: by 2002:a5d:4404:0:b0:236:657e:757e with SMTP id z4-20020a5d4404000000b00236657e757emr2407090wrq.350.1669017945460; Mon, 21 Nov 2022 00:05:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf5T7MYZ1Z7Tgz3Lc6SCcOpsIQYMy0SCl85W6ZxjqCOEXMJCtZCTWw6mvGWUD1VqWChgbiyWGw== X-Received: by 2002:a5d:4404:0:b0:236:657e:757e with SMTP id z4-20020a5d4404000000b00236657e757emr2407080wrq.350.1669017945195; Mon, 21 Nov 2022 00:05:45 -0800 (PST) Received: from ?IPV6:2003:cb:c702:dc00:2571:c3c2:c6ea:84ef? (p200300cbc702dc002571c3c2c6ea84ef.dip0.t-ipconnect.de. [2003:cb:c702:dc00:2571:c3c2:c6ea:84ef]) by smtp.gmail.com with ESMTPSA id f19-20020a05600c155300b003c6f3e5ba42sm19113223wmg.46.2022.11.21.00.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 00:05:44 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 09:05:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings To: Mike Kravetz , Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Peter Xu , John Hubbard , syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com References: <20221031152524.173644-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669017948; a=rsa-sha256; cv=none; b=Brpxfr4NizGs+LMEhSY+oO26IUEyC30CIhhR2Hh8jJC+vZC6c75GQ22wcENNj/HGs8FAmh bhjPk4RZa9bFyf7+y2m7qPCWRgNx/Uzlgp2fDwTt9qyLfjrcvuCd1hTCopAvYo4d6dWsTU 0D6qaRxVlqKGy5paE7j0gblRMbmRxcs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9zqECG1; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669017948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4fkuVnnKfnYdazWQA0wQdSIDRDvDUTp9+DxYQu2B22U=; b=N8H1WrN0E3+xhfgFdqKS6fEh6SvouK720cuIgsws6bhY+ZEXlO4f44BFReRCf1pqlH72DS 4rlUJrXIhk6e7V+Ztq3oHVnpHgStO4PpAhsdyXDLZeEw2wKbz7fMGbtnLu+CgZJL6dj/jz HTohzNnUgZjUH2+p2I4EYCA8H2ZH1SU= X-Rspam-User: X-Stat-Signature: qnpp1k18u1kzhamerwwowntisgu3dok1 X-Rspamd-Queue-Id: A733E40014 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9zqECG1; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-HE-Tag: 1669017948-880075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.10.22 23:13, Mike Kravetz wrote: > On 10/31/22 13:14, Jason Gunthorpe wrote: >> On Mon, Oct 31, 2022 at 04:25:24PM +0100, David Hildenbrand wrote: >>> Cc: Andrew Morton >>> Cc: Mike Kravetz >>> Cc: Peter Xu >>> Cc: John Hubbard >>> Cc: Jason Gunthorpe >>> Reported-by: syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com >>> Signed-off-by: David Hildenbrand >>> --- >>> >>> I assume this has been broken at least since 2014, when mm/gup.c came to >>> life. I failed to come up with a suitable Fixes tag quickly. >> >> I'm worried this would break RDMA over hugetlbfs maps - which is a >> real thing people do. > > Yes, it is a real thing. Unfortunately, I do not know exactly how it is used. > >> >> MikeK do you have test cases? > > Sorry, I do not have any test cases. > > I can ask one of our product groups about their usage. But, that would > certainly not be a comprehensive view. With https://lkml.kernel.org/r/20221116102659.70287-1-david@redhat.com on it's way, the RDMA concern should be gone, hopefully. @Andrew, can you queue this one? Thanks. -- Thanks, David / dhildenb