From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE66DC4167B for ; Tue, 5 Dec 2023 13:32:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D9F16B0088; Tue, 5 Dec 2023 08:32:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 489576B0092; Tue, 5 Dec 2023 08:32:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 329D16B0093; Tue, 5 Dec 2023 08:32:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1FC616B0088 for ; Tue, 5 Dec 2023 08:32:15 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C5EFCA0747 for ; Tue, 5 Dec 2023 13:32:14 +0000 (UTC) X-FDA: 81532853388.10.91BFBB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 1153080024 for ; Tue, 5 Dec 2023 13:32:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MCKqCksS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701783132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZlWEYQXKg81nONkiYpPbgG9RelSWsxKHpc2b5kqkVXg=; b=Ac9Eg/6salaX38midSQW0dWUQRCmgbD/FEcIKlmSHRFe/Arx5ug8JqUDsI4vqLmFuwzZGQ t2NHT4uhuyNH1rsuVWLxv6BhXTMRFUKP2UdY1Xwe2jQZmkqRM7cUpqQwwazd/AJBfdzeJ/ Kr+9XDe/kHIz9DsEaUY6Ye5PGmwtJw4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MCKqCksS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701783132; a=rsa-sha256; cv=none; b=q0QsNiUBRueRUR84sttl6/Vui/wlvStLF+HSNBtzKJ4yeuwAj87md0FS8/H5SUg825XLXn xRPMIueSPKG7nu2/wRwMjcY1QRBBuwQfXUuar71E83kdsmZ5qVLSsdKUNpZq403hYoQCg2 sfL4NzWDxueFYLGc9MucOTqQQ6XvM5E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701783131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZlWEYQXKg81nONkiYpPbgG9RelSWsxKHpc2b5kqkVXg=; b=MCKqCksS98jhzLyPLvnhbZyntUESw2vUl7H3sGYzpf3Hdu6QH7URkeqkNAChpvZfexBQ9h DoMGQNX9deUepPwUUPA29ePxv6K0IQ4QbfS+XgksMzB3ZsirWv7UWnHNxARxD6FEewBnfy tMrFjxdDHrTidmXaN+oOXv20jkHvgUc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-6uSD2N3nNbS8SQyoXh6wlg-1; Tue, 05 Dec 2023 08:32:09 -0500 X-MC-Unique: 6uSD2N3nNbS8SQyoXh6wlg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40b443d698eso39091975e9.2 for ; Tue, 05 Dec 2023 05:32:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701783128; x=1702387928; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZlWEYQXKg81nONkiYpPbgG9RelSWsxKHpc2b5kqkVXg=; b=uVJiX4h5Kxgk3on05mgSpz09pRWA4ZyKsz7NDngE9GeiUwuzRzUzR1d+4siWgasgKA iXr7UiniNZUgzffG992Uc2+dHleCen7IIkgEJAE8jkMthmXry9CFlGh+GqZJTZMhlyjP GGuMSBRU9RLuM3IMJNHHkUp2tnKO3J/u9elLPURFD9D8jAnM2Fp+mkaXTAy9Ij8oPSWj 8Eg2iUyw7NFdoa4cHPJwakV2/FHhYaWy/nsXio5+rCQ9K6GwoLYBfQa3jwt1BI2x9erN gfNyX3mIsfszQmNhn9FTSNW3DYVuI14JGYUf4tr/7sfN0fDVwdpDL8vELw7lhN++M3OX pztQ== X-Gm-Message-State: AOJu0YwhwBJToIo54QulTLMD5nMzGpuk5aEAsIB3VAsqym2ke9kIujho ox2k8rZtvQ+yqIilCbOvZo6dHSsMWx1Fr4OhMmAl6qVYpQDgrzF3VsrVtcKOW0WFjh4ce5XzBVq yMRVNGYzSl7M= X-Received: by 2002:a05:600c:a05:b0:40c:503:24de with SMTP id z5-20020a05600c0a0500b0040c050324demr443576wmp.88.1701783128069; Tue, 05 Dec 2023 05:32:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOqXRjOubfLuT0xgSNa9lK9U/VlBCU3Bv53uHau47CGelyNV2o2s8V8VL4AnY8mLCH1L/QMQ== X-Received: by 2002:a05:600c:a05:b0:40c:503:24de with SMTP id z5-20020a05600c0a0500b0040c050324demr443563wmp.88.1701783127563; Tue, 05 Dec 2023 05:32:07 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id l27-20020a05600c1d1b00b003feae747ff2sm22534426wms.35.2023.12.05.05.32.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 05:32:06 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 14:32:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 34/39] mm/rmap: introduce folio_try_dup_anon_rmap_[pte|ptes|pmd]() From: David Hildenbrand To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-35-david@redhat.com> <88a341bf-0b6a-454a-aeb1-0699233eb37c@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <88a341bf-0b6a-454a-aeb1-0699233eb37c@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1153080024 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nbmkcderqz3h9umcbmsowf6p7jyh8csx X-HE-Tag: 1701783131-244472 X-HE-Meta: U2FsdGVkX1/295WbfTyGf9FB/u9R+kRE/+OP7iuurbnmo7VP8FNedFOxiwGFi07I2HLsK5DMs3iHbsXDPxygtquvKZ74KCfcUg5IrywZwgaw5xi1QGS87RmKpggEvDiC4DO9Nvim4+bzgc0xmkJ/BEjz3zCenDdSVTpNSy0St/+aKiIaAJFnp3Hm1SeIST23w+4AK4XeI/nVc+tGm51M2PktLSp4ee1uZF5FCIqH3EeJg+N6omO3d7t/hXjb5XVcXt33O6SJMbTcV9qIHHPtlsDZPvAKOHTVh9u92G2G05vIhz48BbtrHOUNXmgfS/tCy/02rSeLha3TlqzaA+P+X8aMhx1uH8q7MACYB+X38dHu81lG5aZ72wJLA5HhuyLvjT8e0BVrFngo8YkYEt5koA3x4cJulu9ZNx2QiOoU1S8AJDaZU9vmg7VaEUdjFpimIyhGPDga1KKzQJ6I+jpG0uvLaq8V+6MDLTAPUOi0ua2SdlSLSH6VlqK5Yw+dLlg62Wk5JA4QznuH6XPtchDUI4Wj+HpstaP5HtWk4tcuqhmBkm8zt0VHimTdiAO1Ak+Q5yYY6i7nLVCg//xOAKgx+4MG+3y1BtALSNgJRzJgx1weMzvbLq9V1sabTEQSfCR0Df9ibO6ptbjo3R8Td3Dc3kF9R8wW056OssDd6t0/h/IQzFT5RG6f2gdUrgvjT/kq7huus89NfzZsdwPa+S08kM/YKNXFjMtLP6s8APb1dsnZkWUwao/Wj3BCWzanHLpo1f1MxxsnNzOCGjyYVI9kZ7n6t9pqlVfYSEZYF0qAiSMKsvZYhZ3xXnJMxi7BU4nWkgX8iihF1t/oqkGCd6DvHRsE/ddYzeu5dbmI440LD+jc0NTlyziLu8YTN3uY2oRAg9Lh2IySLASxJFGI4siZaroH9tFk/BsB8r8NgdVnrFwZSVR7Z9JC4ocfRD6CAlcbPh2oDSduW/YVe6ZYwqc HZVLARgb DS/sQ/GL5/sSKx4Qb7GdF8KOixuEFHlyf98pPtLb5AlLqDwPk8URDW3L0kOtxc4/lrapfd/qStlEyaPa+Imlq5+vQatXJWHR7dYjrMmQ0sjvO2zctKGF5pOhAFG4toeLpjxhylgt0+jBHW3jgVkjAFEYCSFY7La0cNwi0hJEAHf/RrzbKgX5C51Dzwu5Mntf+IiL7ex13M5P1g4Y54u30W9p3xLyzk3R5iWPCRPlDl4JX8e5zrXWoNeAjA4FZmcFTV+ajlGBSc3btd4hzIS885r9HN6PPQS50QlVTTtCyCsCq0JtUpLyX2ag1QtKXN5JDYMZXE2AYqQON8azsyiYMg+OqYnDPapIL/sxe85XGT2qFB5G+MOj9zOTT3j52rr9nFvhXU/zoSKRlhHimvvKn/+PQkdcgI5b2E7NTlYtvUrLEhcIlFNotet6zotc7yUZGwNdJB6D50bhvUMZIDD5IbSCc0vGt3LY0mPN9lHgC861ZXwtjkimXDLjSrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.12.23 14:17, David Hildenbrand wrote: > On 05.12.23 14:12, Ryan Roberts wrote: >> On 04/12/2023 14:21, David Hildenbrand wrote: >>> The last user of page_needs_cow_for_dma() and __page_dup_rmap() are gone, >>> remove them. >>> >>> Add folio_try_dup_anon_rmap_ptes() right away, we want to perform rmap >>> baching during fork() soon. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> include/linux/mm.h | 6 -- >>> include/linux/rmap.h | 145 +++++++++++++++++++++++++++++-------------- >>> 2 files changed, 100 insertions(+), 51 deletions(-) >>> >>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>> index 24c1c7c5a99c0..f7565b35ae931 100644 >>> --- a/include/linux/mm.h >>> +++ b/include/linux/mm.h >>> @@ -1964,12 +1964,6 @@ static inline bool folio_needs_cow_for_dma(struct vm_area_struct *vma, >>> return folio_maybe_dma_pinned(folio); >>> } >>> >>> -static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma, >>> - struct page *page) >>> -{ >>> - return folio_needs_cow_for_dma(vma, page_folio(page)); >>> -} >>> - >>> /** >>> * is_zero_page - Query if a page is a zero page >>> * @page: The page to query >>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>> index 21d72cc602adc..84439f7720c62 100644 >>> --- a/include/linux/rmap.h >>> +++ b/include/linux/rmap.h >>> @@ -354,68 +354,123 @@ static inline void folio_dup_file_rmap_pmd(struct folio *folio, >>> #endif >>> } >>> >>> -static inline void __page_dup_rmap(struct page *page, bool compound) >>> +static inline int __folio_try_dup_anon_rmap(struct folio *folio, >> >> __always_inline? > > Yes. > >> >>> + struct page *page, unsigned int nr_pages, >>> + struct vm_area_struct *src_vma, enum rmap_mode mode) >>> { >>> - VM_WARN_ON(folio_test_hugetlb(page_folio(page))); >>> + int i; >>> >>> - if (compound) { >>> - struct folio *folio = (struct folio *)page; >>> + VM_WARN_ON_FOLIO(!folio_test_anon(folio), folio); >>> >>> - VM_BUG_ON_PAGE(compound && !PageHead(page), page); >>> - atomic_inc(&folio->_entire_mapcount); >>> - } else { >>> - atomic_inc(&page->_mapcount); >>> + /* >>> + * No need to check+clear for already shared PTEs/PMDs of the folio. >>> + * This includes PTE mappings of (order-0) KSM folios. >>> + */ >>> + if (likely(mode == RMAP_MODE_PTE)) { >> >> Presumbly if __always_inline then the compiler will remove this if/else and just >> keep the part indicated by mode? In which case "likely" is pretty useless? Same >> for all similar sites in the other patches. > > Yes, also had this in mind. As long as we use __always_inline it > shouldn't ever matter. It seems to be cleanest to just do: switch (mode) { case RMAP_MODE_PTE: ... break; case RMAP_MODE_PMD: ... break; } -- Cheers, David / dhildenb