From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DC2EB64D9 for ; Wed, 14 Jun 2023 07:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A268E0005; Wed, 14 Jun 2023 03:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1132F8E0002; Wed, 14 Jun 2023 03:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECEE58E0005; Wed, 14 Jun 2023 03:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D50A28E0002 for ; Wed, 14 Jun 2023 03:28:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A3FF81607F5 for ; Wed, 14 Jun 2023 07:28:45 +0000 (UTC) X-FDA: 80900526210.02.E8F5B08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 6EB2EC0003 for ; Wed, 14 Jun 2023 07:28:41 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SUq7OWaU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686727721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RoOp2WXZj/1IeU1OQfnjNJXRwTjLv2KdN6AVUPP90dQ=; b=VmeUz+RYfmg9B7mPh/8FDuPsr6jiTo9MNa5Sb+H5UpI6B12AFtX4/jgtNeu3z3qiWEqnmy javZHw/7EhCE02ru1pjwrtMkXazAOLvhruiZmMizhxFMUz5rDJ3P4slhek54Rx7Q6+P8ti TpUWfzKPMiW7eF1EGJrCDK/IF323NQw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SUq7OWaU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686727721; a=rsa-sha256; cv=none; b=giXdssLgjMOd+qbmnN42/JONaOA7l9Qz3tllrCWIjnivXKAb3DgZdDPQLBVKAPKTxnL/za W8ot1X45WvfSEPBqjE6IsNK5xkULnGcirEZnAhFlP44Yf79Mq4DZ7cZ8fFqA1S8gWIX6cQ aydpnneJacfJguDjxsDBxZvEhQlT2zk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686727720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RoOp2WXZj/1IeU1OQfnjNJXRwTjLv2KdN6AVUPP90dQ=; b=SUq7OWaU/DmPPP8qAFyOHEqE2UgbMtlVQeB2IqFldWs10X19NiMkctAIVKEa70rlwOpXO3 2FJJHqpJLtzd5EVjnbO0JEJL/IeBO0/TxBlQ7vpyq7xgitAnY2+NYgOo+wiHuRmLYQmkrO qlcO3zVE4igpAYUkLo+mjAqY6kq7B2I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-GF6XS96VN3ypOheEYm90PA-1; Wed, 14 Jun 2023 03:28:39 -0400 X-MC-Unique: GF6XS96VN3ypOheEYm90PA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f73283f6c7so1475325e9.1 for ; Wed, 14 Jun 2023 00:28:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686727718; x=1689319718; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RoOp2WXZj/1IeU1OQfnjNJXRwTjLv2KdN6AVUPP90dQ=; b=RNrcHqPxInPn1lCHMhf/0x0uIi9lKHihWF13AlUgDxUcpD8NLqJK7t1xxYOAcDFeY9 2aAF63qw7vQSlKrY5aGHuetR2hVW83O8Mrma5DqjZGe50fjeWsn67AuBbgQ2xdRLkaDn gMNvweVLaHM04KHmNSCZzwctWPfzeGCPqmB5xskbJmAMe2Pw1l8EGrIBuvlWvIUGSm7o /tpgMu583q8ovWVkMA7tw+AP5fg2kyUG/3xO9AvLp20Kv6Ux/5YUQnWCYPrahU6yDoti HhxtUFNru9gcIp8PaNFvEclllCb9qHIaVmrYSjb67xWsbViDSO/c46/8oBWdJqT/8tfk hOLQ== X-Gm-Message-State: AC+VfDzZ1wIKRMOou2JPYc/Ck7KiAo09FvMpS5mkUvL8csyddOkthbmu 8sZLpqrYiaUzIep172nfMd2UeE306IdUzXwJU71TCc4pJqboxYNUeMtds7u2Er6DnFohkmeApj0 SiB1FhzBPZpc= X-Received: by 2002:a1c:720c:0:b0:3f1:731e:cdb1 with SMTP id n12-20020a1c720c000000b003f1731ecdb1mr701022wmc.6.1686727718359; Wed, 14 Jun 2023 00:28:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47nT/sd1Fp64hlEKEvu1oRyMkoHoA3zodk9vinDMdNyiquCqMTYEZ40M2Y4d+tAIpyY0MLVA== X-Received: by 2002:a1c:720c:0:b0:3f1:731e:cdb1 with SMTP id n12-20020a1c720c000000b003f1731ecdb1mr700995wmc.6.1686727717995; Wed, 14 Jun 2023 00:28:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c228b00b003f7361ca753sm16474673wmf.24.2023.06.14.00.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 00:28:37 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 09:28:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] block: Fix dio_cleanup() to advance the head index To: David Howells , Jens Axboe , kernel test robot Cc: Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org References: <1193485.1686693279@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1193485.1686693279@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6EB2EC0003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7yjza8e6yccp4ewsdcfunoyx1g6796f3 X-HE-Tag: 1686727721-861984 X-HE-Meta: U2FsdGVkX19nUlIZS9OMUp9KnAEGfzogJu8L+6jsj1+9kQK2+T9c6akDb9fZm62ZXH64Li+HaQNNNPNmXryShiNrJtEQH06T7KSaPof6NFz6MUJDvjpjzohfLPxT/AtWbvC5seatA/0ZdOJy6XLeLMZ9jiiH5P80Tm1TjMMuAnNbgv8sUwaOYtWBxuGgp4TiDgg4Z53uTA/OA6i2/+8+lio6rPvjbFbWmjVvHJp4YwbIYe4lXE/aJwn0Y3AlN2oykFDh5FM36mNDoGsuXZJtJM9TS0dEHGgsK2pWKsL0j2IfDH0G2/cVUQrECGPtALaGL1zgnf7QR8fF7f2US2FadKnYkB5aXEcBDDL0soLGUp6BCOae+koFZ7xtpNCuHiXUXVzGRHuLVeDA9j2ZJmadOf08HWUyiyvH9yN7YsYTDpO0ASCa7YGwdLXipNwEVuww1b8mJFn/OsaxUmfNcdHlz+2qjR8lw2I1L8Z2UqqzyFoUGkz+5bOVtrLxsOAeYHQp4OgJP+ckBAvW1kdMa1F69VLeffbJ725MFO3GDqc/gCWp+uKEmGbPfSygPADvU2MxqQBSw3SN0P4pMlhEHKxRw4hZ+X6BswwJ7LAxlkTbpQ+PybeoUjowmdKKVliMjo/B1tqBn6VsRcmkg6bIQJWPQrnNHfob893cLj0BQITzLwstAjjFOSXVHc+x9S86uyHCBELjMcbyyfgUqCB4Wrb+lHHqTrN+zBoR6tAJzGQGbWQmt8w3DNzU6U4Q7EfXbMq2/rwNUtM25WPEm8hOQcONYcAQWiekPcUEzkA7oZrArjVcnH/vnKlszoW9iqT6A/pQA+SoQbH2CI/Bb6thv5HiWV5IcPWnquEuT8O50qLajiy8zySu+Z2qCIp7z8j3b4JfFVfSRIsdePaDbOmCFDgz4PmnJaCWjA3w/ZWMZcZzV/HY7rpTD9vUNaWrGVmQgHdYKEMwsQlmdy0raUNvH2D 2rXeIars axymS/G3O6FyNhWFxLSqS9ilvgXNX9RBifVBdtan9WejhbdT+4a/PQ2IqGzgOBYO37poX6okUAfqdEVV+v/LPYiR+Svrmz/KshVbtXfBHJcUCTNrBSUzJZHk6PORpi0kkFb7Bvef0jlCNX/wNv+smJLtNRRha/26x2cJJTmJLP5tBTljOlZA/Pj7OzFIDqcZ3H8Q6wo1lUqgT1XGzJuK3fvvOHLEoXI0r9e8b4WhTPsrbotqbatrA+c5E+ErYtuXka+h879knYavzDVRs4taMss90T63fOMdxwPvsdqmVhWUgLE0wOcv/XehVwDoYZrWBHXbW3HCRthB6XrJLH0Gw9gHn5rOzvTokAA+YLigSalDdtnO2MKweRqzv+U4Ox2f/G1avMfEJZPjEVAjaR52wky3JUpEhGNvY1U/cR4aOxgePvOaxE4sV3c6WKtCTq0bjoGJTuibGVihYocCiCQTOv0bPNlHMNpSutAyuK5RQ1d1TthkykLV/cbNs8XEpBFzyVllwAvwliyCvNsJoHTjW0657255bkufdESqJBlkgJAf/zn9tVKTYgMRNwcYl70XkwbiC4d74pjbADDC7FU9ne6DcbgTD2avhw7I+kqdwimRNpsCRW+W6+A1Fjbs7yOab28SdAeRnfGGFX11sanhWbguwfCCW5IsODsF2Iv0d9QgYWs6Hu3iomGeLzmhWoWI6dP7ptVviu1e36K1Oe3cNS8J6x8Nu46A9XECX4mvrWWdyDSPLwnE5qz34Jl8XWZu90BWbyVWeay8V22D7wf3xGGr9A3nnKaLihsfRyIVe9gapLVO4qgHGqstP5T9kdFjjAG66 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 23:54, David Howells wrote: > > Fix dio_bio_cleanup() to advance the head index into the list of pages past > the pages it has released, as __blockdev_direct_IO() will call it twice if > do_direct_IO() fails. > > The issue was causing: > > WARNING: CPU: 6 PID: 2220 at mm/gup.c:76 try_get_folio > > This can be triggered by setting up a clean pair of UDF filesystems on > loopback devices and running the generic/451 xfstest with them as the > scratch and test partitions. Something like the following: > > fallocate /mnt2/udf_scratch -l 1G > fallocate /mnt2/udf_test -l 1G > mknod /dev/lo0 b 7 0 > mknod /dev/lo1 b 7 1 > losetup lo0 /mnt2/udf_scratch > losetup lo1 /mnt2/udf_test > mkfs -t udf /dev/lo0 > mkfs -t udf /dev/lo1 > cd xfstests > ./check generic/451 > > with xfstests configured by putting the following into local.config: > > export FSTYP=udf > export DISABLE_UDF_TEST=1 > export TEST_DEV=/dev/lo1 > export TEST_DIR=/xfstest.test > export SCRATCH_DEV=/dev/lo0 > export SCRATCH_MNT=/xfstest.scratch > > Fixes: 1ccf164ec866 ("block: Use iov_iter_extract_pages() and page pinning in direct-io.c") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202306120931.a9606b88-oliver.sang@intel.com > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: David Hildenbrand > cc: Andrew Morton > cc: Jens Axboe > cc: Al Viro > cc: Matthew Wilcox > cc: Jan Kara > cc: Jeff Layton > cc: Jason Gunthorpe > cc: Logan Gunthorpe > cc: Hillf Danton > cc: Christian Brauner > cc: Linus Torvalds > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-kernel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/direct-io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index 0643f1bb4b59..2ceb378b93c0 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -459,6 +459,7 @@ static inline void dio_cleanup(struct dio *dio, struct dio_submit *sdio) > if (dio->is_pinned) > unpin_user_pages(dio->pages + sdio->head, > sdio->tail - sdio->head); > + sdio->head = sdio->tail; > } > > /* > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb