From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CB0C282D0 for ; Fri, 7 Mar 2025 05:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADDAB280006; Fri, 7 Mar 2025 00:47:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8D49280003; Fri, 7 Mar 2025 00:47:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97CDC280006; Fri, 7 Mar 2025 00:47:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B7A1280003 for ; Fri, 7 Mar 2025 00:47:45 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 01705140447 for ; Fri, 7 Mar 2025 05:47:46 +0000 (UTC) X-FDA: 83193673374.15.2F68887 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf02.hostedemail.com (Postfix) with ESMTP id CFD0E80008 for ; Fri, 7 Mar 2025 05:47:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=TZgS5QiU; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741326465; a=rsa-sha256; cv=none; b=jcTKl+Ba4bHe2xTG6QUzIbSt0+0IAc4SXfpkkCSnkNDOdCqcZLBBw51o/CeQM/w1ALl0mq Kq90ZSlwDHj5ZOVg6Y07I8njepNBLF/bUktkh86Ji9XB0NBQAoBHAIHer5x6+zD47C3+Ia fD+DoG1g6kCyC23KY12byhE4BfgoykQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=TZgS5QiU; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741326465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8hBVXXenNjxx3BHyz1WHioxLNd57++2diGf/KDJPqY=; b=6Jy4Ek+X4braTHtqHx6+xr7Aon6QViTnayPkxU03f0nN8G2qmt4Wjnikct84OGlZv2qS/c XklSRP8Nmv0FEPPXNDJtppwBA1L9qBQfuN09sHkXSkgVES19vdOiArj5FHmBeH1ieV1Umm xK8vBzsrzfe2gybSX9Ghf7tho7ca0Jw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741326461; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=i8hBVXXenNjxx3BHyz1WHioxLNd57++2diGf/KDJPqY=; b=TZgS5QiUYbinaPVgMCfVs8gdK5dz8ZImIQbjToreh1ouccnZmQ4xUqMLkAniBgzRNSYTX5KmzeebBzHR3V7prDjg9pm2LjBPIUuxJgIlEvLuHVPEXtyQ5MQASciBDutz27jyFwWTtO7l8cewnBGs/nD96gQWvJP2Su0dV/qRH/A= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQqyKli_1741326459 cluster:ay36) by smtp.aliyun-inc.com; Fri, 07 Mar 2025 13:47:40 +0800 Message-ID: Date: Fri, 7 Mar 2025 13:47:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] x86/mce: Use is_copy_from_user() to determine copy-from-user context To: "Luck, Tony" , "bp@alien8.de" , "peterz@infradead.org" , "catalin.marinas@arm.com" , "yazen.ghannam@amd.com" , "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "nao.horiguchi@gmail.com" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "jpoimboe@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" References: <20250306021031.5538-1-xueshuai@linux.alibaba.com> <20250306021031.5538-2-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CFD0E80008 X-Stat-Signature: kodyokei9qchrkpfubd5g5mo7u8i6bxn X-Rspam-User: X-HE-Tag: 1741326464-261666 X-HE-Meta: U2FsdGVkX19ptVKZqZt+NX5UcL1WX+/9YQTLMqcIGiGRPaDLBNauha/u2kTqSa609s+k3CEgErGQ1YVHK2T62BuCSPv1HNZvM3EVB7/1NGSJ4TK2FY+2iSTft8QGCpGKcHQIqiw3ym4bnunW/5tZqGwJ51b4XW/VvEPQ+aYO5NW4cJsVbJ7IgGdN6pnqP9nlt8lH08H/3PGuh8OZyTCwU+n2tUQgaF2D9RfTKBopfvN+aSi2OQosNkwuIxrY9TX1AesckYiQqvKGEgSFMJQhAvLz+2LMX8husPdBBfeoPO+RoHY8BHqKWUgwYwoOIFpujZWxXVbXeTQYhbc2mtWFFygzGFR0SPh9EwTQq+3UJyZqbor2s38OT5n0r8d9GFcR2beVOtBmwFwlPv2dJVn5maURQKLT1IunNJIcp7YJVUj/FDJSfeG6CJDqOaaZ1t8kNtcIIHxD2ypaqlaqGY6vrLz97w0TXOt3oMQbG5lCONWUxVCCy5J44v57sipPijZTBP2KfOtNVvA99yUMJuyr/T5t/2qTmiSjr+3erxD53vP9w0bEWquVywjy9Ck2nvHsJvDA5RpGxwc/4G/EvAFPj8w/nvCM7B6/S8Qdy5TDlwtCUswDxVPGD+/W9DdOkdhSWaFYc9I0TetxtVf8PeFRRMsMPK252POV9nVDMgiqwLkwDXruvh2jj6yyzt4tvgnM+0cMmEnbCBEHdlYJDSzNW5LrnQT2JufE+642fFO+ZE4Nw1jBNPn6CuxMLXpuOoU/93TQK/vS1xY8K5lOHalJ7sB03aQdwFzJLtniffrJsCKu3otic6o2SApN5m9j1bcf4m2eHglz0m9hY0/O1FDmBUsvTzS7S2EdRVSvIowuWfQ+gqzQJmIB5u4tep3Ir1cib8Rl+Ed91R3tBLmip4tgpkersF2YgcG53gyvHZcnfMSLifHAs49TcymePKMfJjkUg7IqBNFpsOreTC1vsQn xpfVZ1+f TUlGlAI/OwP/DkQ0toblwCxYZHdTC5sI05zB7RNx1IyOH2KlxcVBKNrTwJlkqlmtmzIbztJcW/8Th4oubZQ0ES6U9KfyvfHdgCjnULgC2BsykR/wBuiij6TcQp5HcIbhGjAAAscAs8/fSseyfeQaxSINTEwbtYhO+MT7aJngsiR6EIz8PnQIsj+1z9n8C/RmfWxpuudY+DAfecXXgJHjJH5wALZUl0mwgtoOuS4N617sldElt605r0DGrhTOB3/uc1kh3A7OhedQIG5v2/YLfSM19TV7Qeswyz7hkmztSFnbpw9J8STGmb0DUFfew8mFEO0koZbl+gMotRzkjIYD5QE5gS6q40Ym2G6WcbkBTErRAFDaoRnEjFV5CLLvuns9q1ioHUUsQN9maI3Xh60kwOZhuRdZTJ1+N2Sw4fSgCyX8RRevqveRa4ASVBPTkNgc7c36GneE0X3XTljlb/G78pbTuLeVm4WPnkaCe9kEbr5/3I4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000991, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/7 02:15, Luck, Tony 写道: >> diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c >> index dac4d64dfb2a..cb021058165f 100644 >> --- a/arch/x86/kernel/cpu/mce/severity.c >> +++ b/arch/x86/kernel/cpu/mce/severity.c >> @@ -300,13 +300,12 @@ static noinstr int error_context(struct mce *m, struct pt_regs *regs) >> copy_user = is_copy_from_user(regs); >> instrumentation_end(); >> >> - switch (fixup_type) { >> - case EX_TYPE_UACCESS: >> - if (!copy_user) >> - return IN_KERNEL; >> - m->kflags |= MCE_IN_KERNEL_COPYIN; >> - fallthrough; >> + if (copy_user) { >> + m->kflags |= MCE_IN_KERNEL_COPYIN | MCE_IN_KERNEL_COPYIN; > > You have " MCE_IN_KERNEL_COPYIN" twice here. Sorry for this noise, please ignore this version, I resend a new ready version, please see: https://lore.kernel.org/linux-mm/20250307054404.73877-1-xueshuai@linux.alibaba.com/ Thanks Shuai