From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CF9C54734 for ; Tue, 27 Aug 2024 14:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B0F46B0082; Tue, 27 Aug 2024 10:50:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0619D6B0083; Tue, 27 Aug 2024 10:50:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1CF86B0085; Tue, 27 Aug 2024 10:50:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C42186B0082 for ; Tue, 27 Aug 2024 10:50:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 375A7121B5B for ; Tue, 27 Aug 2024 14:50:06 +0000 (UTC) X-FDA: 82498310412.25.6D47DB3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 9AE9240014 for ; Tue, 27 Aug 2024 14:50:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ggcBwPdE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=exAJhI2t; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=i7Uk2jkM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6HKRMLC0; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724770159; a=rsa-sha256; cv=none; b=S3+CtYyZRiWPvGK+Kxg0Pj7DF1AP2Jn9bQ+iWihz10iVg7Y5xEsfvEhJPYmtJl74yw8vvF F53H6T5C+UkJH/FH+F2tWJ/AIJR7DCPadBkAH3xCbehOxFUbRlB4KqjX0pnmtD4fk73uxw OcYj9/lFZMNZ/H4+H8rDhrciUePd8Nw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ggcBwPdE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=exAJhI2t; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=i7Uk2jkM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6HKRMLC0; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724770159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6bJlqtyr9FYBDBfgV0l4YtLYptHYgNLTydBU7vTBwbw=; b=BzXI3h+t9CANuVriN2no5zyofWZwC/87+WF9XH18kbcocn2w/YWIUqwl9Izd0qvGnV+91q gXKvCsXCxmSJPHjyHwOMUdjZFUJ6AB+ZEIyjaXOZ+29PNNzRiq0sdYNk2lA2Pc9xWtrP7t L7+pbXeHxei9QQhs/J5gttU1hFHFGZA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09D7521ACF; Tue, 27 Aug 2024 14:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724770201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6bJlqtyr9FYBDBfgV0l4YtLYptHYgNLTydBU7vTBwbw=; b=ggcBwPdELJsZnsbkkiYoiBC/2yr9rj/r50K3RVteSAzcMztIqE5HnCSxcTr6OPj/kW1h3g 4mfnNYqL9xklFKKSH463+KNhSkxMKTDXWis9PoKLVyBc8FD8RedP/KUri3NKNp1X2OAJyN zJyciPgAUwRtIHFPQ3gnE6oO0Mry/ig= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724770201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6bJlqtyr9FYBDBfgV0l4YtLYptHYgNLTydBU7vTBwbw=; b=exAJhI2t9+tpj/BZNYaJtVJEGlJEWFzbInOD9tFQ6fMpIsvdWkgvhwvzoZxKqVw17ypSQ7 7hNNXxe6Cv7IuWAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724770199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6bJlqtyr9FYBDBfgV0l4YtLYptHYgNLTydBU7vTBwbw=; b=i7Uk2jkMyU0l9t5qdeExBUD9/iKDR1gpfmQv+3Aa8IxYNvV60hL255OxtDIP4HZcvjg52L 4IFeIZei7GtTFa2cLADsEggDrA660qPbQ+RfWifloJ0Hz6CN+56pX7avejhyvgbpBCO44U 13M9qa7W6nKfRpNodvmAaZjoSsLNHZU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724770199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6bJlqtyr9FYBDBfgV0l4YtLYptHYgNLTydBU7vTBwbw=; b=6HKRMLC0kxRsV8RlSXwv7vBfA14Ykfd+kYVurDfSinVYAHhAH82Xzc+SIw7DMuue8GBkcP 9hdRri05jvB1K0CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E175E13724; Tue, 27 Aug 2024 14:49:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 14OoNpbnzWYiGAAAD6G6ig (envelope-from ); Tue, 27 Aug 2024 14:49:58 +0000 Message-ID: Date: Tue, 27 Aug 2024 16:49:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm:slab:use kmem_cache_free() to free Content-Language: en-US To: "Christoph Lameter (Ampere)" , Yan Zhen Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com References: <20240822022704.1195439-1-yanzhen@vivo.com> <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: 6d1ebd1xk7nteqzeonuzs3c3w3q6b8ow X-Rspamd-Queue-Id: 9AE9240014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724770202-253871 X-HE-Meta: U2FsdGVkX1+A+byv4TEG6HJNskW+hv5VVbsu/6ak6UTwKlzKLxxUFkq+MQseaNV6etHd5sLIIFRPkaS1C4wo2bizR5pDYqxtyPkw2Eh6c/HocIneaQLD1m3k5bW3J0mWSS7II/0cpr4GMgSOjPN9EErYIend2H3cbOPqrRXZmnPaRlw01GQ3A8SZTglQ3viZaMAQyeTM8QZUpx1EkbKHOCxLFCZnSfQRnV2Q+QUnC50nJBepvFPtTGXz6dahB+L/jWc2F7994n1K1zGRP9GfEp5npExwJg8ObTxc55V2PpZkN8cPIOwYSJn5jHNPz5C7/wDPmwErBNsL2VqUZRDwHrWUSvhfLUrhfUvPTdVKkfC+SHSuol6kFGNtlMKyQcdMFBWxRA9TKm1k4ptJ7HUy6zEW8PcuhHk7ReEX5huQi4FfUrYfOgROaROSWFJ6bCflmyJ9mESQDweYTduil/OM6Ine+rO5qBdKBO8cKd1XjhXlKckmC0VapCO9CklKiS68yFlODQsgzykZRHpY+mF2dtXIOaJYM0w/Qe7CV9WqU4V2YqBYO9aX8dvG5f/Oelmc9y/QtVS1uxOy5RDLHYireYLdXKMnobdO4NxrDaSrODt3BqnzO7bX513T6S63SoR047QZqIkcBboEukmpwQ76bcVLmkEC8QEgK+86j6blYq7Pv6tYdb+jzuyRcNWTuXmLWM0sQeTEovBGHpQUVErSQRsusbgYt/75N3DZharGi6cI+6zCvGaqRYiC3vdJtEj9V4QsW5ejXec3GV+q+a+tUGaPkOjfZy1a5tjiM8siwlJHdDP5KVKdzJoxvYMbJmPWZq+4/3nX3wipmqW4j+1OU7XrIOZ2tKCFOjZC+Xl+So/vHNQSMPRp4BSsdU0F2iUm5nqtCYQlnkqY1mpzOJhujCaG4MjCimbO311HNOg8y34Fgbql7zNbeOJ0fHzbryxicbgslB5Wn7VlDbb8DRe AF4AQl5S RfINOLjJ3O/3X4ij4ya9mMFv/RyKRWmCbqrjAOs3sxtj9dBrg5WxKJ+p3mzQ18Zxd8d9Vj7BLohQm3im/vgXUJb3/R6Fq9gSOSeoY6T7qxkxT2Tk7lWQ5YVT1mzRfTuuaT2j/75PdQdNspp8735qolynhvwl8xBw57CXOcvNN77t2+irQenda4W9XwBWfXM1G7zgecLD/mFHW9CNVzXYBAjC5haaNltYJ5x5aflvdEfPcf6zrTDipyS5jDWNtSTwg/3Z4k3qxnASonEnG3aHb76cSqWurzzjmVuOcGqZOYEdUdlcLoHe8MFwUZJfNEW6wRStptgTWwDTqi8sEuOC1507ISB1jWz7G/DheWV9SfPrCTT5H8W9JyBQZwY1xB04K+SM9scMIiByN5j/j+DUx4P5wg8QDKUjhGSTwNTXN2O7K2gDFvtjdWldaXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/22/24 18:59, Christoph Lameter (Ampere) wrote: > On Thu, 22 Aug 2024, Yan Zhen wrote: > >> The kmem_cache_alloc() is typically used to free memory allocated through >> the kernel memory cache (slab allocator). > > Well yes but since we removed SLOB we can use kfree() on any slab object. > >> Using kmem_cache_free() for deallocation may be more reasonable. > > > It is more symmetric and looks better. Right, added to slab/for-next, thanks. > Reviewed-by: Christoph Lameter