From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E67C63793 for ; Thu, 22 Jul 2021 04:51:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07C5E61260 for ; Thu, 22 Jul 2021 04:50:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07C5E61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 495F76B0036; Thu, 22 Jul 2021 00:50:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 446446B005D; Thu, 22 Jul 2021 00:50:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 334AA6B006C; Thu, 22 Jul 2021 00:50:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 1D7A46B0036 for ; Thu, 22 Jul 2021 00:50:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BDBBD19232 for ; Thu, 22 Jul 2021 04:50:58 +0000 (UTC) X-FDA: 78388998996.13.64360F9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 48147F0027B7 for ; Thu, 22 Jul 2021 04:50:58 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47E6CD6E; Wed, 21 Jul 2021 21:50:57 -0700 (PDT) Received: from [10.163.65.134] (unknown [10.163.65.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CFA23F66F; Wed, 21 Jul 2021 21:50:54 -0700 (PDT) Subject: Re: [PATCH v3 11/12] mm/debug_vm_pgtable: Remove unused code To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com References: <20210719130613.334901-1-gshan@redhat.com> <20210719130613.334901-12-gshan@redhat.com> From: Anshuman Khandual Message-ID: Date: Thu, 22 Jul 2021 10:21:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210719130613.334901-12-gshan@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: 5rfpr493unnr3opw6oow4xj4jwk8mndd X-Rspamd-Queue-Id: 48147F0027B7 X-Rspamd-Server: rspam01 X-HE-Tag: 1626929458-359354 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Small nit for the subject line. s/Remove unused code/Remove unused page table debug elements/ On 7/19/21 6:36 PM, Gavin Shan wrote: > The variables used by old implementation isn't needed as we switched > to "struct pgtable_debug_args". Lets remove them and related code in > debug_vm_pgtable(). > > Signed-off-by: Gavin Shan > --- > mm/debug_vm_pgtable.c | 54 ------------------------------------------- > 1 file changed, 54 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 5ebacc940b68..4f7bf1c9724a 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -1124,14 +1124,6 @@ static int __init init_args(struct pgtable_debug_args *args) > static int __init debug_vm_pgtable(void) > { > struct pgtable_debug_args args; > - struct vm_area_struct *vma; > - struct mm_struct *mm; > - pgd_t *pgdp; > - p4d_t *p4dp; > - pud_t *pudp; > - pmd_t *pmdp, *saved_pmdp, pmd; > - pgtable_t saved_ptep; > - unsigned long vaddr; > spinlock_t *ptl = NULL; > int idx, ret; > > @@ -1140,41 +1132,6 @@ static int __init debug_vm_pgtable(void) > if (ret) > return ret; > > - vaddr = get_random_vaddr(); > - mm = mm_alloc(); > - if (!mm) { > - pr_err("mm_struct allocation failed\n"); > - return 1; > - } > - > - vma = vm_area_alloc(mm); > - if (!vma) { > - pr_err("vma allocation failed\n"); > - return 1; > - } > - > - pgdp = pgd_offset(mm, vaddr); > - p4dp = p4d_alloc(mm, pgdp, vaddr); > - pudp = pud_alloc(mm, p4dp, vaddr); > - pmdp = pmd_alloc(mm, pudp, vaddr); > - /* > - * Allocate pgtable_t > - */ > - if (pte_alloc(mm, pmdp)) { > - pr_err("pgtable allocation failed\n"); > - return 1; > - } > - > - /* > - * Save all the page table page addresses as the page table > - * entries will be used for testing with random or garbage > - * values. These saved addresses will be used for freeing > - * page table pages. > - */ Please move this comment as is to the right place inside init_args() in the first patch itself. If possible all comments should be moved during the first patch and just the code gets dropped here. > - pmd = READ_ONCE(*pmdp); > - saved_pmdp = pmd_offset(pudp, 0UL); > - saved_ptep = pmd_pgtable(pmd); > - > /* > * Iterate over the protection_map[] to make sure that all > * the basic page table transformation validations just hold > @@ -1256,17 +1213,6 @@ static int __init debug_vm_pgtable(void) > pgd_populate_tests(&args); > spin_unlock(&(args.mm->page_table_lock)); > > - p4d_free(mm, p4d_offset(pgdp, 0UL)); > - pud_free(mm, pud_offset(p4dp, 0UL)); > - pmd_free(mm, saved_pmdp); > - pte_free(mm, saved_ptep); > - > - vm_area_free(vma); > - mm_dec_nr_puds(mm); > - mm_dec_nr_pmds(mm); > - mm_dec_nr_ptes(mm); > - mmdrop(mm); > - > destroy_args(&args); > return 0; > } >