From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0ABC54E58 for ; Thu, 21 Mar 2024 11:20:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2A516B0087; Thu, 21 Mar 2024 07:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B38C6B0088; Thu, 21 Mar 2024 07:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DF3B6B0089; Thu, 21 Mar 2024 07:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 676DC6B0087 for ; Thu, 21 Mar 2024 07:20:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D406D1414B3 for ; Thu, 21 Mar 2024 11:20:28 +0000 (UTC) X-FDA: 81920802936.04.3927153 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 53D384000C for ; Thu, 21 Mar 2024 11:20:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zvr6beSX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjqIxvkz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zvr6beSX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjqIxvkz; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711020026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TVnW9rBBDhVBd0pbBPwkNhr3UB074n24M3Ue4qKQFKU=; b=Kv/+BbmIjAhVln1Qh1ldUI9FgFZxH34lHd3Vk3574shmGdG/I2Oa3g+rOweRmVnTTDpTMq ssm/rjdUPOvGjWBBs4A2rlptWZs/2/rWsMZnj0wpw6zRXhU43qkhiCES3gXPtZEbdBUDtm CX+UnL5tlzLd/KfNZkzC25uvZ34SN7k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zvr6beSX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjqIxvkz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zvr6beSX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjqIxvkz; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711020026; a=rsa-sha256; cv=none; b=yEzibJVU3gASur/QiIsK0hW94p9/QBjVP6HVjcFzsvY/jXcTi0+LbSsNkD5gZjTOmpcb2H 43ZhLxvCcn5A68vR0T3ArQ62U3mZwrhm4oiAocIwzSraYVob89yDmXqiawJBf3q9vxpyNF EFcqn0MEdwP0lyMRZCSXbgw8hEH0kPU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8412B372A0; Thu, 21 Mar 2024 11:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711020024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVnW9rBBDhVBd0pbBPwkNhr3UB074n24M3Ue4qKQFKU=; b=zvr6beSXOkPF756BBoOsjkZQmvXZbTr5cmGzVdFZnzyMyNcka05BFe93cOdCK+Azjpjs4P OHSe8yaPB6Ebrl714zUuUJ3iqYFoX1rWVHZiyZMFXn1eX5FV65VW44HjMPMuYQdIkckbqu sir22oqI+Ga+xTkFomfYCiwYa7JO1xo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711020024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVnW9rBBDhVBd0pbBPwkNhr3UB074n24M3Ue4qKQFKU=; b=fjqIxvkzBByZaF2rk+TDrU/mBkCmq+5UUQJLZOFhHLKC5ynYuPfCIrKwQ5B9TPxnU2cnch jhGXhxeyWoCt9bCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711020024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVnW9rBBDhVBd0pbBPwkNhr3UB074n24M3Ue4qKQFKU=; b=zvr6beSXOkPF756BBoOsjkZQmvXZbTr5cmGzVdFZnzyMyNcka05BFe93cOdCK+Azjpjs4P OHSe8yaPB6Ebrl714zUuUJ3iqYFoX1rWVHZiyZMFXn1eX5FV65VW44HjMPMuYQdIkckbqu sir22oqI+Ga+xTkFomfYCiwYa7JO1xo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711020024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVnW9rBBDhVBd0pbBPwkNhr3UB074n24M3Ue4qKQFKU=; b=fjqIxvkzBByZaF2rk+TDrU/mBkCmq+5UUQJLZOFhHLKC5ynYuPfCIrKwQ5B9TPxnU2cnch jhGXhxeyWoCt9bCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6B811136AD; Thu, 21 Mar 2024 11:20:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xGzWGfgX/GW7LwAAD6G6ig (envelope-from ); Thu, 21 Mar 2024 11:20:24 +0000 Message-ID: Date: Thu, 21 Mar 2024 12:20:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm,page_owner: Fix accounting of pages when migrating Content-Language: en-US To: Oscar Salvador Cc: Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko , Tetsuo Handa References: <20240319183212.17156-1-osalvador@suse.de> <20240319183212.17156-3-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 53D384000C X-Stat-Signature: skhh7kywoqsbhtrtnmoda6t76woieh9o X-HE-Tag: 1711020026-218092 X-HE-Meta: U2FsdGVkX18QtJowWjUhKxgnSTEIvW2nFu3O3SBzhrCAK2NaDtjiqFfxEzMGJOLGn4RrboDCfwEndZFFqLtWWCNTEXFzM68uqVs9LTJWczVqyGpwnBrOYFZxy5Fbp41YhSbzaQJYI21euki7pGZsZiVfeZMJ61Oe7KNIemS7dMEB4PMT4T2KBM1vcJKf8m5gbLNoZc1qJfhYGCPABgiVE2SLatdVGvDWxpYpOT5FC85LlGEKT/5MduQYmnYLkVc1hXScmStEbiaEaktY7E2gv1K/C+dqx5lwiSYByZMQ+T8TEgH5xuKZzaSf/DBUWCPateUmzDKeIbtk39251VHlkm6pxV9jOIBcYGSY3XWPmAD/79du74khNps/cjqsfhfsicqvPp6gWqeJr46MZOtsfebf+b9LSsOLNd/Y6zmS2LpZ6yYrJsERVotLm40aHAFkEjoRkx75bQxopd/IMGCBvHjyDm4RvAALqz5pTDETBLK+mg3e+Vt2oh/Lg/KIGDVB/C8Qg8JNQy2VekSLCZF/WZcQhxJjmnBw16gDKlxro++HV6O0RtEjkue4sYTsjomtpPP5btjzkK7fp2quk4eIY/HZPoGZ/wYKxgNMB4cm+iDJXqnYeIXhMoQuPkoSljXxkqiuVZyCwH5hHzvawwIS/NLBl3pJXO51MmZjmdYnuINTBj4Y+U4b5/DbOaz9ve6jgc9NHizFk6w8JMpYpe4EMrW2GkKHy93asbiAfHjHtcAiSJdF/GCzyKlLtYE3WK+6wK/K6sFA0EMuFweIomg8mIkoDiKCiKEhrYlBQF6aiA2BLDjSyFy+/ImFZPcdeSSQD5tYsRNu6RkOk+djL0Ssm9BAMqsaTxIwCpAEzO7b+9RBgaQizX4Aih7RQg6cGMHxagL3sZ51yvoFi0je+HK5CI1gAf7Sp2eW64raY0yuXt6fcEZ9xlEJU3Yo/jWuvydve2f2DaBcLlnV7LDXYwS X07SHsXU stBKUYAlN9TD25gsbwyj6EedqUCMLchk7p0Bpp9TUMAyf3G0Sk7Xf76L8N2M9ak6vMZSo9KfxvYeuVPFW8CPfY1nz5uhtLEmAqy1s7eYGHAC7prG50PxF8kJeK+9uBiUAolecBiZBMcDcuBxcx+B1XHcz8VrUcfR9MHC2SNuNrqZGziHwIDPkPTIxbZ2BGCxeOQMRckeNln/HHhMD5nIe1zxub3i6jhMgLEzYcr9P1xnWAbEozqc3lXS33cUtXD1jFzaKwC0qxb7ktQSJRhigoUn5S83LxsZ4vTHz4xXV4ZaOiUVnj2QuebTTVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/24 12:07, Oscar Salvador wrote: > On Thu, Mar 21, 2024 at 11:50:36AM +0100, Vlastimil Babka wrote: >> Yeah I think we could keep that logic. > > I am all for keeping it. > >> But we could also simply subtract the refcount of the old handle (the >> "allocated for migration") in __folio_copy_owner() no? Then we wouldn't need >> the extra migrate_handle. > > Since new_page will have the old handle pointing to the old stack after > the call, we > could uncharge the old_page to the migrate_stack, which new_page->_handle holds > before it gets changed. > > So we basically swap it. > > It could work, but I kinda have a bittersweet feeling here. > I am trying to work towards to reduce the number of lookups in the > hlist, but for the approach described above I would need to lookup > the stack for new_page->handle in order to substract the page. Understood, but migration is kinda heavy and non-fast-path operation already so the extra lookup wouldn't be in a critical fast path. > OTHO, I understand that adding migrate_handle kinda wasted memory. > 16MB for 16GB of memory. > >> Also we might have more issues here. Most page owner code takes care to set >> everything for all pages within a folio, but __folio_copy_owner() and >> __set_page_owner_migrate_reason() don't. > > I did not check deeply but do not we split the folio upon migration > in case it is large? > Which means we should reach split_page_owner() before the copy takes > place. Do I get it right? When I mean is we have __set_page_owner_handle() setting up everything for tail pages and then we have __folio_copy_owner updating only the head page, so this will create kinda a mixed up information. Which might not be an issue as __folio_copy_owner() should mean it's a proper folio thus compound page thus nobody ever will check those mismatched tail pages... Maybe we could adjust __set_page_owner_handle() to skip tail pages for compound pages as well and unify this, and tail pages would be only setup for those weird high-order non-compound pages so that the odd case in __free_pages() works? Or maybe page_owner is considered debugging functionality enough so it might be worth having the redundant data in tail pages in case something goes wrong. But either way now it seems we're not doing it consistently.