From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8C9C2D0CD for ; Mon, 19 May 2025 18:59:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F0DE6B00CC; Mon, 19 May 2025 14:59:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 154826B00CD; Mon, 19 May 2025 14:59:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC1B66B00CF; Mon, 19 May 2025 14:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CAD966B00CC for ; Mon, 19 May 2025 14:59:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 076A4E5583 for ; Mon, 19 May 2025 18:59:40 +0000 (UTC) X-FDA: 83460571320.10.1818234 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 99D131C000D for ; Mon, 19 May 2025 18:59:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K1gCuF1T; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747681177; a=rsa-sha256; cv=none; b=0alaWna/sgm9rax0rnxVlkQCZJERJjO4Vq6H0M2rw1yCAS3BoezymTbSmExViZ6CBtujTJ eGHivReE6pO/1ki7m4GuxFN+Fdn2N9oNCo1be+dTNKYH7mo8N0/6fy9sqLrBXfmS4nyRCN fjjroCidT57Se8hkhXi6gVvEG78BxVE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K1gCuF1T; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747681177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X0Qk3+ymMKfgujs1vuiAbuMvJLkr0y04FOhPHdnkwSc=; b=LA05SxnMAiscqawuGz1ScotRBKSJvsPGsiL69g2JtU2eXzCBjdzqrWzNR5GBpblZlTXC+v K08CW1myMHqmlxg0IO0Aw5pNU0CiP4/7voZ2S6XHVXAsJqMa2QGRbWLZzZL/WCgjsk599a MTaS5cGcRcXjziAGk+H9C+8aaT2FaaQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747681177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X0Qk3+ymMKfgujs1vuiAbuMvJLkr0y04FOhPHdnkwSc=; b=K1gCuF1T8HZOBjtezzhnUyksGhG0QsaNFhgxeXeNxsBl/yDIoU+zSB4Y1oosUUqIEK8TOR ZeSUQAqWBLebAebZjZ98LMqfhmrwnm5aeVaZzjraZTVC5/UUcNCZYSdPCZ+OBZqZTuq1iA xYLtpx8DYQlI1VWduHDccGrQnN/2cUU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-AAQvmse1Pv2_f0wsSB_eRA-1; Mon, 19 May 2025 14:59:35 -0400 X-MC-Unique: AAQvmse1Pv2_f0wsSB_eRA-1 X-Mimecast-MFC-AGG-ID: AAQvmse1Pv2_f0wsSB_eRA_1747681174 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a376da334dso462635f8f.0 for ; Mon, 19 May 2025 11:59:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747681174; x=1748285974; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X0Qk3+ymMKfgujs1vuiAbuMvJLkr0y04FOhPHdnkwSc=; b=rmfcM+BjAs0RC7YcNRwOmhrtLm4OS9fIzlSGr8MU1bFYOSsfz8UuvoFuwliHxXxjcB GY2ivSf28SWuJwjJZHAkBw5BhL8vchfOf32zS8G+skzyGB4vYMrlPPEVDKbBGxr7vRRC 5y49r+L2v0kBkd0CCk7k1uNhtxuAOy89JtDUVaCC1j6HL2zTIOGAdnMAJoVjKAAmdoKv u6dEzUXOMZ83zBZLDRPm5UfHI35pSFaUZFSd+fKwboszbKq1E3NYB0ueOXbAvXQjT4vO 0rOOR/FBGuXi4Y8sNeA/kkjb2IiKshEfNcU/04O7V1ujQP7cc3rI3rhtGbXUrBJ7jKsS WclA== X-Forwarded-Encrypted: i=1; AJvYcCXGySwZsw1T7i2/5PWjdcZmnIKtGjoc/dr/UGxQR7jzXazNpBgZqPuiPJjSEAKqjQHUSpEDmOJwpQ==@kvack.org X-Gm-Message-State: AOJu0YxDDKu02KjQ6lv9U7/JEm6yUvOCDYBmNVrmXpulCq6kjV2wpd9j 2JW251EKkBCpurAtBGCHv9XNcTDqmpcmjIwx9z8SLUfdz/KytcIZSaWn72ZvR3mVC2W4cwxbLzN 9t1DJP1tNkDls4NCQP8nt00QGJrjpq9mv+6C+UXwYMXp6kFBCXK7B X-Gm-Gg: ASbGncutCGvwcdq5sza7X3zGG9AMKulephhrhrIxqHGByXqHfwulunO8ukeIscM4p50 aHo91ef46wmjU6maFQBDQv+SuAPRJtbOCfI8KXzIJkEJTqooeQKzfXH7ChIiepg9pzWExLmMg1b RhBOevIZ8ajt4Rz9tPUI/+0dU1kSyn6hxdM6X7G+UHgaDYZqTnm+Bx/pKwh4JRhzhRH3rWctG7d uBIMCNYjt803itFWwwVs0oqKSgqi5o82QmbNdTn2l4z/tlCV0JjIQnu/FVqWSxUQ3FXNCSka65O A+xlkS02CpG8gSZiD5cFp8A/AsRsro66vOeviD+VmSFBkyyOAuPCRsAK9OhFtkoVgAsCLqIJsJ/ ioW1tz5PDbQNX9r8j5JlyLekPqwrIptJkCKxlxXo= X-Received: by 2002:a5d:5986:0:b0:3a3:76da:32b3 with SMTP id ffacd0b85a97d-3a376da331fmr2195986f8f.18.1747681174497; Mon, 19 May 2025 11:59:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUwd5DmDCrWqDk782Fvd284ghiMbFSA1l7ydnuebYBS00RZnMHD2oMIoWNw/QJBYRcVq1hKw== X-Received: by 2002:a5d:5986:0:b0:3a3:76da:32b3 with SMTP id ffacd0b85a97d-3a376da331fmr2195970f8f.18.1747681174134; Mon, 19 May 2025 11:59:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d26esm13969960f8f.13.2025.05.19.11.59.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 11:59:33 -0700 (PDT) Message-ID: Date: Mon, 19 May 2025 20:59:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: prevent KSM from completely breaking VMA merging To: Lorenzo Stoakes Cc: Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <418d3edbec3a718a7023f1beed5478f5952fc3df.1747431920.git.lorenzo.stoakes@oracle.com> <2be98bcf-abf5-4819-86d4-74d57cac1fcd@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2be98bcf-abf5-4819-86d4-74d57cac1fcd@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zmGDDOUrEPHzUrWwmXhZjwtwehn8H1bbb1c5ihFp9Hc_1747681174 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dqsknuijsdp4on6f6qnotbxwdkyowhey X-Rspam-User: X-Rspamd-Queue-Id: 99D131C000D X-Rspamd-Server: rspam06 X-HE-Tag: 1747681177-857472 X-HE-Meta: U2FsdGVkX1+sNxVIhSzt5Eves1Gsa6yiRIDcUHzMMbs9djIeSYiOEtVD07qy0iXBSxW7nfWaxRgkldAEb1qgkOSzokjlPn73f0laBHDHrC7Pf1gLnisHaTsvjTu9AjAclgZwBZkKKRnUgz/9uqCsPp9UdmptHrZgAqJUTzO+cJCG05XrXpD6g69JtJAgyE7qWODDaLjfRmq5z/CZZxRTNNle5MPFNNPiiXORtY8UhTM/AuDp8qcGv8fiT7pAREGnLSp6zf6P/9futeH8K7bhCitdmEXc4A9za2FmllmDCln4hLyCVWNkXSFoekNa+3plbTBZEFpmkWO+qc89VWqq8bNhegMdyvc6XYl3TWrwtz/XklndbRH7FAmh1YqvtAZk168kAZL1Nphi0cqIw4FzClIoVS8tigs9t8fM80ckSCLVIM1hrwUW9lAJSTXNpxAPPgd8gFi+myEiW+v4JRFetuuGDVHH8iSNeiswEFOTdlYfYJ8vwC4mIwU07Hidtw9sejCTtSYpQDGKSnaHifmeufJvYCgV+rwhL+iaOYFe0bPCzU0d5LCaY6xTdTkQpxy1bniowqpoF4zTA7riWOA24XXutcyxiTTebgm5YYhTmqarTJ0s7cECcM4b5zPTeHquZFMqCj0yT9Lp9vZRXMzg5mOYYF/nrZHzk050J8EM8qDYKOLW/DyX6k4lDM/aMeCC4KfJ07rB8dghADeMFqRfBiornZ/5CmN+NsGIdERv1/L0M2QSDmHwNyDLneysVaGMMeciQNAgZkpighpzbFXLyOvtwwU2neu3Mvfky/YVzC93ffeVjoj+eShQpG0HwulY4Qr3dSXTuDaU9MZHZ7APAMSqOhN6nq99sRKYUk2GEsoG9WNJBZtb8FGXz70ayvSRQKY3PGfxi2/5r54iEjzns7k+ovmtWg4i2R0N72dAFnjIQk7V8iX1Ps/K7HxrrfZyWStUTR9yoP7meMD3QLg z5UMWCr5 /oWwxVNTNT5gmFwacBM2yIhTIsiadJseuVpX2NDpBfXGpSEwqs/C18VenSRjWW7OmAbx5SD4U9R0i5QY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> I am not 100% sure why we bail out on special mappings: all we have to do is >> reliably identify anon pages, and we should be able to do that. > > But they map e.g. kernel memory (at least for VM_PFNMAP, purely and by > implication really VM_IO), it wouldn't make sense for KSM to be asked to > try to merge these right? > > And of course no underlying struct page to pin, no reference counting > either, so I think you'd end up in trouble potentially here wouldn't you? > And how would the CoW work? KSM only operates on anonymous pages. It cannot de-duplicate anything else. (therefore, only MAP_PRIVATE applies) Anything else (no struct page, not a CoW anon folio in such a mapping) is skipped. Take a look at scan_get_next_rmap_item() where we do folio = folio_walk_start(&fw, vma, ksm_scan.address, 0); if (folio) { if (!folio_is_zone_device(folio) && folio_test_anon(folio)) { folio_get(folio); tmp_page = fw.page; } folio_walk_end(&fw, vma) } Before I changed that code, we were using GUP. And GUP just always refuses VM_IO|VM_PFNMAP because it cannot handle it properly. >> >> So, assuming we could remove the VM_PFNMAP | VM_IO | VM_DONTEXPAND | >> VM_MIXEDMAP constraint from vma_ksm_compatible(), could we simplify? > > Well I question removing this constraint for above reasons. > > At any rate, even if we _could_ this feels like a bigger change that we > should come later. "bigger" -- it might just be removing these 4 flags from the check ;) I'll dig a bit more. -- Cheers, David / dhildenb