From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2567CE7B02 for ; Fri, 6 Sep 2024 11:20:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35D116B0085; Fri, 6 Sep 2024 07:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30C1D6B0088; Fri, 6 Sep 2024 07:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FAFA6B0089; Fri, 6 Sep 2024 07:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05D696B0085 for ; Fri, 6 Sep 2024 07:20:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 962BA1C1510 for ; Fri, 6 Sep 2024 11:20:39 +0000 (UTC) X-FDA: 82534070598.26.D5503F5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id D044140003 for ; Fri, 6 Sep 2024 11:20:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725621558; a=rsa-sha256; cv=none; b=LEaWB5+dY8fcdsT3n61mamSI9tUvbe9KvKrmb3sjlCjNIOl7tFpmcF5K3rhr3SC5dUpNdQ 2JjlFUsaSexQ6J1RQECNxBBHmIxDGQ1w0YcLW6KpErIKlQW6miYjlmm3NCW+ZpT5bky2NL 5s3DlRMidlpD2GHZIimsR3GXDl4WLSc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725621558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZD8Zx0VfpA/SiDzoJs5m8N2JQdRaYaOrLKWB1EyGdhI=; b=t0/J6B/hlu6dKXeK5yP7oyPySBsfW674w1K/5uhdPgYs4EiLto6ejn2bR3QWqDo/rflR1k CqImVwIY9ecXakmAZAwqVsl6r9oFn0HHkFEEwFTqu9wmBIuqUVan4fnmr8lsm1ANOmLZ6Z +IPqkeuGb24RS4E6sqN0IWyqp1o30f4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 539ED113E; Fri, 6 Sep 2024 04:21:03 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86F7C3F73B; Fri, 6 Sep 2024 04:20:33 -0700 (PDT) Message-ID: Date: Fri, 6 Sep 2024 12:20:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h To: Arnd Bergmann , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Theodore Ts'o , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D044140003 X-Stat-Signature: 1t4epxu76ckfcf7xfdupss7ro91mgteq X-Rspam-User: X-HE-Tag: 1725621637-904902 X-HE-Meta: U2FsdGVkX19gwrsFGCmjsI4s1O90PA61eNQ47DWVZR4ShlgfaHVMqY7bRvTJ0WDk+Zm43U17AD9VvUTtTRPCzo1osx7wUt+CkHG8DebWCXyjQe3vAF8bQIWBUm39Dk5CLnLL4qm2zoEnLJYwEGSiZfCxnx3xqGqWQt3ex47u0nZvxdkjcAL8dSVZDlL4iwEzoxjhEyxMDGoPNbBsMZ7VpFUQ97xJb/tIcECG8YgQYL4WL9Kk1YXr9SbahS9UAp316aE/3STuoSyWmGvrgHM6w+1St7nLFQVs/nNVP60hizY1NHu0JkKWL+w0cN67Ys6rTY4wS/QIfX2mAdCX6U1JruwCn9qfw0TPcc/rb9mP7l0Ue5doyL01gyHmCfBo0L9AiN9Mne4LCO3U2hi33bc3HSehSsrZhIkC3aBXMw6RQLW/c6zg99gl05GxGvkjl2O52dcvDFwT7HJgozYx72xDB7v/zCgUGvvMTZ/4wsOpVmL5Y2SSS33px5+gkAwPUbRFYnWw8Db67myNoCb6jvwbpMSh1hQzN2Wx9wnHvWFpg9fvskWZNxGnTB/DS8I36gD0xyqJQRYUK+ARbvOPm18OvZxwgTooQvgByDdM3sE35K+e3Df06k5YMX6Pvd6xK/IFiS9WboPhoYBS4lAH15TJXWw/sH+pii36cr4CFr6J3/hKPyEbjzrqyba7J9z5mQQp1DWz/7O9MId9oDlu6cPa0aELclbZATMNPFSCLvkhjCQbVZS0gX5OszonziKB1DN3iGPntEqZEN5cVEuOEGC9r8SEJN5JNgtZXvF/CYPkSxG02fBOeCCTHg1nOgJIlLneU1pXiLkjMBeA2Ir+UX40ZPelbSxGxailz8rwa9t2wGS7fGfsB/aAa/cRGIE11GdACGDL9VWNwFRM10JkxWlj36P1B/7TUXbQr52aYhvKLet3DWLAcLEY0HjLIeZnt6AMt02x31d6NjGme1T6+40 YlmLE8/T 1NUfVmgiNs2j+9GslIBOnwKwzx1a+aqwNJw0aEeRpQAQT2K2N8Wl2DNEGctK424LOGcZ4Bucmum+2YN9695fwFQmS4DDszxIZd9rRchXF7DYK6NoiDJBWF+VQZrT7e8hZBr7iB0jqA3/2/Xf7JunxRQ4vgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Arnd, On 04/09/2024 15:52, Arnd Bergmann wrote: > On Tue, Sep 3, 2024, at 15:14, Vincenzo Frascino wrote: > ... >> + >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef __ASM_VDSO_PAGE_H >> +#define __ASM_VDSO_PAGE_H >> + >> +#ifndef __ASSEMBLY__ >> + >> +#include >> + >> +#define VDSO_PAGE_MASK PAGE_MASK >> +#define VDSO_PAGE_SIZE PAGE_SIZE >> + >> +#endif /* !__ASSEMBLY__ */ >> + >> +#endif /* __ASM_VDSO_PAGE_H */ > > I don't get this one: the x86 asm/page_types.h still includes other > headers outside of the vdso namespace, but you seem to only need these > two definitions that are the same across everything. > > Why not put PAGE_MASK and PAGE_SIZE into a global vdso/page.h > header? I did spend a lot of time a few months ago ensuring that > we can have a single definition for all architectures based on > CONFIG_PAGE_SHIFT, so all the extra copies should just go away. > > Arnd Looking at the definition of PAGE_SIZE and PAGE_MASK for each architecture they all depend on CONFIG_PAGE_SHIFT but they are slightly different, e.g.: x86: #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) powerpc: #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) hence I left to the architecture the responsibility of redefining the constants for the VSDO. As a long term plan I would like to simplify the code and have a single definition as you are saying in vdso/page.h for both the macros. But my preference would be to post it as a separate series so that I can focus more on validating it properly. -- Regards, Vincenzo