From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B38C04FFE for ; Fri, 26 Apr 2024 19:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF8D56B0096; Fri, 26 Apr 2024 15:08:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA8316B0099; Fri, 26 Apr 2024 15:08:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70796B009B; Fri, 26 Apr 2024 15:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9A20B6B0096 for ; Fri, 26 Apr 2024 15:08:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4287740A2E for ; Fri, 26 Apr 2024 19:08:54 +0000 (UTC) X-FDA: 82052620188.12.10B2E2A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id E77A780012 for ; Fri, 26 Apr 2024 19:08:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IsbbtcTd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714158532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqymC4N1I5xnwiJ3V4c/ehB/KNavulLMGbF+wl7/oH4=; b=sKqrqZB9UhrbQzn5gXgChJKFnabwwvOMtFwYoS2wa6vYzTHXKAy/t386R6ptcfoRkM65U1 9+4ckk/rbciMXXgfpq0zQWYCrkRVkpfIUVBet7OxzUOhyGkrYz1+nXqVIaFkIyICOBJ3VA StrKEStedaAGjVZntmEBzQxivgd7558= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IsbbtcTd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714158532; a=rsa-sha256; cv=none; b=Izv8u9qe+JC6EdSB5yN5rQyh7x312XlCGZWm/Us9xeJfkaW730fMXT4W0F3rrl95ghIUY8 qGlWj83xJdkbrJNSgJLhjvB3Qyox+XTeHu09+LcyKAwOQeJLlZTv3rMgG31XCsPG2a1xVS DFoEbrQlRaEkqF13Uzsmf4SKAsYWr18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714158531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EqymC4N1I5xnwiJ3V4c/ehB/KNavulLMGbF+wl7/oH4=; b=IsbbtcTdQN5nY+ufYK5/b8yImlEBhNKJXfVVCeRZSU9I/KSW0gUQ4MIjNzl2UqNO0V+T3/ pOYn2sNKR1jqjpbqviqSiQwobydXZY90wjGKjflPZZLr/2Qg9s1vYoBwHXAHfH++zNqZvG dZfikn1x9cJQmq1KKlJ4YwA/nIvDlUs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-ZC82Y-BrMl6KUfi3XokEew-1; Fri, 26 Apr 2024 15:08:49 -0400 X-MC-Unique: ZC82Y-BrMl6KUfi3XokEew-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-418f8271081so10051715e9.3 for ; Fri, 26 Apr 2024 12:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714158528; x=1714763328; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EqymC4N1I5xnwiJ3V4c/ehB/KNavulLMGbF+wl7/oH4=; b=UP5XUM+f7xit9Hso+4EKI3ipywAZu7rtDEzcw9tuLUDU4yV1K2zBPmTQWHd78mIl6J XO1mUIWUBSrBgsAxtejiUF2KGb9147W7r9v4tCYN1Y1+i6YcIneWfpr/2DZhOYwhu68d 2SfL5fv9u03DFQeVnzY/YOu/is1Iwe8unexABVhGoNvC7g7zdxNnpBcDZS30Dd+XZKPx KGpL/UMtosU6G42Y+ARHOzHY2hXwIjDLXCavJ9Zm3W1on559DwruoTAQzF9mbUylYDdE O3cuhyOV26h0tVoSB3MRpdHYNQKYYrJRz2TZZhbxAJN8cSctGvaNmCKnilxqPXLkUWFv X72A== X-Forwarded-Encrypted: i=1; AJvYcCUcnXUv+USPK/PeNuSth9AdZV1QnBt8Fcx4JMECnzR9Prlfscvg8H3BeOxXz1jhPYU9W/URUC9oeAugbRka8fi1HME= X-Gm-Message-State: AOJu0Yx2u/jTVeJekisjL48uLEHPErSOHPvH2xYI50QKAH8+GCuRPj6/ wjuL4ZrLJEfapNCS74Tm6h/PEjYmXSIFu0Wtn/7S06N6bOzm2XtejL6R2RjRydjyqpnDuw+UZL6 YrHMgLT1R6KjSoD194kZMvhdawqhExoUZtqZwIiFZdv8A9rVg X-Received: by 2002:a05:600c:1911:b0:41a:8055:8b89 with SMTP id j17-20020a05600c191100b0041a80558b89mr3100068wmq.6.1714158528471; Fri, 26 Apr 2024 12:08:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn9ghvM5IIb9vzOAT3wgOf7S+IUgcSYF25UPVL+0bIqUVbmXDKa7jf6fcE/z6Np6M3huuacA== X-Received: by 2002:a05:600c:1911:b0:41a:8055:8b89 with SMTP id j17-20020a05600c191100b0041a80558b89mr3100051wmq.6.1714158527972; Fri, 26 Apr 2024 12:08:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6100:20f2:6848:5b74:ca82? (p200300cbc726610020f268485b74ca82.dip0.t-ipconnect.de. [2003:cb:c726:6100:20f2:6848:5b74:ca82]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c3b8600b0041892e839bcsm32170985wms.33.2024.04.26.12.08.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 12:08:47 -0700 (PDT) Message-ID: Date: Fri, 26 Apr 2024 21:08:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm/rmap: do not add fully unmapped large folio to deferred split list To: Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Ryan Roberts , Barry Song <21cnbao@gmail.com>, Lance Yang , linux-kernel@vger.kernel.org References: <20240426190253.541419-1-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240426190253.541419-1-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ku5qwif66au9wbmketod7uykisc9oo1a X-Rspamd-Queue-Id: E77A780012 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714158531-519788 X-HE-Meta: U2FsdGVkX19qy6d71F326d+cK8RdhaDfNWK0xmCdrwf2G2nW7AuPpbmLLVdyMhUDYj4NLQP/6o3jSTyRGgRdKSNs4rUpir+Yza3kOAuzqz8mwXwdmAOZHmnNYEAk5cLJJ5BsG03cLVSuQu6l3hMaP/gT2Odj70eEgR0WBU7OciD8amPgXWteTc1z6c8ImqOwJoh/+G8XpLKO7qEyEHhamvJBUChr7F8wp4G9YpRRQ5xbYq7y9eJwrlv+TA1ll4aAMfpX32SWBaTkv2SCzXMNKpspAprsR9mAwd3713ynAd5qGh5na53HQRcWkzWt0EVqCQdSSJZns/BoFEXhuN5VW9feJuXc52SyEUWIiQrwh4iz3i5Iw1eVKvv4sjWKZsEKDV/W/l5MDt719ipE1NJq6EtQLGoYzO7oUtHJXY15wp6n+NPF3pgzJTplHNcQMrU1K6USAtDZALEfjKcV8wmghJ9MfjqHZVU77i13P8+HS0pm+lxxagXQIClIeDFMHSpOajF6etTOaNFvHAV0RCjgZTDn6EmDGigOkWC2WsAojwquTRerP8r+CergEZPWKgSn6FW8A0hKRYwW/x8+1/4V1KiiFAS1DwnhKlyVLxnEw2aO4gyX/Nse/+SKRr2BDp4tC5xmoNGZ5zQICjmH1KGKCgyjBFBfYGjeu+uhxdXnwuPIjWmiqX+mSsqh3I25eqaRDcCtbNevgbm3QSX25TYRw/JXJKccFQM4E03vxwWC+ghGWl5ketE55f6qSf5DqlS67aV5wtfQnzQVd5FrudJrkhjmbf9vH5p7htTdcypUyLA9T9nRUSX2CbCm1Zmk1Z2DFGTd3s6jGBQwYY5LGYVYnOZORaTJCD1qzVF14zOsjwGXfPIQneMXnn0d4CdwasSrSG1ZoQyKs+jCEL3R96AQuB7N5c0JRgUKfCoussj2UK+qI/atytwYU9ZZTbXmYF7S5E37yc9tOt1LcHUXpGz 93rSwk7U YX03RFlmihr8rGtCNqpwTmNKMl138TlRaRb4fQAan423e8zgol/tvTPYQ1rdm8aBCj5Sj4iLCDUNq5K4VCSSd+jcgipj9zRewXOifrl9ekX6/pw+nkgoH7kKAlnbefELpi59H9mTP750IfbwbQYTyygJ/QbyKBvtXQdAm3rAQs05et/Ku1TfJu5s3Q/uNmSX2wHJynJzpG7TMI1iSy+IDQdWbIr/25gQF8uavSXIZqgy98HCsMz81sgW5Lxi8d6o0RhyMPJXbOwXmEYEKdxtlNoCmb8oYatAbF4jX4TG4UvP8RcBLlad95UJVtcEBm5kLPY6Je4Apbsh4vlxsUS0/Kh0OGdu6aJcA3sxH3SLHbFcvF4bbPtR+R4qni/qJT3DZ1NlK/vBpwASpEpy9HbGw1lJy08IrTQilvooFCfwzeWyG/nLSYZmwlUWTUezTuyrZJbaa3TJmU8ZBGB1Yj5pcecIeBi2WDQPRP0v5h+RhH3biB4DgeYH/EK/pe4CBYjZVrPet X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.04.24 21:02, Zi Yan wrote: > From: Zi Yan > > In __folio_remove_rmap(), a large folio is added to deferred split list > if any page in a folio loses its final mapping. But it is possible that > the folio is fully unmapped and adding it to deferred split list is > unnecessary. > > For PMD-mapped THPs, that was not really an issue, because removing the > last PMD mapping in the absence of PTE mappings would not have added the > folio to the deferred split queue. > > However, for PTE-mapped THPs, which are now more prominent due to mTHP, > they are always added to the deferred split queue. One side effect > is that the THP_DEFERRED_SPLIT_PAGE stat for a PTE-mapped folio can be > unintentionally increased, making it look like there are many partially > mapped folios -- although the whole folio is fully unmapped stepwise. > > Core-mm now tries batch-unmapping consecutive PTEs of PTE-mapped THPs > where possible starting from commit b06dc281aa99 ("mm/rmap: introduce > folio_remove_rmap_[pte|ptes|pmd]()"). When it happens, a whole PTE-mapped > folio is unmapped in one go and can avoid being added to deferred split > list, reducing the THP_DEFERRED_SPLIT_PAGE noise. But there will still be > noise when we cannot batch-unmap a complete PTE-mapped folio in one go > -- or where this type of batching is not implemented yet, e.g., migration. > > To avoid the unnecessary addition, folio->_nr_pages_mapped is checked > to tell if the whole folio is unmapped. If the folio is already on > deferred split list, it will be skipped, too. > > Note: commit 98046944a159 ("mm: huge_memory: add the missing > folio_test_pmd_mappable() for THP split statistics") tried to exclude > mTHP deferred split stats from THP_DEFERRED_SPLIT_PAGE, but it does not > fix the above issue. A fully unmapped PTE-mapped order-9 THP was still > added to deferred split list and counted as THP_DEFERRED_SPLIT_PAGE, > since nr is 512 (non zero), level is RMAP_LEVEL_PTE, and inside > deferred_split_folio() the order-9 folio is folio_test_pmd_mappable(). > > Suggested-by: David Hildenbrand > Signed-off-by: Zi Yan > --- > mm/rmap.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 2608c40dffad..a9bd64ebdd9a 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1495,6 +1495,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio, > { > atomic_t *mapped = &folio->_nr_pages_mapped; > int last, nr = 0, nr_pmdmapped = 0; > + bool partially_mapped = false; > enum node_stat_item idx; > > __folio_rmap_sanity_checks(folio, page, nr_pages, level); > @@ -1515,6 +1516,8 @@ static __always_inline void __folio_remove_rmap(struct folio *folio, > nr++; > } > } while (page++, --nr_pages > 0); > + > + partially_mapped = !!nr && !!atomic_read(mapped); Nit: The && should remove the need for both !!. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb