From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B60C433FE for ; Mon, 10 Oct 2022 17:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBFBF6B0071; Mon, 10 Oct 2022 13:02:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D968E6B0073; Mon, 10 Oct 2022 13:02:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C37826B0074; Mon, 10 Oct 2022 13:02:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B34306B0071 for ; Mon, 10 Oct 2022 13:02:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8CE891C636C for ; Mon, 10 Oct 2022 17:02:32 +0000 (UTC) X-FDA: 80005658544.27.3D4D2C3 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 1ECA5180021 for ; Mon, 10 Oct 2022 17:02:30 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id p16so3205594iod.6 for ; Mon, 10 Oct 2022 10:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=GfZe1er7asCP0ALA4xE6quMC5DxOFhh/7LbUYi1cC7lbaczkr2bHNyRdEFHjv207Vn Wiqxjkj1oviICRGEGXz7Mcg6Awz7FctKFrN1vYbsEPlnEa06eG1DIgm3v2oSHEgptcur spkpD/4M/kpmoHV9rtcTZJr2HLtXnkPJPYdPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=x3BekVgTQdMkN1ywAWt4MUfrpG3V1NfE/lkRind9oaVPhg0OWCGP6LBJUGDzTg36/i njSG1M6SoivHVYO/F7EvoagfD2GnLw4CpNJv79rtdXgeHRtujvffoszROXNtzLMYmsdv 6LIletWteGOCyZlmNy4EdjBrsofUisXKntheVBgU8d90BgR4XYRahgDpqNLp61/1Txp/ mfLGCPpUHBTYQQ3IRx/IulSh45Ir/CxEDo9gmhti6Ia9XUmrN0ssw80chSvC7Fg2gqe7 qfn3zk7By+KGhu3fUklJ9rAwR00MNLeUj3bYNFVhWgbYQtqejTYxZmc3WkUdYVXEE11v 0ApQ== X-Gm-Message-State: ACrzQf3U0/5b9u/G1CNekyF77onLDrJJC7TFEY0vdFiRrOZoXp+ZaYbt zZrbp5Kqt8ZfA2ZhdY7jzEj9ow== X-Google-Smtp-Source: AMsMyM5MdoRFlHdN/oWlHzW5c6TiU0d91kNy2sJnAp7PMUFFDAN10eFKJ+CZjzZGIA+MbGA7ivOSYw== X-Received: by 2002:a05:6638:2491:b0:35a:53dd:f98e with SMTP id x17-20020a056638249100b0035a53ddf98emr10571658jat.261.1665421350124; Mon, 10 Oct 2022 10:02:30 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id v2-20020a02b082000000b0036378e4747esm4096449jah.114.2022.10.10.10.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 10:02:29 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 11:02:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit Content-Language: en-US To: David Hildenbrand , zhaogongyi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Cc: "akinobu.mita@gmail.com" , "corbet@lwn.net" , "osalvador@suse.de" , "shuah@kernel.org" , Shuah Khan References: From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665421351; a=rsa-sha256; cv=none; b=GBxLdTahumJNiFZAj018P+/QmUANK6asHcByRLULYQIZSza2MDB71rNMWe4RPWdfG8qWqU ylpaGHOO/0rhyufwg9JpDfYvukfjisVkCVipR7mUGJdLyXxXa5uevBBEf+CGgGF/0MMH0X GfogvlptxyQPtAyWPEXeChizBiHT9Js= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GfZe1er7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665421351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=sDp1l+eFFyqk1g29gYtAmREZvSbKZcLbYRaQw4QbEymPGxLFD1piBstc3OxIhitRUdJ4fy uQGXmMNz4klqLn3o/VwSbOS+tSyGKB3BxfTgXkyr7xO3lR+CkqKcaiOACTrZlySz8Sk4UH TbDbT/FCIm4FOA+vwNWPgo20oKOdcHE= X-Rspam-User: X-Stat-Signature: ms56b1tbbuwtcps7bzgpxzc6puyu5zyp X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1ECA5180021 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GfZe1er7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf16.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-HE-Tag: 1665421350-539499 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/10/22 00:54, David Hildenbrand wrote: > On 08.10.22 03:40, zhaogongyi wrote: >> >> Yes, online_memory_expect_success() already prints a warning, remove the warning in online_all_offline_memory() seems ok, >> >> My previous consideration was that one more log information would make it easier to locate the wrong location. > > Let's keep it simple unless there is real reason to warn twice. > zhaogongyi, Please note that I already applied the patches to linux-kselftest next for my second pull request before the merge window. Please send the change David requested in a separate patch on top of next as a fix. thanks, -- Shuah