From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8905C6FD1F for ; Thu, 16 Mar 2023 15:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67778900003; Thu, 16 Mar 2023 11:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6284D900002; Thu, 16 Mar 2023 11:37:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EF9F900003; Thu, 16 Mar 2023 11:37:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4073B900002 for ; Thu, 16 Mar 2023 11:37:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EDA9AA07F7 for ; Thu, 16 Mar 2023 15:37:43 +0000 (UTC) X-FDA: 80575166406.10.23897D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id A3F3740014 for ; Thu, 16 Mar 2023 15:37:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KxjY9hU/"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678981061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=10cvjAWj/i7Tr+Lb50o4wfxv3/cWk1L2EfPxqlS0kiI=; b=Fnr0cmydXgHRozVB60Xs/GLAaNEGwfIAXPcdPFeDtOtC6RWVTTscS+CA5CXmvPD1lRUjqL NQtYefxGUSgrAmkuSfxsYO7NYM9ysJ9QxH6kfM0acf5aXtKa++Yb4xP6fmOilN3emC4dMM FTDElVMiM7tmmEhsazRZE9AdazgHItw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KxjY9hU/"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678981061; a=rsa-sha256; cv=none; b=eEnIUg9Q1W1yi//Uef2ATlsJ4bMXzGTDO7Mc9BdQ0S/vNVHlX7S0+KGaJj070h14UaLfoS 2X2ottwiUttbX/PutGBWCvWm9VY6HiEe0RaVTw4KAH3xjbzVzCsZ5znbIJ3MLzk2I6sEOV bduiRJJwJOLBTwfB2h5hmqaahdEvjCo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678981061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10cvjAWj/i7Tr+Lb50o4wfxv3/cWk1L2EfPxqlS0kiI=; b=KxjY9hU/A2lfP4WypJptrGSYDjNFJzCxJQMnXCYdDzQ4c/jHk1vbkZklGa8FwXDm1NippN FujQpfc19cQNeqJB70tpcyYr7K4oWIpfpfESSSKDmlDPq2y5uHuukgOFCunIpg0UndfNgv 7KuCebkrnz6aLPQzRoyA6wiAYcD/cFM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-qZOhkGinOUSXy51E7I2xKA-1; Thu, 16 Mar 2023 11:37:39 -0400 X-MC-Unique: qZOhkGinOUSXy51E7I2xKA-1 Received: by mail-wm1-f70.google.com with SMTP id j13-20020a05600c190d00b003ed26189f44so2788656wmq.8 for ; Thu, 16 Mar 2023 08:37:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678981058; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=10cvjAWj/i7Tr+Lb50o4wfxv3/cWk1L2EfPxqlS0kiI=; b=FAdwBCFO728xlYLccH247UsJUd9oRSJbhlrBIG6WYGblRky1TzDpGHRMtyUiQJblez p8g6SJWcjIsGpX1CHqZ5wR07w5H3DIm13BBpeb2/GSgC6Tw5xy+sWX+EdXw+yfaHNBiQ y1ctJL1rLwhjvQT7YacyYqhnXRRfpyosFDXwXxG/q34PpJ0uuV7fWzIOc54zugi96MR4 CxeCkiNOqJd/kfeSHXFg4ScTwBz97a0v+RdqJ0YnrcNKKSWBCdWP/Bssz7MDFj4+GPS0 0jpM4sx1XEvj0WMshp3BcyLXmSgOf9VYkDjYbp6ZN5NvFP7mXLnLdGueBIFbYHsK/xgk s42g== X-Gm-Message-State: AO0yUKXfHYWE3KINgWTWhgFpmAScRS5oh6kQI+k/9aCPIwMH1VK/WKkF YUAkjMBw5au/OFZEgn+i60pGsdekwOA3Tbp/CAGRx/p32J1FRlFp5kTILz0nTIHYQMk2pOQZb2Y j4G69DfzWrGI= X-Received: by 2002:a5d:5955:0:b0:2cf:e29f:d7f5 with SMTP id e21-20020a5d5955000000b002cfe29fd7f5mr4525451wri.25.1678981058131; Thu, 16 Mar 2023 08:37:38 -0700 (PDT) X-Google-Smtp-Source: AK7set8fqjO7xgut70o0sevMb1v49SL3ULnSmxx8KeSVsgNMEeq2wco+1sVFyTBO2HcQ0pt6HItXAg== X-Received: by 2002:a5d:5955:0:b0:2cf:e29f:d7f5 with SMTP id e21-20020a5d5955000000b002cfe29fd7f5mr4525437wri.25.1678981057806; Thu, 16 Mar 2023 08:37:37 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id w12-20020a5d608c000000b002cfefa50a8esm6184757wrt.98.2023.03.16.08.37.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 08:37:37 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 16:37:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/thp: Rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Aneesh Kumar K . V" , Yang Shi References: <20230315171642.1244625-1-peterx@redhat.com> <83625129-26c9-8885-7367-bb56bc5367f3@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3F3740014 X-Stat-Signature: ini61enbhm9eb64qnw1t1ztagsod759h X-HE-Tag: 1678981061-161334 X-HE-Meta: U2FsdGVkX18gux5olwyQ9wMAtDs4o7X/+scoFUsREi8c3nBqbsG/ARjE5RdJ+FNFlu/BzsDJZi3678c3yyP+Q3fESqktntTrP4K9ck1X+TAl0/2caEmGji0NnS7BXRX3sNOrP9+XM91ul+gV7SQTBYPZIc6sAuiHITXSR0EkD1AIkvXCjutLT5SeNp2hs92Ydfc3UFb3sP/IFBvd5wYRlRa5wGYZQaGs5TBKQbrPBj9fNrh6/lpZSVOXnM9dwV7OZrUcOne01Fpue4kAfkaYdLwB730J4QQmJAI0YBoqjljbSoZQueB9E6doq/WWG//k18gJYJHYr2R1Ha7axlYIZybO8t02wuQE7iV4W4b1IPQ4C1Co1gBIK6ZMMCoXOHjSNycut7SXvfxoaE1xtJ3GCWHUhSGyV+pReYGsKaLYRxNba9kU2m7VaNzpS360P8zObtW1yO9Gn4j2b+sOkCzYn10Uub6lYLQM1kYe4L9uSXZZ5/mNUFqUZd5i51AjrDmt/455iohRl1HKIT++GOG4qSmmzW0gI0GzwCPpFCR/EsQg1i/2UE/DSYfNV1sesnY9e00ctUhKEkh8ixyXOyXWILYTlRFIOjb9zCGzq0LCmhxnb7nfKAy6H5t2VKcXTUe6lP0pxsPMA1wz9AwmJS15b8Ay+n9WhARmr4CohlSdta6yze8WXU81FqvKEDOJbXnXIYYf9cxLlbZByFeBZ+QA7ZacRbvKeX+do6iUc6tqyhSIQ9lYaQ0p4a0x8CTJ6IoabpoGWIV8PHt/3ntyrSAFL9DfIjAgTfPP7S1Ojmoj/4fKFKgeYQmNZxBhs7uEA2ZhJt5I0u7gUWk/ESVcWMqrkOtyhnJTp7ysB2emwczYyrruFGbhZt66TAC23N2xoiyuMZ1ZtSkTOOkrwl+ho03TreBfkUIO/r0Stw4wuxAPksveFupbegxqT/vblEfrV+DHujGZJkAJj39PG15Vz1d uHdoVG3v tOxoAPh9heLk4FBfFTIIFR2Q85I3KF4s6A0WkPF/dZfF61K/jmVZya3lm/D9uJQKwlQZDsjLC38Zu3vMtLlAGUZxCkFYngzPieEO2+8urytSu2m3dWga4nogvhgpMH3Owj1oMmlTx4SvjW2I0j8wNy17tnWeGwW9KmF3vZ1uUm28tJHpj/VVchy4H3vW3T3L8b1HuEcaPskJwQfaUPWbEr0Vwzrd2qbsNF7d6sZMNSrEinSPyN0IjUnUkJLXFX8c301VFE44Yjk8SECCXO6oQdKzCxgE46+K/0kOztdcktv6BaZJB25JhhVm5Ds+V/G8ir9tqWW+mq7IeBPybG1ITAZPh4CWxHUXTrmEHRmzGou17tuNxaCvzxvpJigpe9RYwE0z5B+LII4pRAmssXCCkt5ZHhc9Or3xZStjraqWOp4TpVzrpnklFb7lx+STKqvG88bxTLd60WG3tCidxNPDUNbOT2bbjVtqsN6mDuXc6s4Ryh7ZtL9eL1JgUNMKWZ55sJGHZ622mZvrDyWqt8eKrA0scWLxknhKoeJC6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.03.23 16:18, Peter Xu wrote: > On Thu, Mar 16, 2023 at 03:57:12PM +0100, David Hildenbrand wrote: >> On 15.03.23 18:16, Peter Xu wrote: >>> TRANSPARENT_HUGEPAGE_NEVER_DAX has nothing to do with DAX. It's set when >>> has_transparent_hugepage() returns false, checked in hugepage_vma_check() >>> and will disable THP completely if false. Rename it to reflect its real >>> purpose. >>> >>> Cc: Aneesh Kumar K.V >>> Cc: Yang Shi >>> Signed-off-by: Peter Xu >>> --- >>> include/linux/huge_mm.h | 2 +- >>> mm/huge_memory.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>> index 70bd867eba94..9a3a3af2dd80 100644 >>> --- a/include/linux/huge_mm.h >>> +++ b/include/linux/huge_mm.h >>> @@ -79,7 +79,7 @@ static inline vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, >>> } >>> enum transparent_hugepage_flag { >>> - TRANSPARENT_HUGEPAGE_NEVER_DAX, >>> + TRANSPARENT_HUGEPAGE_UNSUPPORTED, >>> TRANSPARENT_HUGEPAGE_FLAG, >>> TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, >>> TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index b0ab247939e0..913e7dc32869 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -88,7 +88,7 @@ bool hugepage_vma_check(struct vm_area_struct *vma, unsigned long vm_flags, >>> /* >>> * If the hardware/firmware marked hugepage support disabled. >>> */ >>> - if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER_DAX)) >>> + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_UNSUPPORTED)) >>> return false; >>> /* khugepaged doesn't collapse DAX vma, but page fault is fine. */ >>> @@ -464,7 +464,7 @@ static int __init hugepage_init(void) >>> * Hardware doesn't support hugepages, hence disable >>> * DAX PMD support. >> >> >> We should also fixup that comment then, no? > > Yes, I'd drop the comment since the code explains itself. One fixup > attached. Thanks. LGTM -- Thanks, David / dhildenb