From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F411BC35274 for ; Thu, 21 Dec 2023 12:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 518438D000C; Thu, 21 Dec 2023 07:00:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C7308D0001; Thu, 21 Dec 2023 07:00:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B6068D000C; Thu, 21 Dec 2023 07:00:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C78C8D0001 for ; Thu, 21 Dec 2023 07:00:11 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F26161606D7 for ; Thu, 21 Dec 2023 12:00:10 +0000 (UTC) X-FDA: 81590682180.09.953370D Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf12.hostedemail.com (Postfix) with ESMTP id E54B940012 for ; Thu, 21 Dec 2023 12:00:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703160008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZXZr/aQDcTXunW//cVBUw8BPaZNEIyciQ+S6UZ+BO0=; b=OQv85pd6fX7xAd08AQpO4eGRHE6brU5on/NK1pkyZSyDnklw9z2He34dB7zSrN/4HljLpx nGGS/oeDR6uJJhZF0L8KEFkk8z+nc3FffIwPUYVVupp+GzCyvfSbOXPQs3XbI5MVh7sHbe u+6ceZh/nWV5XBp9G7fCGyfAVXpbWfM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703160008; a=rsa-sha256; cv=none; b=iFuyfXsGdXKlJJJR3Yn8iWCPcdqEysEjZbmRHtx+tDaHYsGRNTSr+X54wSf/j2ljTqadHR KT+C3WPBe1Bi2Bax266h/p0cX+1TWkYSMect54gvo40nvYjavXW1DlB5jFAiET1mqAN7Y2 Q2+7pP2m5eRQWp+KZ7g0os2u9HgKT2Y= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Swprp3hvMz4f3l20 for ; Thu, 21 Dec 2023 19:59:54 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id BCF291A0517 for ; Thu, 21 Dec 2023 19:59:59 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP1 (Coremail) with SMTP id cCh0CgB3xw26KIRl_5H6EA--.61666S2; Thu, 21 Dec 2023 19:59:58 +0800 (CST) Subject: Re: [syzbot] [mm?] BUG: unable to handle kernel paging request in copy_from_kernel_nofault To: Thomas Gleixner , bpf Cc: syzbot , akpm@linux-foundation.org, bp@alien8.de, bp@suse.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mingo@redhat.com, netdev@vger.kernel.org, peterz@infradead.org, syzkaller-bugs@googlegroups.com, x86@kernel.org, Jann Horn , Alexei Starovoitov , Daniel Borkmann , John Fastabend References: <000000000000c84343060a850bd0@google.com> <87jzqb1133.ffs@tglx> <87r0jwquhv.ffs@tglx> From: Hou Tao Message-ID: Date: Thu, 21 Dec 2023 19:59:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <87r0jwquhv.ffs@tglx> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID:cCh0CgB3xw26KIRl_5H6EA--.61666S2 X-Coremail-Antispam: 1UD129KBjvdXoWruF1kGryUCFWDXr13ZFW3Awb_yoWkKFcEq3 42934kurZ7uF42yr1xtr4a9r1rtw4kArWFq398ArWavFnIva9xG395trZ3Ww4UGwnagFZ3 JFW5Z3srKrnI9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIxYFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kIc2xKxwCYjI0SjxkI62AI 1cAE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWr XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAF wI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa 7IU13rcDUUUUU== X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-Rspamd-Queue-Id: E54B940012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1wg4ubxzaynoh58irpmh9nqtz51ohbp9 X-HE-Tag: 1703160006-595040 X-HE-Meta: U2FsdGVkX19qlEv+YRVKwVnDWSh/m092MqT3lVTq40PNtHcxbxUsOOK8bxVdukGpKy2vEhoEUQbPTWdenqueTHz99njCc+qwagAAKBUj2Xo72eDPzio5fc46QYDgvoLXMbbzw4txuawuOmR1DC4No4IOoFkBUluPAzjjvpSzF33aJyggvIjajdjI4JwaWUmp/bdTgqp2SwNmq2lDZJAGTNz2rEA0wEXZi86qRJ3R47TJ+ySZOnjjVQGpkOtao+rxBnOzFLQTq68jDnQtnm9fpuguVnAyfGJ1DQ8WGjLieSc8aQbLl8l84PFb1R4V/IAuUweV9BnJ5dQe2EcohNvQYeHG2K51si0Q+W1yIDL/Gh1+eQinZ4Iq5LCPE0PA1iHRh9NfoeRT42GPFG7E0OtIuMaTxf9WQqwUkUN0MIA/92tWWnjTld8OVvMEecfMOaRMWmFGInsCMDsfQ2e1d5bGwrK8YRYnMzu7kQLf4Quj+ajMzplyrhID+bKX7sKTvjpYuul6yp56tnkDlrnHKp86rroqWxhi/BLCqaK7IKDaWlEcGzq7gSaF9IzznvevVt9nw3TD00KADsHlCTRzNXxzul3xuTyTlkmHUEUIhqUygfQAjbCxHnrrO2tmSJJrpB5bJjaQNQOEnUjDvmTDKc2L1hIzYm5i5VBUbP/xC7IaFayftEK9m22biJzBY0duTruSmZdIWX0q9PB7lZMOUn4AMwvHVavJ8u2RRHQThsMQMkwXCAn96swlexCx+Q4JoEjGnqZgErcV5drqDwRgfcy2O5Hk8YC5zFQVO/nxx2A333ZNI7SCtRkO+g7NoHD1znk0QBcm6f527/CFigzlx+/KX3YkQO6+x6r8MnS5x7dOw0KMVuKdFkH79gc2tLeFO+x1hQqY0yhAMsb5zd/F2ZWfyI6ev5bynX75ovGFzb6jT3z+XUQ4xV0kXj2f4D4Vs44qZkvcykaNvRaA1NN2C2f ZLP3A+X5 1SWzvEQkQ1x1biA0IZrTrmy0qmiLanU2lG3xu3o0RHJ9IF0KxXYP2AsJUi1Swa67Et9kmebzxeW52KHELG0MJhh0er712chMTCbXJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Thomas, On 12/9/2023 5:01 AM, Thomas Gleixner wrote: > diff --git a/arch/x86/mm/maccess.c b/arch/x86/mm/maccess.c > index 6993f026adec..8e846833aa37 100644 > --- a/arch/x86/mm/maccess.c > +++ b/arch/x86/mm/maccess.c > @@ -3,6 +3,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_X86_64 > bool copy_from_kernel_nofault_allowed(const void *unsafe_src, size_t size) > { > @@ -15,6 +17,9 @@ bool copy_from_kernel_nofault_allowed(const void *unsafe_src, size_t size) > if (vaddr < TASK_SIZE_MAX + PAGE_SIZE) > return false; > > + if ((vaddr & PAGE_MASK) == VSYSCALL_ADDR) > + return false; > + > /* > * Allow everything during early boot before 'x86_virt_bits' > * is initialized. Needed for instruction decoding in early Tested-by: Hou Tao Could you please post a formal patch for the fix ? The patch fixes the oops when using bpf_probe_read_kernel() or similar bpf helpers [1] to read from vsyscall address and you can take my tested-by tag if it is necessary. [1]: https://lore.kernel.org/bpf/CABOYnLynjBoFZOf3Z4BhaZkc5hx_kHfsjiW+UWLoB=w33LvScw@mail.gmail.com/