From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C284C001CC for ; Thu, 11 Apr 2024 16:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40676B00B0; Thu, 11 Apr 2024 12:45:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC93B6B00B5; Thu, 11 Apr 2024 12:45:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C69F16B00B8; Thu, 11 Apr 2024 12:45:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4C166B00B0 for ; Thu, 11 Apr 2024 12:45:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 250A2120B73 for ; Thu, 11 Apr 2024 16:45:47 +0000 (UTC) X-FDA: 81997827534.16.240651C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 7780F140006 for ; Thu, 11 Apr 2024 16:45:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712853945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YR33RvNC4Kh8HNmPxc3EjNBfPG8fkQI4xRuM5v17eAo=; b=Bzh40m3hR9rOTwLAf5TvTmHVgbXntzJUkZMXYETJL1Hm74N+Lxb8ODKq7ljaZ3DKuws99m 3+plRYQAmz6cxm+pjVqOoa7V/rRwpPLlQ5sM1WJ7Wvbs8xZ6jBp3KsjytqfpdaOOfSrvbQ 1GF8qAXeACI/RydOkni1AJVWPZlHZXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712853945; a=rsa-sha256; cv=none; b=uqyncZCN7kCvrxTPVPGa8udg8xw3IczS9UbcvOsdXZtAxyWywe87FzHiaQicWdLiIfUwCq fOHsgHAWFEC9H2rk5Ohb9GguV9Xaai0aqEu+0ODpiC3SoPYbrSGu5U54mRSuLB/O9UPNRB mjSVp3qDDcTJnVd+MxSabUKOe2BWs/I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 341A6113E; Thu, 11 Apr 2024 09:46:14 -0700 (PDT) Received: from [10.1.38.151] (XHFQ2J9959.cambridge.arm.com [10.1.38.151]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E9503F6C4; Thu, 11 Apr 2024 09:45:42 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 17:45:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] mm: add per-order mTHP alloc and swpout counters Content-Language: en-GB To: Barry Song <21cnbao@gmail.com>, Andrew Morton , david@redhat.com Cc: linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, linux-kernel@vger.kernel.org References: <20240405102704.77559-1-21cnbao@gmail.com> <20240405131140.8881aae1af0d877dc70c8ea9@linux-foundation.org> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7780F140006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ijstduf38ei6qfuxmo1k193m4zxmtzb6 X-HE-Tag: 1712853945-205248 X-HE-Meta: U2FsdGVkX1+3zm2mMAT5cMM82g8Gz2+kOs/+iyM3J/ss7ZqcTlXsJ9m6nlBB9aMEPy5pGkmBRA0gLI4bWbkDHkXdl+xAlkzxSD074dTxZ2gIGRiOcB5Cjzv0Di9fYHER8uqFacud91IAUnlpKnvZjEl7KuwTWnaa7bwR2dzyBHLd7bAIf4ruH4B4tszRk/Hdb64pE1rDjcBEnREaB7R5jSoc42MAmXM+9fTzgV8oJXB+LcO6zqavq8jvzFefl3H9ioQ7ceU/3T/uxhcZlAo9vW5n16i+ZtGxQWDwqUdloa7l/rdXZkYFxixpgwcHuShoZ1zhuoPcUNVGPvbJBpAteQgM4rwS/0P9Tab/Aiv2Dd6lth8TJ3BlsJZQRAFf2H1SvSFmFAIrNm5c92ZYCNV+y+KcfFRS6qDp54CF6A8zbqBroHz9k1z/EE3xpxVRmdurQcjnCPK1IPFLgunSAPDDY72YAxB85gKLJDFjhy9WqJxwOFPSyC35xh5aP8S0kWOpoTvhUuLO1nn5wNwKXrkd6mDT12gELcTWRbpcwlaAG/2OVZzv1hBakcd/yai2Xsu0wIGohBawgGIZGS/xW2ypcOEB3Cn0YbMpPjhwiZB1sPDgT/wt4kDR2/kBg/gfpsvbIEBv0DSaC2DIWRHBADSDyNehmIQZm+CgUiWurGsZ2OSpmRSV31o3V4k7VDxIucyULW+QB41iv6QfD+i2q7qefhUQwSpOMUlYCs/r+V4RwStea+aOyxG1uq4KP+fw/B8I7o8Oj7uReVXYBMgY6xE7+Vy46T9KXqLX7428wueHS8JkRKLoGYbS8Y1PZOU9R1XgN/+J+UzU+tJ3OpjK1s3KUd5nVUFsc8DvpyNpcXoZD77scRMg+C4SAx7Y0dSZo7kdkrr6wxbwWKjDywNExjZht23tqSMMhJp0e4Ot/8axfQ7fMWTUx1Xj+Ve1QOlSslek7Cz5QO3dQsxiP0JTd8R MPZXwaUx erW+TUMHkEOPCTC3g+2ksRB7KY6ik2Q0+Rf8ldabrWfM/2VmYKwiQ/CPZ9VD9EJWAx6FMCaMHScSEpfgjtZ/ExxfUo/uC15vIBYOClvKEZSDhNoRFIFyNnJnW5Ay7r0CHhoU9hmpUXU9hUgbJbSWkpqL56Lf243E1Gf4tN6Kl9rPH5H+u2cBkRuVTVo+F5yzxf2pjZU7mHP6magK+qrzQ169IZVFCDLwDenz5hw4ahfR59/lta+iySzuoOYx+Pzd32Dyh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/04/2024 23:04, Barry Song wrote: > On Sat, Apr 6, 2024 at 9:11 AM Andrew Morton wrote: >> >> On Fri, 5 Apr 2024 23:27:02 +1300 Barry Song <21cnbao@gmail.com> wrote: >> >>> The patchset introduces a framework to facilitate mTHP counters, starting >>> with the allocation and swap-out counters. Currently, only four new nodes >>> are appended to the stats directory for each mTHP size. >>> >>> /sys/kernel/mm/transparent_hugepage/hugepages-/stats >>> anon_alloc >>> anon_alloc_fallback >>> anon_swpout >>> anon_swpout_fallback >> >> Please let's get these documented? > > Sure, I will do it. > > Furthermore, after careful consideration, I suggest renaming anon_alloc to > anon_fault_alloc and anon_alloc_fallback to anon_fault_fallback. This > renaming is consistent with the naming convention observed in > thp_fault_alloc and thp_fault_fallback in vmstat. Additionally, this > modification will facilitate the handling of large folio swap-ins. > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > anon_fault_alloc, > anon_fault_fallback, > anon_swpin_alloc, > anon_swpin_fallback, > > Otherwise, without this renaming, it would be difficult to > differentiate fault_alloc > from swpin_alloc. > > Hi David, Ryan, > I would also appreciate your input on the modification I am considering. Yes, this makes sense to me! > >> Documentation/admin-guide/mm/transhuge.rst seems to be the place, and >> under Documentation/ABI. > > Thanks > Barry