linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>, Peter Xu <peterx@redhat.com>,
	Aishwarya TCV <Aishwarya.TCV@arm.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] selftests/mm: Log run_vmtests.sh results in TAP format
Date: Fri, 15 Dec 2023 13:54:06 +0000	[thread overview]
Message-ID: <e2296501-e9c9-4bc6-88ba-1e43ea083d4a@sirena.org.uk> (raw)
In-Reply-To: <20231214162434.3580009-1-ryan.roberts@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

On Thu, Dec 14, 2023 at 04:24:34PM +0000, Ryan Roberts wrote:
> When running tests on a CI system (e.g. LAVA) it is useful to output
> test results in TAP format so that the CI can parse the fine-grained
> results to show regressions. Many of the mm selftest binaries already
> output using the TAP format. And the kselftests runner
> (run_kselftest.sh) also uses the format. CI systems such as LAVA can
> already handle nested TAP reports. However, with the mm selftests we
> have 3 levels of nesting (run_kselftest.sh -> run_vmtests.sh ->
> individual test binaries) and the middle level did not previously
> support TAP, which breaks the parser.

Reviewed-by: Mark Brown <broonie@kernel.org>

> Let's fix that by teaching run_vmtests.sh to output using the TAP
> format. Ideally this would be opt-in via a command line argument to
> avoid the possibility of breaking anyone's existing scripts that might
> scrape the output. However, it is not possible to pass arguments to
> tests invoked via run_kselftest.sh. So I've implemented an opt-out
> option (-n), which will revert to the existing output format.

What I did for ftrace which had a similar situation was make a wrapper
script which invokes the test runner, make the test runner a
TEST_PROGS_EXTENDED so it's not run by the kselftest infrastructure
automatically and make the wrapper a normal TEST_PROGS.  Neither option
is especially lovely.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-12-15 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 16:24 Ryan Roberts
2023-12-15 13:54 ` Mark Brown [this message]
2023-12-15 13:58   ` Ryan Roberts
2023-12-15 14:08     ` Mark Brown
2023-12-15 14:28       ` Ryan Roberts
2023-12-15 14:34         ` Mark Brown
2023-12-16  2:25         ` John Hubbard
2023-12-16  2:40           ` John Hubbard
2023-12-18 11:32             ` Ryan Roberts
2023-12-19  0:51               ` John Hubbard
2023-12-19  0:55                 ` John Hubbard
2023-12-19  8:33                   ` Ryan Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2296501-e9c9-4bc6-88ba-1e43ea083d4a@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Aishwarya.TCV@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox