From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF66C25B76 for ; Wed, 5 Jun 2024 20:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F8F66B00A1; Wed, 5 Jun 2024 16:48:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A77D6B00A2; Wed, 5 Jun 2024 16:48:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796966B00A3; Wed, 5 Jun 2024 16:48:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CA7C6B00A1 for ; Wed, 5 Jun 2024 16:48:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E1ABCA1169 for ; Wed, 5 Jun 2024 20:48:52 +0000 (UTC) X-FDA: 82198024104.26.BF131A2 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id AE21040003 for ; Wed, 5 Jun 2024 20:48:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=djRW8dej; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of "SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717620531; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KKqACQwsw0UMD64ceEvLLbjPzghIohbVqbXl6kDY0sA=; b=q0ZklOzVkYLhNrgEG1rTl4DIpy5JvPU+PAJsFZccY3GHgnSF4erhajM6/9RwhTEpgu1t2f rIRYs6qtr6ct36gH+zxRCBUun7VDqC/JlkkCXYFfrsAjqVYiQAeagAI2N0uNosXZZkrzcP fXtZAGUJi6vBOySkcbppLaa+RScpPpc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717620531; a=rsa-sha256; cv=none; b=i1vNtSFvpmbX36xotPjT6t2S6JJ/zFss2gGQmHWpywbDoWxl34FJUJNLTHQU866A/0hSXh X9QTc6lWvYbwX2cEfjyvcFxmEn0gJ5CI1I2UyH3Ahlj6OSZAUz6buGEQG/Ju4IRZE9lUCU DW3y7sEm5aPWolfFl/nJPNBwiPvsfXU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=djRW8dej; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of "SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=PUG/=NH=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8C276CE1905; Wed, 5 Jun 2024 20:48:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8FCCC2BD11; Wed, 5 Jun 2024 20:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717620526; bh=T5vr5sPvG0JFOXXVreMHeuAt0slBjtXGtC/wJP+h424=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=djRW8dejK447Uba2SB73pKSW2tX5d1fwBlUICNRuXwHtUGONv/nLgcLoamj1LO53F 1oR6q6IjjbXmLgxcxYaRzF5sXVqQnhzL8O17xmL1hkh9vVMt6XI/PJCEfln1H6xWKr GvUmsUPJS5YbaeUi86r5hrSAo57RjJqffa9+dp6kmKEkHHhM6b503YHxmuPFbwJ/U9 Ojo3EidLxLlwktsKpYgINSAj/FSrB4uZhq1TE7RtMpMzU4Ktnudm9uWfuU8PDcdMWy qCVIgBdd76wr6Iu7hfhoaPHrU+cZP5meL/Y6ie8/jvSGuF4FRqo8FRo3FGnK19gH9Q L0JEXLbmGQ35Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 7138CCE0A72; Wed, 5 Jun 2024 13:48:46 -0700 (PDT) Date: Wed, 5 Jun 2024 13:48:46 -0700 From: "Paul E. McKenney" To: Jan Beulich Cc: Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Mike Rapoport , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: Reply-To: paulmck@kernel.org References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> X-Stat-Signature: 1stp9c9tm8j7b9f56u719h6iu4hnbqup X-Rspamd-Queue-Id: AE21040003 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717620530-474851 X-HE-Meta: U2FsdGVkX19RD14llTGiBx2UhLnHg8UPqc8a9qY1SrB/ZEo6UrVxbiNmcsJcauBlbAAvR7h+9gGgY+jCq5k0Oz6CCcl8MBea0WNHAdmvJv/G8BR94vmopgd7+5PPE2nu9Lqa7RtkBY0Vrf58ef9pQtrfaZPDfnWgQSbuMxazjmeo1m/DSkziioe2o732Pqx1YKgMzOZs+ihpk6EggdH2/uShRUynSWkdcz8QhWoS3CQulIY0Aa0svgcheURojk3yUCAdPXBrUL7oBJKZOwR19965emxcJlLUtsCuOt21UhOBAadrWgSd65L/JBEjEVPZGvDAiutzclbTfUT2vc+d0pEFKAN+7M1jJGbP6Hwf23EpnB7F4x08refQKKOdtwkaaeAiCStRpe+kghVs/tqh9YVK13bNRn8wTTFU5wOJB30ZNqbcRrJ2n7m+wXyH5JAphdYOXf4XgY20iyYcYrv1zozBpz+xxivcFBfjCCJiPB4gZ7a31u56x+i+P5xIuqFHe2Wy4j4gjtZl2t5+XVylVfWyyF3gJmpr3xznMKHC1bMcTOLoVwP8T/uN9st91RV8KPzikxPqK8tOHTIVnepmjyqpxPNHxvypKDDjQlr1lCXatQB1ngn1IOi994Gy1YHbiqjt5gWl+UzdTGZjy/3IC5DbPWCKY/Dxuj+OQQGinXbDHO4t7no9s0K6cySpVHr151A1QZ/MLMEBXcNpqNF9C+cp7JR4OZIrElBSw7YAR6Dd5RAzKYk+Rasfn0k56IZTPqXMkuUy1LLPwbKJsAq4+meh8w5aUd5sdaScuufjnlzZDuyujhWevYq3w3F67unawY4VfIPo763CFT3+UIF9n4YCjgghETFCTA0JRjJnRlldqn1g/PP58EVfrf/u3mprPgmpVDOOcAc24joHb1HXAfKDTJarhYg6EkhPFFVOeco+hncwBuMBnENlrKMIK+q2j63KwjtjpO59AxVIVVI ppZP9Mqz RMKlgCvkm0D/umkppzAVhan+/JlGNybVfvYiLQFMFAt1zvkBYUU0KhcjtaaisL1nxUtHge11l3h6vr5Nx/mU4EC5yiHekSHwjtDJ0LMELWQdPnkFJMqTZMKdtecLMFKF3hR+a13KxArxV/WfQbA6R8AhjuEemcC/XYZCXlEl28Vkr8yzmkPFEP2t9L8CrW9/oforoW3eIAA+fwReZQxdG43D808LvyrEStY33jbj7pg93NVm3usXbjwOlPNdI6thyJaqN7Bdh6CJKLOz6h19vGTmll1vrnNwswmvu0kBIZFN+Nw1YcLanXGHZhcnaKr6ByhKRseRYSfAwuEOzgHg9iDmfBEWZ3LOEUbbhc4+qsGy8FBvDjnp0e1WiQIFh4ZGAnr7Haejqf+ExzY3r3AGrX+foebcDbhR3soFkOubS8WV/QWw/BHWdEcjkfQjWvnZpfiUUGYuRh0KZLDdtDZ7rq86i4FxwrqOrCnqzSPYIBS9tpU8Hl5lNhA4VBgykcErndJTzbXQ3sNP8uSrCxVwBo4qnjocyBdn27BfO9eunyqlqvWf0V+wZDw1TLMHfgGfCTcVtfc/1ua1yPfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > On 05.06.2024 21:07, Paul E. McKenney wrote: > > On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > >> The following kernel warnings are noticed on x86 devices while booting > >> the Linux next-20240603 tag and looks like it is expected to warn users to > >> use NUMA_NO_NODE instead. > >> > >> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > >> > >> The following config is enabled > >> CONFIG_NUMA=y > > > > I am seeing this as well. Is the following commit premature? > > > > e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > > > > Maybe old ACPI tables and device trees need to catch up? > > > > Left to myself, I would simply remove the WARN_ON_ONCE() from the above > > commit, but I would guess that there is a better way. > > Well, the warning is issued precisely to make clear that call > sites need to change. A patch to do so for the two instances > on x86 that I'm aware of is already pending maintainer approval. Could you please point me at that patch so that I can stop repeatedly reproducing those two particular issues? Thanx, Paul