From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B06ECAAD3 for ; Thu, 1 Sep 2022 09:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674856B0072; Thu, 1 Sep 2022 05:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FD006B0073; Thu, 1 Sep 2022 05:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477D28D0001; Thu, 1 Sep 2022 05:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 32C916B0072 for ; Thu, 1 Sep 2022 05:03:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0515BC0EF8 for ; Thu, 1 Sep 2022 09:03:12 +0000 (UTC) X-FDA: 79862927466.05.7B4BD45 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 3ABCE80067 for ; Thu, 1 Sep 2022 09:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662022991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mrKHoCTy/cp62lo3FDhMr8bD3kYn4ot6+m7P8dmXw60=; b=GtPkh9c2Tlxkd+KT5TY5Emqr2cQiyk4MIWSTKKSMKH6/hUBxmpfnQAOEg5WnY2kZmO5q1a NG3VJ0j16nzflSqgsq+yTu14yWshrfRMA2x9IIYo+V7AM23xNbMAaIHP5BkxGTVq+vdY8j Hf/zGvOFyv50H8hTZ9i549/QkrwGS0I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-58-23rlwVsNOwOxgRQbJT0Oqw-1; Thu, 01 Sep 2022 05:03:10 -0400 X-MC-Unique: 23rlwVsNOwOxgRQbJT0Oqw-1 Received: by mail-wm1-f71.google.com with SMTP id h133-20020a1c218b000000b003a5fa79008bso969620wmh.5 for ; Thu, 01 Sep 2022 02:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=mrKHoCTy/cp62lo3FDhMr8bD3kYn4ot6+m7P8dmXw60=; b=YH5nnGTuscy7o4jGsR5aO9gcio1clGCYZ98gWY14Y5n4jD3Bg919WnCvVxyCWYnnxs b0ob0aDGaH4RFgRtvQCn6lq4/yRBuki4KME670B79Sdres5TrQgcqph5TuRE2JK6hIRl bco3t2XIhZHYn09XV5m4kS2ewfTC+llZY8ipNsE6qoAtQXgyBmN+JaBA9AzpOdB77X8S Caj/lxB0dRC0xxVeywOc3zqHoFcLucNZ5Bkz23jJHnRjHT0cRb3DHF+UkghyFdq9rX7x jBKEWejf19N/0pex368eURxNrOuiDqtAYPwJwTJiZ+EPJe9eQL094tK4yGpU9Keki46B o8ow== X-Gm-Message-State: ACgBeo3ICTHjcD1K05BU0OwQixbXqx9TKBGB0RpFSKHDSJHXjTj4ZV4w eXKm5qS2cOsd3krM59fXIUAFlFiltCZb0/MRHYpyWwWVF04H+5kW0Ox++Q3/mMBJVtJR0Iq7oL2 bSppAaQxan54= X-Received: by 2002:a05:6000:15c7:b0:226:f1f6:a061 with SMTP id y7-20020a05600015c700b00226f1f6a061mr2160745wry.395.1662022989715; Thu, 01 Sep 2022 02:03:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR6A195Tuml2HQ1a93DU2zk3JUgL5Enmdh6tJBboweFD9ejBDdn4Dq3In44+Nfh9iP7w/u9dxg== X-Received: by 2002:a05:6000:15c7:b0:226:f1f6:a061 with SMTP id y7-20020a05600015c700b00226f1f6a061mr2160702wry.395.1662022989069; Thu, 01 Sep 2022 02:03:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id q3-20020adff943000000b0021efc75914esm14186300wrr.79.2022.09.01.02.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 02:03:08 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 11:03:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm: hugetlb: eliminate memory-less nodes handling To: Aneesh Kumar K V , Muchun Song , gregkh@linuxfoundation.org, rafael@kernel.org, mike.kravetz@oracle.com, akpm@linux-foundation.org, osalvador@suse.de, ying.huang@intel.com, rientjes@google.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220901083023.42319-1-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662022992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mrKHoCTy/cp62lo3FDhMr8bD3kYn4ot6+m7P8dmXw60=; b=6cTx58TNzrjV9eqcMsljwddQio+TUi8H27YypF79CP5leskK1etWnCEX+qi/uMo2hb91hM 9UWx+Y3D46N+NS953naoxB+li1/gGRu08JQ/NvzBI72qfPMl+9+kFyfVX9I9MgF20eBp1E GMEl4PV2cIuZow/dVpiVNIm8ZFtEKmY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GtPkh9c2; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662022992; a=rsa-sha256; cv=none; b=EGz+KsrEXf7nahkth4S9OZlr8tQ8Q/yvCtERofc6JfxnuIjfuI0lKgbrHAr4+Gv7m80Sxn LlOohNIvFYq8KeM/Oh3Tvfi+Jk1Mo0loESVD3CoBtBmcX/T9yldPjDp3iAydWWAdxyWzce SqY43YyZgxHhQyF4i7Giwom6mUqjqag= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GtPkh9c2; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: iq38ezzhfpotd8n98yb4pnzspix416xk X-Rspamd-Queue-Id: 3ABCE80067 X-Rspamd-Server: rspam05 X-HE-Tag: 1662022992-361681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.22 11:00, Aneesh Kumar K V wrote: > On 9/1/22 2:00 PM, Muchun Song wrote: >> The memory-notify-based approach aims to handle meory-less nodes, however, it just adds >> the complexity of code as pointed by David in thread [1]. The handling of memory-less >> nodes is introduced by commit 4faf8d950ec4 ("hugetlb: handle memory hot-plug events"). >> From its commit message, we cannot find any necessity of handling this case. So, we can >> simply register/unregister sysfs entries in register_node/unregister_node to simlify the >> code. > > Isn't that hotplug callback added because in hugetlb_register_all_nodes() we register > sysfs nodes only for N_MEMORY nodes? > Right, that needs adjustment as well. -- Thanks, David / dhildenb