From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765A5C4167B for ; Wed, 6 Dec 2023 12:11:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C05B06B006E; Wed, 6 Dec 2023 07:11:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB6B36B0071; Wed, 6 Dec 2023 07:11:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A567C6B0082; Wed, 6 Dec 2023 07:11:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97FD76B006E for ; Wed, 6 Dec 2023 07:11:09 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6AA97C01B4 for ; Wed, 6 Dec 2023 12:11:09 +0000 (UTC) X-FDA: 81536277858.26.217C42E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 2DCB540018 for ; Wed, 6 Dec 2023 12:11:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VeThNjMF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701864666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; b=3t8WQvr9xwit9WDzu5E/3EtLouVYhSLbIR3zlB/jOWX5w8l5ZXmuXe0KZ27hsKuA8PC8iv BaRgxSpFE+5tlNheidMoU6uz//jM53uXBNhes1/3XgQFvDKuvcMogR8Kyn94Nyw3gG+rCT 68ioG36SlxNW9sJH3l33JguWP9d0jBY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VeThNjMF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701864666; a=rsa-sha256; cv=none; b=ZKh9d9y7L3KosOSxOko6anPHCoqqrpEmn8LUlzpQWkUaA0Y+l6ooRY5CHYnG+fxr4M5T1J qKb27pcpoS0mAT53pDLaUL+juWMJ6zh+u62HKjH19CdvNd5FaHyGbaHGrxneW93g9AKI1X +uza9m0SJM6WjtKb8HOwz3mPuq7Ly5w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701864665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; b=VeThNjMFX/J8+p2fuXu3oFUc9oJIyopI99XRoIamaCihnL5JKP8MHcfqyHl6HoGDQ44AKf 9SQ+ivlWCIbxOcQhBUbAgWjblpaEbJjrKin1jEcKVPijKHs3OD9tH5YwpQ6etrIjB3OTsq vX4pYcK5XhL78vbf7vFQvBUmKK0EUfs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-s5ldszlTO-CLPrBuRCbx9g-1; Wed, 06 Dec 2023 07:11:04 -0500 X-MC-Unique: s5ldszlTO-CLPrBuRCbx9g-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-332e71b8841so653111f8f.0 for ; Wed, 06 Dec 2023 04:11:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701864663; x=1702469463; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; b=KKnVApXEBZEuETcs3BOxBgkNlyqxHtKJwChps5vyOhpNvCJhSdVw8eLV4yLN7Wg/cr rKufBsmF6DpJogHOPC44LMvUM7te3XjyqL+3OBHdeaA/vFW+TG7In9W8kWS/KR/MRNpX Rwi0WCqzZQP6XjEjmJ80KkXyqsfP+g/lVRT44W63NJw83c+sn+FcVqkgjLBDKFb5Dqdf Ab4sIwluxNif3Azt6AVfyn5xZzj94EgFtasx+JDvZ5tm0c5tNaiATFpYecU2XBddem97 MES3KRdBjNQQcuNx5pGDxbwVyKDhR7U0NUZ4cOzgphVhL24tSmKz6X/RQuwxsDMP0qrJ r6UA== X-Gm-Message-State: AOJu0YywrD4QxIGXHI0YyWTXGvvCfgrHjOKjmUsnqe4HYYo89QVwzecn LY42YrG1gUdnzaoNfsGNGTz8KuZB7uzS3xxH0rz49Rn08ICF9bk3T6Y4SFzsck6oGF5DKr5mkws Rh7Lp7RsfQBE= X-Received: by 2002:adf:ec0c:0:b0:333:2fd2:5d30 with SMTP id x12-20020adfec0c000000b003332fd25d30mr517884wrn.98.1701864662915; Wed, 06 Dec 2023 04:11:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOfpSI7H+ja+6FN+41pGyQ/bpa6+CW58ZKS+Dz1kKlzOgT1YnbkRyMmouF+tJUS5fQ96eDmw== X-Received: by 2002:adf:ec0c:0:b0:333:2fd2:5d30 with SMTP id x12-20020adfec0c000000b003332fd25d30mr517878wrn.98.1701864662545; Wed, 06 Dec 2023 04:11:02 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id x16-20020adfec10000000b003333beb564asm11180742wrn.5.2023.12.06.04.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 04:11:01 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 13:11:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 02/39] mm/rmap: introduce and use hugetlb_remove_rmap() To: Yin Fengwei , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2DCB540018 X-Stat-Signature: ebfx6i4t8qwrqk4ge1bmsksjthyqwryr X-HE-Tag: 1701864665-490562 X-HE-Meta: U2FsdGVkX1/yq3lg9dZYjce6J0VIUxqYw6hZ5IK54QsZmXyTE1L77YXh6SNjYkqa+JbW/A1l73MgS6OZ3NElVeKRj6m6zHrbuu6zacB2TABAlaI0bCiEGP6EepvVdCdcPXG+qXoLBEgMiC0t5x0O016EUSaBOGLTaEWVVMdNxBkPnY5juStYqwhSnuxlrk3NN47AEKlSEDSsWq59IeBbBM3OFOIT7DaodwJaThsFbNcbvazywEdG4tOaikT8FEbbTBBf5NRApSp7JLMwbPTd5Qr2vtyioz58VETslnjiLEA50WqUdjvBwF0h3LHzM6OQoM9DR5unVSDFfvvazHfbM42MUjOz3DcSW5ktNbOLb6WJKWIsQLdQudcogCSHo/fa5SvZ/T3C0VBuqX9g4FpnVOeydus2zgLX7Z8ks+lHzLt9/8B95k3xjADf3Cp/2jarj3RNiINZa+5jzgxsNpmMZ+VvyFtmV+3R27MnTJUDuH47kWTGb9fdMnq4fOMti7a/5B6+sVVwhDOLYOKcZVumIjQQse+iwxjbkPK9cU9o3Nvo/JJfpH01ZJDp230YWGuM9bnK0s6VcKnjCAQqf7ORVrNMNX4pSfVJ5jLWq6F51XEe48OIg6UbfSqZ/BN/4zC2H5wa+ktIWuLoeG3G7LJ53hHZk5g3NlGiqA5uUaN2HVnN+s9/Zl30UUI4F/og2xr8D/j/PktIW59ts1Y64kXnlvq0nTB2I5lrvvkzIn9bKctUiuYn5sJF2jLWIjpH1hnaoPNS0fITL9z4cLxZA3ut+fl6AXKFxT+JTuq0p6eNAEli1QpTh98txS+sj+g7FYJ+O6d1IFAaVQIY0Dp3G3MVJwW3v49a1wuLvi9QxV53cgTl0N9EuHmsZ9/MfXkpBUALT5rO/SQTBiPY/UszYnpRVrM+CR5Zuy3dO/UoC5zzoxBFUCp0bLh5z+MtnsadKcTyr6fJByTH6CLWBifwKjb HnbOEw5+ U+mhyojS6YdTaYABSsn1GIhNeUHAOa3s4tJW+XziVvGBrqPGyyAI2UujSuuxkBZhhYtm5sMFmTILzd53YyorifOEdbRzdgLeyQTkt/JxEitECIiQrRnFCnIFvT6SXAnwOEKqtJuJtpDRjIphb1WYxD4JcEXASCXiD6GRaRmWUvy1oLjZF3TJPqh2MQfVD97Bb/VOFWrFaLzSMWMp5tHmsY+tQ7ytOeMahOJ1uX5bdqPeick4AQXZTk+iccu+TTNproE3zGEDXF7kujpZO+63R3vD7zCvdHL683Hrll44+HOZZrw8Pra71niwW3rB7Yy6RK2CinzlW4E2Tw0Uc8IDL6lQL7TnkE6gRhjf8x2bgssAaqGx8yyq350oyzTxG2FER5z8KA+eCs5HY6Go6RpYmOXZ99qzSgbx8sIAY0yI64RpQ4i8JE2q1vJacdLwCLJ6eagnCOn3Nu2hdyHilp3NXEBngC26b2K5uEkqqKVJVZPvudqlRe8fFDya0m3BnpSAXOWyYfJoDh48sneU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.12.23 02:22, Yin Fengwei wrote: > > > On 12/4/23 22:21, David Hildenbrand wrote: >> hugetlb rmap handling differs quite a lot from "ordinary" rmap code. >> For example, hugetlb currently only supports entire mappings, and treats >> any mapping as mapped using a single "logical PTE". Let's move it out >> of the way so we can overhaul our "ordinary" rmap. >> implementation/interface. >> >> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb >> code from page_remove_rmap(). This effectively removes one check on the >> small-folio path as well. >> >> Note: all possible candidates that need care are page_remove_rmap() that >> pass compound=true. >> >> Signed-off-by: David Hildenbrand > > I suspect you wanted to place your RB tag here? :) -- Cheers, David / dhildenb