From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1631CD6E67 for ; Wed, 11 Oct 2023 13:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203058E0007; Wed, 11 Oct 2023 09:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B1888D0109; Wed, 11 Oct 2023 09:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0795B8E0007; Wed, 11 Oct 2023 09:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EAEA98D0109 for ; Wed, 11 Oct 2023 09:31:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AEDBB1201DB for ; Wed, 11 Oct 2023 13:31:55 +0000 (UTC) X-FDA: 81333268590.21.C8C1D7B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id 588F12002F for ; Wed, 11 Oct 2023 13:31:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aY11rfjx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PAmlM41f; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697031113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HljStu/Mi1i6SudIv7bnTBAyqUy/d41TujLNpYF5gMY=; b=SjJcNiRIUYTiWpq5FOlHAMheiisWnfYWTYi2VOBEdljpJbqeyqxmsUnTX9uE6T/cRXAL6S aWie8tqja/igqXIPBqUHsnYqYfbi5P9iL6vEOpjkPDrgBsHjYAz6AQc/0JgQt4/lWYL0mm i1i2NSmhoBmG2ftDnvluo1xa6XHd+mk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697031113; a=rsa-sha256; cv=none; b=DlliKQkxCg/KXqC5TR/8FvLuz2/KpDJUWHa1+w+8w0dPoN0NHedeSZp236sOV0B+8G6UTD S1xg4Xkgz5qUmJ9uvdjjT9Kw6bY0EQf9l0KRxGhncddICN1bKn9xSGPg888XkE66z+4dzH aS0bFZEfWnLrwKga1P0yOJ6h6YczLEc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aY11rfjx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PAmlM41f; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2817E1FEAE; Wed, 11 Oct 2023 13:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1697031111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HljStu/Mi1i6SudIv7bnTBAyqUy/d41TujLNpYF5gMY=; b=aY11rfjxTE1FoeWh6i9Jql5jaIjxUPytLcWtK2OULeNH9XeIosVjcl49lSJGDZyiiQ7cHy M20he2RtrKjbkcjoo+3rja5ilfQxv4CHAHbRvKwWmX636VF65mmtSHPyVmRaeg2YNoqcWr Mj3A4BflLN/Rh6kui5F4I8rNOIujNBs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1697031111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HljStu/Mi1i6SudIv7bnTBAyqUy/d41TujLNpYF5gMY=; b=PAmlM41fP4rh/VdU5dAsjrnxjAWX6nOLZNJeAgeEnJBWqG69vJKdY5DTG2uB0LffBORKle 8PfVse5bOIiYZHAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A6E1134F5; Wed, 11 Oct 2023 13:31:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oB+/AcejJmVZTgAAMHmgww (envelope-from ); Wed, 11 Oct 2023 13:31:51 +0000 Message-ID: Date: Wed, 11 Oct 2023 15:31:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RESEND PATCH] mm: slab: Do not create kmalloc caches smaller than arch_slab_minalign() Content-Language: en-US To: Catalin Marinas Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Mark Rutland , Peter Collingbourne , Petr Tesarik References: <20231006163934.3273940-1-catalin.marinas@arm.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 588F12002F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8idbaxtkz88961apu5xc886bkxkpfwja X-HE-Tag: 1697031113-638199 X-HE-Meta: U2FsdGVkX193oaGwsCFt52Km63osNhFBPZJD4CApHt8CF/lKKCbDPYlJAc6NschG+jXtGN6ar1CzV2mfgpGGvARyY9Wadb6qA5CX/1yOmlZ+zPmlRTQ6VaVCOUb1sCZliJ6BiDeyrzdR8npKXmwwDUN/+vH9z0vcvMR0sghMkCibd9NaXsSR7RwfCFeWkSjLLg0dMFr7HEKTuiQfRdc7zuYUm8iXkOKQ+o0weenWBMz6cA2TacsEKhpKed0VFpGtqXNGsk/kPEEM8IcAZEwZsF/h/kAuNXqCtvixKU15iOLIo2ddNa3dAJvZQz30smS6oaDVRGgFPsJeQSn6z8Z+wPiDZhHD86UVYbwEhpHsGqJfFJjCz5DL6hU4D4f1N7OPeBsTdhsieNdAyUPKBMcec6WQfCWGPNZGWB2X9IGZNRleWUOD7NWwLGf502lyt8HJ4ZpJvIpuEpMmrPA+Asb2NHCCQrSvpYzvF0BNQnAaqbvfowRIH9qErARyMEkh4K9x1uU1hF9ZiUwqCtwXWvKn48mUUIBfM5jP11KbZd4+sLHu2ncBCUDnM6AsEPMM7NYhPZlnu/Yn3kbzxtXdn1s0dtePsFBUuFF/40TszljwOkf2izDaI7OLFpbHwdIRN+bfK5s4WpCQd5V+CtePFoky4XdYFC1TxPKXF+X/o9kLPxDJhWoKFpZNe4sVTwpRK1xPQoHDTFIT2dQbk1KyZFzQ6zz4orxsJzueaL7TtTm66vEAtUymaAlfJLK82ExYlc/lo+NTXUYxYov/KJPqTlHlN4BS7XlkS3eL/eVlKZDOJ41N4rvifjd5HGbqa8QXZMSM0Dh+FXsawag5qemhUTJQHt6rZdScVAZq7alA7E7iiHLFf3VSWz4065l5G18liwDl1s7e0Fa1FfXskJ3o681L7ACfeLCJa4+WvT9JvjGsE+2VkvuntznQvcbEVbBpgHKY7sQV+DN1CCFwpCD3j+Z Q9jLhS6S EokOxQRU+Z0ciRHrkhbDE+oTyy45aYq/8ManEJswztmOmQG894DFzO0Yb126Iin1o8h40euHg9qO+YDlkMV+iV6pvFSTkcG0deRLq/XIVABQ73VffiArCpPwb18oDP37YxcLcVeYS16OWeX1Sj/iSjR0/C4O0y3qVq2FZnoCEdFNI4u7ZP/uQwfkN5y7UhN7pduJPCuqcRcIdavbgeD63/nbMupQMGg7hFAEiMvDJ4r28k334GthXP0D3Ow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/23 13:20, Catalin Marinas wrote: >> > mm/slab_common.c | 7 +++++-- >> > 1 file changed, 5 insertions(+), 2 deletions(-) >> > >> > diff --git a/mm/slab_common.c b/mm/slab_common.c >> > index cd71f9581e67..8b45922ed295 100644 >> > --- a/mm/slab_common.c >> > +++ b/mm/slab_common.c >> > @@ -895,10 +895,13 @@ void __init setup_kmalloc_cache_index_table(void) >> > >> > static unsigned int __kmalloc_minalign(void) >> > { >> > + unsigned int minalign = dma_get_cache_alignment(); >> > + >> > if (IS_ENABLED(CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC) && >> > is_swiotlb_allocated()) >> > - return ARCH_KMALLOC_MINALIGN; >> > - return dma_get_cache_alignment(); >> > + minalign = ARCH_KMALLOC_MINALIGN; >> > + >> > + return ALIGN(minalign, arch_slab_minalign()); >> >> Could it be max() instead of ALIGN()? It would be more obvious, at least to >> me :) > > Yeah, max() would do since they are all a power of two. Do you want me > to repost? No need, picked up and changed locally. Thanks!