From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8ABD68BD7 for ; Fri, 15 Nov 2024 21:31:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61CD16B0089; Fri, 15 Nov 2024 16:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55A126B00B6; Fri, 15 Nov 2024 16:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 340D36B00BD; Fri, 15 Nov 2024 16:31:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 115C16B0089 for ; Fri, 15 Nov 2024 16:31:16 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B083C1603F3 for ; Fri, 15 Nov 2024 21:31:15 +0000 (UTC) X-FDA: 82789624890.14.B6BEA1F Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 7F7B5C0008 for ; Fri, 15 Nov 2024 21:30:26 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=ECCtKwq6; spf=pass (imf28.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731706216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h0tYENsGaJFO8JDAStk6yXv0HXHF9Ts4iNM+HpTmVVA=; b=rgaAjqgFsDnZiipkbbv9Q2CCJzk9vPEu9jL2YYxLOKz5nYhGUu/VKmAY5x77gi2XnHA/J+ gr8O+r88XfxKRNZZB8H0doW/U/s60Roj/WPuGmi1nMiiR/hhZjsi6Scas2SX83vNErVbQq ETsMm7kSf2Dm+fxOqLWnaWZNIwiaApQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731706216; a=rsa-sha256; cv=none; b=I1KkuVTdPd2EBY4UJkXxTKduUNvLNPRPOFPsMRF6uLsHAbXUI7xcHt8BlQm2Q3XwuM2EiS hiQIl046OA7UOwXJIrAbADTxRGeZbCNNQnOZWNk44puvo5fi5vxWYRIj+1jHCDMyirqd+u jkEpNOxnYAg8QZ3MJ3QUC8t3zpJsjUc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=ECCtKwq6; spf=pass (imf28.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AFBRrRp005627; Fri, 15 Nov 2024 21:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h0tYENsGaJFO8JDAStk6yXv0HXHF9Ts4iNM+HpTmVVA=; b=ECCtKwq6Cy4NLuZL j2WUeZYNsdHGYwCwotl4/Q3JJFWUcWHz7gsSnNDB+iL7po1zl5LllV34Rd8BicSR 9ZhaW0psyAjm90yO+xdBZAQR2N+BNsxWv7rLBNXjlQiIPWBa1yvitZRPCxTpPbfw Cg+cd7DCPZpNjEahimwlyHuvXlt8vqPlFUL5VktjnMqhWF5hDijj5bAtLxhAD0oc D1i3vFAs+GUMNPK5b3Rv4wJqmmGh4qZDucIdWFwnin1FB9/KAmxpYybkULOapKD8 Gey6OqqdHevsuhCW6YMpiT4CXpP2hs6x9/0dOyqFe/2DN0Iw3Eca3M+RZSonp9bg YT7Xyw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42wex8wcg1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2024 21:30:43 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AFLUgSW012417 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2024 21:30:42 GMT Received: from [10.111.176.23] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 15 Nov 2024 13:30:38 -0800 Message-ID: Date: Fri, 15 Nov 2024 13:30:34 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 22/22] jiffies: Define secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan CC: , , , , , , , , , , , , , , , , , , , , , , , , Anna-Maria Behnsen , Michael Kelley , Thomas Gleixner , Luiz Augusto von Dentz References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v1-22-19aadc34941b@linux.microsoft.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20241115-converge-secs-to-jiffies-v1-22-19aadc34941b@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: h43h8EgANEiwtjVrnKtKVRWKc8bYM2XJ X-Proofpoint-ORIG-GUID: h43h8EgANEiwtjVrnKtKVRWKc8bYM2XJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=893 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411150180 X-Stat-Signature: 7hra5u69pq7eei4fd4piic9r38c6azhz X-Rspam-User: X-Rspamd-Queue-Id: 7F7B5C0008 X-Rspamd-Server: rspam02 X-HE-Tag: 1731706226-560785 X-HE-Meta: U2FsdGVkX1928CmvELpgtvBTSPKX2QyypOgAZnWG5aK8IxMKQhbnCA1xCO900FmbwAUYET3w8aeSAeSvF84HWkVlOxUdgjdp9D4NhvFTYVWm8HdMJg0zsmdxG9pZUDmjq0idd3lFZPmAhRGR2AGzyES2ksLFCMrLI/ADcXkhjWuT4rOj2d/WPqow7OrLalpuwv9EkOPSs10f91Ns1MEtaOBF4UsmHI+yNTBv5xWcg5x4puyIxJD2xG53oOPhpkeLGJftTWACvViii4EL5Y4k6XmVnVErSq0/IV4qP4uc8tztJ9RmY1mqJS1+DxS8CPPv3UbF8/Yriqou+czGXyTdNlmYdYpqunvwlJh92+vEem+daw8J9AyGi/YQtg0KcV+gKCg2LVQJZ7/wkbBvbwvnDDicrpi7fz/tHpgIVQHsEMIsTXaHwQj7yD77CzQo9Sj2KPfoal5eiXCl9CeCwuTLdRYq0ilaoaNeOHEVmXZUVMo0aJD/0Ri/MIOU5KXRtjtw0Bk4C47mT4+ypAzAU2dTe9pJY5wKsFH7zX68IlqExl9sKTV3NqJ5WmtDpGyrgKg2OLrgYD5JDD+b2J4kUP19MzUBpONlOtExYXyUErzrc0ILGaHE7sO6w6Ys5RGVz0OoxxTncVFxmubYoOZQlYJuMqmUyDZltq1WbKE9a7kXhrBeA3gT4zXZMVd/4e8ilZpGtIp2v7Cy2aRV6E2LZ0LzQ1S9FMUlOwBT1v0PmXsRa2ZknxvfvpmJcRNsyeTJb9KmjanJo/GXiRJu9UWdcjBoTD0QlFaKfiVy4SVFNlHmEvcUFEDoGEr+SxUfFPcOe2W3HjUJyXbTK8tS/r7LQDdmCGX/jGrliq9aE8QfGDGDJpzR8xk9WwLkaLoDRFYhogK72yigVLHrfbqV1Cm6nLBSnWDWHAC5APW5qh+IvJJtzBvdr3YLkDjXsKkcrOjrp4E9BoUbGH1hZfaK5B7iQv2 KMStffBE hHn+IfnshwE47ijApZtbTOLw9X+txlcgulYlxRWzxomHcUEb93CIL9/I586/CGOihaXVodAbGx25v4UJKRNGIMvCW2qN1OibHn7Nx5L021XPeFa42vsaiefD9lBzjX0aem4KR391HM6mIHWUnAFJI9nbvZLzkXQbAwwCEKyKev1HOz5atk1MC8gkoQFlwp5Uv76CJO4P/PzNmuSh/2LUE9EDFYiCwuvhWyhGI0mg92W1YOJoujtljY6Z4zFNJQlA3yv+jvB5ch1UQxLmkWQhffowzkSjmk/XyOnjBEvZNHRayYWzPTH3Vypaon+4A4jwYcLCyaQR3tP80hDjB+B8s6YT3N/tX9kq+PPbb/e8K1/0MJX91q8asWJVV0H16uZs8xRXVkCAbRniFA1PoFP5xRQBVJUWEYt2XwQWiY5u157+dwF09cJb9IuB9DY4z6t4AHJMJy3IjqAV3d5NGrmZeBKRLSNEAOU8QlcleCxIjlPcoOsyCCtauaOTjgzZR5v0ny+4SeH+BXPWyoIAZVs69HAvXdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 1:22 PM, Easwar Hariharan wrote: > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > > - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or > - have timeouts that are denominated in seconds (i.e. end in 000) > > It's implemented as a macro to allow usage in static initializers. > > This will also allow conversion of yet more sites that use (sec * HZ) > directly, and improve their readability. > > Suggested-by: Michael Kelley > Signed-off-by: Easwar Hariharan > Signed-off-by: Thomas Gleixner > Reviewed-by: Luiz Augusto von Dentz > Link: https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123facf88@linux.microsoft.com your signed-off-by should be last. and you have a patch ordering problem since this patch must come before all the patches that use secs_to_jiffies(), otherwise this series cannot be bisected