From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91363C433EF for ; Mon, 23 May 2022 20:24:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B277C6B0072; Mon, 23 May 2022 16:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD1CB6B0073; Mon, 23 May 2022 16:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9753D6B0074; Mon, 23 May 2022 16:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 788F06B0072 for ; Mon, 23 May 2022 16:24:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0B4221138 for ; Mon, 23 May 2022 20:05:34 +0000 (UTC) X-FDA: 79498087788.14.0CBC3BD Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf18.hostedemail.com (Postfix) with ESMTP id 71F121C00CA for ; Mon, 23 May 2022 20:05:18 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id ob14-20020a17090b390e00b001dff2a43f8cso347193pjb.1 for ; Mon, 23 May 2022 13:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=8nlcPdUIGG2cVtX3RxOVUlvfsw4FPYq0A3k29gmR/pU=; b=T3D6yNJ37K7Afl1Tb0B+iS0pzL7eDNFeRj1lcKNj7dh/uPFFOGQYZBflz3r330WMWs v8zJ4tt9zPGQDeMAWnS0eTaXNEQJ118SPRLPlFw5jOC3o9BxPhQyXmenCcMYwrqCk2A3 VePb6xiEgrKUqTVZbz0hLT80m/T/zqgLZ9FzW83kyK30815NArQk5bH2PQdH0vuymT/z 1wSIVhACFrJX5tdCStlbpXHi2ueWtTfw1i3i5YoxoSXC7agx/x5c+dft9Zn+qRwQOO1C uzoPfjwKuB8LB+fp9jViGOvgCmVs8+svbJ/Q/DTIRlP89GJl6ptr1wNCMhfSLqELJ+OL t80A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=8nlcPdUIGG2cVtX3RxOVUlvfsw4FPYq0A3k29gmR/pU=; b=DJSes2lgWlIvWX5OTBIRfglZykKYfJKppQmIdIM/nIU95qY5DKsDZh2sTtDIE3Ax4v d4ZCsfMXPomDpg9l7YMYQi/zAS7WlkUMWHAnOtHQWWPOMtCjbfAwtOo0P0sRXIRNje1q J240vkOl8lj+IvTbV/jzkOQVOszHtaCNjk0ZCb48zMggIRPu3rq2nHRNVFsz06ISYX+U sJvGQjugsdEnnhWUxh9NAnJqzCA24pLCuLcZFpdq7IukVaWGBjixXjN5NeY7gDlINOMv sFZPaEeEuc7xoBvrcaTn15c7ndLnDaY29g6mBpVamveZnVdLVQHi3a//tfnAMlRKZAZp u1iQ== X-Gm-Message-State: AOAM531BLjidRmEm1fnZPiZNr1V6Q7ryLeKxzy9H9cgORqnEOAZ1JONv A/rLYT+exT3MUIH6zWY9pX7hVg== X-Google-Smtp-Source: ABdhPJw5jFG8elE6hgZ8FZveZNV3BjkMoKBiRXm9zUm5oqGpeDoeKe76siVSOtsPMKKhmzBClRVq+A== X-Received: by 2002:a17:90a:cc6:b0:1d2:9a04:d29e with SMTP id 6-20020a17090a0cc600b001d29a04d29emr679619pjt.136.1653336333432; Mon, 23 May 2022 13:05:33 -0700 (PDT) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id ge10-20020a17090b0e0a00b001d75aabe050sm83853pjb.34.2022.05.23.13.05.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 13:05:32 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 13:05:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] cgroup: don't queue css_release_work if one already pending Content-Language: en-US From: Tadeusz Struk To: Tejun Heo Cc: =?UTF-8?Q?Michal_Koutn=c3=bd?= , Hillf Danton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+e42ae441c3b10acf9e9d@syzkaller.appspotmail.com References: <20220412192459.227740-1-tadeusz.struk@linaro.org> <20220414164409.GA5404@blackbody.suse.cz> <20220422100400.GA29552@blackbody.suse.cz> <20220519112319.2455-1-hdanton@sina.com> <25fb057a-077f-b601-dcb7-130071c733db@linaro.org> <489592f6-b783-7bdb-2cc8-0c8e35ebc674@linaro.org> <20220520164255.GB17335@blackbody.suse.cz> <6ac66e89-2063-c5e8-df15-f77b76befc05@linaro.org> <7bbf2792-355b-65a7-e239-879b3f928384@linaro.org> In-Reply-To: <7bbf2792-355b-65a7-e239-879b3f928384@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=T3D6yNJ3; spf=pass (imf18.hostedemail.com: domain of tadeusz.struk@linaro.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=tadeusz.struk@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspam-User: X-Stat-Signature: aiaiqkpjc9x3gxkn5x63kxw8kcfpkzfh X-Rspamd-Queue-Id: 71F121C00CA X-Rspamd-Server: rspam01 X-HE-Tag: 1653336318-951130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/23/22 12:08, Tadeusz Struk wrote: > On 5/23/22 12:02, Tejun Heo wrote: >> Can you try holding an extra ref in the killed path? > > Yes, I can try that. Should that be with or without the extra work_struct? With this patch: https://syzkaller.appspot.com/text?tag=Patch&x=1264b23df00000 The issue still triggers: https://syzkaller.appspot.com/text?tag=CrashReport&x=162b5781f00000 -- Thanks, Tadeusz