From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D2CC3600C for ; Thu, 3 Apr 2025 13:02:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46E7A280005; Thu, 3 Apr 2025 09:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41F26280001; Thu, 3 Apr 2025 09:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 296B4280005; Thu, 3 Apr 2025 09:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0CE56280001 for ; Thu, 3 Apr 2025 09:02:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 65D681C96BC for ; Thu, 3 Apr 2025 13:02:38 +0000 (UTC) X-FDA: 83292746796.09.C5A476F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 613FE1A0006 for ; Thu, 3 Apr 2025 13:02:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zxai4wVv; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743685355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5+G3U330UiqyqH1vzS6m3R9yJGPSeQp6rkkGrPQDUFo=; b=8JbSjbaeHLIu1zyhMWae3cFSKXHthiVad6fpeI3rmsnDw1XubsKU1bWp0v8PILWRVIPt4k ykd92btL9+P+6Pmh/1O2D6quv+8oFdUCen7UhRHZ7Hg7BOO0bgjxPUxwaTr1Za71FyxkFN wOQnl74OuxGxf5PQ/IkrWC7H3oJAf8M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zxai4wVv; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743685355; a=rsa-sha256; cv=none; b=XdqPbRjOw33ZhCiaDIfWM6chKC5Zcc4SHsAhBZTtF4IuxFqPcGSdXfqna2p19WmGc2aZ5u 43xJYcx56XoE/9rubZGCKiDLxahiLYjN41aEPMBjyskgpC8ZI7zgcYg8B1YToxi4VZKwau zf7OcpKT4ghyGa6pupFHJbfgXvus3Us= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743685354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5+G3U330UiqyqH1vzS6m3R9yJGPSeQp6rkkGrPQDUFo=; b=Zxai4wVv7q2LmTDAwVPaTVN+ubdMNaMqQP6jv27EF+Sghqzm5ywPcSuBTkTMk+ECeTZXya 3amAk0R19BSjDHptL24gmqAj64+4WesU/hh1PGzQfhKa+oI00WVCbZcoLl8ljBnggKMARK Cvg4xgXeirk9KVcX+MPmL73e0y9l3bU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-v5JxxGgSM-yZDUgjnGO4gw-1; Thu, 03 Apr 2025 09:02:29 -0400 X-MC-Unique: v5JxxGgSM-yZDUgjnGO4gw-1 X-Mimecast-MFC-AGG-ID: v5JxxGgSM-yZDUgjnGO4gw_1743685348 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cec217977so5420685e9.0 for ; Thu, 03 Apr 2025 06:02:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743685348; x=1744290148; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5+G3U330UiqyqH1vzS6m3R9yJGPSeQp6rkkGrPQDUFo=; b=M/PtM8uuQ/o2YwGOqGwo2MGIpMdy9e7yyBCWQD3UOhhRFn++WbXl0r+MYp49tfGKv1 PP9rDIhzJkJ7CJbvaNmhqLC4FGW9tQILftGkk4BxNwrGxhJ+gxITJeATEWCfPikxSpfZ 2ubNgNEdjT7wKcAB4nE+agmU6D0l6w/0h4ChdkGEO+aoulQIY8cPUb79VS6iHNglu+4E 2ZVtd+aG2F3T0DYMrPC+uibYFN2DFpLHLyGVCcDPkxx0KsidOyhQQSiaD7AUR0uuIl5b RtoGIIsVeJ38UhaB62V1n9bma59mUIq27vivmh/Iimvor1uFas+t3UFHQOKMMpkpeYpd qTNA== X-Forwarded-Encrypted: i=1; AJvYcCVDgC/qp2YYx1P4KxajZRtGVp7IMzhcPk0H+6z9qCsRc0vnlx472P13R4HG/DzE3ZZwJ+13vW9R4g==@kvack.org X-Gm-Message-State: AOJu0YxZ1QdHq24x4kwg6V8/taAoCGOVhMGOdZf+zwWxNNTdbms2FKO+ Dfonm2TUsB4Nke75eEF4Q087k06XjcwMNpR6CFTMRHwjR0mxySGHdp6J/7uMd+r7vbA2bT3IQ9U ZvJOPSUxd9MckZr3wlBpemxo+cs3KpVwgyTSX/yQmecIdbzju X-Gm-Gg: ASbGnctZ762xpXn37VWHjlTF65Ys9OhfUex9AV+d2ChWEAsKdDStEABsbMxBE/zp7mn Nw/mm0FrCddufT8MCS9qgsy6eVRGnW0XM0BgZNZZaI2TE6s5Z3DpsmrCosCJFmjjyUbRMS8z/Yv +I6QpYc4vhi2BEKUJr4cm6/Law2BlDwmokp02h5vMGlnh/fys3YeeJYlBFBu3fBRPdNXPKFdGRV l4n9z88WIQZ5GKvjjReOXqBC6qa7YN1j1+B15GCBDvV4l0oj770a7EHSrAY0D04dQWqHJ/tpGC6 TSmNJqfF8qWoz61j/vGKV63Zy0bBOARXlTpTfqX7sjx4pM/C1yOvJWmgDvFJtwYxGzbefavP+9+ 5QrKovpJlGic773kQwrDAI5MidPjQSRlaS+RFapjTsHQ= X-Received: by 2002:a05:600c:4f45:b0:43c:f61e:6ea8 with SMTP id 5b1f17b1804b1-43ec13435a8mr32296205e9.2.1743685348025; Thu, 03 Apr 2025 06:02:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1A/61/vXGs8P0oGOh10j6yMCEFpjqa+3WgzBT+p1Ra7BcZ/7uEXet6WWFnDhMijfPu71mpg== X-Received: by 2002:a05:600c:4f45:b0:43c:f61e:6ea8 with SMTP id 5b1f17b1804b1-43ec13435a8mr32295455e9.2.1743685347593; Thu, 03 Apr 2025 06:02:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:7b00:54a7:eb96:63bc:ccf4? (p200300cbc70a7b0054a7eb9663bcccf4.dip0.t-ipconnect.de. [2003:cb:c70a:7b00:54a7:eb96:63bc:ccf4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226dfesm1758109f8f.97.2025.04.03.06.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Apr 2025 06:02:26 -0700 (PDT) Message-ID: Date: Thu, 3 Apr 2025 15:02:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Implement numa node notifier To: Oscar Salvador , Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, mkoutny@suse.com, Dan Williams , Jonathan Cameron References: <20250401092716.537512-1-osalvador@suse.de> <78c976ba-1eaf-47b7-a310-b8a99a3882e2@suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ky4dzBdAgXF94J4MWCfvr8_zOdVip9abi968Fac8aVI_1743685348 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 613FE1A0006 X-Stat-Signature: ht3prfj4tyj18fzsmb7siscorj6ybxup X-HE-Tag: 1743685355-455637 X-HE-Meta: U2FsdGVkX1/U07VWhHHUpij+jr78g4fjAhoTwLZ9kTyzGbrQ56WFlHuJMR/JvScfuHAOFY1wYo87Bjj7WLbYocEDgFizMyIBLLHqFYys0RaYswzcrGvYVXSGOWmgf7BZylABDB8RpXfohiiYuXyIpZ+aNzIzYHKpXZfZty8qouoXbdDYeHt3BTgfVqGBTdKcvhY/dXWqSWr0T9Lx7Ao9xSIUMBg8wbQWW6YVkkqNk64tOXFMjWGS7BGe/66GrTTpo4Tno7ln9zM6vx1w6/d7VTL8ntvbdGpyqBM4pfmY3bWVgqzP4ktSJlp237Q7R0cvqQYsVCxeZvqOzdMg8kJePRNgu5YVy/ZpjVxWZanVKhWYfALYazyj5Idf6++Z0MgeJOAzYYhaqQwqlxtBSoCqlODhG3BCug81URcfq6twIPVwlWTswIFl9/MePtyL2NegSXXfc4i7CuiGyN4+Mx9QOGjLbHbymBQua1Hn2ncIyGffDiNlb21nIrYrFnOs2nLl+/gZSiZXNhBpSL4tdtGKysK+NMt4L6TmEcV1vqiN3CPiFYaacjk48+pB1qg2gZMsgNr8Tut8oVDzy01M3fDIB0xlQvEFA2DNQc7mjhUWFPyhaAKHD4quflwFxVEqb886EcbSCnK6AoR4+6gVKRDE4DToQ1paNwE9jy4F5w11r7NmfK14jtXLxrHH4rLo1+ToNYg6rEOSOvACpNkTMiA5jC4jxfDpWvu76O4bEPcG9HbfziTfVFI/Yhe8txJOAwZ0beuqpmPhQsvs9sZluJkhqRiCN0xeKHdPMNtEwPjWxkpjjrV+csye1nI+yjJCiXIWy1Z7hSFkYDkVzjB0rcq2ucPwppEf5etUdSzEpznzz4FgRKMEZcYdCQ5Irx5eZebx9xdB7X11J4ghMyR6PlopS6z0hhpwBV4S7+1CfVj9I7aE9nqtHKJFsa6vPv3ytEinXpekNb4gnK0ZFp85rL7 Nd/Yxu8J UVIVQv/E9BEPPznmcE5o7nOdNf6ZO8HSs3YEZZXcEz2goVFiasvgPeTyJy3VplKSEoebeSFioc70SmtqNfxZfJlJHteQNOpwwL9vxKdCNyZ5dMaADObAHVtqrwxp4R8thwPxsXDy3e3BGziHc+h4Ur82YVOdtORH4iSy2RibvY+u1uvpze//sH9HCfoqe67QGVsIzzS8FazRsl/JbQ226cs6WQiGe2YdxOyaFpa7YiNJALUAXGAKk3zxjd4sKdXOXTIXsZmTtmpBcarINyjBTzYk6NZa3+aSuRXtfGufLqqEXtP2TMSloFTq7Xx+Q6GCORcI1OoNXHRfIfw0Nl5nZ2ECSGtcx6dFUp7KmadyRVX2PPQMr0FRKjpNBM3AxzE74Yjhhqi+cjOTUnrFY2vuMMPEoqHMbH74wUcqJgQMp7blGRgbkzVux5tKbLvJJNP1fijuA0ky1KMeNd01zpWA8JkJc/T88eR/UQMgBFzmqVQchW94j9Qf0/8Oi0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 19:03, Oscar Salvador wrote: > On Wed, Apr 02, 2025 at 06:06:51PM +0200, Vlastimil Babka wrote: >> What if we had two chains: >> >> register_node_notifier() >> register_node_normal_notifier() >> >> I think they could have shared the state #defines and struct node_notify >> would have just one nid and be always >= 0. >> >> Or would it add too much extra boilerplate and only slab cares? > > We could indeed go on that direction to try to decouple > status_change_nid from status_change_nid_normal. > > Although as you said, slub is the only user of status_change_nid_normal > for the time beign, so I am not sure of adding a second chain for only > one user. > > Might look cleaner though, and the advantatge is that slub would not get > notified for nodes adquiring only ZONE_MOVABLE. > > Let us see what David thinks about it. I'd hope we'd be able to get rid of the _normal stuff completely, it's seems way to specialized. We added that in commit b9d5ab2562eceeada5e4837a621b6260574dd11d Author: Lai Jiangshan Date: Tue Dec 11 16:01:05 2012 -0800 slub, hotplug: ignore unrelated node's hot-adding and hot-removing SLUB only focuses on the nodes which have normal memory and it ignores the other node's hot-adding and hot-removing. Aka: if some memory of a node which has no onlined memory is online, but this new memory onlined is not normal memory (for example, highmem), we should not allocate kmem_cache_node for SLUB. And if the last normal memory is offlined, but the node still has memory, we should remove kmem_cache_node for that node. (The current code delays it when all of the memory is offlined) So we only do something when marg->status_change_nid_normal > 0. marg->status_change_nid is not suitable here. The same problem doesn't exist in SLAB, because SLAB allocates kmem_list3 for every node even the node don't have normal memory, SLAB tolerates kmem_list3 on alien nodes. SLUB only focuses on the nodes which have normal memory, it don't tolerate alien kmem_cache_node. The patch makes SLUB become self-compatible and avoids WARNs and BUGs in rare conditions. How "bad" would it be if we do the slab_mem_going_online_callback() etc even for completely-movable nodes? I assume one kmem_cache_alloc() per slab_caches. slab_mem_going_offline_callback() only does shrinking, #dontcare Looking at slab_mem_offline_callback(), we never even free the caches either way when offlining. So the implication would be that we would have movable-only nodes set in slab_nodes. We don't expect many such nodes, so ... do we care? -- Cheers, David / dhildenb