From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B227DC4345F for ; Tue, 23 Apr 2024 08:44:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4452F6B00E4; Tue, 23 Apr 2024 04:44:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE0A6B00E5; Tue, 23 Apr 2024 04:44:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26FB16B00E6; Tue, 23 Apr 2024 04:44:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 04B646B00E4 for ; Tue, 23 Apr 2024 04:44:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 678961601CC for ; Tue, 23 Apr 2024 08:44:34 +0000 (UTC) X-FDA: 82040160468.21.BBD3F3E Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf26.hostedemail.com (Postfix) with ESMTP id 8D8F8140002 for ; Tue, 23 Apr 2024 08:44:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="nrXmo/ZS"; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713861872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWqIX7XIqqXtg/bUvAU87XObKPSxoqSB7hriUx08qNQ=; b=qDkoSi+/1YH1G/Db0b0xLbMnrbIY9lABzS7WdlM0pdnAST3BZhyb8vNmBl7uKeMDOH05R5 YdCQezVLdtSuK3b/SGRaWz/Ujw12TJ5ti7z6RsDhwS6rsRj55jC99abHQxVihPTCJpXUJQ s8ZkmFiacN/dHwN6WNbDCuLiZnYQC6c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713861872; a=rsa-sha256; cv=none; b=I5xudAICxFfBy2cqfZUmj6U58WN5Av/uM57S0KiP7Rb/YY6aYNHRsKjCmlWSmr4RNYt/At ThpfGxSymlyw54gOOcvrH9VqyNt9zcfXuEG61B0GDqXzygahqjD1IZ1uWeV+HuKyGj06MF /IJqBa/eP29BIXK+QcueJjVpYlN7S7E= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="nrXmo/ZS"; spf=pass (imf26.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713861870; bh=jdsWPAe/3j9MrIf+j6Di+jr1djPe2ZWvG4ZRKncHSZw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=nrXmo/ZS8hSxgaHZp775l+2tsr1u0AKR1FBzyAeNOAHkxniKvx4afpIYlmCKRCzNS gif67zp9wHteIi/soXRfikZnU754o+FdB2N/T48RDzpEtNb4V58afnB5DWvsN/26sK a3HFSKNAMvX5Kq/+Uyn4r5Ypwqd6kHFkwD+k6Yvchrnk6+BC0SN/bQisu52M+4AChF cba/VP+MBV6PdWD6rmPdfC6TiTL/LPuORWQOy3us320eNpf1Kxn9o6bTTl6MJ3EEiF SzkAzumMb56+fLrvXRSnDoJ7t8zm/TO0J4OqCKaH0JAn8VE463+2DyXesr3R8IkDpB 9HFSp7bWGcTGQ== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 705E337820AB; Tue, 23 Apr 2024 08:44:26 +0000 (UTC) Message-ID: Date: Tue, 23 Apr 2024 13:44:54 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 5/5] selftests/mm: soft-dirty should fail if a testcase fails To: Ryan Roberts , David Hildenbrand , Catalin Marinas , Will Deacon , Andrew Morton , Shuah Khan , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , Shivansh Vij References: <20240419074344.2643212-1-ryan.roberts@arm.com> <20240419074344.2643212-6-ryan.roberts@arm.com> <6a08436e-c984-43aa-bbfa-05cfea34516a@arm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <6a08436e-c984-43aa-bbfa-05cfea34516a@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8D8F8140002 X-Stat-Signature: mu18tz1h8zs45h1956o5znmgnmfnmf34 X-HE-Tag: 1713861872-655145 X-HE-Meta: U2FsdGVkX1+ztfoqusX5irX2d2raipV5yDIwn/A6OFjncAS6uiBlSKkjAWGR0PX5l/mVLI3kFgETSnMxDqc0duGdbbkyJ2Q4sk8yb0nauhKAAdEBZd5jV5Q04kHZ7zaUFCJWULBRVTq6iu2pPINVidoZrpdHaLLlsFiTzptvhRfNWTq66tfNkgFh6D29TZ7QbFkHL71yfaCWQcy6d+M9E2fCr3TeY6fJkNpke6qgy1Y/BpxWETUqL36Hweq1o/o7g7wuVM2UlUmuFbShfZu8lvSjKVXMeUiaNdD4RGF+UqGzpeMD8fmYu1aE5E8Fyf38D4a+9mxF9mrwILTz+YycndUruLjfzDux49RPGDvSmgzOw0cbdmc1NFKzlOALvsMh06zh0A/hYnDoGpPlpHqGw/GVyrKp2EV844qatK4peqva/n/IebuLxiAFTzQGJw37g7RDLYXerDFBIZXIP0e1mCtC3huL8acD/ucOuAHXJucY92mxWAVQ5LnvQoXMNlwRgScTQ1jr2JH3Fr+qispNrECcZtGSNMnWUO8+/VCGSdNqxJ5Z5Rij7B4ATxf0Xkl2QHT9j+CwykDoui2LZ+IHjb4i7cZC3UGed/G2xlrSYdLnOLTJRE7gS+FZluG90Te5SpHXrjX2pKU3frwh/tfAdWSsCtUuX9f3MlYlovtYpWfXG0iy4/tmH13+LJ2hwkga0/bMRmJzYCisHPlO3pX8KA4Qx1mAboXp/4iHT5zylN+tyy5boT46xl64BGYJnTspO+sYvovp4LCNYpOZ1pdVb+yjIqGc3qgISGFkjbQPGkl9CLL8lzQlvhyu4FT9NolsHcJoDi9rZNtaB5LnrXmd4UHMW57PVG3Smy4Sg+jO0SKLr4exmmIbQ8SLs5jNXdogUM48QBiytqYU3H3dyhYuR0pkncVo6L/kR/EEpo3kTJafWZjiaTqC9NQ3DfmZ1I+mXFpsVp1oJH3f/P68JjO 0QOacgOj reO/Xba62H0flusZKIxpsC2pZzHkm+74WXzXPdTibTiFsAq2oPEAgGOyu+8rltRyHyvsyKe9YX9WQZ+ld4GThPnLAaW9cmsv/jaBPn/5eh7WTXpRjqDxuMsWoNODhh3OUZX43czgqQvJyS6rCgL1N8kbg3vguI5gACFRIMhU7H3Q0ALjJHD65+0E8yNyhPJjKCQfAwnXWLnY4eZ1CE25Qfyd9P04GSLs6j5Yy9Iw2x839jW+Cv6OQ0GkEDoIBWLgSPZXHSSp5PdvCKQKlzx+iK/0TXpsiIbOlcFFfpGUk3r1e+ibqxZNLFMsTJm2ZvyVyupYFY+wMMRpNCOMPAkujjCi0AlOIuZoVAEOVmL6rgk0s+YqUHkbwYHlDLRKBt36eXsi0Zf0CCEqmXdQ7/qruaQRI6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/23/24 1:24 PM, Ryan Roberts wrote: > On 22/04/2024 10:33, David Hildenbrand wrote: >> On 19.04.24 09:43, Ryan Roberts wrote: >>> Previously soft-dirty was unconditionally exiting with success, even if >>> one of it's testcases failed. Let's fix that so that failure can be >>> reported to automated systems properly. >>> >>> Signed-off-by: Ryan Roberts Reviewed-by: Muhammad Usama Anjum >>> --- >>>   tools/testing/selftests/mm/soft-dirty.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/soft-dirty.c >>> b/tools/testing/selftests/mm/soft-dirty.c >>> index 7dbfa53d93a0..bdfa5d085f00 100644 >>> --- a/tools/testing/selftests/mm/soft-dirty.c >>> +++ b/tools/testing/selftests/mm/soft-dirty.c >>> @@ -209,5 +209,5 @@ int main(int argc, char **argv) >>> >>>       close(pagemap_fd); >>> >>> -    return ksft_exit_pass(); >>> +    ksft_finished(); >>>   } >>> -- >>> 2.25.1 >>> >> >> Guess that makes sense independent of all the other stuff? > > Yes definitely. What's the process here? Do I need to re-post as a stand-alone > patch? Or perhaps, Shuah, you could take this into your tree as is? She can. But if she misses it or you want to post v2 of this current series, you can just send this one separately. Usually I try to send separate patches for trivial and discussion required patches so that there isn't confusion of this kind. > >> >> Reviewed-by: David Hildenbrand > > Thanks! > > > -- BR, Muhammad Usama Anjum