From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1CBC5AD49 for ; Tue, 3 Jun 2025 15:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B40FD6B04AB; Tue, 3 Jun 2025 11:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF1736B04AC; Tue, 3 Jun 2025 11:22:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2F0A6B04AD; Tue, 3 Jun 2025 11:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 848066B04AB for ; Tue, 3 Jun 2025 11:22:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 022E61D6E26 for ; Tue, 3 Jun 2025 15:22:28 +0000 (UTC) X-FDA: 83514456018.13.466913F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 36A1780006 for ; Tue, 3 Jun 2025 15:22:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AFsrjOn5; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748964147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lmsSZec8H0ybvqPzdSVbHiDv88nWKUFgUm2bcmaQhTE=; b=IccRZMVGLfLTRqDIhI9D+PELwyj8XU4gpflQY/OFUZN+AQbhTKAIenacNdDM8Dau7voW8I zn/qSgbymC1NEeE7OKPfn8DyGeiRT9hwexrgo6Uo0rWkam6Z0FyNLOwM2xP/WTpICSLlGM aBMy1CV6yM2gapomHxFXOXRd3ch+TXg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AFsrjOn5; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748964147; a=rsa-sha256; cv=none; b=QNnLRof2jNPkmKfSOPjS1dxcx7EjTcuVVgDWneTBONcCDeoBWoUZ4E2nfkmJXLMQ+9Uz6W LLHvfdq+v6CIkrH+SP59ctISzMjF/ZmjVaYQGWl8bRPdl4SYHIXOMvHPFGodkRKCgle+Cx NsfhChzchLCeNsHqueRhjcfgYT0akOY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DC1914A6BE; Tue, 3 Jun 2025 15:22:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DE31C4CEED; Tue, 3 Jun 2025 15:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748964145; bh=0hTLQi0oAwCP5NrLU1AZ6DJvGLwP+iyJza4JG77lOJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AFsrjOn5vr9Qx6cv8CU2jpKkc9VU0PPSyinAwF+o5qu8Xq5NtS8oRk0goJY0ZNVYD JVMgwbUq4EYAtqOf4sa1+QDPK8JMLU4/1lIwpL/MTNWtW6y+LLcDZSFB2lBf2HOfye ifpAS8qF1RIX2CVPUEbInQK/GMp72nwToZxhfG4VESJ3VrL1vZQEjCXD/WxGEp4ra3 uWA4wLFceuKfXmZodfLTfWAcI1g56Zw0ScbrxosOL00SzJnQCIPlNASgq7yrCxqLNJ eOGfx4f19K6S2PofASc0rGGXA0hfIBNtOdseoF3I3VOWGqoP6Ukr3r38BH20DNRKzZ 1fN+FI5xeCauw== Date: Tue, 3 Jun 2025 16:22:21 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test Message-ID: References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vzYPTz+0185M4LPA" Content-Disposition: inline In-Reply-To: X-Cookie: Avec! X-Rspamd-Queue-Id: 36A1780006 X-Stat-Signature: ua6mdii7a9rkdxca19txar7po5hhm3rd X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748964146-650829 X-HE-Meta: U2FsdGVkX1+X3w+93+Hg/6h0MmfwAT9gmOWVJ85PH8BwCvWM1DsyDjERDW8xFrVMtuHMwwTYHvtTDMznP9c5ELwjYET8l2A0wLv4cArWytAhIuYUMm3jam69mR4H06DrRfRzRoEVNaHRVoaFnzn5lsDaOO+ev1vc1SKe0liOeVvmcAvJ2sNAcDgq3EQIb7CoUxb2ZAFsj5YD10ZR4NPDiUUEF48h+vNNwzzWyEOfgFd3nTB37kdvviywiW1K35n6TIRA8Dxyduq6ETIq/uBbi+DW+HQqfwAw3EyOog/n3yrDMoVlTcqIUl+Cj80QABi12GTrUV/7rIIkG2PWyGSdyp0FdzOuXft31ObsVqw3GqgwyuGmN80nudCAhdQDeFh9anvoz4n+macAHk7MpCPTjiUa5D96NVhgv+AMhpPugFK1ikquW/zZ6UnLrc0Nz9jH2xLsU38GIVgNEcQnkoKZ/mYIVa0KeCMXHPL6CCjbdrw75kA99PhcRtTkNLtwW7wkAcWlGZCjE8gmLe9Aim43KZupA7a+K9qk8irk3c8agvRu4Vnd2AymwcaJGeraEhwuleFFYT+QzpXhLtJmUVH57YidfhfgyCG7bI8sBDVJBVbjHuiRp2evGEi4KvVxhTmZUj3YZsvb2DV+wYEgAAo0NQdgc04xCPA66WirD07ReFca3I0cEQpxJMUOFZIWgAfj273m/ZMKPLN/nTJvhvbfRoyqTriIL/OREZZ1gGzlFb0g+Ds0S4YoCzxNew2XrkC23KzibO9ianhwOFyIEYbiHb7q6TkpWs5mf0YssTTzShsFiBKOn1jqtzluEWhHt3jIBL1YaGP/wpAdK1OvRImatxbeUhvzIClpKC3YHBO+a/VnLwK+WrXAgn37IXcPv617gRauLYx2EQTC5vHoM53R0fcxFq9KbsfND5YZfe0x6HPf98WQvhO1c26yWTB9C0lRYV8mxSRe0qz91ec2dQp ivzOaI8U myv6jQHWuSxA9z+54JFGt2arXXPO25Idepc/TQ3znEw/yWGHaOn4bOygEk3QSqkxsUD3y0gr6LXDVCWfr6dEXZTGVR8ureXLIhje5fuM1PMg55sI89Wvkff5mXkQxHmlRkBfdJU9c0mNsmpbuALUijsBFPwgzGeWsQ2yZe+w3N+djl9FNm2pDVnyDMJpcmNstHkPhpjYTS0aXjBfrk8uGLEt9Sx3y7AO4vs6NMjrQRoeVbX00nXQ+8xeLFcCX4AN24ZEdVHJRIYhVvx1ga9Do5ZPUiCK/5msmpmcz9cR0sIgsyBZQI96FEzIqdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --vzYPTz+0185M4LPA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 03, 2025 at 05:06:17PM +0200, David Hildenbrand wrote: > On 03.06.25 16:58, Mark Brown wrote: > > Like I said I suspect the test name is just unclear here... > I would hope we find some mechanical replacement. > E.g., > ksft_test_result_pass("No leak from parent into child\n"); > becomes > ksft_print_msg("No leak from parent into child\n"); > log_test_result(KSFT_PASS); Like I've been saying this is just the final test result, in this case I would expect that for the actual thing we're trying to test any confusion would be addressed in the name of the test so that it's clear what it was trying to test. So adding "Leak from parent to child" to the name of all the tests? --vzYPTz+0185M4LPA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmg/EywACgkQJNaLcl1U h9C7RQf+NaJb8aic+VrkqhBtJNm1XQMiWUrS35SXFbO6qEGxn5oQanJY13y3xyky /wQsVQhd2hLb1Zin1X6CINnGYyYMdyTIxpxXzTw72Q5DB0DSK46/7oRZTqPgiuIh aHjF9pBHNRQVZvsuhzGJOu3yHbilan4LEjp1ZawjyudxZOyDyW477RJYk+WrE8iu f5ptoGT1Eukrm2ZmdEI51GIvRxtx1K0tVYQN2nTqzb2gzQS4u4vuPNpZhn5uPMBU 8Gf0VDRL3hVckY6XbYIhZwIjzSee6UJe0UudgmwilChz+K3C8kQQ5k+Ia1PYIgNZ q4LsgYvunzKlJK1b9QA4BJmrJ1506g== =QnWD -----END PGP SIGNATURE----- --vzYPTz+0185M4LPA--