From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B078C83F12 for ; Tue, 29 Aug 2023 22:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D72EC8E0029; Tue, 29 Aug 2023 18:58:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D23448E000B; Tue, 29 Aug 2023 18:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC4508E0029; Tue, 29 Aug 2023 18:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ACE4B8E000B for ; Tue, 29 Aug 2023 18:58:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 804651A0290 for ; Tue, 29 Aug 2023 22:58:59 +0000 (UTC) X-FDA: 81178659198.15.DE86E8D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id BA6B040008 for ; Tue, 29 Aug 2023 22:58:56 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UJJSRKRH; spf=pass (imf12.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693349936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/IyI8ii6BrUynwmVcI1iprtPkbpDnPXxoAG6ELBpQco=; b=BT+EpTZPla5m7ppQlY5vJnoDNfvTaJWrBtyg7ZKHPfSow/x11rdW2YgEZyb3dP6pAwrvIR ntTY1u7NTT2KXA8MNZOHeosUK/uMOYne/QSHhDmy6jsjCbv0Tdm3HUdMf43OjkP6I2zMBM v3sQ7UKHdCXwDAnM+DCTjlDS6i7k7TY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693349936; a=rsa-sha256; cv=none; b=uKK/zut4wnaKWna12/sYATb6xM0D7aayW8VutV+/NZlSEDptm5j93GKuvC2JT8NDIspv5x vCnqH6/MUpTERn7KCTMqbU2hkNvI7UvD02cP+K+baZNIP+Yp1KKv4HDgEVym/RS5y5dC/o COJxP4VMmKCJiNH0EAU7yc5O7ig0dGA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UJJSRKRH; spf=pass (imf12.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C592563D06; Tue, 29 Aug 2023 22:58:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9FABC433C7; Tue, 29 Aug 2023 22:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693349935; bh=rn2r8LG5beXDEpNUXXmAsWk7K7Z6B0SkbbGrSUfCikA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UJJSRKRH7LTjcnDdUPp7RtBE/dB7QJhjeEB1YQbMKrKaYzMACob4EBI4SsR0sy5Ye mt7wmIqsOOWPvL2AjZ5YQtEhH9AU5fAVtL4UeL7OEXz9q6ZHDNk6+YIdzODX8+wqil jlsqG5Nirzs8oHVVRgwIrBWk+tU4uj4vEMyBjQFrJmh/cCsnnPwHApt0qQlEh4VPoV fx7tHB0NGyHo231wK83vtI9suH/0L3cn9cyGLY9db8p4Yc0AKTTsIBFPHCXTIrOvy6 YzP3/2IXTyd/Lvsgr1kAOQEzWJjTRoatnNjA657yXZ2FiJLFoy7sfB1K1HWwMGB4Ek xBWdtuLvgMoog== Message-ID: Subject: Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr From: Jeff Layton To: Al Viro Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Date: Tue, 29 Aug 2023 18:58:47 -0400 In-Reply-To: <20230829224454.GA461907@ZenIV> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> <20230829224454.GA461907@ZenIV> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: pnit57izguj978ne17jtx5np3ypmczke X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BA6B040008 X-Rspam-User: X-HE-Tag: 1693349936-28964 X-HE-Meta: U2FsdGVkX1/TRL6A7zwvp77tvwg2nMtpB+1RaaxHKacEwEBH8gvX47l5cZlGNy2iMWwrky4x8ug8fPwqp7RG6d96Jgtq4hC0Ym+3Sl2azXk4d2xQ1puMKtCpVt1HpFWg/gl8tlyfkT+1VceAiyr3TGdP1jmpoY76gLJtsopdyVOUMyhphPKo3srs72G2A0nHQoOxLuE0/cPS3//bxLbIzt0mLsn0P9cahNppdCG+lzw9YbIUFOZt0dIug9GRUV3jBMHuYZcUwZyPGrxSPQH6vX7s+hYyxVTojHCixuxnOHpYf1qy+cgdbON7MkVtsW1q8IdtWomwZHsJXdp8JlhvmBy1DqJI+YWEBujN9Gs0RGVi5mOHyLS/Znjaz4JwMhjBCDpVPOqYSck5kUkE0OJvXEjvJaxt1WQGOd6/vPE3EHccJLv9XPeJifU5/4p/TeyScwLZjThKm8727fccmUQWa44UNhk5SyCcT6GnbTRPNqxZL/mYXkFNLFP7+GDdlVUhd5lZVSOUGp8c0a1QjY1DEykWxN3iLo1MNVMeiGyQWFzSV86lSFLcYkQJ7KeSsPiWrZ+fGo6b8s4OYk05fR2gRsP+GKKQJbPvPYHtL2HZSVFcZKz3yPHjy4fNG2fXDUHMwEooFdXnvAH9EMgRHQlePQFuZDIamJoyLlX2usNSvJbcb/OUZe6O/3vVWiyKWkOLx0feGdw8hC3pLGblU5DqkzNIiDhZYZOUmHtrsuKkp0WArDXxXQwtI/NkyEbJ0uEkZrIHeKjmXaT+sH87aV58RZOGKVD973wCzIg2J/nz4eSi8uU906QzsZ0nbGErFRRDnr4k47CUvUnP1LNAQXh5zDtSuuQF9V3l+sgFFUrLCEUP8Y6KXGy06u6Nc0oi0/2ClkOr5WThnw0BzVP/qX2+EXMw7lQWeg9R21JI31u+xyfHDaO+IaeCx20jIWAubqEyDe4cTraOkmkyI5a2dPt O8GlCKnk heeSuV5cBZEnn5Y0pF2rD2hwCg/T6X2BSnBv0krP52DoAqaXkfrpYdzRbN4ljYK+EGbYgefmMqel91z/xh7XfyZSP4DOQr5Kay2FD5VBeywnsc9UBJRIVKTHdJg2TLHnj9fXO6YgsJor9h/0CjSpB/vhCpP97wk1je5E98MEFiFfcrXKSFBD092q/aB8ScMnp+YKjFzKillOyq5X4k4kiWMl96813E3GgO1Znq1x3pwnDczx3lY6M6Jm+x02VWizxRYcNQS/5RFrU/l4mgJx02lhsdrRdC8hzyixThvQHtPupsgBr41Nghep+znbdKj/oDL25i4+GfNld9qcjBbMzM2EbUHHLh1F4T1ATuHK3adaf5o4i+INZa6w5zlQaIuT9SBl6lAA7jJP9vDI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > > generic_fillattr just fills in the entire stat struct indiscriminately > > today, copying data from the inode. There is at least one attribute > > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > > and we're looking at adding more with the addition of multigrain > > timestamps. > >=20 > > Add a request_mask argument to generic_fillattr and have most callers > > just pass in the value that is passed to getattr. Have other callers > > (e.g. ksmbd) just pass in STATX_BASIC_STATS. Also move the setting of > > STATX_CHANGE_COOKIE into generic_fillattr. >=20 > Out of curiosity - how much PITA would it be to put request_mask into > kstat? Set it in vfs_getattr_nosec() (and those get_file_..._info() > on smbd side) and don't bother with that kind of propagation boilerplate > - just have generic_fillattr() pick it there... >=20 > Reduces the patchset size quite a bit... It could be done. To do that right, I think we'd want to drop request_mask from the ->getattr prototype as well and just have everything use the mask in the kstat. I don't think it'd reduce the size of the patchset in any meaningful way, but it might make for a more sensible API over the long haul. --=20 Jeff Layton