From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41003C433F5 for ; Wed, 20 Apr 2022 17:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8DF26B0074; Wed, 20 Apr 2022 13:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C148A6B0075; Wed, 20 Apr 2022 13:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5C16B0078; Wed, 20 Apr 2022 13:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 9B3186B0074 for ; Wed, 20 Apr 2022 13:14:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 696EC2203D for ; Wed, 20 Apr 2022 17:14:18 +0000 (UTC) X-FDA: 79377905796.16.DC7BD23 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 447461C0015 for ; Wed, 20 Apr 2022 17:14:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 53D461F380; Wed, 20 Apr 2022 17:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1650474856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cCyVaEehkrahTF4ZZE0t6pBOtUmw5LLz8/1wxeHDxX4=; b=K7U7yAPVtWoeKBCvI9IM0SUrBd3SuNQlXwbO69YYMvu/uQgJCBHLxvJUvYDJUM+CzMgGQE RVSlZxkoXhp1TqU71hUtulLocxn+2wyVtaobkUyEwzAopoea+zPD+x5OcZ/P14F7mUWQ0X 9jy/5tEGm6a4qWbujDTO1fyNpFdYlOg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1650474856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cCyVaEehkrahTF4ZZE0t6pBOtUmw5LLz8/1wxeHDxX4=; b=NwzWMKJRWqBiYsMEpHY2LSE0kR5L5AsWQDr46B/AzDDh+7ae+1bOHK7cbVF3M3crtt+AoJ 6QSH0t6rY1IUvWBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E94C13A30; Wed, 20 Apr 2022 17:14:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cLLMJWc/YGJFYAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 17:14:15 +0000 Message-ID: Date: Wed, 20 Apr 2022 19:14:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/8] mm/debug_vm_pgtable: add tests for __HAVE_ARCH_PTE_SWP_EXCLUSIVE Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Gerald Schaefer , linux-mm@kvack.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20220329164329.208407-1-david@redhat.com> <20220329164329.208407-3-david@redhat.com> From: Vlastimil Babka In-Reply-To: <20220329164329.208407-3-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 447461C0015 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=K7U7yAPV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NwzWMKJR; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: u7gn1kib7r8kkgw9a86xrwp6c7iaw841 X-HE-Tag: 1650474857-687359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/29/22 18:43, David Hildenbrand wrote: > Let's test that __HAVE_ARCH_PTE_SWP_EXCLUSIVE works as expected. > > Signed-off-by: David Hildenbrand Acked-by: Vlastimil Babka > --- > mm/debug_vm_pgtable.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index db2abd9e415b..55f1a8dc716f 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -837,6 +837,19 @@ static void __init pmd_soft_dirty_tests(struct pgtable_debug_args *args) { } > static void __init pmd_swap_soft_dirty_tests(struct pgtable_debug_args *args) { } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +static void __init pte_swap_exclusive_tests(struct pgtable_debug_args *args) > +{ > +#ifdef __HAVE_ARCH_PTE_SWP_EXCLUSIVE > + pte_t pte = pfn_pte(args->fixed_pte_pfn, args->page_prot); > + > + pr_debug("Validating PTE swap exclusive\n"); > + pte = pte_swp_mkexclusive(pte); > + WARN_ON(!pte_swp_exclusive(pte)); I guess only this WARN_ON must be guarded by the #ifdef, but doesn't matter that much - won't gain significantly more test coverage. > + pte = pte_swp_clear_exclusive(pte); > + WARN_ON(pte_swp_exclusive(pte)); > +#endif /* __HAVE_ARCH_PTE_SWP_EXCLUSIVE */ > +} > + > static void __init pte_swap_tests(struct pgtable_debug_args *args) > { > swp_entry_t swp; > @@ -1288,6 +1301,8 @@ static int __init debug_vm_pgtable(void) > pte_swap_soft_dirty_tests(&args); > pmd_swap_soft_dirty_tests(&args); > > + pte_swap_exclusive_tests(&args); > + > pte_swap_tests(&args); > pmd_swap_tests(&args); >