From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B77E7716C for ; Thu, 5 Dec 2024 15:22:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B30726B00E3; Thu, 5 Dec 2024 10:19:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94CC16B0114; Thu, 5 Dec 2024 10:19:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B69A6B00EA; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA7F26B008A for ; Sat, 26 Oct 2024 23:42:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 50B72161A10 for ; Sun, 27 Oct 2024 03:42:01 +0000 (UTC) X-FDA: 82717983474.09.5DF2711 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf14.hostedemail.com (Postfix) with ESMTP id 64496100010 for ; Sun, 27 Oct 2024 03:41:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJjL5pGX; spf=pass (imf14.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.215.195 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730000335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/VOnsH2rH5KtfMZxOhoCT0TD1o5zPwTQiLaCxfSmMgY=; b=KcLgckKB7Go63IlduFJSjN5vZmT8VRi6H2RyCmuqJQCY93X2p0ePecrjweNPcH+6QSnqvn LuADAWH9amcvfThHbf9W1IANgVlTQi/2JoMTifmMhGgc9xOF4vJle6LJ3kMZZPid1UCetl 7NMHiOZ7uzhZyqVP/gdziV0+YzVS+cU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJjL5pGX; spf=pass (imf14.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.215.195 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730000335; a=rsa-sha256; cv=none; b=Y9zV6gs77Us91gOz1rclJhVLowpRDr3GQinTIRfSqVEyv4TFLRg+pG3a4IFN0Pbg9/tjGF /Vmn3LBdMuw9eJB6vb5UvaCF1/S59WyaDd82WkVjYftrWRG8BuAP/4aRgRqGYh0cWHyFTs BJ1xnZAJl5IAU6WuURZ6Ac2l/PbseVw= Received: by mail-pg1-f195.google.com with SMTP id 41be03b00d2f7-7ea68af2f62so2543458a12.3 for ; Sat, 26 Oct 2024 20:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730000542; x=1730605342; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/VOnsH2rH5KtfMZxOhoCT0TD1o5zPwTQiLaCxfSmMgY=; b=mJjL5pGX8tfvp4/kvYY66JwRZMYI+JAXC4N+Jr5iKq4u5QwmxrUwDiKSOJkvYEfcic UM0lZC/9X8oPJFdwTwXof9DSq7bpTDWifINEkfNU6laC1RR/GtxYbSbqzuEq8wL/MI10 lKqXZJcZMeUPC2W29SomOYOI+s6LasuFmhzvD1iSfEST3ZNdxQPbVhMNFXHz1fWdNemT GkWaufTZgN+/eLU1Ow/vXqpnm0Z/9zK2IEDDnUKYPIgGRtXOKqWdpphvBeL26L4U9fVD HX1qqpyZI2iC6/jsWzIbDGxZhgGJXuTcnQOfwwHrMnRRydmG9HQonOrnkj/YSOw0NKYP US3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730000542; x=1730605342; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/VOnsH2rH5KtfMZxOhoCT0TD1o5zPwTQiLaCxfSmMgY=; b=V5A0ROf8OHZolKs/lOpAj+Dyf15oqxl2NmYH2mTPTL/9Zj/Q7qmGVcGrpeMQJPpJCJ EOUm5IB2M1/4LjqMUOHmAdaUSkZNgKTtTJj7YrhCR6eBWJvOeKxOxLV87Rj5xIJiqUh/ Rbec0PvYeQCjuFf6KXghDIkZH50UdL/1ZJO5LBU1JI0YgUSFSM8zYu4b0CoHUrvJsNZN fLOYoj4PHCO/zSrym9tFihUq+bMZTyKMb0pUyTbWTd9fFs8tLEr4xAiGhiiI4semFGEX am1K/boEqqv5wrtJsY5UQpfuUw6f61xnf+WWrpXf8mhSC/ia9kfH/1YIUXmzG7PDvOLY cFTA== X-Forwarded-Encrypted: i=1; AJvYcCWN6qLe1CI+0xY0D6U0det67yB45lwiIjtA/g5cxHVGoaTboP8hawm4b2oJUDwNcbx8lIC1BsoSLA==@kvack.org X-Gm-Message-State: AOJu0YxmFTd84fxSCmp7EgxocmwzJWCoHxnF+jpuJnua9blmyVNoBMxi ZyxsbdcOl6nvv1Ot6xjW+JWUVF63sBGcVTVv6AtdHbs5EQ5Q+7pY X-Google-Smtp-Source: AGHT+IGp/IRYQfDtNycrDto4jOncAVRMLfW/PWw3EZ3FspX7Ai2s54yeKWmAKI5lSt8PEVw6z8a2gg== X-Received: by 2002:a05:6a21:458a:b0:1d5:388f:275c with SMTP id adf61e73a8af0-1d9a83d5faamr6172823637.20.1730000542173; Sat, 26 Oct 2024 20:42:22 -0700 (PDT) Received: from ?IPV6:2409:8a55:301b:e120:f124:d73d:1b7f:fac6? ([2409:8a55:301b:e120:f124:d73d:1b7f:fac6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7edc89f2c67sm3089550a12.69.2024.10.26.20.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Oct 2024 20:42:21 -0700 (PDT) Message-ID: Date: Sun, 27 Oct 2024 11:42:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v22 00/14] Replace page_frag with page_frag_cache for sk_page_frag() To: Andrew Morton Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Eric Dumazet , Alexander Duyck , davem@davemloft.net, Yunsheng Lin , kuba@kernel.org, linux-mm@kvack.org, Paolo Abeni References: <20241018105351.1960345-1-linyunsheng@huawei.com> <02d4971c-a906-44e8-b694-bd54a89cf671@gmail.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 64496100010 X-Stat-Signature: ffchiizi354txku8r9qujby9eozjf1zq X-Rspam-User: X-HE-Tag: 1730000519-203596 X-HE-Meta: U2FsdGVkX18NXgX3E+n9+HbH6AaUsJpa6ulekO4655b6uC1wC3d6s+OFEDVdnUv84UsWmSsp0S12UkyskgdiiwZh5KGrncnDcrIF2Gb4j4hbyO5cQ7Atl7+1is+p+6n8L3SeW88KxwwsHtYBQ1Xe1qsW4X0gprI+K6FKBF7sgdI1kLf6E8OIoUS6EiQRnN6pVB4uUFZQ2RG3oNyHgvc/lOUtbhhpBmvFuYpQR/XroJU9qFWMJr40R/oZyWX7s7jxkfJN8zcxiSeD+YwfdhO0DoupbDVW1hDe2VofeCxR0ZFXOfCubNh06f0gu5lksfGTQal/k5Ez72I2lwoVm8yglUFPl+JNr19vkArddPzjCcklfqPrmoNcTPl93a/sblsqufVfH0oddVaeFzaNUSxLIO14RXtkggoAmOAcj7/r95ZvqL7K+l3QPSlqyiaMOD9gdwVVlpH2SIlqTb+ZRXKAQV94UAzGi1l97h+MBIARVohVmunzQQeLX7HTOQaAbW8oVaeEW6zJ6y8RhjOCGBjpRJy8RKENnRni15o02PfLI8+7xsqs5VMo0cKgzndnyJSNQhWwvXwYLcTXZRYITC3vL1fWbNWiZsNDEBhP3BdaFejySrHBmS5ccT7T2IwzkSaWg4ZDPApNiBcaWBDA6fLr94/7DgaWkJxCQFdXkS7AucCXNUOo5CYrtRr9LH6VLx5QTdtOBOcHg1Y0rODqYpSsJTIQl1iQrYxSfsu7wi49Lhf7gq3S4lAJNX2pmUPhTLN8qsisGDzmqdgxueVXOMgQObKQPP3L+iq0ja8nravGi5+vItCxdppWh3NNQYYNvPPh/sWlHktBpuGwttlxc7P+t7kaKN8AGETXiJinEMtPFWT5Su4PKbBjH4X/0bkMj5f/8C0X0fd1S4A4zitS1fK3yBWIGKs+A6eXh3IztMtxPmrYomkwXYcxH39pwcswyM90llPqBgv0NItdddVzSIH jFgjDNyK RvBzlbMA1O5u1aWDdwF4ZbL+i9Z5xJJV4PMFdmBxYu3PZVpxpP2BL+tTmkNe6NF/2qnsk6OlkEiYMssSAmzdMyTJe2Ro1toUsrZ3y3AwiWV2jRMKp5U+IUwKj7KU4MbMpvMVy+RPD3FyeCvLLLnbGC9OxR6vyHTwffnDmcqan9Q63sc4uKHlZwxPgXFH6CYWWnVfSvzZ9NkSUbzXqnNy2vuM3PzVBy69IdXpnochy11sTrbKirEJTbQmlWYICRfpigONTcR6n55SmmobNLPJY7nxHNtBJRGPEm1CO5RL1b4fWPSgPfbEWKg1RNSmgFHZJy0Oz2hOM/jXoOce15uV5go/g6PvKzTx3L6gBDJBQm+xiqH/LRlw996XjfaYlxo5xV2TusGkcAnZ7lYofzVAfTPxZged/WsaYxK1i1bNYT+/Uoa8xN1YtdWpULJNV6Jcl4ETro7iAKn2xtl/xjD+Grx8QsMnvtK1nD6/b/h5eenPH9d8xkrTpFYcPNPBSJIXhU8n9ghdkSABEP4QvX7IFGA0x9lLKkcBVEnQ413IXRNIC7YB6BJQrSbVSOVLTOy8pPcMWNa+xGDeFmglldLf29RbBn2G6KHn0tL6fSpeU9Ry0N3wh/+leE7OBt2Ygd3YOSX/l7OjMCdn5p4xzw7ozLg4Wgm78xaVBwdbCXs5tnvG/cIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000098, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Andrew On 10/24/2024 5:05 PM, Paolo Abeni wrote: > Hi, > > I just noted MM maintainer and ML was not CC on the cover-letter (but > they were on the relevant patches), adding them now. > > On 10/19/24 10:27, Yunsheng Lin wrote: >> On 10/19/2024 1:39 AM, Alexander Duyck wrote: >>> So I still think this set should be split in half in order to make >>> this easier to review. The ones I have provided a review-by for so far >>> seem fine to me. I really think if you just submitted that batch first >>> we can get that landed and let them stew in the kernel for a bit to >>> make sure we didn't miss anything there. >> >> It makes sense to me too that it might be better to get those submitted >> to get more testing if there is no more comment about it. >> >> I am guessing they should be targetting net-next tree to get more >> testing as all the callers of page_frag API seem to be in the >> networking, right? >> >> Hi, David, Jakub & Paolo >> It would be good if those patches are just cherry-picked from this >> patchset as those patches with 'Reviewed-by' tag seem to be applying >> cleanly. Or any better suggestion here? > > We can cherry pick the patches from the posted series, applying the > review tags as needed, but we need an explicit ack from the mm > maintainer, given the mentioned patches touch mostly such code. > > I would like to avoid repeating a recent incident of unintentionally > stepping on other subsystem toes. > > @Andrew: are you ok with the above plan? Are the above patches cherry-picked to net-next tree ok with you? More specifically, they are patch 1, 2, 3, 4, 5, 6, 8 with at least one 'Acked-by' or 'Reviewed-by' tag. Or any better suggestion about the plan?