From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B98D5C07E9D for ; Mon, 26 Sep 2022 08:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2638A8E0030; Mon, 26 Sep 2022 04:41:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 212978E0007; Mon, 26 Sep 2022 04:41:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DB678E0030; Mon, 26 Sep 2022 04:41:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2BD18E0007 for ; Mon, 26 Sep 2022 04:41:29 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C95EA12075B for ; Mon, 26 Sep 2022 08:41:29 +0000 (UTC) X-FDA: 79953592698.25.D18629B Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 805162000B for ; Mon, 26 Sep 2022 08:41:28 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id t190so5926314pgd.9 for ; Mon, 26 Sep 2022 01:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Z6Fq3OQCzJNYUdQqn+SR/VBV1Co8BIFxEWqJxINS4/M=; b=bDq3IyrPTsWd9r6LS5HxCwPJQneldvZPVfwMB/Dn8FmtJsn1I4s14dFuM9I0j2gVLF 3str0e1Xfdbb5ZY9OP//q4v/wv6rrYAuHCzm5sfFf0TG8wCbS1V4yso7uPj7bDWxLmwo mekcXiEuMUM6BNNFwEiVpyVAgNr4Vln6AWDHLBaqV9HUETk4UPogZKHRyhKqQwBIDi40 ngAIbGOvnc8x8pm8xyr8LHTYhyM0NPycNBiW8LWdlnknTWGsbCGdqEw8RVpdy0+rYlQ3 ZX7AsaowB9FTgR8y8ajnBBr7+io7CnToQPSQSATPdp3Golp9LKIPL6iXJxhhujahMkiz OyEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Z6Fq3OQCzJNYUdQqn+SR/VBV1Co8BIFxEWqJxINS4/M=; b=Sfis9pK5eg1yZE4NJyzNrwl8t1CI6bSHjrH4SaEKnihyRumQ1nHxT5hLp2BfCtwgtx MD8VcTbbcrAT+WErgNcCuiuVB4Rd/+AfYT1TWzeZOHuszko02//4a+b/viQqVGfoMcz5 ZS5nXDsDysXZKbPB8yJLYbBXLbzcUCKTnSWb1vPFdzclJiRK+WWX45zMLCAxraNX71it 8GF164cfBgQUgwpQlou96b/FTwoRJO0Qa2rH5BSr3nTJhxk8Gd2LWyhrM326Au+Yisz2 pmnpgxG1n1WI43SrnzwNNOb4g0yIGIYU0XHaf+otBKMyDl3QS7JzHNqs7ngtaWwPZ01d EL4Q== X-Gm-Message-State: ACrzQf0G2u576Q4hpBK3wIO0vJtistsTKEw1ez1kFfZc8tEvOpA10rwg RJWhwaxNs2lu8yu+MGhZccCxMw== X-Google-Smtp-Source: AMsMyM6BiW8KXOMc7a39E2aNr7acYfpjT5DKBwiJ8WaZ6unGoXNteQX640BwRTnho0Ze0V8iXOd8Xw== X-Received: by 2002:a63:50e:0:b0:438:d16d:e8c1 with SMTP id 14-20020a63050e000000b00438d16de8c1mr17853167pgf.505.1664181687415; Mon, 26 Sep 2022 01:41:27 -0700 (PDT) Received: from [10.255.6.155] ([139.177.225.232]) by smtp.gmail.com with ESMTPSA id ix12-20020a170902f80c00b0016b81679c1fsm10594020plb.216.2022.09.26.01.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:41:26 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 16:41:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page() To: David Hildenbrand , Muchun Song Cc: Andrew Morton , Linux MM , linux-kernel@vger.kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn References: <20220924053239.91661-1-zhengqi.arch@bytedance.com> <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> <48590f80-fc58-bf67-5acf-082880a607b2@redhat.com> Content-Language: en-US From: Qi Zheng In-Reply-To: <48590f80-fc58-bf67-5acf-082880a607b2@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664181689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6Fq3OQCzJNYUdQqn+SR/VBV1Co8BIFxEWqJxINS4/M=; b=qi0SneF2tLEdfArP4Nx59PuOFSnF+h7iRvjs9mmM2IV3oCldE6wnIRPDja01ssxdhYpQyP PET2eRtuG8dMhyoOc4jeZ1jmjygTTHxxG0PdCLZHlu/mJl9FabnPFQmX0U7VK/Kcj+Dpyv EGIOw9iMeft3idh+bQko05e8dCn0mqs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=bDq3IyrP; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664181689; a=rsa-sha256; cv=none; b=hHr2aBFWhb9mdgcpvl1OxbJxxVpyTJvfjoZp9IM6CWfBN4q46m3OLrpFqiPignEfq/h9YQ v3qqQZt2QLILqEXMsTgl/2FZOU/3K7IgeIvuCWW2wW6DoZo9G9L1al/wO0Bl6kNisX1R4j u5Ezv7hOdG0sP2UT45GYH/AmVnysbzQ= X-Rspam-User: X-Rspamd-Queue-Id: 805162000B X-Rspamd-Server: rspam01 X-Stat-Signature: j9cb8arzcrig4xgnsnjueofoidytmz5m Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=bDq3IyrP; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-HE-Tag: 1664181688-53254 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/26 16:32, David Hildenbrand wrote: > On 25.09.22 03:43, Muchun Song wrote: >> >> >>> On Sep 24, 2022, at 13:32, Qi Zheng wrote: >>> >>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>> if PTE entry exists") said, we should update local TLB only on the >>> second thread. So fix the misuse of update_mmu_cache() by using >>> update_mmu_tlb() in the do_anonymous_page(). >>> >>> Signed-off-by: Qi Zheng >> >> The change looks good to me. However, I am not sure what is the >> user-visible >> effect to xtensa users. So Cc xtensa’s maintainer and the author of >> 7df676974359 >> to double check this. > > And if there is one, do we have a fixes tag? IIUC, there's only a performance difference here, so maybe there's no need to add the fixes tag? > -- Thanks, Qi