From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DDCEB64D9 for ; Tue, 27 Jun 2023 09:49:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7E88D0002; Tue, 27 Jun 2023 05:49:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 978368D0001; Tue, 27 Jun 2023 05:49:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819298D0002; Tue, 27 Jun 2023 05:49:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 726B88D0001 for ; Tue, 27 Jun 2023 05:49:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F129240920 for ; Tue, 27 Jun 2023 09:49:02 +0000 (UTC) X-FDA: 80948054124.07.219A870 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 9C3E340024 for ; Tue, 27 Jun 2023 09:49:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JU5JqhCj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687859340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3c++9YiOTHNLa4+LTI+K9L5UCqHihkiE/iTsbyT1Cco=; b=HKP8qODsTw4kp5pDjd8gJSWwCJa2jTQXX9eklED53td4nn+Q4MlR2v1NPFa/GoccwJfkTG r7OKLGKk1TxJej8oVST9KPdLV6Myv1ee2ZJGYLkXaWWw8jsNeOhZXp705vX3KXa7xZxRaJ Ovs5czC6S5BG/TybEVsmLNWOW8bMsKg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JU5JqhCj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687859340; a=rsa-sha256; cv=none; b=pvtH9cTUY2g93b+i/YHfktNeh3koEKsKFxw3J0OTzrZ5dMPWObxI63JtVrxa7ljfcALy54 AXXiJ9VqP5ErvfRPM38J92c05GXGmfdYZqmaCFIa83UUFZwF9hKgpLhdMs64bnExpWGZeM g9OuzzG9z/Znrfc43yngjG7l8nbwqqg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687859339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3c++9YiOTHNLa4+LTI+K9L5UCqHihkiE/iTsbyT1Cco=; b=JU5JqhCj9XKN4A2Gwy7jK/IGZ48IFSVLhsZk0LN60IbaDZ3dkJZveOoQecyBQeM1+dLuA2 S+2rmtnN1E+/dp1HrZZ3bHhp/k7tuFjtDsMTsE8LPLCOwMB4ogWszvv95DMS+IX+cSqBNU b+QMWpgE0QlB0tpZNiUbISwCRj++LQY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-HfFd3-0GNSeN6pGf9gzdZA-1; Tue, 27 Jun 2023 05:48:58 -0400 X-MC-Unique: HfFd3-0GNSeN6pGf9gzdZA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-313ead680efso1123920f8f.1 for ; Tue, 27 Jun 2023 02:48:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687859337; x=1690451337; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3c++9YiOTHNLa4+LTI+K9L5UCqHihkiE/iTsbyT1Cco=; b=l0JW6QQgxtsnQGa4suO0jSvmxMZ9MBIN8X7nmyOFKuCoaEPiZt4KHDQAWxIawnR9fT NS7DKaRPAzRdWeHdACh4i4b5tDgxgm9aL+ozZ1Lx/MTMcxjjCYRB6MjQMtrfvweRnQY4 jX/Tab0udReBqoidi189G+B6RxpYE4TLZtfPwOWs0yrj6nYpb78IM2YeUavqCGVkmW7U bY8DOpmVaLpK/7CzHpcHVbWsdRMeHKmovsxDGLmaXBy8yZXPSmUDJW8uo89euIun3hrX yswZZ6iEyPgNLbgaB/66Hz7AwzsisTmGgbX7wgZ9hgeGd8MRmmaFHmZmB0CDorBj5ClP 1KXw== X-Gm-Message-State: AC+VfDwkD9QK73+j6nc/UplkQ0I+G8PoekNLiJ2HTJbUapgELkhGG3jF KoAoDga5VUOMSaIsqIbcmk49tkIImh9tVFM+XCXCeMzF7XkDAHWUH8bwJA615CYm18an6H77VFu 2BcoieTelP34= X-Received: by 2002:adf:f889:0:b0:2f0:583:44be with SMTP id u9-20020adff889000000b002f0058344bemr28181801wrp.0.1687859337304; Tue, 27 Jun 2023 02:48:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4rCZLhsCTr4FFPJrFwNmIwE36seluRYYQYVL4IvPQFKZtHxnczJk5ga4Zc2NX+rG1zlgvS5w== X-Received: by 2002:adf:f889:0:b0:2f0:583:44be with SMTP id u9-20020adff889000000b002f0058344bemr28181789wrp.0.1687859336939; Tue, 27 Jun 2023 02:48:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:4900:68b3:e93b:e07a:558b? (p200300cbc737490068b3e93be07a558b.dip0.t-ipconnect.de. [2003:cb:c737:4900:68b3:e93b:e07a:558b]) by smtp.gmail.com with ESMTPSA id e15-20020adfe7cf000000b0030aed4223e0sm9853784wrn.105.2023.06.27.02.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 02:48:56 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 11:48:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm/hugetlb: fix hugetlbfs_pagecache_present() To: Dan Carpenter , Mike Kravetz Cc: Muchun Song , Andrew Morton , Sidhartha Kumar , linux-mm@kvack.org, kernel-janitors@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9C3E340024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7ua6kiab1yjhca3ironw3emwg87q948z X-HE-Tag: 1687859340-873191 X-HE-Meta: U2FsdGVkX1/ZpQpgJel5c3jjFcSdRAyzz2FS9nULc/gQdkB3P4+xeq41lfjdsOwRpg8x5aSBHRvw5k4gtCfpaCevDbT0hJbofHxuua1kgfAkPlbl0t4LdJ5/vUhG6FrmTGJrtpRL3JMzbvrSbLWkZUMb5e4lme+rWgunpKr8ZrKj4z8GVGm4NEK5rEWlCJhyBetemO9BFC+tvFZFqLhvTvdqJwnwgMpyZg9ZaKdShD2G0K8aA0hwvvKQGTC5ZBCv3GiGOjkfbU7pHWafYsEin+d6XRpL6JbGDi2rHeOr8PhBjms4Stz8VHBvjs/QI0tyAsoSZf2KUi0LST7C5Y5JihAVC7aN39uIZv/XwLEwAloX8NcGK5PiRsrKue41lOMP6kVvDl8+UPrXcvDbD/tTnR3WfbcSzDoywncZ5jAl4+LzX/UksorT/oRRkxREXgfCBdc7NH6imTl0nIkTGYx61OmOtxkIq4WkyCWpGuisnuWu3in7785pmuja4zy+omEmP7QuaF8Zinec6O5GMPV5wpuDXHdgcn7CYBKSc9dLLZ3CpJ5nwVQToto84YxGQVi5M2P6IXiiRNXrac66KQ+N/UAUbKhEmwvaGpd2TOR/HQgQDSqTj3xFZFIPuPlB1kzvHvPatGAgLbTMxP8QmuKJxs2iEXg383f1dGcX9JKiywSE1XzA3OxkMBgkJwcBd3k7nQOsHDbF6zIatj85/wQIPqRQbFsV7TlpF+HoB/oCQOkBmqpuPAwnOWf8cR8qnZhVcqyOGYy3mGTYFs1X60ZKusSxYKpHK7LdkmSGvr+b27Cn+LlY3Xdur3kS9APD6HVsOD+T6zYewYdJ52Ant6QjrgCyidAG9iVl/qKDZdHbhw7ZwcpfxBpkbmtKLY9bz/ik+z1LCG8vkWTl/NDWN2RQZfdAoayNTgfogc6k25zUuolKQeq57CPw8NxlNIEPVZ7SsCbjRrE/aLwI8owH3j6 pKn5htNS A0PTBYK4+8egha8yhUPiS19FJuVmtVFVI+rmMIB3zsmFzuKFuKyakv+dGw1OiibbC4icRm6GYIwX9X28kbCaorCwThKnkkmWIQJkkuokBPCilA/rjzyM10olR0w+eEMsycCN0ZXcdfoVt+nSx1dEdgmOcGeBztSXfsdPFKY8G6pM8vgJPjhs6E2/kyeLLqUZ8FiZnT6/0d83cFD9gZXbF6lI/rmUZNHImekdV4mnUsU2qhNgKBsFT4eUvd/YbI1HnxQsaDFoRSHHgTHCcvxg/FypBG+bxIaBibdcMkrZO0svZkqKgnqoHcCFhoSFamhhFuPIMn+NQxsYsfCzSCgU6ZfP2KMzUxkM6a0g6XCCVWGgJicUMdeVx3yKRQGHwJWoEBWHeTit6/9huvWSaxLVdX6bfpvJQpIUrTohsVkUjUrzRm14ykz3IsKbIY2NNlwbNbk+eM2oPM7QwvtxncUDQ53RWXyVOQYSBRTkCIeZG3xngLFrjyGCwjMjo4v9ZDCWQGHXy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.06.23 08:26, Dan Carpenter wrote: > The filemap_get_folio() function doesn't returns NULL, it returns error > pointers. So the "return folio != NULL;" statement means > hugetlbfs_pagecache_present() always returns true. > > Fixes: 267d6792f43b ("hugetlb: revert use of page_cache_next_miss()") > Signed-off-by: Dan Carpenter > --- > mm/hugetlb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index cb9077b96b43..bce28cca73a1 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5731,9 +5731,10 @@ static bool hugetlbfs_pagecache_present(struct hstate *h, > struct folio *folio; > > folio = filemap_get_folio(mapping, idx); > - if (!IS_ERR(folio)) > - folio_put(folio); > - return folio != NULL; > + if (IS_ERR(folio)) > + return false; > + folio_put(folio); > + return true; > } > > int hugetlb_add_to_page_cache(struct folio *folio, struct address_space *mapping, Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb