From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 028E2C77B75 for ; Wed, 17 May 2023 14:33:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A882900006; Wed, 17 May 2023 10:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730E9900003; Wed, 17 May 2023 10:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D28C900006; Wed, 17 May 2023 10:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 45A81900003 for ; Wed, 17 May 2023 10:33:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D4AE2ADFC2 for ; Wed, 17 May 2023 14:33:57 +0000 (UTC) X-FDA: 80799991314.04.C27F216 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 72D9A20014 for ; Wed, 17 May 2023 14:33:54 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=fu1tzDMU; spf=pass (imf03.hostedemail.com: domain of paul@paul-moore.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684334034; a=rsa-sha256; cv=none; b=7oAaGTPrisqG6NasokwlSgPCaswk1a1FjMXf5TVGlVQY0bHYQNYiZbUA6qGQkb0GK8W1F9 mDqfMFNBQ8fI0GW9fHf9n8UKRqPu/06MofwQq++atliPc7UiukNmGNvb3lAHMHyeBSOXOR J0ni6R1KJFXzxG/ZtR6iazbEQzRC8bY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=paul-moore.com header.s=google header.b=fu1tzDMU; spf=pass (imf03.hostedemail.com: domain of paul@paul-moore.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=paul@paul-moore.com; dmarc=pass (policy=none) header.from=paul-moore.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684334034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=e3oHRvM4+O+XVaUuEdehDkOXM012vn7RckSkGvna424=; b=5cJgtCURyVEquetloAdNeFcMIud4hh8QRq7A1ytdvzz6oopmOX2BIFbyyqYsRNo2VgDKxg yUcvgdsODP5wPO8/rGPlDqqZTVQdDK3xTRrDmR2qfwBuElImuc9FN69hcs0MSRytSMJjWn bmOGJYMkm2dJN+eJcz8A6NWuAWHpNH8= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-3f389c21fe8so4780021cf.3 for ; Wed, 17 May 2023 07:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1684334033; x=1686926033; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=e3oHRvM4+O+XVaUuEdehDkOXM012vn7RckSkGvna424=; b=fu1tzDMU/Og/xO2VDVrDn7AMjoYSOOqIHHpkafFQsXAXa7bAquEW8FLCbTstV+4LMK WozWorjMKA6Ye6vd/CWIiTxdEYThpduYehQ0CQ0WfYzDYjo3Vb2D2M2rgHnkpqG2DoOG hFYTNMutL1PBlKS5Sm6U/taMV6kJ+5c+nFWzW2BnEmFKQvrQZqgN1lt1MaOoYlFovyr9 7rwdJcPszNNgJz0aUNWpj3BWju7B7DitjFIRX5EHLLPdarguqNTfEhlBsUlRfiyyggcm rmyPk1XWlhvVmYgOtYCrVpLjW2EGN4HHxXkb5Vh4zDOUpaw4fdaI2HH4gyNooTHomACq 60Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684334033; x=1686926033; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e3oHRvM4+O+XVaUuEdehDkOXM012vn7RckSkGvna424=; b=icFhsULgagcci1HPvdLyCpxyLUcxAms555BvwaEhGa8XK+iiR9esDZx6DFY6CV57+Z yxPLqags+fDcrRFhq1r68yVuM/2xCs87JViwrNxWgR6a6YblmGrD/J5TH0LI9o2P8Dg5 PWJI4h+I7DYNNruGesXWxSgtqHwl/Z829g37MCdvd7lzudZ0FD0hs6J0hAWxgk4UmUjh /u3LuUtdANIwfBL/8V2GPz0bkqzZND7UFzRUvnry5y6PJOJnWEVa94CKy56haXXKNnii b+v8e8LUSNVHOmaWinQr4wtnvZ+Y3dBz4Ge0vgXmXJsWU8gI2/HLe9tv+HXvr51rlc6k twkQ== X-Gm-Message-State: AC+VfDxVPFKzDVFkNhd23qvs9384pEiehJoisxlU4h5HpHjYeb99B3xp jFC9Avlcq/WbPuUDgav5Qn8O X-Google-Smtp-Source: ACHHUZ62YidM3zKdwt9WsXpqyD57MEzZUZPKzKjSHJhQM0a+oKDUHR+Gn6BJRSHZwAJwHcpYfUyurw== X-Received: by 2002:ac8:5c91:0:b0:3ef:5ba0:7038 with SMTP id r17-20020ac85c91000000b003ef5ba07038mr73060971qta.21.1684334033429; Wed, 17 May 2023 07:33:53 -0700 (PDT) Received: from localhost (pool-108-26-161-203.bstnma.fios.verizon.net. [108.26.161.203]) by smtp.gmail.com with ESMTPSA id d19-20020a05620a159300b0075914b01c29sm645867qkk.70.2023.05.17.07.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 07:33:52 -0700 (PDT) Date: Wed, 17 May 2023 10:33:52 -0400 Message-ID: From: Paul Moore To: Arnd Bergmann , Andrew Morton Cc: linux-mm@kvack.org, Arnd Bergmann , Russell King , Catalin Marinas , Will Deacon , Michal Simek , Thomas Bogendoerfer , Helge Deller , Michael Ellerman , Palmer Dabbelt , Heiko Carstens , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "Rafael J. Wysocki" , Eric Paris , Dennis Zhou , Tejun Heo , Christoph Lameter , Pavel Machek , Peter Zijlstra , Waiman Long , Boqun Feng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, audit@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH 4/14] audit: avoid missing-prototype warnings References: <20230517131102.934196-5-arnd@kernel.org> In-Reply-To: <20230517131102.934196-5-arnd@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 72D9A20014 X-Stat-Signature: z7o6fdsr3e4h88t3j6amusdebu4brd7k X-HE-Tag: 1684334034-407307 X-HE-Meta: U2FsdGVkX1+R3oGODJ2TW90iLODWmzlxNv1/vl/Jxks6JGoxa4iO72X0JjxczbPsC6NYoKcrLhHVwUm52Q++55euuVJ6SJWLNFJhchk4rAiRhu2NmzulHYPW1jowScQE0S8US3EY+Q8Q5v7cOB/astdYgYD8yImFY3XV7D25Zy9b7MU2910V/7j3jEVUSAFRNxdDiHlHaOmUlRQfZ2NnlgOU4v9zjK/2PeN7Dex1BE2xdsvAojJlX0034JkGpYxb0JZB82ngHUmgmeJYv94FATRouxZv/Q8+hbjKpjN8IrFCn1kCY+zgA65I8ETYFeey4/lfeBzCvkVSI6ALCirk74biQJN3RjcptTwyaPpCowWla+VoOKD32ENwnL9byr9vTBPt0jZn5/C8WRV6qHeOod6V/iMV4EAtOok0o6g8koSy8eU+Ng9reuj37BVQ5n1Pca2o+PcDJVHgMaH69KiFxjo1fuLcFxsb8pinANGRMDjgHP9aV09mYd3GcpXwXKtv9m38G615maLZideYM1TJOkGmAbLFYF9jEQCMMJm8LDP8UpBAty1Y74STDLuxiGU32dw9+FDTRtpzQ0cZ4DWDhyUQT34+NHfm6pkg5mMPDIbilncvhDdVipaGS9hOagJLfh4NZF3ygZpQ5d2jIaqyu8/qfvKvAE6uGTBYodcEJSFK7zPUP+OpXygVTxIf3fwSb+duR9iyijZYf2O2WBqR8UtuKnkSsIOtdSn5zZLfC0VWZE1qpfATGxpNaMczYri8fW1WncyepV5WKon68HOLLNqajZfkkcDbFL5G1XYGtFOH6Hqf1EDBOmdC3SqnNvI1jpaJCW6kHuPrfOl559vzF+UqieFHkVWg0v1yOf0y/DrD6qe+fl6ngdwwh9qvyEDlb/aabSJoUkjflItV5zpz4xD6fUkipJYDyjnvxgeU2C/Hcg7XcoIo6t3/fY/d83G47niNxSHzJItT1LFEWv6 u6h7Ekxj n+OxKRrKoX7nhgIoFwBMzc+zc5a2gZuaVZJgVFbFGGFa65+mmjwdr1XjAiOfzmJDWrRtmZIaE91YHFzrkilg+Fj2E391sGdkL9Cd1K0OegYXLHxM6TvNeJNClupUeL2C3Xds2WVF4bYDiAMsv7VJM10RgocpsRV+Hy8rVRGlcyAYWnwzulH0+ofTOgHw8s6i1t4EupxC+De4cQtTBORIk0Jffhf9oudvE+2tEe/+vnhXj2EKBJklnd/2T7MfClXOpkOmXfEvBy0P0FGQkaS/eDpNzjq08KaX1UGHtuxrfZeiIU8W+OwP9Ofx3Le2+ttA74sBv810KdEK4TtnGdSIPnMBOrFth1EZAtjVysGNbzSsR/4gXx4IrWzF118OkcDDj2gWPCtJa/637bkn0qivHCuLxtkcciOu4prjjL5XNLvZoZqy+AqfWJDnwwI09BCNN0veZ4BczWpWb8q2/pA25q/dBylY8Gwu+k7P7yC2S8mLvVnh4mlptOIXk8yhoy7c9SVgq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On May 17, 2023 Arnd Bergmann wrote: > > Building with 'make W=1' reveals two function definitions without > a previous prototype in the audit code: > > lib/compat_audit.c:32:5: error: no previous prototype for 'audit_classify_compat_syscall' [-Werror=missing-prototypes] > kernel/audit.c:1813:14: error: no previous prototype for 'audit_serial' [-Werror=missing-prototypes] > > The first one needs a declaration from linux/audit.h but cannot > include that header without causing conflicting (compat) syscall number > definitions, so move the it into linux/audit_arch.h. > > The second one is declared conditionally based on CONFIG_AUDITSYSCALL > but needed as a local function even when that option is disabled, so > move the declaration out of the #ifdef block. > > Signed-off-by: Arnd Bergmann > --- > include/linux/audit.h | 2 -- > include/linux/audit_arch.h | 2 ++ > kernel/audit.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/audit.h b/include/linux/audit.h > index 31086a72e32a..6a3a9e122bb5 100644 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -130,8 +130,6 @@ extern unsigned compat_dir_class[]; > extern unsigned compat_chattr_class[]; > extern unsigned compat_signal_class[]; > > -extern int audit_classify_compat_syscall(int abi, unsigned syscall); > - > /* audit_names->type values */ > #define AUDIT_TYPE_UNKNOWN 0 /* we don't know yet */ > #define AUDIT_TYPE_NORMAL 1 /* a "normal" audit record */ > diff --git a/include/linux/audit_arch.h b/include/linux/audit_arch.h > index 8fdb1afe251a..0e34d673ef17 100644 > --- a/include/linux/audit_arch.h > +++ b/include/linux/audit_arch.h > @@ -21,4 +21,6 @@ enum auditsc_class_t { > AUDITSC_NVALS /* count */ > }; > > +extern int audit_classify_compat_syscall(int abi, unsigned syscall); > + > #endif > diff --git a/kernel/audit.h b/kernel/audit.h > index c57b008b9914..94738bce40b2 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -259,8 +259,8 @@ extern struct tty_struct *audit_get_tty(void); > extern void audit_put_tty(struct tty_struct *tty); > > /* audit watch/mark/tree functions */ > -#ifdef CONFIG_AUDITSYSCALL > extern unsigned int audit_serial(void); > +#ifdef CONFIG_AUDITSYSCALL > extern int auditsc_get_stamp(struct audit_context *ctx, > struct timespec64 *t, unsigned int *serial); We probably should move the audit_serial() and auditsc_get_stamp() away from the watch/mark/tree functions, but that isn't your problem. Anyway, this looks okay to me; do you have a problem if I merge this via the audit/next branch or were you hoping to have this go in through a different tree? -- paul-moore.com