From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E71C27C52 for ; Thu, 6 Jun 2024 07:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E2036B009D; Thu, 6 Jun 2024 03:14:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9694B6B009E; Thu, 6 Jun 2024 03:14:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 794806B009F; Thu, 6 Jun 2024 03:14:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 56AB96B009D for ; Thu, 6 Jun 2024 03:14:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E25C1C1568 for ; Thu, 6 Jun 2024 07:14:32 +0000 (UTC) X-FDA: 82199600784.02.DB19201 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id A3187100007 for ; Thu, 6 Jun 2024 07:14:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RnBmSAf2; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717658070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4kZNcpCV/fHXWr0HHYiTQCGP/gnLmEScCvTPVT0WHMI=; b=SSLGx6JdqzZhmes9I/DD8xC0Mhfn2zcgvN95lEJDTp5/3UsvFz2CCD98JnjNo6j9kSzvk7 fKutRVKtDx87R77C35hCV5u9tAXKJkA+svzvi4YF6pHd85YBTnZx7s5iQBiMU3FaiZEpBZ hIc76XEKRKJtP3n9hMxk/xQSj80QYuI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717658070; a=rsa-sha256; cv=none; b=xWEScZKOYY9gQIFPSJ39EmBccvRYd0FkUQilrr1VHJyLd7nD1ti6rI1VQ6am+DakaV/0gz KHxFcEd1/wr77dEHQB3YwAyerfrikPMsJ1PWhrl8F45exNIleqnjVwzOYj8IvMjHcb6d6M +VRNs9RXBBJSkPAAuac57GJBlKJp3hc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RnBmSAf2; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717658069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4kZNcpCV/fHXWr0HHYiTQCGP/gnLmEScCvTPVT0WHMI=; b=RnBmSAf2UTs16TkrTwV93cvH0GwDf7smFtGlqgO4sNX0wf5WRQqMrH9VhTzTs4g1Hr+yS0 Y8XSs6Xo83vK52O94bdr61or0VKpa5zBtckPbRtY3OfwUXtJHzMbwfsi2out8iDngLyJQv aBvYoEaEh9nzmdSQ3dL31JrjV3w4FqI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-kZ5nj3HaNBW-gaWJC77VRg-1; Thu, 06 Jun 2024 03:14:27 -0400 X-MC-Unique: kZ5nj3HaNBW-gaWJC77VRg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35dced40d17so473697f8f.2 for ; Thu, 06 Jun 2024 00:14:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717658067; x=1718262867; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4kZNcpCV/fHXWr0HHYiTQCGP/gnLmEScCvTPVT0WHMI=; b=XiqLHXcr6FeFsOCapFAlz+8Vz1Ed0iH+goHOYW4BiZ7h85G8jXXkyAsSp0foqy2dRn LLUQG0Dqz6/lqR5cU8ysc/ELuc9hyFC0V0rUJrFygHVt5u1Mm6YzxzCCnp+NwLfykAbu NbyCFGZ9skWgcu1Ft+hatofybUlEbaCoLOPSsJSZxDe8hmTZFA9ee1xYbk1SO86isL3i lHad7NdCURU2FBzAo2N4wKeXQ/QHsI00VHZQHH192ezLRoMqYGONnUllBr3+8L8Haj4R SkfWH8KJbg55VXjD8sCpsw4lWXSot7cRN2qLazdmXtF7Ue1FwbYh5eBXbgyE1Nz7k3/u /S2Q== X-Forwarded-Encrypted: i=1; AJvYcCUofEBuRgZLvbZwK03BJwjRXqw2MIXB46Z/ratFmBLSdEC3Tag1cuH06zzmL8zCbDO3Zi08M7EazDtJaxjdhm7cJ9g= X-Gm-Message-State: AOJu0YzBHQBPtVYtOCiitOnrx5G/+jKONrDN19NExHFsyILwXyIs/PfO PdV7aqjE+ojuNMQP1BwcAjajpLqZWMWFap9Cz9PbGx5oEzTuaxRwcXLCxYnyEKykcXeCRZFg8Z6 4dWvQ8gf07h+8+QVM+pJxjYFi6/W+0kaQuUFdWfJOdd4pFYSV X-Received: by 2002:a5d:47c9:0:b0:354:df59:c9a4 with SMTP id ffacd0b85a97d-35e84062d0cmr4662434f8f.9.1717658066725; Thu, 06 Jun 2024 00:14:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhiNCq7I9jIMCaIOKzr4195wanEzxWWCIts7J7gsi1sXMo/y6d6mUgK5UJgTgTCaHlu0kUhg== X-Received: by 2002:a5d:47c9:0:b0:354:df59:c9a4 with SMTP id ffacd0b85a97d-35e84062d0cmr4662413f8f.9.1717658066271; Thu, 06 Jun 2024 00:14:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:8800:a73c:ec5b:c02c:5e0b? (p200300cbc7108800a73cec5bc02c5e0b.dip0.t-ipconnect.de. [2003:cb:c710:8800:a73c:ec5b:c02c:5e0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5d696fasm759638f8f.59.2024.06.06.00.14.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 00:14:25 -0700 (PDT) Message-ID: Date: Thu, 6 Jun 2024 09:14:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: increase totalram_pages on freeing to buddy system To: Wei Yang Cc: rppt@kernel.org, akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org References: <20240601133402.2675-1-richard.weiyang@gmail.com> <0316a276-a0d8-4fc2-ad67-0d4732b6d89b@redhat.com> <20240602005820.2uk23ot4mskfl5sl@master> <8297c4d3-f97b-4923-9b27-19294fa130eb@redhat.com> <20240603200123.bvkttf2yqutecjtv@master> <9fa4f1be-790c-4823-aff2-f864807759f1@redhat.com> <20240605224401.re54hhnlkar5akfm@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240605224401.re54hhnlkar5akfm@master> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: rhxczypaf37ejgzu9iu11aq64cew41oz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3187100007 X-HE-Tag: 1717658070-201861 X-HE-Meta: U2FsdGVkX1+QFq5foWif4AqyKfwKtdU1sivMqNQnHiojLvZOWvkMrQ/J3LJWSrpMn8YyRk1YZ0GAPts5gCQZ8ybS3mZ9yQl6laQJODhN/f+NhJO6AUIiFpzov5xF8l0FKzO7SbvLw4Pk9th8p7OnYCvZpiW1wMnFwiOqe2ZJiTKq4uPAn9o/b8BbQiqf/jODQDAJBKTPzWvNimdFuvCCGEff8+78IzHRqyp7t+iT28SWPgSQVTEs5kMK+9AZF3I+20HJPFBJiD88p68mWPNHaqoR8ZyL306tMqrfZ+2YCXCurVgKWQfDA6BtLdo+mh/9CyvKvExuRgzFp75vc7Zhxfs5prLR2ycBRuO+l2JuEAR2MEZtkspo+8y/1CiE2a+xy35c0GCRaNiyEAyh++1ccJlGKa1mb1tWx+/L3rSo2k41hT7scao71I1ZSaGKvkCJzlMxYnqfrw2oxvXm/0bNDy7I0kFX1hpcxk/hr7hfo2HB6+dZD3ybo3OsZWvtEj5o8U9/+BND0/TeB8d+wbgfS7HDUfTRAw44aqbmZv3iU/LP0h+/QwBlLB+TnH2CSYqgl4F1AkKf70Wc+MhGLMCCBGqXmmbGjkKvft3WhGfi2VqLfDMolrzxFjG9JY/+HiY+3+qPTLaQlTsdA8Yv4XaKGtJ7pHRDaSA2ugOmgFHdRxJRO6K8rWoxBMXGiJFZCRX26TflChlqQjss0Hqrtj0TvhCAfUVYKAb2WzdjEGRr1FWMY3BI3BSfHRYSvc0Jc9tTViD3/tNvSkz6gEg+1qcV890zR8OJKtAoxtcNK3yhSSfhjPtiWSf43q8iXLUzuR61pb3qbd0o5NViVg0ifgJLuddcdu9xAtSfnEoGVWCVubWaygNBIO2XmFhsAQsonWOx4BzywwMteUGTRaVQ9rPYwaExpLMTdkoDq0l1H3Xw47h3yrAwzl9idUjHCLv7v4DgW7+IVmtPlxTUVDIhYFS ThXvVvId OTxwgdGTg4ooRR9AJ/zE8pe8JqMoqkhbuVs4PLUH+2svlWAcvCwfqJK7fBqbjzkcLARWib/bPZW89NQaacjpBzaI8kE3Zpp1zjghICiZiDmaU0s+eJDjoOzTOkZvVI+A5Dx8GW/Tj/8s8Y2MhysO2yRWNvjua8b5cHeAXqFVXGtV8eS3r0vEa9N5Gd3F2z7R3jPjWCGrGHXJoK+DSbP6xLaVn43JRQwwulxCyUffIFCa37ACNSPHhFplomdw8fqw7VsJX2jM27ZR8qtKChzlh6cYVu0gHL52qb0AYbBuryfEiSqQP5bnBqbeYLIGobMI79vnyMOeZhYTlpmAHDUG8ceaT6X9A5KOQHndvIbTbOwc85YVtn6VfT++ejE1XEmNAxH8P0SEyEbmXj+UT2DL/PRpv07HAnQSxGT7Tf9pPIz/tjtEO21zqobOtWvVAag1HRVKdkNXf9RDQI1+JpasL0kpvUVOwMXl+ODkPEiE+G/hRW4fbi5LRpIDLe1rztbvMRffoFCb9Mtlh4fn4K/mXhbAORPqG1kzVn8OG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.24 00:44, Wei Yang wrote: > On Mon, Jun 03, 2024 at 10:43:51PM +0200, David Hildenbrand wrote: >> On 03.06.24 22:01, Wei Yang wrote: >>> On Mon, Jun 03, 2024 at 10:55:10AM +0200, David Hildenbrand wrote: >>>> On 02.06.24 02:58, Wei Yang wrote: >>>>> On Sat, Jun 01, 2024 at 06:15:33PM +0200, David Hildenbrand wrote: >>>>>> On 01.06.24 17:32, David Hildenbrand wrote: >>>>>>> On 01.06.24 15:34, Wei Yang wrote: >>>>>>>> Total memory represents pages managed by buddy system. >>>>>>> >>>>>>> No, that's managed pages. >>>>>>> >>>>>>>> After the >>>>>>>> introduction of DEFERRED_STRUCT_PAGE_INIT, it may count the pages before >>>>>>>> being managed. >>>>>>>> >>>>>>> >>>>>>> I recall one reason that is done, so other subsystem know the total >>>>>>> memory size even before deferred init is done. >>>>>>> >>>>>>>> free_low_memory_core_early() returns number of pages for all free pages, >>>>>>>> even at this moment only early initialized pages are freed to buddy >>>>>>>> system. This means the total memory at this moment is not correct. >>>>>>>> >>>>>>>> Let's increase it when pages are freed to buddy system. >>>>>>> >>>>>>> I'm missing the "why", and the very first sentence of this patch is wrong. >>>>>> >>>>>> Correction: your statement was correct :) That's why >>>>>> adjust_managed_page_count() adjusts that as well. >>>>>> >>>>>> __free_pages_core() only adjusts managed page count, because it assumes >>>>>> totalram has already been adjusted early during boot. >>>>>> >>>>>> The reason we have this split for now, I think, is because of subsystems that >>>>>> call totalram_pages() during init. >>>>>> >>>>>> So the "why" question remains, because this change has the potential to break >>>>>> other stuff. >>>>>> >>>>> >>>>> Thanks, I didn't notice this. >>>> >>>> I think having your cleanup would be very nice, as I have patches in the >>>> works that would benefit from being able to move the totalram update from >>>> memory hotplug code to __free_pages_core(). >>>> >>> >>> I got the same feeling. >>> >>>> We'd have to make sure that no code relies on totalram being sane/fixed >>>> during boot for the initial memory. I think right now we might have such >>>> code. >>>> >>> >>> One concern is totalram would change when hotplug is enabled. That sounds >>> those codes should do some re-calculation after totalram changes? >> >> We don't have such code in place -- there were discussions regarding that >> recently. >> >> It would be reasonable to take a look at all totalram_pages() users and >> determine if they could be affected by deferring updating it. >> >> At least page_alloc_init_late()->deferred_init_memmap() happens before >> do_basic_setup()->do_initcalls(), which is good. >> > > But deferred_init_memmap() will spawn threads to do the work. I am afraid > do_initcalls() won't wait for the completion of defer_init? Do I miss > something? Don't we wait for them to finish? /* Block until all are initialised */ wait_for_completion(&pgdat_init_all_done_comp); -- Cheers, David / dhildenb