From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26919C71157 for ; Tue, 17 Jun 2025 08:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EFBB6B0095; Tue, 17 Jun 2025 04:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A00B6B0096; Tue, 17 Jun 2025 04:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 867CA6B0098; Tue, 17 Jun 2025 04:38:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7263D6B0095 for ; Tue, 17 Jun 2025 04:38:16 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 31EB51D893E for ; Tue, 17 Jun 2025 08:38:16 +0000 (UTC) X-FDA: 83564240592.04.ABA68D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 7BE844000A for ; Tue, 17 Jun 2025 08:38:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uvg6+MA7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750149493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmqTo5X5o1GGUk3Ji6SPTFrK3ZJSli4Vt2vgFzwoTIg=; b=aj15MNdWMHL27LGj/PD/vw0KmbiScLCORv4hXNBYHVIYe4ktNHA9fF0Ws2VBFtwMTJqJSc VET26Pv6onmtVGwcRSlfhP0aDgeRKmbIcl2f/6AJuNZ7XyLuBZxZMP7HojvVmTxCEejEm8 XJW7wCRo5glPSLy65jMrEWcw1w/8T/8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uvg6+MA7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750149493; a=rsa-sha256; cv=none; b=tfM75KpiVAA7aUmdmLAgEQC/Tt+Wxio5pwk3QF6a6/Hq4umODQKNF8Erl8YK6/jkUhujSu nu5uIn+Y9JUP3hvyz9cJ3F+DV5x72iWMtOScRlvdnffSo5XBCScMMCvJQEQrjspoDXhOzx ChdO3R9DvhAuhgwMKz/KJzTRI4nmp5U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750149492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MmqTo5X5o1GGUk3Ji6SPTFrK3ZJSli4Vt2vgFzwoTIg=; b=Uvg6+MA7iTYBhXMJJikMFVlcmSD9jO/U9rRCKWbPUxLgrjF5aAHKgIwwBWiSJayVNtOjOx R2CMx/K9zyIX8tItQnHeNzfO6df3a5NFn1cOXXcqQ2iTjiMfclaaZc8SVTh5Ko/Kn3LuWH S7z8ajRZn0tP+2B4m1ng4KL9XkKsS54= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-iY6mRnZnO1mexil8pX80JA-1; Tue, 17 Jun 2025 04:38:11 -0400 X-MC-Unique: iY6mRnZnO1mexil8pX80JA-1 X-Mimecast-MFC-AGG-ID: iY6mRnZnO1mexil8pX80JA_1750149490 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4530c186394so23560255e9.0 for ; Tue, 17 Jun 2025 01:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750149490; x=1750754290; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MmqTo5X5o1GGUk3Ji6SPTFrK3ZJSli4Vt2vgFzwoTIg=; b=Zgi+CiKFFWCD5ZXeUELKW8RIhcV5bycUrAYbSwWfRJoAFmI2iXTkAwCVV9F+2/1/uK UJiRQKxZwd9AedXvSfQfVPmW8cDuYMxPaqdZByIJQgPTzXtr+NPipybS2GCsMiQp04/k CrAuT/rmDzZRjCD8WLh+vqqhKOKLnoSw6gS4etm9Lcv5PvupALF8bgwtCD4kmo7YvN5k LumV0f+mBNUZ/5Es37QGz10AQwGXb4kdyRJFTJTIWnSKkWa5Eqm3Imch+gpM4z8sqpRJ GONaFSGxXIlQQDHzVARp2haZX39IP+5WYBRaIAsRoB7EEPuyNKIMl6Wcm9XAEG5U8ikw Xymg== X-Forwarded-Encrypted: i=1; AJvYcCUC9I3t9Ce1i7kP7SrdXU4NyqgGySBzMUGkdmmXEaIa5PRqYTgfWH2jxMEeAUgmyEEmjtylLdzXLQ==@kvack.org X-Gm-Message-State: AOJu0Yy4u/49k7bnlRizs3EepNSJ7bfMzjLya6Ch1y0KQDusqUxuOgG3 dNaOhn1lO3eR/0hW5yWxSVjt4gY4cQkR80cxsSitjqBnvAic7QGgUTahFJwi7N7+bjJzQkJtpAb M96kmyv7AZoOehYTMoEJVU1g17TdkSyL4t238tFfiFcybNPAlRLnn X-Gm-Gg: ASbGncuwcGHyAZGVDTAtvc2qCC0N0w68QNJTZvkDTnW450tb0LW0pGF4d83hbsw5h8K Xd6LFMKwsT3e9TrCrXIHbiX8NehKlsY6DenLHuhztO5xXP4vfGw5xMViX+mlrqAQ0fWedCbEsbr k/Co40mk7+u/pJL6aHj1OYazm+rSeUHpWuLCPXpXHyi/5MSowrZ3i5+Hg03tD6ig1J+91PzE5OV 0OHQQ5AONXxxy3BHpDsba9tlhp+Xm3H3Y1F+W6XmSHzsv77gSmQCno8sGE2O2AkW+EHDFX0NFcW 374mr/zLo3x3zMNAUsEf+u18sx+kBdJt+SI5o+I8eqoieIxe4jY7UjRVfLQl9aT1+d9pmymcy9S FrMwYRwnDHqKsuN7UGPpymuAErrK5V6cwGBI3qYaW0vcN1Xw= X-Received: by 2002:a05:600c:1e1d:b0:453:6ca:16a6 with SMTP id 5b1f17b1804b1-4533cae690dmr142720855e9.10.1750149489820; Tue, 17 Jun 2025 01:38:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwdczGKW+8rdzPsG3SMNQ+s4av1P7w9f37iq5/ml4P7N8BTaO+qi3Vfd9hogmNw30QeplGMw== X-Received: by 2002:a05:600c:1e1d:b0:453:6ca:16a6 with SMTP id 5b1f17b1804b1-4533cae690dmr142720585e9.10.1750149489413; Tue, 17 Jun 2025 01:38:09 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320580af6sm193492425e9.1.2025.06.17.01.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 01:38:08 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 10:38:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/madvise: initialize prev pointer in madvise_walk_vmas To: Lorenzo Stoakes Cc: Lance Yang , akpm@linux-foundation.org, 21cnbao@gmail.com, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lance Yang References: <20250617020544.57305-1-lance.yang@linux.dev> <9e80cea5-fa78-46a2-b2bd-2f3846c24a34@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9e80cea5-fa78-46a2-b2bd-2f3846c24a34@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ue-Ri3GDN_PM_Mg8g5lTq9T3CBLPQALXKBc82URrcYQ_1750149490 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7BE844000A X-Stat-Signature: yziff7nwp75epu6z6oac7zq8ka818acs X-Rspam-User: X-HE-Tag: 1750149493-126581 X-HE-Meta: U2FsdGVkX181FNb9syCkFKkabK2FRpprG1dJ1FHeLjUpo5pUvGhW46SmdEuvApbM2twno8FtJOWf4vycDrg0nnSYBEh6ucNdDw2YGjL9S+iv89ZuU34slRMXati2A2hbLczvsEHeVdR4FvGF9HDrXWKWzPI3Ezhv9yyOdbTg1XSMrBCCKN0W22abwGlsyN5pLDnylqU3xxoWbAbWlRCRzsm4OOnxDn8jv6HtJB7mdJKRsyKHARyestlAq9AzrwhOnbrcXSUaX4sRSnm5gnfsI8UGznOTnVHPmtNgGoXw1VlYxISGhZSE35zqe505waC3D77Il+4RQxxFKb+OZmVy0+15LOW63OGQaI8eDa9BR3kjDjozyBIZci2Hi90ZnjsmkbtDwyErBiIkU1cNls+ni8dfk5Y4cksVlWz1NetYiP6PZcSXrK9XjoQ6fychJp8S9fACZZ4oHWfEArEvGktX84iVUKqJOtuEAG0y4wcCSgaxeIu1bHtAcguw9jEID69CQvgW6PgXNqX6sqJrJV1LEQE3goK1qN8BZavvXwha8WU3+GKflPhLFjgaRwtUnmYX6rvciHnaVOnSLHFbOSmskCEYGBW0xhpQulsnSe7eh6Lov9u7/NqCJDJohgYRg4mdwCLo2n4s51iOn8wDP9cj8+MFvVUoF/9FrCY+Ya1soqxNq9VsNpkZfKdZAH/bRjTsVrVFHgvT01BATammvakkvVD8OYgfEz9kpbxXhg5hQojDAK1ZutcPHpKInZA6166HHzxPTfnhkzuf0u5L70Hr+Zn0NnZbwX7Tu1kwjt5DYSl4rBQfAYryHYAeU2F8jHjT/ZfnKTUU+T1j0wGZvsqKfQHRi1TAjsS3N2CgcAb2pbVbRGiCrpVE7l0kjzQzeFb6x2FfokORQfF9g2xwRANmgnmw2NSb5+h+zJ9jfMHhaztYKOutp2Iojf/A2JBPeiy4x0pRuj5MBG8MDT/05LA TVmQWdXy bIQ/nkUllxvbO1QRjBhrDZD8P+16OEj8FCP2PJWjbt3A7bQ35mXtDzIL2g+7SVsIPL6BwW0n2DKMYly6MvLOoaQKqzNRk5wngqYGBumsmecrZh2U2ywdtrWrPLTY3iklEPzo4ZiWkgb7GeyHgl2yhuw5UHHH4Q9FSu09Y6Z4zS1xWG5Ktfp5wf7Om3BanjFLzeNdYXy/sIkYuOu1+tMyVEb7rujVyBuCUChIw/RsxnKiSDsMY3YcOh6XzNHXUCj7fAnZ5Wh0PxfXtzBpgVbNMMXFjYSiRhpQW6+iM5q/DiFahWim3eprGCbo8/t3Dmo5sEDbQneNFzyO1GWnuREXfUrxW9wNRswkBEElZRDTVXwVXyCt4ZMqd1PtSFJjVn8yorGQ/dNh8INQeEGifbErmU4KfKu0ddn/gBnHUAkzu4PtN0AnEnrNd8BlYwE3qpqAqIQQ+nQMjbX1v56OFiQg16Le2gtcCWPZNmjILa2dkdB3Nex6Mtm7ElMCIOd7IQ9sjENfZengB87K+KUNjHZuBLL6Kh3JRyatasP0rJbQ9Nl5BhLnzSmAZ2wq68CE+z4LQvAZZgd7Y3dMoRF+LLUZQ4av5iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>> vma = vma_modify_flags_name(&vmi, *prev, ... >>>> >>>> We should use Fixes: then. >>> >>> So no we shouldn't... >>> >>>> >>>> >>>> Acked-by: David Hildenbrand >>> >>> Sure? :) >> >> Unless I am missing something important, yes :) > > This solution isn't correct as prev == NULL when prev != NULL is wholly > incorrect. I am not able to understand what you mean :) I assume you mean, that we reach a point down in the callchain, where "prev" is supposed to be set to something proper, but it would be "NULL". That would indeed require a different fix. I wonder why we didn't trigger this case so far? -- Cheers, David / dhildenb