From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DC9C433EF for ; Fri, 11 Mar 2022 19:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 900418D0002; Fri, 11 Mar 2022 14:36:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 888628D0001; Fri, 11 Mar 2022 14:36:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DC928D0002; Fri, 11 Mar 2022 14:36:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 5C1D78D0001 for ; Fri, 11 Mar 2022 14:36:43 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 21BD5251B5 for ; Fri, 11 Mar 2022 19:36:43 +0000 (UTC) X-FDA: 79233112686.13.3C7F69A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 6BC721C0026 for ; Fri, 11 Mar 2022 19:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647027402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wPUrpfRAqac225NyEd4nrs7asUwgp/J03uajT5hWfqA=; b=ODb/Hqet88t30d9PPigV44qy9132GbWtMnzdvmrmvz4P1HKd9Ev2/+JWOe6CqWsSH7FXOe b33VGd+GshOW/qq6nYYpI9Uuc/cf9n3xLnp0VxkQbjHppKpgYY0C7+PfOOTSNFKYTMoYBQ UjYypYiOVMFb68xtPBDesMW3Uc2yuy0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-wdnLNDIHMnGIbT2Jqfr7ZQ-1; Fri, 11 Mar 2022 14:36:41 -0500 X-MC-Unique: wdnLNDIHMnGIbT2Jqfr7ZQ-1 Received: by mail-wr1-f69.google.com with SMTP id b9-20020a05600003c900b00203647caa11so3166066wrg.5 for ; Fri, 11 Mar 2022 11:36:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=wPUrpfRAqac225NyEd4nrs7asUwgp/J03uajT5hWfqA=; b=DiAoryl0K6i0yopUYEnsDuwO8JgaLqG2xlcdWTm6Zi1YGDS+kDus9M3SOl+cRZh/Uo kdxcZA8yoVasXUFIalQNy7LBxrsZb/RLM6MYBUFp92dBlHF0jD+sg8kwG+BKxGdl+DzS iGAPPDFWRX7d6tXo5PC5InTteP8yfHHXKAqPehE6ejMfnZUgqCvx4LdjuWSioEN2/nmo TjTN2yQF6TfW6EDPMWgbf5PwpIfmdIVYJ8x+MEHrkTWVt/gnq8pbOb8H5/JaBmPqumP0 VCDrWYpeZ2E2tMfXjOHHYe8znwFEbmoPsVj7GQJ77+9V6WLpzdE1TbQToi3p/8WIZhwz pBAA== X-Gm-Message-State: AOAM533mrykZA58knAV0F8Ew9fEau8O2CIHb5BfPBolpLDxxHyrpIYuW q3a+GXpWabXfJPlFmxOzUVmB/yTz63bCawlaTj/iPzHAaj+h6LYp61GXNhqk4aAWPzsXXiuDMSk DpEMiiqGdol4= X-Received: by 2002:a05:600c:a0a:b0:350:564b:d55e with SMTP id z10-20020a05600c0a0a00b00350564bd55emr8525949wmp.124.1647027399842; Fri, 11 Mar 2022 11:36:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmSNNgK3mtCqM8BBLibdarWwsWTj73jvbn2Q9MTbGHUOVZZYQKYfSDUZJrKEFrYJWsCU7UaA== X-Received: by 2002:a05:600c:a0a:b0:350:564b:d55e with SMTP id z10-20020a05600c0a0a00b00350564bd55emr8525926wmp.124.1647027399517; Fri, 11 Mar 2022 11:36:39 -0800 (PST) Received: from ?IPV6:2003:cb:c707:8200:163d:7a08:6e61:87a5? (p200300cbc7078200163d7a086e6187a5.dip0.t-ipconnect.de. [2003:cb:c707:8200:163d:7a08:6e61:87a5]) by smtp.gmail.com with ESMTPSA id v6-20020a5d5906000000b001f0639f69e6sm7631228wrd.55.2022.03.11.11.36.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 11:36:39 -0800 (PST) Message-ID: Date: Fri, 11 Mar 2022 20:36:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v1 10/15] mm/page-flags: reuse PG_slab as PG_anon_exclusive for PageAnon() pages To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM References: <20220308141437.144919-1-david@redhat.com> <20220308141437.144919-11-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6BC721C0026 X-Stat-Signature: 7y4dxr31rrhuu67xhtqjhbzeen16sdi5 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ODb/Hqet"; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1647027402-58491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.03.22 20:22, Linus Torvalds wrote: > On Fri, Mar 11, 2022 at 10:46 AM David Hildenbrand wrote: >> >> - PG_has_hwpoisoned = PG_mappedtodisk, >> + PG_has_hwpoisoned = PG_waiters, > > That makes me too nervous for words. PG_waiters is very subtle. Yes, but PG_has_hwpoisoned is located on the second subpage of a compound page, not on the head page. > > Not only is it magical in bit location ways (and the special > clear_bit_unlock_is_negative_byte() macro that *literally* exists only > for unlocking a page), it just ends up having fairly subtle semantics > with intentionally racy clearing etc. > > Mixing that up with any hwpoison bits - that aren't used by any normal > mortals and thus get very little coverage - just sounds horribly > horribly wrong. I used PG_error before, but felt like using a bit that is never ever valid to be set/cleared/checked on a subpage would be even a better fit: Note the: PAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) __CLEARPAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) whereby PF_ONLY_HEAD translates to: "for compound page, callers only ever operate on the head page." I can just switch to PG_error, but for the second subpage, PG_waiters should be just fine (unless I am missing something important). -- Thanks, David / dhildenb