From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C797C47DD9 for ; Wed, 27 Mar 2024 13:15:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D833D6B0095; Wed, 27 Mar 2024 09:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0CA36B0096; Wed, 27 Mar 2024 09:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD8B6B0098; Wed, 27 Mar 2024 09:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C1D06B0095 for ; Wed, 27 Mar 2024 09:15:31 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 577D6140A88 for ; Wed, 27 Mar 2024 13:15:31 +0000 (UTC) X-FDA: 81942865662.24.E289CA8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 45C59180025 for ; Wed, 27 Mar 2024 13:15:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WlC5zEpA; spf=pass (imf24.hostedemail.com: domain of jarkko@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711545328; a=rsa-sha256; cv=none; b=J3+p4bDIiMQthsfWaLYTa4wt8LKL0eXhnAqsRKP2ETkHFTq3zgiaYwa4Ii8fNEY0xtLFah L5KSvkfV1ueZGI6536H3xCYtIXnoD4P27qUdZ13RFzbiddURedHMAUyLKqvVHyYGLJtejH T98ZPDXM3m8rP4jQpyGWgfOfnhqSn5w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WlC5zEpA; spf=pass (imf24.hostedemail.com: domain of jarkko@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711545328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hVWGFMnT3NSh/Y5bcfvnFJ7BOfpWRpHZTt1+sFeRYK4=; b=GcU7xlKV/OVZMEtKDFqDacPtBd9jP0sCGFjCoibzUmAVyPmMAyEjbXe/MgiHAGiQbJqcEQ FHO/O4syikrC/Dx3Q1gTn1s8vd5l39t7X525lhyCajQIjGYMKUotFJJz7apw9g3ni2utuM FVnOfz/36T5a01GAACzGxfNnedoNRZU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A2109CE1B2C; Wed, 27 Mar 2024 13:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24B85C433F1; Wed, 27 Mar 2024 13:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711545323; bh=hVWGFMnT3NSh/Y5bcfvnFJ7BOfpWRpHZTt1+sFeRYK4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=WlC5zEpALyHcMLL7crzKzm7z4rnrwW8uowh4E59sISP/prn0iAEbwxHXS7+uKc/Bw wqYGQilNWFJ+5kfznbP5jYfOcjMrK1brNMdB9bdD3SvgfimE43gkSodM2ShnLCFCEv dajJ3Yz10qJsLnDCfEhKopyfEJq0gvIwVYovDawkfcn6oHnklPZtey6rVEgLmyWPEW E4PyqpPn0WepobbP4ZCzTB0lH2Gu+IQbfjUU9TXdLpBKot4bTj6an5nQ1I4caHFct3 xEXFx6xrVEhsmAkJsShcH7vHCWmfF6SFD+e74pyrl9dxggHDC3ksSqQCHRrsdwas/m v4ecGkxzUp56A== Message-ID: Subject: Re: [PATCH v4 02/14] mm: Switch mm->get_unmapped_area() to a flag From: Jarkko Sakkinen To: "Edgecombe, Rick P" , "keescook@chromium.org" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "debug@rivosinc.com" , "akpm@linux-foundation.org" , "Liam.Howlett@oracle.com" , "kirill.shutemov@linux.intel.com" , "mingo@redhat.com" , "christophe.leroy@csgroup.eu" , "tglx@linutronix.de" , "hpa@zytor.com" , "peterz@infradead.org" , "bp@alien8.de" , "x86@kernel.org" , "broonie@kernel.org" Cc: "linux-sgx@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-mm@kvack.org" , "linux-cxl@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "io-uring@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "bpf@vger.kernel.org" Date: Wed, 27 Mar 2024 15:15:17 +0200 In-Reply-To: <5b585bcced9b5fffbcfa093ea92a6403ee8ac462.camel@intel.com> References: <20240326021656.202649-1-rick.p.edgecombe@intel.com> <20240326021656.202649-3-rick.p.edgecombe@intel.com> <5b585bcced9b5fffbcfa093ea92a6403ee8ac462.camel@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.0 MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 45C59180025 X-Stat-Signature: 4w8ma1hpec4afr6ph3jdh3ksxqxj5yxb X-Rspam-User: X-HE-Tag: 1711545327-471265 X-HE-Meta: U2FsdGVkX192TEnb8zjVv3fErh6xh5bRs6w6EjvrxODFU5J2UqpqskjZYLwaz5dKTq7M5q+cWfiIY7f/emhcyO/5fsCxNb5DqqmKhRZPlHEhmA0S/xD0syW/RHaB5VXEjNzjzEBkmrQG550CR9xBLYZviL3OOh7iYaKA98Q7Wc+pwE8K38CWQH1Fj+yQhDcsfI/7XbrthuFQi9yZ2tH7B9n+XwWNRItl9OyXiNCSl+5HhE7tcoUa4FMZklih1saKKvTplrGCKeQS0zNxm0/4j7hM2sYdVxTFm4O1n+kSLhVRzo/F0C/2yng21mAfhJjqNDZQzww/xGKhoDlOBLN3J8FHgV+gk+B63vnmpBeYcCuNxL/O2TBja5CzISD8FhW6Q9MLCSHfGNV2qy8S3TPzKQ6rsGMTOZPRhKa2UuoYT4J9tw8aiyWlK+9LcVcHGAwTnAmtQuQIJ/SpQPLDPgu9+ubgTcqW6NVHNw9ZzuBKzqeJb47FnvJ06hxz5/Pbi5qYzXErfdLHG/S0URxQpWr9lmbmtBQgd6LWwQARMlpj1vBnTYn0QvEasZEm+tNp/dNVHGebuIMeXwo5beye9DW406oFM24qWeJ7AW77Lue25anqEs+VZMmzneXZd5tDsCbWPaRHZGidmfPykzEEoMbjeSvBCSZZU3WReLPUQRxx0Mfn77ijtp4NNTdkrOihb3pgDXC+YjsH74TtsfDPQL4DPbT4atYjRQ/TQMeVVqkUumrhif+73MB5E/GddBFAjNTyKyH/LdAfpHdG+QDVwyE6Y1RqXdtk+GnvdVViXfrMCUCNQEsmIdhEZQHhg9+NZjbmV2tRGnjv//C/7rgKlA+dWyG1hnbcAWYH05TnsD6rUIM2mp3bpMNKKQjMfy3jlQIG3ETlxwKpi4/pjSYbFraxfLEu6fSj/vdDphQSCo/lBjFrnRtOxoHthXdZn8JBZhR9sqIQ+h+HpGfv/rVwy4s jtvPjNN0 Y8x4RxEe5UNitIm5aLi+fmv5dva1LGkzEFMnNem4Zt6g4YJtH4AfgLC4GP/GilcaMSZfdUAg0yGym8I7Qdz+uSczLl/yvYMVD3MdjsFDn8IFNMi6ZgfE3BnvDkS30tsYZuiApP28zpkmav48AJw+TPMyrbRFRk+bQ9HPV/AmIkFVpfo9GDEGgGqSebu7oldlcN1jOorv+7snEm3DeS05RDbVN1UR4Off7wtHc2lb8IebnkKk0YBX3lxLsu+U14Qd6mKaxeNAviZ1UvVrvPKt9MatKeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2024-03-27 at 02:42 +0000, Edgecombe, Rick P wrote: > On Tue, 2024-03-26 at 13:57 +0200, Jarkko Sakkinen wrote: > > In which conditions which path is used during the initialization of > > mm > > and why is this the case? It is an open claim in the current form. >=20 > There is an arch_pick_mmap_layout() that arch's can have their own > rules for. There is also a > generic one. It gets called during exec. >=20 > >=20 > > That would be nice to have documented for the sake of being > > complete > > description. I have zero doubts of the claim being untrue. >=20 > ...being untrue? >=20 I mean I believe the change itself makes sense, it is just not fully documented in the commit message. BR, Jarkko