From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 0D2096B0003 for ; Wed, 8 Aug 2018 01:36:21 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id f11-v6so935206wmc.3 for ; Tue, 07 Aug 2018 22:36:20 -0700 (PDT) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net. [217.70.183.195]) by mx.google.com with ESMTPS id o4-v6si2705355wmo.206.2018.08.07.22.36.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Aug 2018 22:36:19 -0700 (PDT) From: Alex Ghiti Subject: Re: [PATCH v6 00/11] hugetlb: Factorize hugetlb architecture primitives References: <20180806175711.24438-1-alex@ghiti.fr> <20180807095402.GA12200@gmail.com> Message-ID: Date: Wed, 8 Aug 2018 05:36:07 +0000 MIME-Version: 1.0 In-Reply-To: <20180807095402.GA12200@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: linux-mm@kvack.org, mike.kravetz@oracle.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org Thanks for your time, Alex Le 07/08/2018 A 09:54, Ingo Molnar a A(C)critA : > * Alexandre Ghiti wrote: > >> [CC linux-mm for inclusion in -mm tree] >> >> In order to reduce copy/paste of functions across architectures and then >> make riscv hugetlb port (and future ports) simpler and smaller, this >> patchset intends to factorize the numerous hugetlb primitives that are >> defined across all the architectures. >> >> Except for prepare_hugepage_range, this patchset moves the versions that >> are just pass-through to standard pte primitives into >> asm-generic/hugetlb.h by using the same #ifdef semantic that can be >> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***. >> >> s390 architecture has not been tackled in this serie since it does not >> use asm-generic/hugetlb.h at all. >> >> This patchset has been compiled on all addressed architectures with >> success (except for parisc, but the problem does not come from this >> series). >> >> v6: >> - Remove nohash/32 and book3s/32 powerpc specific implementations in >> order to use the generic ones. >> - Add all the Reviewed-by, Acked-by and Tested-by in the commits, >> thanks to everyone. >> >> v5: >> As suggested by Mike Kravetz, no need to move the #include >> for arm and x86 architectures, let it live at >> the top of the file. >> >> v4: >> Fix powerpc build error due to misplacing of #include >> outside of #ifdef CONFIG_HUGETLB_PAGE, as >> pointed by Christophe Leroy. >> >> v1, v2, v3: >> Same version, just problems with email provider and misuse of >> --batch-size option of git send-email >> >> Alexandre Ghiti (11): >> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h >> hugetlb: Introduce generic version of hugetlb_free_pgd_range >> hugetlb: Introduce generic version of set_huge_pte_at >> hugetlb: Introduce generic version of huge_ptep_get_and_clear >> hugetlb: Introduce generic version of huge_ptep_clear_flush >> hugetlb: Introduce generic version of huge_pte_none >> hugetlb: Introduce generic version of huge_pte_wrprotect >> hugetlb: Introduce generic version of prepare_hugepage_range >> hugetlb: Introduce generic version of huge_ptep_set_wrprotect >> hugetlb: Introduce generic version of huge_ptep_set_access_flags >> hugetlb: Introduce generic version of huge_ptep_get >> >> arch/arm/include/asm/hugetlb-3level.h | 32 +--------- >> arch/arm/include/asm/hugetlb.h | 30 ---------- >> arch/arm64/include/asm/hugetlb.h | 39 +++--------- >> arch/ia64/include/asm/hugetlb.h | 47 ++------------- >> arch/mips/include/asm/hugetlb.h | 40 +++---------- >> arch/parisc/include/asm/hugetlb.h | 33 +++-------- >> arch/powerpc/include/asm/book3s/32/pgtable.h | 6 -- >> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 + >> arch/powerpc/include/asm/hugetlb.h | 43 ++------------ >> arch/powerpc/include/asm/nohash/32/pgtable.h | 6 -- >> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 + >> arch/sh/include/asm/hugetlb.h | 54 ++--------------- >> arch/sparc/include/asm/hugetlb.h | 40 +++---------- >> arch/x86/include/asm/hugetlb.h | 69 ---------------------- >> include/asm-generic/hugetlb.h | 88 +++++++++++++++++++++++++++- >> 15 files changed, 135 insertions(+), 394 deletions(-) > The x86 bits look good to me (assuming it's all tested on all relevant architectures, etc.) > > Acked-by: Ingo Molnar > > Thanks, > > Ingo