From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE1CC352A4 for ; Wed, 12 Feb 2020 23:50:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9712F206B6 for ; Wed, 12 Feb 2020 23:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="P7ajGiSR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9712F206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2D1D96B045B; Wed, 12 Feb 2020 18:50:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 281FD6B04DD; Wed, 12 Feb 2020 18:50:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 172D56B04DE; Wed, 12 Feb 2020 18:50:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id F14796B045B for ; Wed, 12 Feb 2020 18:50:16 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B9FA2180AD817 for ; Wed, 12 Feb 2020 23:50:16 +0000 (UTC) X-FDA: 76483121232.24.heart48_3c9454465c35a X-HE-Tag: heart48_3c9454465c35a X-Filterd-Recvd-Size: 5273 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 23:50:16 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01CNo5sl181038; Wed, 12 Feb 2020 23:50:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jCnwpb7DiCIZDUVhTqk9j54Zp/9vu9TDq6BMBg+b96c=; b=P7ajGiSRHN3VmVU3wBf17HNH0ogElmrSunxM8zJdKOdrudD5mSM5yohBgnYTvnZrg3MP OZPa5hnr+fQnq2EXGXLXf7hiQlb8ziMMISB7/mmJSmCZJG+/R8PnyfI10rA6cqFReRMa XPTufxIht+iYZzvSnQtJ6m0sealybYZt7gO1KlWlLGdaPiVcvh1PNqMlN1Gf+j890MXF lc7u8RYn/VI6enDEVs9sFqI9/DPEQGYT/xrc3mKjNBXmiruI4UkHb+VlzkZPb4Bx49yg fbcZL9xXXHIMlqY7oG2KdISX5bIOa/D94wzHuyeJtr7P4jxdn1sjrx/SaiUDJiP4xSN0 6A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2y2p3sp4cx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Feb 2020 23:50:10 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01CNl6nx027945; Wed, 12 Feb 2020 23:50:10 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2y4kah5b4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Feb 2020 23:50:10 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 01CNo9fq014234; Wed, 12 Feb 2020 23:50:09 GMT Received: from [192.168.1.206] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Feb 2020 15:50:08 -0800 Subject: Re: [PATCH] mm/mempolicy: support MPOL_MF_STRICT for huge page mapping To: Li Xinhai , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBICjloIDlj6Mg55u05LmfKQ==?= Cc: n-horiguchi , "linux-mm@kvack.org" , akpm , mhocko , linux-man References: <1580434395-9962-1-git-send-email-lixinhai.lxh@gmail.com> <07cd0750-d908-dd3b-dee1-bc3fcf5bf771@oracle.com> <20200212032139.GA31425@hori.linux.bs1.fc.nec.co.jp> <2020021213250278382352@gmail.com> From: Mike Kravetz Message-ID: Date: Wed, 12 Feb 2020 15:50:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <2020021213250278382352@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9529 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002120165 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9529 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1011 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002120165 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/11/20 9:25 PM, Li Xinhai wrote: > On 2020-02-12 at 11:21 HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80=E7=9B= =B4=E4=B9=9F) wrote: >> On Mon, Feb 10, 2020 at 09:19:48AM -0800, Mike Kravetz wrote: >>> On 1/30/20 5:33 PM, Li Xinhai wrote: >> ... >>>> >>>> Signed-off-by: Li Xinhai >>>> Cc: Michal Hocko >>>> Cc: Mike Kravetz >>>> Cc: Naoya Horiguchi >>>> Cc: linux-man >>> >>> Hello Naoya, >>> >>> Do you have any thoughts on this? In previous discussions you sugges= ted this >>> approach of removing the special casing for hugetlb pages. The code = looks >>> good to me and patch is fine with commmit message modification. Just= wanted >>> to get your opinion. >> >> Hi Mike, Xinhai, >> >> The suggested change looks good to me, too. >> >> Thanks, >> Naoya Horiguchi=20 >=20 > Naoya, thanks for inspecting the change! Can you please send V2 of patch with an updated commit message. I would like the section that which lists the impact to "users using MPOL_MF_STRICT alone" to say something like this: If MPOL_MF_STRICT alone was previously used, hugetlb pages not following = the memory policy would not cause an EIO error. After this change, hugetlb p= ages are treated like all other pages. If MPOL_MF_STRICT alone is used and h= ugetlb pages do not follow memory policy an EIO error will be returned. --=20 Mike Kravetz