From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EF1C433ED for ; Wed, 12 May 2021 03:06:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E73A6191C for ; Wed, 12 May 2021 03:06:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E73A6191C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D5AF66B0036; Tue, 11 May 2021 23:06:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D30956B006E; Tue, 11 May 2021 23:06:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B35616B0070; Tue, 11 May 2021 23:06:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 959676B0036 for ; Tue, 11 May 2021 23:06:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5ECE0180AC173 for ; Wed, 12 May 2021 03:06:09 +0000 (UTC) X-FDA: 78131090058.08.30F298B Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by imf09.hostedemail.com (Postfix) with ESMTP id 5CC1F600013E for ; Wed, 12 May 2021 03:05:57 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14C30LiC060898; Wed, 12 May 2021 03:06:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=l/rTg0XshzcJiwGVb3tS3iz6T4JWRPVNQuB5+LfkquY=; b=NDftNhNwbOqIqSN9JeX7P4+S6Lw/papGlogJ05lfwjtDWGp3t0MrS8T7A8tPEwtVaDZV ZWVvnvcGroIPe2RAGCk97c7MGPuqrhDq4ausKYK1P4nNUPr02xhS6+5gY6TknX+qIBCF RLh1U3BeH0oweePgq+MZhK5OyN9oQbKocfXlB6Lde7kepM272onZGb+e77NWMS3i2I4g f1XjTq6KUTcV9K5KchLhQNLNBQLecTbaB2W/1AajKK0TqcHSO0WkkiPIjexJrAtMTO6s Ltr3fy04tLxdnYG559QUvSpIR1f6x7XzL+r8eVU4II0Amnp4+OJvcfbPQE/rVe8S1dJ1 Bg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 38dg5bgsk9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 May 2021 03:06:06 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14C2xqeh059832; Wed, 12 May 2021 03:06:05 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by aserp3030.oracle.com with ESMTP id 38e5py9jgx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 May 2021 03:06:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpP2Q+D6wtC8xP7ESDrPcXUPsOyBI7F2KvpFl4pFtQ+FhyCP0zheEmSaxumoWn+5IDggWS7pAhXsZL7fpM04KNl3xsywIq25yvnDAareEUbI91V4UpT4SMx2Gj68Er4GGyJS+Ke4931oOwCQ9zl5XNQIDcMmru1IqaIDL+jze6FOfksE7Xy0TrPF5ef6duwra4QXJXmvESa1pZmloOHBWBmQiX/1nN656+o3oau7pyBRpLcI6WkdEz7LHHtGpcOCHCFagqrKqU93MZPGWbBFBceJBQmlhgq3vSOY4KYvM7EQzmf/FHOGpW/V2vI0IvK0236GzCUG10varL3uu69ZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/rTg0XshzcJiwGVb3tS3iz6T4JWRPVNQuB5+LfkquY=; b=JeXw+5bHALTXqqNDJz6NmukYy+DUoMac3kkwADQ+R3We4nG2p/MQ2Z6EN5KrELrEWpGxsmEVmWf1pZhd3TcUZqQYZG4hgbTH9PG6w5euFmA5697LPEqnxj6OV/luZ+8T9ZVPK8RPHup+ZBBIFk8GUnosuLARZbpXWxhFRSOK1ARFyG2Aauj9Ca57zG2/MTRqNAWv6PusbbrpigNRZ69+AnMeiQXYoA7duPRL9lytrqlFYvQRvIMu3mYZezETQnxH6J45iZ08dRx6pg0Nac79N8Uj8IyMuuPbR+P9z5nKCpS11crlVEspMQEB2DNNtjg7w90q1uCddDCj9+RvUI+u6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/rTg0XshzcJiwGVb3tS3iz6T4JWRPVNQuB5+LfkquY=; b=JkNmqTRosUEvN65pP4v0sk+MMsxGTrkY3tsolo5Qt336yF7ccOVX+Bxjn/mRt/m0eBCrt1r/GVTL9bwK0N0qBFoZCUC44n0MVH2HImVRtfwXzmS1ELNdfMzlpYL+4e/y+jmM1Gz8JCU5jsxoC7rCWiyWs5Mg12OjDRF7uZQPWEc= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BY5PR10MB3810.namprd10.prod.outlook.com (2603:10b6:a03:1fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.30; Wed, 12 May 2021 03:06:04 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::4407:2ff6:c0a:5d90]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::4407:2ff6:c0a:5d90%8]) with mapi id 15.20.4108.031; Wed, 12 May 2021 03:06:04 +0000 Subject: Re: resv_huge_page underflow with userfaultfd test To: Peter Xu Cc: Mina Almasry , Linux-MM , Axel Rasmussen , aarcange@redhat.com References: <096e28e2-5937-beb2-57f7-d112f9b54d97@oracle.com> From: Mike Kravetz Message-ID: Date: Tue, 11 May 2021 20:06:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [50.38.35.18] X-ClientProxiedBy: MW4PR03CA0295.namprd03.prod.outlook.com (2603:10b6:303:b5::30) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.112] (50.38.35.18) by MW4PR03CA0295.namprd03.prod.outlook.com (2603:10b6:303:b5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Wed, 12 May 2021 03:06:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73275d92-377e-4868-4d14-08d914f2e0f7 X-MS-TrafficTypeDiagnostic: BY5PR10MB3810: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4uBxDDjdKQKyiqAR+nkGgYfYIE5yE11e4/nlw07w7tMKZlCKYma0ucT/scaXoqYXlsn4CrL+WbXbeYHiGur85rWbTtOTFrbLiglzvgbDyImRTqJAfBiK+ATHHsA2ayXiDVdfVSKPmZVokKAOwg95gEGRbWZjE2zddMTvG07KIlbIwDQrhNx7mlwi+jfmjQO1Vr4Kf6CwrcxBvAe/9Q/8OMEPgDU2Gsc0iybSXmDmzhbv4RLlt9c6QntC4ZCSTEborvuIc+yiguka9HSda2zHnGjIch17lnt2GirPloG7fJAos206HESFpVRCHHc+0dRZrMcxHfoWuAgMvOgsmFPraqIW+OkDcPQTQ8PGD1Z3Os5HarqQVwHIUSnEF67jGI5FHay8OUtWdBHoV8aAS5eYGX/KWX6gT8pSgQdwFZaoby0AkPyOnRS5hu1QpqOZrPA/4LdwgkVMENEDx0/3KRUJET2zXRmi7vAm7xd72WP++xzf12wU5CaR/wUWZC4C0ljM1zXTfsuGcqq/sW6atTPG/TVU3R7nOfAJphRbSkn/fU3IrPxE4y37Pbotrjcn15sKkxapb2nAnm6+yQaj30M6lOoyDX1lRJgSMy581v3CsFdls3ajBeepwHlkcdLjotd/baSQGv7ZQqJMcVWeK2FebO0suAKLzlOUMoUx9rCJQQLfAPqnx2cJHrpNmTScdBwAOEI3rQYhzLELXto5+cwkt8mMGHweOD4zHtcBeoP2XWL4IuXkKXQD6z3qVpxEUtLh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(376002)(396003)(366004)(136003)(83380400001)(36756003)(26005)(4326008)(186003)(66476007)(52116002)(66556008)(38100700002)(31696002)(956004)(478600001)(2616005)(38350700002)(5660300002)(16526019)(316002)(44832011)(6916009)(31686004)(16576012)(2906002)(66946007)(86362001)(8936002)(8676002)(53546011)(54906003)(6486002)(14583001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WnhRNnZEU0xWWGJHbEZUQ2FoUHdEMXhVUC9HUWdqakJtZnFOaDlSalJZOVRL?= =?utf-8?B?RmdaOUU3b2NGY3Y5amhZTzhlcjZmUkc0bCtkMm5iRmhuQ0ZNaWZQUkJObk0r?= =?utf-8?B?U2NsTmNtYkQ5TU1FZWhyV3hhM2JNa0tjYWN4TERnclVaa3FoeDNCeXpoRnlI?= =?utf-8?B?QVVRUnMraUVURE04bW93K2FMUWxubXRaeVlnU05rTlNkRCtjOHBoQkFQeTh2?= =?utf-8?B?WXA5c0FjdVY5enFadWR4SlA2bkpXYUd0dnNUUmpvSjRMUnBudGlhbWYxdmZk?= =?utf-8?B?SjBMTithUWpER29mQXBldFdKRUF4N2VjVVdwcHZPY0pNNGIzSDllMEM5UzJP?= =?utf-8?B?T0pmZEliUGpBalVhMkF3cytOZXo4ZE95YzJMZEt3aXZITUhLNG9SNDdoUStl?= =?utf-8?B?Y0ZaL1duT2IrdVdBK3B6bnl5dm1BVVpyZTN3R3dvY05mU0FrN010aDBaTE1I?= =?utf-8?B?WGYwVUNROTYyeFVuakRYOEhzSE9HVmQrckY0MHUzMnVxc3IzajVCSzQ2bkky?= =?utf-8?B?cjVHVUhhdXdjOVlKemtXalpXNzJBZ1JLZGYvLzJqWUV0MDhneUZCYTdlVG5v?= =?utf-8?B?M3F2U1lYZzBTUXJPMlMrMlZvOEdUZERCRDNxZDFXdHo1ZHdpM0Y0OW1YUVlU?= =?utf-8?B?T1JzYmQ5VWJYSFVvNXl5WDYrMzlreHA3bG1SQUUrSVVPL1FzKzd1VGZidy9E?= =?utf-8?B?YlZxa2JhM3ZkU0JyQTVya3k1WXpscXErVXdnS3UxOERWR2tFdDdaWWtqcGhF?= =?utf-8?B?WjZKQk80WHpZM09QSURqU1JpdkVxOUorQmVPWmpKSGxPenBnNGw4bXozQ2E1?= =?utf-8?B?S0ZVVDNzTkN1MVJET1FpaTFBNHAvYUF6b20xZHZrY2VqODBtVHRSdVdNbENT?= =?utf-8?B?cU9pSFpxSVlJSFRhNFZyK1FleUZxWWo0a21wd2xYb050UHBuaU55ZzhVRjFo?= =?utf-8?B?anp2UUlyV3dhUXRkaXdGYWQ4Z0E2WkxMRXRzcC9kbWdyRGNjRWhmSXdXSTFT?= =?utf-8?B?UVNoL3pZaU0yNmxRcjA5NkRHWm9Uck54dnA5QVliMXlzdE1hNUN1K2dQeW43?= =?utf-8?B?MmhXVVY0eUh4QmhydTM0d0tNWWFoZG5tMnBuOXlxdnJQODh5YnhFT1ltM0Ru?= =?utf-8?B?QzdQREZwMktHbWlIajFncCt4UVJ6M1hOOWpxdkdtZEVmT1lmMTEyUXpkcUJp?= =?utf-8?B?NlovcWlSaFF6b1AzTHZvZTBCVHFnU1B6K1JLcjc5akFlNm0wcVRrTGIrVFdI?= =?utf-8?B?Q2J5S0gvVW5UejVtRFluUDI4MFFYNThxMkVmcExZeFV5SjhuS3NwUnNpQk4v?= =?utf-8?B?UGJ1SW9MSWtLVW5HcDl2Ykc1R2xEYXVNeFZRdHR0WFVwa3hjd0lmbkdGSFNX?= =?utf-8?B?SENZNE4raFBYVVJYRGJOWWRlakFlZXB4eGEyb2dhTlczM2hxOFU2N2FsZWJq?= =?utf-8?B?Y0FYWStWNStobDlzVzRtUkpZc1l3VGpiTktSYUtyRDFVd0xuYjM2cjN0c29R?= =?utf-8?B?MWhuZzRjenp5Y0VFdTV0dEE2dXdYS09WckkvS3FDTnhENHNrdTJ5VldoSCtS?= =?utf-8?B?TWZRRjlYMmxsUHZIc3hrVnpwTkRiVTF5MFlNNi9TRDZkaEwyM1luK2c0WGpo?= =?utf-8?B?d1RueTZXYjQ4NTY4cW1JRWFneTFncjdFeWIzczZzNUFaQllIMUVaVU16cjZY?= =?utf-8?B?eTJ3TWw3S0FQOVBIVzc0Zi9TZjQ5QVJ4UWNQWHk4RjdycWNXbHdwMEtvUTZQ?= =?utf-8?Q?+ITwxY+RpVXntdHEUQSUqLX/K/HZ3CpVmOpWMSi?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73275d92-377e-4868-4d14-08d914f2e0f7 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 03:06:03.9367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 56h4DhHD56AGUMqq/hqSv5aj/aSZTAvOznW3HuhZz5eOeuixEpdi6TWhfNVlrbEqILYMs5ON9Bc7QjzkAknmjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3810 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9981 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105120022 X-Proofpoint-GUID: NFewz-Jm1PG-fDJk4lf9XeFzZRd_Wy4G X-Proofpoint-ORIG-GUID: NFewz-Jm1PG-fDJk4lf9XeFzZRd_Wy4G X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9981 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105120022 X-Rspamd-Queue-Id: 5CC1F600013E Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=NDftNhNw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JkNmqTRo; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf09.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 141.146.126.79) smtp.mailfrom=mike.kravetz@oracle.com X-Rspamd-Server: rspam03 X-Stat-Signature: 41qun5c8wxdx6asd8but9frufjjosg9d Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=aserp2130.oracle.com; client-ip=141.146.126.79 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620788757-768507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/11/21 7:35 PM, Peter Xu wrote: > Mike, > > On Tue, May 11, 2021 at 07:25:39PM -0700, Mike Kravetz wrote: >> I looked at this a bit more today and am not exactly sure of the >> expected behavior. The situation is: >> - UFFDIO_COPY is called for hugetlb mapping >> - the dest address is in a shared mapping >> - there is a page in the cache associated with the address in the >> shared mapping >> >> Currently, the code will fail when trying to update the page cache as >> the entry already exists. The shm code appears to do the same. >> >> Quick question. Is this the expected behavior? Or, would you expect >> the UFFDIO_COPY to update the page in the page cache, and then resolve >> the fault/update the pte? > > AFAICT that's the expected behavior, and it need to be like that so as to avoid > silent data corruption (if the page cache existed, it means the page is not > "missing" at all, then it does not suite for a UFFDIO_COPY as it's only used > for uffd page missing case). Thanks, Thanks Peter. Making it fail in that case is pretty straight forward. BTW, in this case the page was not in the cache at the time of the original fault which is why it is being handled as missing by userfaultfd. By the time the UFFDIO_COPY is requested, a page has been added to the cache. -- Mike Kravetz