From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2758AC5AD49 for ; Fri, 6 Jun 2025 12:35:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B406B0092; Fri, 6 Jun 2025 08:35:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64BCE6B0093; Fri, 6 Jun 2025 08:35:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 514176B0095; Fri, 6 Jun 2025 08:35:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3282A6B0092 for ; Fri, 6 Jun 2025 08:35:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 959B4161866 for ; Fri, 6 Jun 2025 12:35:35 +0000 (UTC) X-FDA: 83524921830.04.235DEA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2B8F240006 for ; Fri, 6 Jun 2025 12:35:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VdV/OTlJ"; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749213333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sSb0ikd6dE0bNHJf4fDasJAbxnz21Z9UlDYPOcjiVX4=; b=B+aOeNxszZrzFBPqMkRvs0IiRgyLI2S6kyqllf9IsvH5iW13r5CseXBYNvuU76M+0CHTUV ih3Se+gvlZCtpJ4RpMSp/EI218QuaLEfbSLNkL4Y1XWF9Yk1Ig37/CYj9/pqqkQuTBjWGR TGSSA+9/h29Y7gQsg8I9EYNRdI6eaWk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VdV/OTlJ"; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749213333; a=rsa-sha256; cv=none; b=Redn2+/1cyerz59m25+LnndXgCKM0sYhs7Z8x3swoWUb0a0AJ8hVIg1WoFyQC186D1jM6N IkW7IbB2DCWNxm3h6onWmZ3uiKoSlAxrrDJdhjxv9t9U9ozRpz6TRxLZcKYJ8eYqTWpdBf HiSlphnNW6mPJNNDeEmeNkmVb41690M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749213332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sSb0ikd6dE0bNHJf4fDasJAbxnz21Z9UlDYPOcjiVX4=; b=VdV/OTlJmud2hXMtcpQGU1m6bz/J39Z9DEutp6WbqjNt74cvsTm9ozaKSMUZ+GUeMFskDb v/DoP2rRu7a1RIYBzBDCZOhzQy+YVTMaL7ZJEgU91ggrMtxT0nPrJK4w6PfdhS8uJEPprO xFPG+TqSspMXm1zPoFUzLvvCDw6ee60= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-ZVFb83bFOkWBNoQ0k1EnUw-1; Fri, 06 Jun 2025 08:35:31 -0400 X-MC-Unique: ZVFb83bFOkWBNoQ0k1EnUw-1 X-Mimecast-MFC-AGG-ID: ZVFb83bFOkWBNoQ0k1EnUw_1749213330 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d3f03b74so12338305e9.3 for ; Fri, 06 Jun 2025 05:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749213330; x=1749818130; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sSb0ikd6dE0bNHJf4fDasJAbxnz21Z9UlDYPOcjiVX4=; b=HvM7dFsDyMo7/u3eAr9D31S8CmPIHiaV15e5Bjphq6DhUJGtCx2eBQI1BCJBXUD3+5 CD31Yoj3Soj/lZGCWNjQ7/UEGE4VN3lGeP11fquLoM8G9zipOI7LK75Epxg59uX0blnU rRG0nPKSGNstVjVBJSkjR9noKvcsmwNELTPi8dfnnzTdBos92VSL5qn2omLRzOF22TSd 27JPonOGJ793tWpYkWB8icIYMFAlDuA3cvEWcGi6FqDFvCUJ2K9SM4HqyaXZZ1iR5qKu hLHvDDOTUu+jQT5oiIltapqCKbDhDT3PN7IL5TfPa0fZeu7+LtY32HhESs2avv179/0A awUg== X-Forwarded-Encrypted: i=1; AJvYcCU5vScCMUdZoS6bMb3aSNSUm5tsMq4VHdhpQlLFepu0Qu/GQ4T+T/cXlGc7XtRwLfM0lIGh+KHPqg==@kvack.org X-Gm-Message-State: AOJu0Yx91+fzaTnk07+wkoKtFOP5XO0jwWgcNZynLQbQ46UV0xKKi5zQ Icd5hAcnjemG8i38iuYcWp4tz5rbPWNZ5VCf5eHekgf28IvJnkEskvkkJOdKxvfPX5l1TbuVmfw jG/O6ofwMFbiI3tkGyNFTq0WIKRQiSn3kQg1GLQadmnRWH7WZCk7H X-Gm-Gg: ASbGnctuLlwOVolQgWL0oou8USQF9f7p+1TdkEjiSowPofXULiWcwW61WskcpacIIz4 XaeZ7/SS8jHU3C0R9E4FUtjOHHoC/bwI72AQqnwe2pv+ahXDr46c6S5xY0Y0J0om6p2Vr6pB0H1 q+ksG5mPxBiP3JBLNAAe2vFk90zetfZC5X9MxAjl7Qmq6aeeEdZ1hLRDsRpaOP7omv1pqyMt3Da 1WaXGsj2XbO9MO6NCkuD8ff1tAtDa6px7QMKfOxiplOW0obOPkABmAArrqoXhE+dBtpsqsparth x0eg0TrXNGXh+3KFiXMu78tG8fUUCVQhjww/w7zE13FEhd77B41SYJHYeI/eNXVYYLtDneUK9Ka BcLiZE2YdNEs25SMu0h8GFtbEJlUOOtJmhA+c869HdQ== X-Received: by 2002:a05:6000:310d:b0:3a5:2beb:747b with SMTP id ffacd0b85a97d-3a5319b592bmr2739323f8f.3.1749213330327; Fri, 06 Jun 2025 05:35:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6Ebolrz1IOoMpW3aYGJSUpFY88OxyWoAs8HB+AGnlcGOsl5vVciX1PlKuEnfQRSWeZP/PAQ== X-Received: by 2002:a05:6000:310d:b0:3a5:2beb:747b with SMTP id ffacd0b85a97d-3a5319b592bmr2739302f8f.3.1749213329969; Fri, 06 Jun 2025 05:35:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532436668sm1788926f8f.54.2025.06.06.05.35.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 05:35:29 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 14:35:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier To: Oscar Salvador Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-5-osalvador@suse.de> <0ca963af-8dc9-4cb4-9142-04497c359b81@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XTObB5hETH1GSU20_PDyxmbiQTfjEfWvPjQ5zQduFKs_1749213330 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4wx99pcejf7r78sbfxc59jwbioxnc9d4 X-Rspamd-Queue-Id: 2B8F240006 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749213333-675648 X-HE-Meta: U2FsdGVkX1+K9TfIu4zcZaHzpR35GA+FiFL7fpVr93w4h+A5A2fpt0qK9pgeC8ngHiZzA4aotQFA073/2xIEmC4qTDjCwK2nmbjSK9cP6PYIFs4typvPJAa2adij6Y+0u7BeauCoDa1nnv2i8nw460yej83GsYZ7zP1xUSHBxRCZ07czH2pFBkH7jllqDzhx7LsrHXGq5yyS/yV0HU1wN2XSQ/Y7xiLAXuVHWhpvpRBRigwJCdFsSrOhMRTE/HdqjmT/5kIiNm/Uncpk+tJ1t5H83kPr+btojj2m6TLakgHW6SfaKzhdGjlaChMyPgq+zd99qBuKCH8k/DAABFdi0UNMXUR98t1JLKeNmZtr+6D6ftxEGPrAtUC3KtDaBZwIMqzCW1bsrql0yJgQdfKCgJh0lLvd2TIbiU4Ut26vxaY5srLfuKU0FCtn51U0hLWzg0VIHDwpf35PKz9jSyybYHERK9Drsb30HgOx/EZOrXGJflAu9bMmi0g+5OrE/csjeF3s+aYT0A/h8aK+tKxwv9QGCYMcqQQFACjCwEytK6SWCjVMrsmOjukJu/nFhV3MtADgVDVQ8IlfguOZZa1lQHhPYaEFeV/U8J3rjfn8ERwjPsN/v4acJdQ3yAbM3RiN3zyCBYd5HynHJ6LGFKv8eQYgmsW/s6bwkncpZb68XXoBl8/VgFE8ZwHiVgzfro+NbARnZUU8/dgmCtax045ytsUxwDCYDF/4qzMdri8NJPIqZ6hw917USQjGNGR3PtoDrmoTJ/L+JroqhyPXb+tFRrKJ7tksjyLMM2UaVu7X98D/7NREEsjDlCzWL9eC4k253bRerr5FcYofuYXtBCbkZ+9MD7f7udLuVZzeWuk4RiKjxDWjTOdqQHZ0wCiDLZgpEaIsoJ8f/S/+gQdGavfBkFlLRf0oBZKS2yiZtf41dr4ndpHLqR/8JhVkiMnDGOiTSdq8RcTXQaAFrwU8VUR AuqJTMQB XjRsNgCc940cJwquRa5gJO+jnTnANhn6SnORuHnmJkgsNtQEkCtiY+OGVqS74g9cgd8WYnsniYao39PzRb4cuyfZAAs9Bh0IDy3kT5jj01se2sRScLldFMX1U4QWSExdJOgpSN/i4wSvZEbnJXIobW+6TQ46IlIQlHdHpxtYvH4AFKx99hE74T4QugEqQSHZ4/MgqVYy2HA3rtzzaRU/jwetbz179X6emYH88vC9NnD3cQrAbACcuXazzUeQIfqEv87UdAlcR2Rwxl01YM+EovfRGqbCYL3kEwfmPj06e6O7GRbip8xUkdkWB++ZMuTxQ2GH5hLnJnmYAEw7fFkN4Z9eYeesKQs6mo91AOu+SKeDzjN7IxhKGnPYyFcHeVZCLWjaKaH0Rl6tB/yNUSDZEcLS0iN7yYzYSUX6jSofPim9cFk8J52njDv8J4wLjtEr8JRMZbXXRuyzYWv88qQzUaCwlwLi/edEB7pt5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 14:28, Oscar Salvador wrote: > On Fri, Jun 06, 2025 at 01:56:15PM +0200, David Hildenbrand wrote: >>> @@ -6217,15 +6217,12 @@ static int slab_memory_callback(struct notifier_block *self, >>> int ret = 0; >>> switch (action) { >>> - case MEM_GOING_ONLINE: >>> + case NODE_ADDING_FIRST_MEMORY: >>> ret = slab_mem_going_online_callback(arg); >> >> In slab_mem_going_online_callback we will cast arg to "struct >> memory_notify", no? > > Uhm... not sure if I understood this correctly but slab_mem_going_online_callback looks > like this: > > static int slab_mem_going_online_callback(void *arg) > { > struct kmem_cache_node *n; > struct kmem_cache *s; > struct node_notify *narg = arg; > int nid = narg->nid; > int ret = 0; > I'm stupid and missed that hunk, sorry. > > >> Probably needs to get fixed. >> >> ... and probably best to pass marg directly. > > You mean to cast it directly in slab_memory_callback and pass 'narg' > to slab_mem_going_online_callback? Yes :) -- Cheers, David / dhildenb