From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5992DC433EF for ; Wed, 13 Apr 2022 06:22:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE08E6B0075; Wed, 13 Apr 2022 02:22:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C90456B007D; Wed, 13 Apr 2022 02:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B573D6B0080; Wed, 13 Apr 2022 02:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id A41596B0075 for ; Wed, 13 Apr 2022 02:22:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 671F48142F for ; Wed, 13 Apr 2022 06:22:07 +0000 (UTC) X-FDA: 79350860694.09.F2A74F5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id C9F6018000A for ; Wed, 13 Apr 2022 06:22:06 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BB61150C; Tue, 12 Apr 2022 23:22:06 -0700 (PDT) Received: from [10.163.39.141] (unknown [10.163.39.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A73273F70D; Tue, 12 Apr 2022 23:22:00 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 11:52:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V6 4/7] sparc/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , khalid.aziz@oracle.com Cc: "catalin.marinas@arm.com" , Christoph Hellwig , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "sparclinux@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Khalid Aziz References: <20220413055840.392628-1-anshuman.khandual@arm.com> <20220413055840.392628-5-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C9F6018000A X-Stat-Signature: jxxb9n3u6ohnj9cwf1ozz9hf3karysta Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspam-User: X-HE-Tag: 1649830926-249760 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/13/22 11:43, Christophe Leroy wrote: > > > Le 13/04/2022 à 07:58, Anshuman Khandual a écrit : >> This defines and exports a platform specific custom vm_get_page_prot() via >> subscribing ARCH_HAS_VM_GET_PAGE_PROT. It localizes arch_vm_get_page_prot() >> as sparc_vm_get_page_prot() and moves near vm_get_page_prot(). >> >> Cc: "David S. Miller" >> Cc: Khalid Aziz >> Cc: sparclinux@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Reviewed-by: Khalid Aziz >> Signed-off-by: Anshuman Khandual >> --- >> arch/sparc/Kconfig | 1 + >> arch/sparc/include/asm/mman.h | 6 ------ >> arch/sparc/mm/init_64.c | 13 +++++++++++++ >> 3 files changed, 14 insertions(+), 6 deletions(-) >> >> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig >> index 9200bc04701c..85b573643af6 100644 >> --- a/arch/sparc/Kconfig >> +++ b/arch/sparc/Kconfig >> @@ -84,6 +84,7 @@ config SPARC64 >> select PERF_USE_VMALLOC >> select ARCH_HAVE_NMI_SAFE_CMPXCHG >> select HAVE_C_RECORDMCOUNT >> + select ARCH_HAS_VM_GET_PAGE_PROT >> select HAVE_ARCH_AUDITSYSCALL >> select ARCH_SUPPORTS_ATOMIC_RMW >> select ARCH_SUPPORTS_DEBUG_PAGEALLOC >> diff --git a/arch/sparc/include/asm/mman.h b/arch/sparc/include/asm/mman.h >> index 274217e7ed70..af9c10c83dc5 100644 >> --- a/arch/sparc/include/asm/mman.h >> +++ b/arch/sparc/include/asm/mman.h >> @@ -46,12 +46,6 @@ static inline unsigned long sparc_calc_vm_prot_bits(unsigned long prot) >> } >> } >> >> -#define arch_vm_get_page_prot(vm_flags) sparc_vm_get_page_prot(vm_flags) >> -static inline pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) >> -{ >> - return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); >> -} >> - >> #define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) >> static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) >> { >> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c >> index 8b1911591581..dcb17763c1f2 100644 >> --- a/arch/sparc/mm/init_64.c >> +++ b/arch/sparc/mm/init_64.c >> @@ -3184,3 +3184,16 @@ void copy_highpage(struct page *to, struct page *from) >> } >> } >> EXPORT_SYMBOL(copy_highpage); >> + >> +static pgprot_t sparc_vm_get_page_prot(unsigned long vm_flags) >> +{ >> + return (vm_flags & VM_SPARC_ADI) ? __pgprot(_PAGE_MCD_4V) : __pgprot(0); >> +} >> + >> +pgprot_t vm_get_page_prot(unsigned long vm_flags) >> +{ >> + return __pgprot(pgprot_val(protection_map[vm_flags & >> + (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]) | >> + pgprot_val(sparc_vm_get_page_prot(vm_flags))); >> +} >> +EXPORT_SYMBOL(vm_get_page_prot); > > > sparc is now the only one with two functions. You can most likely do > like you did for ARM and POWERPC: merge into a single function: I was almost about to do this one as well but as this patch has already been reviewed with a tag, just skipped it. I will respin the series once more :) Khalid, Could I keep your review tag after the following change ? > > pgprot_t vm_get_page_prot(unsigned long vm_flags) > { > unsigned long prot = pgprot_val(protection_map[vm_flags & > (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]); > > if (vm_flags & VM_SPARC_ADI) > prot |= _PAGE_MCD_4V; > > return __pgprot(prot); > } > EXPORT_SYMBOL(vm_get_page_prot); - Anshuman