From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40639C3ABC9 for ; Fri, 16 May 2025 08:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A820D6B0107; Fri, 16 May 2025 04:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A31286B0108; Fri, 16 May 2025 04:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D0E36B0109; Fri, 16 May 2025 04:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F0346B0107 for ; Fri, 16 May 2025 04:25:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B8CC1615D0 for ; Fri, 16 May 2025 08:25:50 +0000 (UTC) X-FDA: 83448087660.28.118B5F3 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf03.hostedemail.com (Postfix) with ESMTP id EC9CD20007 for ; Fri, 16 May 2025 08:25:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LQYJD0NE; spf=pass (imf03.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747383948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6nbeIWfPgmSdzJgtHDSYDHI6Wi/sK9JWvegm6vZV/4I=; b=NT0+sKtKxP10xp/bk/IXf1onGhZVw70qBiqMQuhl/zoxpYXWfg40WRI4BLFli5cgBQE/z9 YsolSkryNQYYBgegzUi3osrBttNOzHOOqbWsGV0L6iLka4960Nbt+m+tTgNdVbRdw3l0Dp du/vV0VOfRPSIokY9npNzCmDONbnpe8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747383948; a=rsa-sha256; cv=none; b=LoIoy0kO9iqd+w/MQ+N+do41Dd5R/0byWJN+PdeeuUL22vFY/G8g4l2NIKY7hDBkhVUtnT S5SdwHUDJP5Ntlqf8xAigEDslEWbBjTwEKS/YSEbYgBOFpeGyANdCQKkWn+IMK0/qHA3oQ 8UMlgbvw/kb/lWuQEmdPKMm+X4bBKyc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=LQYJD0NE; spf=pass (imf03.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54G5utB3014153; Fri, 16 May 2025 08:20:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=6nbeIW fPgmSdzJgtHDSYDHI6Wi/sK9JWvegm6vZV/4I=; b=LQYJD0NEoOkuXwc+otQKF/ 0t0c5x0Q38bt5LlnryuaP1+TF0fYDW+MuyRD3p/1q5Cx2EEX7AYEvSaTKMPU2dEv zkvUvtpX7QJgaEAuMXoiPSa2ahz4yqwUMoUrSDzxacKAkLLzn9YVd9+/gFpVjJSw 5xaG0GpUxW9M9ycklkEF/E28NnPX9/JCpB6aQ3emy/oejsUDVNaow/kixQLkaHlJ LdZ8eHC8n3iUwhCPF3ERyVruwX0lsOclKsV12gn9y0vZf2EGXnzLR04ure0e8Vnx FMc2qDI1+cegGx1C2yGCDvWG77wu7i3TMQH12fQxPESA+M9Hn1aKGNXml/YkcD0A == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46nhg34as3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 08:20:37 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54G8Hb4C032758; Fri, 16 May 2025 08:20:37 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46nhg34as0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 08:20:37 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54G5hJOI021408; Fri, 16 May 2025 08:20:36 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46mbfrxjts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 08:20:36 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54G8KYvd56099324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2025 08:20:34 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C5E0201EB; Fri, 16 May 2025 08:20:34 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CCF4A201EC; Fri, 16 May 2025 08:20:31 +0000 (GMT) Received: from ltczz402-lp1.aus.stglabs.ibm.com (unknown [9.40.194.31]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 16 May 2025 08:20:31 +0000 (GMT) From: Donet Tom To: David Hildenbrand , Andrew Morton , Mike Rapoport , Oscar Salvador , Zi Yan Cc: Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , Donet Tom Subject: [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node Date: Fri, 16 May 2025 03:19:53 -0500 Message-ID: X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Cf0I5Krl c=1 sm=1 tr=0 ts=6826f555 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=aznVoBAsOnskw8r2mgMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE2MDA3NSBTYWx0ZWRfXypFikYKBjWxu phxyK4pmimcXyJ0YuOIb1FNYwf6VzMrFB7YemVSo4Enm1TTVGM/1xgpvlL+7IYFrkAawnXyE4G6 cz91VsDldNh3YKFXWXgo48loqVuXqBZzNcqoHVZfjemo1ntunDnShFJ8QKSGjhS18TWHstxxfHo kw5AOlk8BbPCpZZsOyM0AU9OIHaUGLKY9l6HJn2bGyaW7hpNPphnMaLbhh4cTlO7xFot86wlQSY 28J06/+vbYVF7cuxb+Jbsx1CUAOk0tYY2evHGzurLAFsq1vYWy5Yo+qPkxr9aa9Jqd/ZfiG7tYt uamBJx8mOISWa3Fxx+HkqK8W7VdVeJhpl3Ats7O+nb71ZapLESTtgkIi7YyAjypjtAeKBFCq+PV OtW/kXENL/oIN21cuMc38pruyxvGa1pMMa6zXzUeurrCMCr1cyBB8S96fHTMJcn8FyoiE5jw X-Proofpoint-GUID: aO0xNzaezBjp-tI_reYSbW-8nNA5qIDT X-Proofpoint-ORIG-GUID: rBlDIF-PZ8Sp8UWD4TIDm2PPNl9IAB0m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-16_03,2025-05-15_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=913 impostorscore=0 phishscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505160075 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EC9CD20007 X-Stat-Signature: wxwd41thuowhb5ubuekxak9dxuow8yxi X-Rspam-User: X-HE-Tag: 1747383947-733844 X-HE-Meta: U2FsdGVkX1+2BsDECmvERXZvnFtMZBkxb3qyL85UbuPhjk5And32S/ULAVov8zuI/5e5PQqQuBHDs1KoMWlmgMU+FwC9InHzApzgcYzFkXrsW5zodCtMEDKppQ9iouNQWGuAECFcz01ubpb9lGjCC6La9uDq4ccmgYAcw/CjlTC6oaHoYEpR1ZSSmZcCC0woez4nvzhwXDLWT9qYcfDQW8REF3AK+LKfXbSk6rq7m47r51i7Q5bKgR9AMbFvqVNc2q7+sfMD6t+8Jrjz3iUbQ70hcc6+T9rr1qN/jyEmzkbi9OJFqnMfAWl1LF3YLxD19ObZ+6buKgsVukn0qugee1vcsXzG1xnwoTskhutDVvj0uxxjfxupLdVjA4MT3oXkWdEhfA00CSM15dhqLV/yXuRpPI1qqkPhMd+YV9vcv29iSvCYbem6hbqRMg4C+hBUGbdF4Gse/QHdz+YbBpcXzzNXZkt8OSl8IyxIjrUmPdTRzVFq8NN3MiV1/hgBHMpDrsN6v31IFhj5lfXrQ/M81Qb7EVRffiqZ5OwYL72XD6MvztosQke8EMFrZRmVQI6B7iXJfFHzc6svO7kILy4Efa1f/T0+McfytOSOQVcpA6rMCImKmAvxYgUXCj8JuJJ6r8Q56JG96efkZVJKWimnTBB/TAgJxbkV06vpGuX3aPv8gdTwHg0NIJfRIp9rzwtcGS0dZzSF0XDrkOZYwmJisDqijk6slpCmD982Uap4qByYUAqCYxOfTszhmxqknFKACTt8k2r/0XZVyyV2si6W7tKi216+DGVZfNKUd5FyRBTnXJ0bBo/UGQn1JUCt+kgblSkWKXzPgIQDk/qa5hpSgicdkVNdTvQMUsH+OuWMHCAUOyUjEZ3oYiKpgWPLINiLZJW04bAcEztSiZfItccOpkOMwc8KnIVu6p/dxzU71NgzxqS+sVEtDD/x2NSKvIFc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: register_one_node() is now only called via cpu_up() → __try_online_node() during CPU hotplug operations to online a node. At this stage, the node has not yet had any memory added. As a result, there are no memory blocks to walk or register, so calling register_memory_blocks_under_node() is unnecessary. Therefore, the call to register_memory_blocks_under_node() has been removed from register_one_node(). Signed-off-by: Donet Tom --- v3->v4 Addressed Mike's comment by dropping the call to register_memory_blocks_under_node() from register_one_node() v3 - https://lore.kernel.org/all/b49ed289096643ff5b5fbedcf1d1c1be42845a74.1746250339.git.donettom@linux.ibm.com/ v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/ v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/ --- include/linux/node.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/linux/node.h b/include/linux/node.h index 806e62638cbe..8b8f96ca5b06 100644 --- a/include/linux/node.h +++ b/include/linux/node.h @@ -137,15 +137,9 @@ static inline int register_one_node(int nid) int error = 0; if (node_online(nid)) { - struct pglist_data *pgdat = NODE_DATA(nid); - unsigned long start_pfn = pgdat->node_start_pfn; - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; - error = __register_one_node(nid); if (error) return error; - register_memory_blocks_under_node(nid, start_pfn, end_pfn, - MEMINIT_EARLY); } return error; -- 2.43.5